[GitHub] cordova-docs issue #608: Update platform/plugin versioning
Github user stevengill commented on the issue: https://github.com/apache/cordova-docs/pull/608 @fredgalvao, I agree that there would be benefits to implementing it. Feel free to open a feature request issue at issues.cordova.io. Regardless, this PR is to fix the docs issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs issue #608: Update platform/plugin versioning
Github user fredgalvao commented on the issue: https://github.com/apache/cordova-docs/pull/608 Why not implement it instead? I'd bet `cordova plugin rm XXX && cordova plugin add XXX` is a very common thing, and a `cordova plugin update XXX` could be usefull. I've had situations where I couldn't update a single plugin with that workaround because of dependencies, so an `update` command wouldn't be a shortcut only. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios issue #225: CB-11352: Call setUserAgent before creating a view
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/225 The lines I quoted show the descriptions of what failed - you don't need to touch the tests, just fix your code. The tests run on the standard UIWebView, not WKWebView, and must pass before any PR is accepted. In any case, in iOS 9, there is a "customUserAgent" property for WKWebView that should be set instead: https://developer.apple.com/library/ios/documentation/WebKit/Reference/WKWebView_Ref/#//apple_ref/occ/instp/WKWebView/customUserAgent and not the cordova workaround way. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request #226: Add one cocoapod to Cordova project
Github user juliascript closed the pull request at: https://github.com/apache/cordova-ios/pull/226 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request #226: Add one cocoapod to Cordova project
GitHub user juliascript opened a pull request:
https://github.com/apache/cordova-ios/pull/226
Add one cocoapod to Cordova project
To use:
var podMod = require('./installPods.js');
podMod.installPodsSync ('HelloCordova', './HelloCordova',
'GoogleAnalytics');
//or
podMod.installPodsSync ('HelloCordova', './HelloCordova', 'AFNetworking',
'~> 2.0');
*** Works only for one pod at the moment -- calling it more than once will
overwrite any previous pods ***
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/juliascript/cordova-ios
CB-9825-cocoapod-install
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/226.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #226
commit 04d1f87cad4c47c3f470c5a6fc69582ab06a1394
Author: juliascript
Date: 2016-06-02T23:32:55Z
Add one cocoapod to Cordova project
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs issue #608: Update platform/plugin versioning
Github user stevengill commented on the issue: https://github.com/apache/cordova-docs/pull/608 Thanks @carynbear! I don't think we ever supported a plugin update command. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib issue #448: CB-11164 Allow forced dependent plugin removal
Github user codecov-io commented on the issue: https://github.com/apache/cordova-lib/pull/448 ## [Current coverage][cc-pull] is **80.60%** > Merging [#448][cc-pull] into [master][cc-base-branch] will increase coverage by **<.01%** ```diff @@ master #448 diff @@ == Files68 68 Lines 5384 5386 +2 Methods 851851 Messages 0 0 Branches 1041 1042 +1 == + Hits 4339 4341 +2 Misses 1045 1045 Partials 0 0 ``` > Powered by [Codecov](https://codecov.io?src=pr). Last updated by [cc0e0e9...96bbba0][cc-compare] [cc-base-branch]: https://codecov.io/gh/apache/cordova-lib/branch/master?src=pr [cc-compare]: https://codecov.io/gh/apache/cordova-lib/compare/cc0e0e9ac2f1a589bb6a13be4a1d4299fe1bdba1...96bbba0b496e1d5629516b6b47c2d6407477 [cc-pull]: https://codecov.io/gh/apache/cordova-lib/pull/448?src=pr --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request #608: Update platform/plugin versioning
GitHub user carynbear opened a pull request: https://github.com/apache/cordova-docs/pull/608 Update platform/plugin versioning Remove cordova plugin update (this command does not seem to exist) You can merge this pull request into a Git repository by running: $ git pull https://github.com/carynbear/cordova-docs patch-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-docs/pull/608.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #608 commit aaa6cacb334a79fbacfaaf40423bd5dc358ffb5e Author: Caryn Tran Date: 2016-06-02T22:47:15Z Update platform/plugin versioning Remove cordova plugin update (this command does not seem to exist) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request #448: CB-11164 Allow forced dependent plugin remova...
GitHub user carynbear opened a pull request: https://github.com/apache/cordova-lib/pull/448 CB-11164 Allow forced dependent plugin removal You can merge this pull request into a Git repository by running: $ git pull https://github.com/carynbear/cordova-lib master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/448.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #448 commit fda0f67fea2a9f5d5197fdeddd087e83b3f66866 Author: carynbear Date: 2016-06-02T21:44:43Z CB-11164 Allow forced dependent plugin removal --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
RE: Proposal: Change Android Project Directory Structure to Android Studio style
Joe, As we discussed on the call yesterday, I wrote a script that transforms a Cordova plugin's android platform to a module structure: https://github.com/jasongin/cordova-plugin-compat/blob/master/scripts/Modularize.js The transformation to a module includes: * Generation of build.gradle for the plugin module - Referencing a custom gradle file from the plugin if specified in plugin.xml - Referencing dependency plugins if specified in plugin.xml * Generation of AndroidManifest.xml for the plugin module - Including config-file transformations specified in plugin.xml for AndroidManifest.xml - (The contents of the module's AndroidManifest.xml get automatically merged into the app at build time.) * Copying source files and resources to correct subdirectories within the module - Remapping to the directory structure preferred by Android Studio: src/main/java and src/main/res I verified with several real plugins in a test app project that the result builds successfully, after you also reference the plugins' modules in the application root settings.gradle. The script depends on some things in cordova-common, though I have not included a package.json that specifies that dependency; you'll have to `npm install cordova-common` explicitly if you want to try it out. There are some TODOs in the code for things that would be required to make the solution more complete. And probably I have forgotten some things, which could be found by testing with more plugins. But it's a good start. While I put it in (my fork of) cordova-plugin-compat, that is just temporary for lack of a better place. I haven't done any work to integrate this kind of transformation into cordova-android plugin installation code, as was suggested on the call. Please note I'm not planning to do any more work on this feature. I hope someone else can pick this up and build on this idea, so that cordova-android can maintain compatibility with lots of 3rd-party plugins that might not get updated anytime soon. Jason -Original Message- From: Jesse [mailto:purplecabb...@gmail.com] Sent: Wednesday, June 1, 2016 4:28 PM To: dev@cordova.apache.org Subject: Re: Proposal: Change Android Project Directory Structure to Android Studio style The newer version of push is here [1] and it would break also, we can discuss this more in the hangout. Also, note that it is not 20k references, but more like 2k ;) [1] https://github.com/phonegap/phonegap-plugin-push @purplecabbage risingj.com On Tue, May 31, 2016 at 2:56 PM, Frederico Galvão < frederico.gal...@pontoget.com.br> wrote: > I know it's only a detail, but > https://github.com/phonegap-build/PushPlugin, > the example used as a plugin that would "break", is a deprecated and > old plugin. > > 2016-05-31 13:46 GMT-03:00 Nikhil Khandelwal : > > > It sounds like you are working on a plan to remap the older > > directory structure to a new one. Will look forward to updates on > > the design and > code > > for that. In that case our expectation is that most plugins will not > break > > - is that correct? It will be great to do some compat testing with > > say > the > > top plugins. > > > > I understand it's hard to guarantee complete compat and we need to > > move forward but breaking the entire plugin ecosystem will cause a > > lot of > issues > > for existing Cordova developers. > > > > -Nikhil > > > > -Original Message- > > From: Joe Bowser [mailto:bows...@gmail.com] > > Sent: Tuesday, May 31, 2016 8:22 AM > > To: dev > > Subject: Re: Proposal: Change Android Project Directory Structure to > > Android Studio style > > > > On Fri, May 27, 2016 at 12:22 PM, Nikhil Khandelwal < > > nikhi...@microsoft.com> > > wrote: > > > > > As I see it, a change to the directory structure will break almost > > > every Android plugin currently out there. > > > > > > > > I know. However, I don't think that's a good enough reason to not > > do > this. > > > > > > > There are atleast 20K references [1] on github where people use > > > depend on the current directory structure for android: > > > "res/xml/config.xml". > > > > > > Taking the example of a config.xml manipulation that will now stop > > working: > > > https://github.com/phonegap-build/PushPlugin/blob/master/plugin.xm > > > l#L3 > > > 4 > > > > > > Can you explain how source-file and other tags that reference path > > > will continue to work? Looking at your current branch [2] there > > > are not changes to path old path references in plugin.xml to new path. > > > > > > > Actually, here's the thing. They won't. We're going to have to fix > > our tooling so that they remap. After working on the exploratory > > branch, all our plugin installation code is stuck in plugman and > > really should be handled by the platforms so that we can actually > > handle changes to > Android > > Studio and Xcode. > > > > What I'm now proposing is that by default when we specify a source > > file, or a con
[GitHub] cordova-cli pull request #256: CB-11349 passing --fetch to create
Github user purplecabbage commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/256#discussion_r65622045
--- Diff: src/cli.js ---
@@ -464,12 +464,15 @@ function cli(inputArgs) {
cfg.lib = cfg.lib || {};
cfg.lib.www = wwwCfg;
}
-
-// create(dir, id, name, cfg)
+var fetchOpt = false;
+if (args['fetch']) {
+fetchOpt = true;
+}
return cordova.raw.create( undashed[1] // dir to create the
project in
, undashed[2] // App id
, undashed[3] // App name
, cfg
+, fetchOpt
--- End diff --
how about just passing?
``` args['fetch'] != undefined ```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
Hangout
After a slight delay, we are live. https://www.youtube.com/watch?v=BdJCIsZ5OS0 @purplecabbage risingj.com
[GitHub] cordova-cli pull request #256: CB-11349 passing --fetch to create
GitHub user carynbear opened a pull request: https://github.com/apache/cordova-cli/pull/256 CB-11349 passing --fetch to create You can merge this pull request into a Git repository by running: $ git pull https://github.com/carynbear/cordova-cli master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-cli/pull/256.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #256 commit c007ca593b38c514af019ccf54f0612e1cc262d7 Author: carynbear Date: 2016-06-02T18:17:28Z CB-11349 passing --fetch to create --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
RE: [Vote] Cordova-windows 4.4.0 release
I vote +1 * Reviewed Release notes * Verified that blank app creates correctly with platform * Verified that blank app can be successfully built and ran Thanks, Sergey -Original Message- From: Alexander Sorokin (Akvelon) [mailto:v-als...@microsoft.com] Sent: Thursday, June 2, 2016 6:11 PM To: dev@cordova.apache.org Subject: RE: [Vote] Cordova-windows 4.4.0 release I vote +1. * Verified archives via `coho verify-archive` * Verified tags manually * Verified that blank app creates correctly with platform * Verified that blank app can be successfully built and ran * Verified that platform can be updated from previous version * Verified compatibility with core plugins (ran autotests for released and edge plugin versions) * Verified release notes * Verified version * Verified line breaks Thanks, Alexander Sorokin -Original Message- From: Vladimir Kotikov (Akvelon) [mailto:v-vlk...@microsoft.com] Sent: Tuesday, May 31, 2016 5:51 PM To: dev@cordova.apache.org Subject: [Vote] Cordova-windows 4.4.0 release Please review and vote on this 5.0.0 Android Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues.apache.org%2fjira%2fbrowse%2fCB-11334&data=01%7c01%7cv-alsoro%40microsoft.com%7cb8ab3520cd4448b61bf808d38963060b%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=u2c5j81Bk8wa26Ddj%2fAERPHP8%2f2cdWwRyNSRymZLLOo%3d The archive has been published to dist/dev: https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fdist.apache.org%2frepos%2fdist%2fdev%2fcordova%2fCB-11334&data=01%7c01%7cv-alsoro%40microsoft.com%7cb8ab3520cd4448b61bf808d38963060b%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=fggyRRVKmyWeZDZV9HQV69Y%2fc0Zij0LlrJQXAqPo9cs%3d The package was published from its corresponding git tag: cordova-windows: 4.4.0 (4c0c81a121) Note that you can test it out via: cordova platform add https://github.com/apache/cordova-windows#4.4.0 Upon a successful vote I will upload the archive to dist/, publish it to npm, and post the blog post. Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md Voting will go on for a minimum of 48 hours. I vote +1: * Ran coho audit-license-headers over the repo * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses * Ensured continuous build was green when repo was tagged * Ran unit and e2e tests * Created and ran mobilespec app - Best regards, Vladimir - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
RE: [DISCUSS] Cordova-windows release
Guys, need one more vote - Best regards, Vladimir -Original Message- From: Vladimir Kotikov (Akvelon) [mailto:v-vlk...@microsoft.com] Sent: Friday, May 27, 2016 11:03 PM To: dev@cordova.apache.org Subject: RE: [DISCUSS] Cordova-windows release Makes sense. I'll proceed w/ minor version update. The next version will be 4.4.0 - Best regards, Vladimir -Original Message- From: Nikhil Khandelwal [mailto:nikhi...@microsoft.com] Sent: Friday, May 27, 2016 9:36 PM To: dev@cordova.apache.org Subject: RE: [DISCUSS] Cordova-windows release I agree this qualifies for a minor version bump. I feel like these are the inner workings of the clean command and not a very explicit contract that we know anyone depends on. -Nikhil -Original Message- From: Jason Ginchereau [mailto:jason...@microsoft.com] Sent: Friday, May 27, 2016 9:26 AM To: dev@cordova.apache.org Subject: RE: [DISCUSS] Cordova-windows release How is that a breaking change? Note it doesn't affect a platform-centric workflow. I had expected only a minor version bump would be appropriate. -Original Message- From: Vladimir Kotikov (Akvelon) [mailto:v-vlk...@microsoft.com] Sent: Friday, May 27, 2016 2:21 AM To: dev@cordova.apache.org Subject: [DISCUSS] Cordova-windows release Hey, guys We're planning to do a major cordova-windows v.5.0.0 release. The major version bump is mostly required due to changed behavior of 'clean' command which now wipes 'www' contents as well as build artifacts which can be considered as a breaking change for some users. Here is the list of changes to be included: CB-7: Optimize prepare for windows platform, clean prepared files CB-11259: Improving build output CB-11204: Catch when SDK not present on build and give appropriate error message CB-11156 Change default FadeSplashScreenDuration value CB-11176 Fix windows-splashscreen compatibility with older plugin versions CB-11139 Use PluginManager from common to install/uninstall plugins CB-10653 Making the windows activation context complete CB-11150 CI Error - Windows Platform - Could not find XHR config file CB-8056 Implement splashscreen for Windows platform CB-11066 Remove uap prefixed capabilities along with regular ones CB-11022 Duplicate www files on plugin installtion CB-10964 Handle build.json file starting with a BOM. This closes #166 CB-11024: Add preference to set the min UAP target version in the JSProj File Does anyone have any reason to delay a this release? Any other patches to land? Any objections? If not, I will start the vote on Monday - Best regards, Vladimir - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
RE: [Vote] Cordova-windows 4.4.0 release
I vote +1. * Verified archives via `coho verify-archive` * Verified tags manually * Verified that blank app creates correctly with platform * Verified that blank app can be successfully built and ran * Verified that platform can be updated from previous version * Verified compatibility with core plugins (ran autotests for released and edge plugin versions) * Verified release notes * Verified version * Verified line breaks Thanks, Alexander Sorokin -Original Message- From: Vladimir Kotikov (Akvelon) [mailto:v-vlk...@microsoft.com] Sent: Tuesday, May 31, 2016 5:51 PM To: dev@cordova.apache.org Subject: [Vote] Cordova-windows 4.4.0 release Please review and vote on this 5.0.0 Android Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues.apache.org%2fjira%2fbrowse%2fCB-11334&data=01%7c01%7cv-alsoro%40microsoft.com%7cb8ab3520cd4448b61bf808d38963060b%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=u2c5j81Bk8wa26Ddj%2fAERPHP8%2f2cdWwRyNSRymZLLOo%3d The archive has been published to dist/dev: https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fdist.apache.org%2frepos%2fdist%2fdev%2fcordova%2fCB-11334&data=01%7c01%7cv-alsoro%40microsoft.com%7cb8ab3520cd4448b61bf808d38963060b%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=fggyRRVKmyWeZDZV9HQV69Y%2fc0Zij0LlrJQXAqPo9cs%3d The package was published from its corresponding git tag: cordova-windows: 4.4.0 (4c0c81a121) Note that you can test it out via: cordova platform add https://github.com/apache/cordova-windows#4.4.0 Upon a successful vote I will upload the archive to dist/, publish it to npm, and post the blog post. Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md Voting will go on for a minimum of 48 hours. I vote +1: * Ran coho audit-license-headers over the repo * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses * Ensured continuous build was green when repo was tagged * Ran unit and e2e tests * Created and ran mobilespec app - Best regards, Vladimir - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
