Nightly build #51 for cordova has failed

2016-06-24 Thread Apache Jenkins Server
Nightly build #51 for cordova has failed.

Please check failure details on build details page at 
https://builds.apache.org/job/cordova-nightly/51/
You can also take a look at build console: 
https://builds.apache.org/job/cordova-nightly/51/consoleFull

-
Jenkins for Apache Cordova

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-coho pull request #127: Update platforms-release-process.md

2016-06-24 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-coho/pull/127


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-coho pull request #127: Update platforms-release-process.md

2016-06-24 Thread stevengill
GitHub user stevengill opened a pull request:

https://github.com/apache/cordova-coho/pull/127

Update platforms-release-process.md



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/stevengill/cordova-coho patch-54

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-coho/pull/127.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #127


commit 1a18a04efc051e14c18e8b49fee45f6a4f7f088b
Author: Steve Gill 
Date:   2016-06-24T23:08:47Z

Update platforms-release-process.md




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-lib issue #458: CB-11412 template support for www folders

2016-06-24 Thread codecov-io
Github user codecov-io commented on the issue:

https://github.com/apache/cordova-lib/pull/458
  
## [Current coverage][cc-pull] is **80.59%**
> Merging [#458][cc-pull] into [master][cc-base-branch] will increase 
coverage by **0.01%**

```diff
@@ master   #458   diff @@
==
  Files68 68  
  Lines  5377   5380 +3   
  Methods 851851  
  Messages  0  0  
  Branches   1039   1038 -1   
==
+ Hits   4333   4336 +3   
  Misses 1044   1044  
  Partials  0  0  
```

> Powered by [Codecov](https://codecov.io?src=pr). Last updated by 
[0c6f88d...086c991][cc-compare]
[cc-base-branch]: 
https://codecov.io/gh/apache/cordova-lib/branch/master?src=pr
[cc-compare]: 
https://codecov.io/gh/apache/cordova-lib/compare/0c6f88d2b136cf78ce57f323b75600a9b284e58a...086c9913682cd82d1d364621f4dfa8322985e263
[cc-pull]: https://codecov.io/gh/apache/cordova-lib/pull/458?src=pr


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-cli pull request #257: CB-11412 removed link-to, aliased copy-from t...

2016-06-24 Thread carynbear
GitHub user carynbear opened a pull request:

https://github.com/apache/cordova-cli/pull/257

CB-11412 removed link-to, aliased copy-from to template

@stevengill and also merge lib!

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/carynbear/cordova-cli CB-11412

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-cli/pull/257.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #257


commit 195159aec3f3e236093f9f6b999cb16626147c25
Author: carynbear 
Date:   2016-06-24T21:25:51Z

CB-11412 removed link-to, aliased copy-from to template




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-lib pull request #458: CB-11412 template support for www folders

2016-06-24 Thread carynbear
GitHub user carynbear opened a pull request:

https://github.com/apache/cordova-lib/pull/458

CB-11412 template support for www folders

@stevengill yay but also need to merge the cordova-cli!

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/carynbear/cordova-lib CB-11412-remove-linking

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/458.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #458


commit 086c9913682cd82d1d364621f4dfa8322985e263
Author: carynbear 
Date:   2016-06-24T21:22:17Z

CB-11412 template support for www folders




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-osx issue #35: added support for native calls into javascript for os...

2016-06-24 Thread tripodsan
Github user tripodsan commented on the issue:

https://github.com/apache/cordova-osx/pull/35
  
@kusog I still don't really understand why you need this. can you provide a 
code example of how this is used?

please note, that compared to iOS, we can execute javascript directly in 
the webview, eg:

```
NSString* testId = [self.webView 
stringByEvaluatingJavaScriptFromString:@"runTests()"];
```

if you need more, we would also need to add more methods to the `CDVBridge` 
to simplify the bindings.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-osx issue #35: added support for native calls into javascript for os...

2016-06-24 Thread tripodsan
Github user tripodsan commented on the issue:

https://github.com/apache/cordova-osx/pull/35
  
> this means that I can use JavaScript for Automation on Yosemite ?
no. this means, you can call cordova from the native shell code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-osx issue #35: added support for native calls into javascript for os...

2016-06-24 Thread tripodsan
Github user tripodsan commented on the issue:

https://github.com/apache/cordova-osx/pull/35
  
created corresponding jira bug: CB-11483


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[CI] Build status for 06/24

2016-06-24 Thread Sergey Shakhnazarov (Akvelon)
Hi guys,



Build Status (# of test failures):

1  - Android

1 - iOS

0  - WP 8.1

0  - Windows 8.1

0  - Windows 10



JIRAs that need attention:

· CB-11103 Flaky accelerometer tests

· CB-11479 ​File-transfer ​304 ​tests ​are ​failing ​on ​iOS

· Issue with --copy-from causing mobilespec creation failure on 
Buildbot [1]



[1]: https://github.com/cordova/cordova-discuss/pull/49#issuecomment-228346713


Best regards,
Sergey Shakhnazarov.



[GitHub] cordova-plugin-camera pull request #187: blackberry camera fixes

2016-06-24 Thread kovacs-tamas
Github user kovacs-tamas closed the pull request at:

https://github.com/apache/cordova-plugin-camera/pull/187


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-geolocation issue #78: navigator.geolocation.getCurrentPositi...

2016-06-24 Thread VPantaleo
Github user VPantaleo commented on the issue:

https://github.com/apache/cordova-plugin-geolocation/pull/78
  
I do not understand.
It means I have to wait for a new version?

Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-geolocation issue #78: navigator.geolocation.getCurrentPositi...

2016-06-24 Thread cordova-qa
Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-geolocation/pull/78
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-geolocation/pull/78/commits/006523732616ff94b03853d2580cf0e15263c778)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/16/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/16//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/16//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/16//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/16//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/16//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/16//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/16//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/16//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/16//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/16//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/16//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/16//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/16//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/16//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/16//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/16//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/16//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/16//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/16//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/16//PLATFORM=android/artifact/)
 |
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-geolocation pull request #78: navigator.geolocation.getCurren...

2016-06-24 Thread VPantaleo
GitHub user VPantaleo opened a pull request:

https://github.com/apache/cordova-plugin-geolocation/pull/78

navigator.geolocation.getCurrentPosition is very slow (Windows 10 mobile)

Hi,

Why in Windows 10 mobile the navigator.geolocation.getCurrentPosition 
return often Time Out ?

Thanks!

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/cordova-plugin-geolocation master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-geolocation/pull/78.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #78


commit 8fbceca845441f4f421548f243d2f05573d11225
Author: Guillaumedev 
Date:   2016-01-20T20:47:40Z

Update iOS geolocation plugin to avoid THREAD WARNING: ['Geolocation'], 
operation occurs in new Thread

commit ed59863125a4692a1800cf12d9552a5fb14d5e3b
Author: Norm Estabrook 
Date:   2016-03-25T20:12:29Z

updating readme witha sample and snippets

commit ba68accdb164606a4982ac569f8004f939e6e561
Author: Norm Estabrook 
Date:   2016-03-31T23:44:47Z

Removing sample link and including sample content

commit 2fff5f9bbda43b2473fd0ba2fa012375fe2fbd45
Author: Norm Estabrook 
Date:   2016-04-15T16:44:10Z

Merge branch 'master' of 
https://github.com/apache/cordova-plugin-geolocation

commit 444f84ad8e7bcc2b6ed2c54c568690875dfc6225
Author: Norm Estabrook 
Date:   2016-04-15T16:47:06Z

Updating weather part of this readme to use a new service

commit 72ec7bc640b4c55bb847c8d0128277de1a68f6a1
Author: Steve Gill 
Date:   2016-04-15T20:45:27Z

CB-11091 Incremented plugin version.

commit a16a75f8739bc47db9e2eb85babfd0eed8e89ac7
Author: Norm Estabrook 
Date:   2016-04-15T22:11:25Z

Merge branch 'master' of 
https://github.com/apache/cordova-plugin-geolocation

commit 5a66abc0e2052d48226fb9f790ef5b2d2af8ed8a
Author: Norm Estabrook 
Date:   2016-04-15T22:15:36Z

Adding links to subsections

commit b298182c00d66ebea430ea7090c8dfd744a2a69d
Author: Dmitry Blotsky 
Date:   2016-04-23T02:35:50Z

CB-10996 Adding front matter to README.md

commit f148399906284d6a08cbe6d4006914be2dbcda60
Author: Jesse MacFadyen 
Date:   2016-04-25T20:53:59Z

Merge branch 'master' of 
https://github.com/guillaumedev/cordova-plugin-geolocation

commit da4c1d4c55162fa9b752b1247fe3c9c4f08333df
Author: Norm Estabrook 
Date:   2016-04-27T21:31:55Z

Adding links to reference content and sample content to the top of the 
readme file

 This closes #76

commit b8f65bb60c6792694682ad5060eb9c7554c63785
Author: Nikhil Khandelwal 
Date:   2016-05-23T20:53:59Z

Add pull request template.

commit 006523732616ff94b03853d2580cf0e15263c778
Author: Vladimir Kotikov 
Date:   2016-06-10T09:00:54Z

Add badges for paramedic builds on Jenkins




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-camera issue #220: Fix Android bug in permission requests

2016-06-24 Thread cordova-qa
Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-camera/pull/220
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-camera/pull/220/commits/0ddc927890e8a353e5bed4581b644182ef8d19a3)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/35/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/35//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/35//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/35//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/35//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/35//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/35//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/35//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/35//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/35//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/35//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/35//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/35//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/35//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/35//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/35//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/35//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/35//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/35//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/35//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/35//PLATFORM=android/artifact/)
 |
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-ios issue #229: Incorrect reference to UIWebView

2016-06-24 Thread eladmoshe
Github user eladmoshe commented on the issue:

https://github.com/apache/cordova-ios/pull/229
  
Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-ios pull request #229: Incorrect reference to UIWebView

2016-06-24 Thread eladmoshe
Github user eladmoshe closed the pull request at:

https://github.com/apache/cordova-ios/pull/229


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-camera issue #220: Fix Android bug in permission requests

2016-06-24 Thread XiMnet
Github user XiMnet commented on the issue:

https://github.com/apache/cordova-plugin-camera/pull/220
  
Hi there!
  
 I'll be away from 24 Jun to 28 Jun and will be back next Wednesday. Thank 
you!
  
  
 Best Regards,
Sim




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-camera pull request #220: Fix Android bug in permission reque...

2016-06-24 Thread Gorcyn
GitHub user Gorcyn opened a pull request:

https://github.com/apache/cordova-plugin-camera/pull/220

Fix Android bug in permission requests



### Platforms affected
Android

### What does this PR do?
Fix a known bug: FIXME: Stop always requesting the permission

### What testing has been done on this change?
Logic

### Checklist
- [ ] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and 
submitted to secret...@apache.org.
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.

While trying to pick a picture form the library, the application ask for 
READ_EXTERNAL_STORAGE at each time.
This bug is due to the fact that if permissions[0] (CAMERA) is not granted, 
the code asks for READ_EXTERNAL_STORAGE.

Now, READ_EXTERNAL_STORAGE permission (persmissions[1]) is checked and 
asked if not granted, once.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Gorcyn/cordova-plugin-camera master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-camera/pull/220.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #220


commit 0ddc927890e8a353e5bed4581b644182ef8d19a3
Author: Ludovic Garcia 
Date:   2016-06-24T08:08:25Z

Fix Android bug in permission requests

While trying to pick a picture form the library, the application ask for 
READ_EXTERNAL_STORAGE at each time.
This bug is due to the fact that if permissions[0] (CAMERA) is not granted, 
the code asks for READ_EXTERNAL_STORAGE.

Now, READ_EXTERNAL_STORAGE permission (persmissions[1]) is checked and 
asked if not granted, once.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org