Nightly build #55 for cordova has succeeded!

[Apache Jenkins Server]

Nightly build #55 for cordova has succeeded!
The latest nightly has been published and you can try it out with 'npm i -g 
cordova@nightly'

For details check build console at 
https://builds.apache.org/job/cordova-nightly/55/consoleFull

-
Jenkins for Apache Cordova

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request #257: CB-11412 removed link-to, aliased copy-from t...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-cli/pull/257


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #458: CB-11412 template support for www folders

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/458


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media issue #95: CB-11148 - BB10 Media getDuration does not w...

[dpeacock]

Github user dpeacock commented on the issue:

https://github.com/apache/cordova-plugin-media/pull/95
  
The test that failed is an iOS test... this commit is only for 
'src/blackberry10/index.js' not sure how the two could be related... thoughts?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media issue #94: CB-11146 - getDuration only available after ...

[emirdeliz]

Github user emirdeliz commented on the issue:

https://github.com/apache/cordova-plugin-media/pull/94
  
Some resolution for this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media issue #95: CB-11148 - BB10 Media getDuration does not w...

[emirdeliz]

Github user emirdeliz commented on the issue:

https://github.com/apache/cordova-plugin-media/pull/95
  
Some resolution for this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request #313: Support project template with aar for bui...

[HenryPing]

Github user HenryPing closed the pull request at:

https://github.com/apache/cordova-android/pull/313


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request #313: Support project template with aar for bui...

[HenryPing]

GitHub user HenryPing opened a pull request:

https://github.com/apache/cordova-android/pull/313

Support project template with aar for building app with custom plugins



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/adobe-marketing-cloud-mobile/aemm-android aar

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-android/pull/313.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #313


commit eaef4d47a23faafa4ce4e764c0d04fa882da920c
Author: Steve Gill 
Date:   2016-01-21T00:18:52Z

Update JS snapshot to version 5.1.0 (via coho)

commit 2bf47422ce7b307bc780c09bf130554a6d988322
Author: Steve Gill 
Date:   2016-02-24T19:50:06Z

Update JS snapshot to version 5.1.1 (via coho)

commit 9aa758a1d1980c4ac0ec2b2e24cb84a20301a2c0
Author: riknoll 
Date:   2016-02-03T21:12:21Z

CB-10498: Resume event should be sticky if it has a plugin result

commit bf74f97e7f54a4dbfa690a92fa657a4190ccfeae
Author: Steve Gill 
Date:   2016-02-24T19:50:06Z

Set VERSION to 5.1.1 (via coho)

commit 41ac464aca1fb8fae3871b433c1f2c24a1119b91
Author: Steve Gill 
Date:   2016-02-25T19:33:16Z

Set VERSION to 5.1.1 (via coho)

commit 765a93b3e749e1be2b72e275133c83c406c8e84e
Author: Steve Gill 
Date:   2016-02-25T19:33:16Z

Update JS snapshot to version 5.1.1 (via coho)

commit f485c1ec7ccecdb8cd61c4433982b3073588cbca
Author: Matt Mullins 
Date:   2016-05-24T22:15:32Z

Set version to 0.1.0-dev

commit 14ad2966760bb5e9ec0a0c7e01e8d26d1c2c5955
Author: Matt Mullins 
Date:   2016-05-24T23:03:31Z

Reverting version change

- Turns out the version is used for plugin dependency management

commit f449bd8dc1f90a74fbbfb773583975661ef69f8b
Author: Matt Mullins 
Date:   2016-05-24T23:35:05Z

First crack at getting "platform add" working

- Use "cordova platform add  --verbose" in a vanilla 
cordova project
- Build doesn't work yet due to transitive dependency issues
- This is an in-progress non-working version of aemm-lib-release.aar

commit ea528d7232a95733cb4da43ba804cff270a3c37f
Author: Matt Mullins 
Date:   2016-05-27T22:28:50Z

Use our custom version of cordova.js

commit 730c93abd93c6c339a2d19245148a94e438d7448
Author: Matt Mullins 
Date:   2016-06-01T01:38:57Z

Resolve issues with transitive dependencies

- dependencies.gradle lists all our dependencies. We use it when creating 
the AAR and again when building the cordova project.
- update AAR
- side step project.properties issues

commit 7cc32fe72469647034944989d596fd5ee34675b0
Author: Matt Mullins 
Date:   2016-06-01T18:02:44Z

Add mobile-services jar (and un-gitignore it)

commit 391a28fa0c0ad96ffa87571a7df2ed08bcfff102
Author: Matt Mullins 
Date:   2016-06-01T18:25:51Z

Replace corrupt aar

commit 5d86466a1e431292eca99ae4f11dafd577c63adf
Author: mttmllns 
Date:   2016-06-01T20:46:49Z

Try to replace corrupt aar again

commit e3d6119e6ea89d51958fba93c7a4f13b6bf67d28
Author: Matt Mullins 
Date:   2016-06-01T20:50:27Z

Delete aars...

commit 4e1ee89b51a28425e4378581c39f2a67f48860c9
Author: Matt Mullins 
Date:   2016-06-01T20:51:27Z

Corrupt aar again...

commit b4de460239ee9422ca687f2c1893c48aba8ac399
Author: mttmllns 
Date:   2016-06-01T20:53:31Z

More corrupt aar tweaks...

commit 95b843df62fcf8d8d820a15003a613497f2cc862
Author: Matt Mullins 
Date:   2016-06-01T21:09:12Z

Delete binaries

commit a1e259435cab507107810705d9f130e91f4f2c26
Author: Matt Mullins 
Date:   2016-06-01T21:09:47Z

Hopefully last corrupt aar/jar fix

commit da75c22834a250d990592225fd2b651a77ce7ae3
Author: Henry Ping 
Date:   2016-06-09T22:54:21Z

Added missing java/resource files from the template to the APK.

commit 3b7c98c77388d6f126588ba78aaac13c8d5e7b15
Author: Henry Ping 
Date:   2016-06-10T21:22:20Z

Updated aemm-lib-release.aar pointing to publication with various cordova 
plugins to ease the testing.

commit 776bc9683ea584aee91ec635a60d6b5d26fd2a96
Author: Henry Ping 
Date:   2016-06-15T23:54:54Z

- Updated aemm-lib-release.aar from 
https://git.corp.adobe.com/mmullins/viewer-android/commit/a813e58e66809983747fa2ce4217bdd41217fbdd
- Enable "isPreview" by default to allow previewing local content via 
PhoneGap server, it will be disabled by AppBuilder

commit 

[GitHub] cordova-plugin-wkwebview-engine issue #7: Fixes CB-11074: WKWebView configur...

[shazron]

Github user shazron commented on the issue:

https://github.com/apache/cordova-plugin-wkwebview-engine/pull/7
  
I'm creating failing unit tests for this first, I think we have passed the 
point where we can argue about the implementation, but we need objective 
verification: https://issues.apache.org/jira/browse/CB-11496


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request #178: Grant Lollipop permission requests

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-android/pull/178


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-wkwebview-engine issue #8: CB-11074: Ensure settings from con...

[shazron]

Github user shazron commented on the issue:

https://github.com/apache/cordova-plugin-wkwebview-engine/pull/8
  
I'm creating failing unit tests for this first, I think we have passed the 
point where we can argue about the implementation, but we need objective 
verification: https://issues.apache.org/jira/browse/CB-11496


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android issue #178: Grant Lollipop permission requests

[infil00p]

Github user infil00p commented on the issue:

https://github.com/apache/cordova-android/pull/178
  
BTW: I'm going to close this and recommend that the approach dpogue is 
mentioning be taken.  We can't guarantee behaviour across multiple webviews.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser issue #116: Added support for file:/// access

[shazron]

Github user shazron commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/116
  
Thanks for this PR. There's 3 issues with this PR:
1. It doesn't merge cleanly anymore - the commits should be rebased
2. An issue should be created for this in issues.cordova.io so it can be 
tracked (as you can see there are lots of PRs here that are less likely to be 
tracked vs JIRA)
3. Once an issue is created, prefix the PR with the issue token, e.g. 
"CB-" so it can be automatically tracked to the issue


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser issue #116: Added support for file:/// access

[mani95lisa]

Github user mani95lisa commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/116
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Why doesn't `cordova.requestPermission` have an `callbackContext` arg?

[Philipp Kursawe]

I see. Cordova already uses a `permissionResultCallbacks` that holds the
user provided `requestCode`. It could additionally hold the
`callbackContext`.
And when android calls `CordovaInterfaceImpl.onRequestPermissionResult` it
could call a new plugin function with a new signature that contains the
`callbackContext`.


On Tue, Jun 28, 2016 at 10:36 AM, julio cesar sanchez <
jcesarmob...@gmail.com> wrote:

> onRequestPermissionResult is an Android method we have to override, so we
> can't choose which params to pass.
>
>
> https://developer.android.com/reference/android/support/v4/app/ActivityCompat.OnRequestPermissionsResultCallback.html
>
>
> 2016-06-28 10:29 GMT+02:00 Philipp Kursawe :
>
> > I wonder about this API design decision.
> >
> > The current API forces us to save the callback context in some state
> > variable to have access to it
> > in the plugins `onRequestPermissionResult` like this:
> >
> > private void requestPermissionAction(CallbackContext callbackContext,
> > JSONArray permission) {
> >   this.permissionsCallback = callbackContext;
> >   cordova.requestPermission(this, REQUEST_CODE_ENABLE_PERMISSION,
> > permission.getString(0));
> > }
> >
> > @Override
> > public void onRequestPermissionResult(int requestCode, String[]
> > permissions, int[] grantResults) {
> >   if (this.permissionsCallback == null) {
> > return;
> >   }
> >
> >   if (permissions != null && permissions.length > 0) {
> > this.permissionsCallback.success();
> >   } else {
> > this.permissionsCallback.error("No permission");
> >   }
> >   this.permissionsCallback = null;
> > }
> >
> > This works but limits the concurrent calls to the plugins
> > `requestPermissionAction` to one caller from the script at a time (that
> > means until the success or error callbacks are called in the script).
> > Otherwise the `this.permissionCallback` would be set again for a second
> > call and when the first calls `onRequestPermissionResult` is called it
> will
> > actually call the handlers of the second `requestPermissionAction`
> > callbackContext.
> >
> > Wouldn't this API signature make more sense?
> >
> > cordova.requestPermission(CordovaPlugin plugin, int requestCode, String
> > permission, CallbackContext callbackContext);
> >
> > @Override
> > public void onRequestPermissionResult(int requestCode, String[]
> > permissions, int[] grantResults, CallbackContext callbackContext) {
> >   if (permissions != null && permissions.length > 0) {
> > permissionsCallback.success();
> >   } else {
> > permissionsCallback.error("No permission");
> >   }
> > }
> >
> >
> > And while we are at: Change `permission[]` and `grantResults[]` to an
> > object `results[permission] = grantResult`?
> >
>

Re: Why doesn't `cordova.requestPermission` have an `callbackContext` arg?

[julio cesar sanchez]

onRequestPermissionResult is an Android method we have to override, so we
can't choose which params to pass.

https://developer.android.com/reference/android/support/v4/app/ActivityCompat.OnRequestPermissionsResultCallback.html


2016-06-28 10:29 GMT+02:00 Philipp Kursawe :

> I wonder about this API design decision.
>
> The current API forces us to save the callback context in some state
> variable to have access to it
> in the plugins `onRequestPermissionResult` like this:
>
> private void requestPermissionAction(CallbackContext callbackContext,
> JSONArray permission) {
>   this.permissionsCallback = callbackContext;
>   cordova.requestPermission(this, REQUEST_CODE_ENABLE_PERMISSION,
> permission.getString(0));
> }
>
> @Override
> public void onRequestPermissionResult(int requestCode, String[]
> permissions, int[] grantResults) {
>   if (this.permissionsCallback == null) {
> return;
>   }
>
>   if (permissions != null && permissions.length > 0) {
> this.permissionsCallback.success();
>   } else {
> this.permissionsCallback.error("No permission");
>   }
>   this.permissionsCallback = null;
> }
>
> This works but limits the concurrent calls to the plugins
> `requestPermissionAction` to one caller from the script at a time (that
> means until the success or error callbacks are called in the script).
> Otherwise the `this.permissionCallback` would be set again for a second
> call and when the first calls `onRequestPermissionResult` is called it will
> actually call the handlers of the second `requestPermissionAction`
> callbackContext.
>
> Wouldn't this API signature make more sense?
>
> cordova.requestPermission(CordovaPlugin plugin, int requestCode, String
> permission, CallbackContext callbackContext);
>
> @Override
> public void onRequestPermissionResult(int requestCode, String[]
> permissions, int[] grantResults, CallbackContext callbackContext) {
>   if (permissions != null && permissions.length > 0) {
> permissionsCallback.success();
>   } else {
> permissionsCallback.error("No permission");
>   }
> }
>
>
> And while we are at: Change `permission[]` and `grantResults[]` to an
> object `results[permission] = grantResult`?
>

Why doesn't `cordova.requestPermission` have an `callbackContext` arg?

[Philipp Kursawe]

I wonder about this API design decision.

The current API forces us to save the callback context in some state
variable to have access to it
in the plugins `onRequestPermissionResult` like this:

private void requestPermissionAction(CallbackContext callbackContext,
JSONArray permission) {
  this.permissionsCallback = callbackContext;
  cordova.requestPermission(this, REQUEST_CODE_ENABLE_PERMISSION,
permission.getString(0));
}

@Override
public void onRequestPermissionResult(int requestCode, String[]
permissions, int[] grantResults) {
  if (this.permissionsCallback == null) {
return;
  }

  if (permissions != null && permissions.length > 0) {
this.permissionsCallback.success();
  } else {
this.permissionsCallback.error("No permission");
  }
  this.permissionsCallback = null;
}

This works but limits the concurrent calls to the plugins
`requestPermissionAction` to one caller from the script at a time (that
means until the success or error callbacks are called in the script).
Otherwise the `this.permissionCallback` would be set again for a second
call and when the first calls `onRequestPermissionResult` is called it will
actually call the handlers of the second `requestPermissionAction`
callbackContext.

Wouldn't this API signature make more sense?

cordova.requestPermission(CordovaPlugin plugin, int requestCode, String
permission, CallbackContext callbackContext);

@Override
public void onRequestPermissionResult(int requestCode, String[]
permissions, int[] grantResults, CallbackContext callbackContext) {
  if (permissions != null && permissions.length > 0) {
permissionsCallback.success();
  } else {
permissionsCallback.error("No permission");
  }
}


And while we are at: Change `permission[]` and `grantResults[]` to an
object `results[permission] = grantResult`?