[GitHub] cordova-plugin-camera pull request #115: CB-9490 Fixed cleanup function

2016-07-20 Thread cojomojo
Github user cojomojo closed the pull request at:

https://github.com/apache/cordova-plugin-camera/pull/115


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Nightly build #77 for cordova has failed

2016-07-20 Thread Apache Jenkins Server
Nightly build #77 for cordova has failed.

Please check failure details on build details page at 
https://builds.apache.org/job/cordova-nightly/77/
You can also take a look at build console: 
https://builds.apache.org/job/cordova-nightly/77/consoleFull

-
Jenkins for Apache Cordova

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[DISCUSS] cordova-create breakout from cordova-lib proposal

2016-07-20 Thread Steven Gill
Please review and comment at
https://github.com/cordova/cordova-discuss/pull/51


[GitHub] cordova-lib pull request #461: CB-9825 framework tag spec parsing

2016-07-20 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/461


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



RE: [DISCUSS] Platforms and tools releases

2016-07-20 Thread Vladimir Kotikov (Akvelon)
Sorry for delay, Jesse. I will publish it tomorrow morning.
Also could you please take a look at the blog post here: 
https://github.com/apache/cordova-docs/pull/621 

-
Best regards, Vladimir

-Original Message-
From: Jesse [mailto:purplecabb...@gmail.com] 
Sent: Wednesday, July 20, 2016 10:29 PM
To: dev@cordova.apache.org
Subject: Re: [DISCUSS] Platforms and tools releases

Where are we with the tools release?
CB-11023 has landed in cordova-lib master but has not been released yet.

It would be great to get this out.



@purplecabbage
risingj.com

On Mon, Jul 11, 2016 at 5:27 PM, Steven Gill  wrote:

> LGTM.
>
> Published the android 5.2.0 blog post. I published cordova-android 
> 5.2.0 on npm and dist before I left for the week off.
>
> For tools, I'd say include those two changes and make it a minor 
> instead of patch release.
>
> -Steve
>
>
>
> On Mon, Jul 11, 2016 at 9:00 AM, Vladimir Kotikov (Akvelon) < 
> v-vlk...@microsoft.com> wrote:
>
> > Please review blog post for Android:
> > https://github.com/apache/cordova-docs/pull/619
> > Also I noticed that we still didn't announce Android 5.2.0 - the PR 
> > is
> not
> > yet merged: https://github.com/apache/cordova-docs/pull/617
> >
> > -
> > Best regards, Vladimir
> >
> > -Original Message-
> > From: Vladimir Kotikov (Akvelon) [mailto:v-vlk...@microsoft.com]
> > Sent: Monday, July 11, 2016 3:52 PM
> > To: dev@cordova.apache.org
> > Subject: RE: [DISCUSS] Platforms and tools releases
> >
> > Nope. I didn't include this into the list of patches to release 
> > because I was thinking of a patch release that will not include new 
> > features.
> However
> > we could do a minor release instead, as we have 2 features live in
> master:
> > 'edit-config' and improved 'template' functionality.
> >
> > Thoughts?
> >
> > -
> > Best regards, Vladimir
> >
> > -Original Message-
> > From: Simon MacDonald [mailto:simon.macdon...@gmail.com]
> > Sent: Monday, July 11, 2016 3:35 PM
> > To: dev@cordova.apache.org
> > Subject: Re: [DISCUSS] Platforms and tools releases
> >
> > Has CB-11023 - plugin.xml should be able to add attribute to an 
> > existing element in AndroidManifest.xml been merged into a release? 
> > Apologies if I missed it.
> >
> > Simon Mac Donald
> >
> >
> https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fhi.im%
> 2fsimonmacdonald&data=01%7c01%7cv-vlkoti%40microsoft.com%7c0582012e3bc
> e4d42b79708d3a987e9e9%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=8XH
> Sb45049MNOgI6fkOwPA0CUge0X8kV0jXlkl%2bAdIE%3d
> >
> > On Mon, Jul 11, 2016 at 12:00 AM, Steven Gill 
> > 
> > wrote:
> >
> > > Do it!
> > >
> > > On Fri, Jul 8, 2016 at 7:07 AM, Vladimir Kotikov (Akvelon) < 
> > > v-vlk...@microsoft.com> wrote:
> > >
> > > > Hi guys,
> > > >
> > > > Next week I'd like to do a tools release (cordova-cli and
> > > > cordova-lib) to update pinned versions of platforms and to get 
> > > > patch releases for 2 of 3 main platforms - Android (5.2.1) and 
> > > > Windows
> > (4.4.1).
> > > >
> > > > Here is the list of platforms' patches we're interested in:
> > > > Android:
> > > >   - CB-9489 Fixed "endless waiting for emulator" issue
> > > > Windows:
> > > >   - CB-11548 windows: Respect user-specified msbuild location
> > > >   - CB-11516 windows: Preparing icons w/ target fails
> > > >   - CB-11470 App crashes when trying to open from another app 
> > > > using
> > > Custom
> > > > URL
> > > >   - CB-11443 Splashscreen is created the second time on resume 
> > > > on Windows
> > > >
> > > > For tools if we're going to do a patch release here is also the 
> > > > list of important changes to include:
> > > > Cordova-cli:
> > > >   - CB-11284 Telemetry: Track platforms/plugins
> > > subcommands(add/rm/etc...)
> > > >   - CB-11263: 'cordova telemetry help' should display help text
> > > > Cordova-lib:
> > > >   - CB-11412 template support for www folders
> > > >   - Fix config.xml path in PlatformApi.prepare
> > > >   - CB-11412 improve template implementation
> > > >   - CB-11164 Allow forced dependent plugin removal
> > > >   - CB-11349 added --fetch and cordova fetch to create --template
> > > >   - CB-11274 Platform browser: wrong path for config.xml
> > > >   - CB-11274 Make serve dashboard take config.xml -> content.src 
> > > > entry point into account
> > > >   - CB-11261 Cut out '-nightly' prerelease tag when checking 
> > > > plugin
> > > engines
> > > >
> > > > Does anyone have any reason to delay a these releases? Any other 
> > > > patches to land?
> > > > If not, I will start the release Monday next week.
> > > >
> > > > -
> > > > Best regards, Vladimir
> > > >
> > > > 
> > > > 
> > > > - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > > > For additional commands, e-mail: dev-h...@cordova.apache.org
> > > >
> > > >
> > >
> >
> > 
> > - To unsubscribe, e-mail: dev-unsubs

[GitHub] cordova-plugin-inappbrowser pull request #167: doc: do not use `with` in JS ...

2016-07-20 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/167


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-windows issue #187: CB-11241 Return adding BOM to www back to prepar...

2016-07-20 Thread toddm
Github user toddm commented on the issue:

https://github.com/apache/cordova-windows/pull/187
  
:shipit:


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-inappbrowser issue #167: doc: do not use `with` in JS samples

2016-07-20 Thread purplecabbage
Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/167
  
This is big in my mind, gonna merge it now. 
A CLA would be appreciated at some point if you wish to contribute more.
Thanks for this @jakub-g 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: [DISCUSS] Platforms and tools releases

2016-07-20 Thread Jesse
Where are we with the tools release?
CB-11023 has landed in cordova-lib master but has not been released yet.

It would be great to get this out.



@purplecabbage
risingj.com

On Mon, Jul 11, 2016 at 5:27 PM, Steven Gill  wrote:

> LGTM.
>
> Published the android 5.2.0 blog post. I published cordova-android 5.2.0 on
> npm and dist before I left for the week off.
>
> For tools, I'd say include those two changes and make it a minor instead of
> patch release.
>
> -Steve
>
>
>
> On Mon, Jul 11, 2016 at 9:00 AM, Vladimir Kotikov (Akvelon) <
> v-vlk...@microsoft.com> wrote:
>
> > Please review blog post for Android:
> > https://github.com/apache/cordova-docs/pull/619
> > Also I noticed that we still didn't announce Android 5.2.0 - the PR is
> not
> > yet merged: https://github.com/apache/cordova-docs/pull/617
> >
> > -
> > Best regards, Vladimir
> >
> > -Original Message-
> > From: Vladimir Kotikov (Akvelon) [mailto:v-vlk...@microsoft.com]
> > Sent: Monday, July 11, 2016 3:52 PM
> > To: dev@cordova.apache.org
> > Subject: RE: [DISCUSS] Platforms and tools releases
> >
> > Nope. I didn't include this into the list of patches to release because I
> > was thinking of a patch release that will not include new features.
> However
> > we could do a minor release instead, as we have 2 features live in
> master:
> > 'edit-config' and improved 'template' functionality.
> >
> > Thoughts?
> >
> > -
> > Best regards, Vladimir
> >
> > -Original Message-
> > From: Simon MacDonald [mailto:simon.macdon...@gmail.com]
> > Sent: Monday, July 11, 2016 3:35 PM
> > To: dev@cordova.apache.org
> > Subject: Re: [DISCUSS] Platforms and tools releases
> >
> > Has CB-11023 - plugin.xml should be able to add attribute to an existing
> > element in AndroidManifest.xml been merged into a release? Apologies if I
> > missed it.
> >
> > Simon Mac Donald
> >
> >
> https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fhi.im%2fsimonmacdonald&data=01%7c01%7cv-vlkoti%40microsoft.com%7c0582012e3bce4d42b79708d3a987e9e9%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=8XHSb45049MNOgI6fkOwPA0CUge0X8kV0jXlkl%2bAdIE%3d
> >
> > On Mon, Jul 11, 2016 at 12:00 AM, Steven Gill 
> > wrote:
> >
> > > Do it!
> > >
> > > On Fri, Jul 8, 2016 at 7:07 AM, Vladimir Kotikov (Akvelon) <
> > > v-vlk...@microsoft.com> wrote:
> > >
> > > > Hi guys,
> > > >
> > > > Next week I'd like to do a tools release (cordova-cli and
> > > > cordova-lib) to update pinned versions of platforms and to get patch
> > > > releases for 2 of 3 main platforms - Android (5.2.1) and Windows
> > (4.4.1).
> > > >
> > > > Here is the list of platforms' patches we're interested in:
> > > > Android:
> > > >   - CB-9489 Fixed "endless waiting for emulator" issue
> > > > Windows:
> > > >   - CB-11548 windows: Respect user-specified msbuild location
> > > >   - CB-11516 windows: Preparing icons w/ target fails
> > > >   - CB-11470 App crashes when trying to open from another app using
> > > Custom
> > > > URL
> > > >   - CB-11443 Splashscreen is created the second time on resume on
> > > > Windows
> > > >
> > > > For tools if we're going to do a patch release here is also the list
> > > > of important changes to include:
> > > > Cordova-cli:
> > > >   - CB-11284 Telemetry: Track platforms/plugins
> > > subcommands(add/rm/etc...)
> > > >   - CB-11263: 'cordova telemetry help' should display help text
> > > > Cordova-lib:
> > > >   - CB-11412 template support for www folders
> > > >   - Fix config.xml path in PlatformApi.prepare
> > > >   - CB-11412 improve template implementation
> > > >   - CB-11164 Allow forced dependent plugin removal
> > > >   - CB-11349 added --fetch and cordova fetch to create --template
> > > >   - CB-11274 Platform browser: wrong path for config.xml
> > > >   - CB-11274 Make serve dashboard take config.xml -> content.src
> > > > entry point into account
> > > >   - CB-11261 Cut out '-nightly' prerelease tag when checking plugin
> > > engines
> > > >
> > > > Does anyone have any reason to delay a these releases? Any other
> > > > patches to land?
> > > > If not, I will start the release Monday next week.
> > > >
> > > > -
> > > > Best regards, Vladimir
> > > >
> > > > 
> > > > - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > > > For additional commands, e-mail: dev-h...@cordova.apache.org
> > > >
> > > >
> > >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
>


Re: process.env.PWD vs process.cwd()

2016-07-20 Thread Steven Gill
Hey Toby,

Send over the PR if you don't mind. It got put on the backlog for me.

On Jul 20, 2016 10:46 AM, "Tobias Bocanegra"  wrote:

> Hi Steven,
>
> did you have a chance to take a look at this? If not, I would create a PR.
> Regards, Toby
>
> On Wed, Jun 8, 2016 at 10:17 AM, Steven Gill 
> wrote:
>
> > Hey Toby,
> >
> > Thanks for bringing this up. I'll take a look at it
> > On Jun 8, 2016 10:14 AM, "Tobias Bocanegra"  wrote:
> >
> > > Hi,
> > >
> > > btw, this also affects all those developers that use a java based IDE
> to
> > > invoke Cordova (Intellij, WebStorm, AppCode, Eclipse, Android Studio)
> > >
> > > Regards, Toby
> > >
> > >
> > > On Tue, Jun 7, 2016 at 10:08 PM, Tobias Bocanegra 
> > > wrote:
> > >
> > > > Hi,
> > > >
> > > > I see a different behaviour in relative plugin resolution between
> 6.1.1
> > > > and 6.2.
> > > > I'm invoking cordova via ant (java), which sets the current working
> > > > directory of the cordova process correctly, but does not change the
> > > env.PWD
> > > > [0].
> > > >
> > > > until 6.1.1 this was not a problem, but since 6.2 my relative plugin
> > > paths
> > > > don't resolve anymore. I tried to figure out where the change came
> > from,
> > > > but until now I was not successful.
> > > >
> > > > I would change the order of the assignment in [1] to:
> > > >
> > > > origCwd = process.cwd() || process.env.PWD;
> > > >
> > > > but since this didn't change between 6.1 and 6.2, I don't think this
> is
> > > > the culprit.
> > > > any advice?
> > > >
> > > > regards, toby
> > > >
> > > > for details see: https://issues.apache.org/jira/browse/CB-11387
> > > >
> > > > [0]
> > > >
> > >
> >
> https://docs.oracle.com/javase/7/docs/api/java/lang/Runtime.html#exec(java.lang.String[],%20java.lang.String[],%20java.io.File)
> > > > [1]
> > > >
> > >
> >
> https://github.com/apache/cordova-lib/blob/6.2.x/cordova-lib/src/cordova/util.js#L131
> > > >
> > >
> >
>


Re: process.env.PWD vs process.cwd()

2016-07-20 Thread Tobias Bocanegra
Hi Steven,

did you have a chance to take a look at this? If not, I would create a PR.
Regards, Toby

On Wed, Jun 8, 2016 at 10:17 AM, Steven Gill  wrote:

> Hey Toby,
>
> Thanks for bringing this up. I'll take a look at it
> On Jun 8, 2016 10:14 AM, "Tobias Bocanegra"  wrote:
>
> > Hi,
> >
> > btw, this also affects all those developers that use a java based IDE to
> > invoke Cordova (Intellij, WebStorm, AppCode, Eclipse, Android Studio)
> >
> > Regards, Toby
> >
> >
> > On Tue, Jun 7, 2016 at 10:08 PM, Tobias Bocanegra 
> > wrote:
> >
> > > Hi,
> > >
> > > I see a different behaviour in relative plugin resolution between 6.1.1
> > > and 6.2.
> > > I'm invoking cordova via ant (java), which sets the current working
> > > directory of the cordova process correctly, but does not change the
> > env.PWD
> > > [0].
> > >
> > > until 6.1.1 this was not a problem, but since 6.2 my relative plugin
> > paths
> > > don't resolve anymore. I tried to figure out where the change came
> from,
> > > but until now I was not successful.
> > >
> > > I would change the order of the assignment in [1] to:
> > >
> > > origCwd = process.cwd() || process.env.PWD;
> > >
> > > but since this didn't change between 6.1 and 6.2, I don't think this is
> > > the culprit.
> > > any advice?
> > >
> > > regards, toby
> > >
> > > for details see: https://issues.apache.org/jira/browse/CB-11387
> > >
> > > [0]
> > >
> >
> https://docs.oracle.com/javase/7/docs/api/java/lang/Runtime.html#exec(java.lang.String[],%20java.lang.String[],%20java.io.File)
> > > [1]
> > >
> >
> https://github.com/apache/cordova-lib/blob/6.2.x/cordova-lib/src/cordova/util.js#L131
> > >
> >
>


Re: Resigning

2016-07-20 Thread Jesse
Hi Dmitry,

We are doing well but miss your input ... :(

There is no reason to resign, unless you really want to break up.  We have
only ever had ~3 members resign before even though we still have pmc
members who have not contributed in years.  It is not a big deal to just
mute the channel and go off and do your thing.  Committing once every 3
months is welcomed too, even though you don't really need to be PMC for
that.

If you still want to go emeritus let us know, and we'll go through the
steps.
Otherwise, if you just want to mute some of the day to day, send emails to:
dev-unsubscr...@cordova.apache.org
private-unsubscr...@cordova.apache.org
commits-unsubscr...@cordova.apache.org
issues-unsubscr...@cordova.apache.org

(see http://cordova.apache.org/index.html#mailing-list)

Not sure how to remove you from the other lists that are not
controlled by us. Try "[listname]-unsubscr...@apache.org" to any
Apache wide lists that you are subscribed to.

No matter what you decide, it has been a pleasure committing with you and
you are always welcome back.

Cheers,
  Jesse


@purplecabbage
risingj.com

On Mon, Jul 18, 2016 at 9:11 PM, Joe Bowser  wrote:

> Hey
>
> I believe that you can resign your committership and PMC membership and go
> emeritus on this project.
>
> http://www.apache.org/dev/pmc.html#emeritus
>
> The main advantage I can see in becoming emeritus and giving up
> committership is that it's one less account you have to worry about.  Also,
> committership doesn't transfer between Apache projects.  For example, I
> don't have any commit access to httpd's SVN, so I can't create a log
> message saying "STOP USING PHP!!" every time mod_php is loaded or
> something (not that I would, but it's an example).  AFAIK, the only thing
> that really carries over is that you have a valid ICLA.
>
> Of course, an actual ASF person could probably direct you to some more
> useful information.
>
>
> On Mon, Jul 18, 2016 at 8:21 PM, Dmitry Blotsky 
> wrote:
>
> > Hey folks,
> >
> > I’ve been monitoring the mailing list weekly, but I’m realising that
> other
> > than that, I’ve contributed exactly one bug fix to Cordova since I
> departed
> > in April. So, I’m writing to ask if it would be possible (or advised) for
> > me to resign from the PMC and from the committer list. I remember someone
> > saying that we have an immensely large PMC, and I figured that removing
> > committer privileges from myself due to being a non-contributing member
> > might be the responsible thing to do. Do we have a process for this? Or
> > would you guys advise that I remain a committer in case that I contribute
> > to Cordova or to another ASF project in the future?
> >
> > On an unrelated note: I hope you’re all doing well! I can’t believe that
> > it’s only been 3 months since I left, because a whole lot has happened
> > since then. Glad to see Jenkins builds on the CI and new releases on the
> > blog, and also glad to see new faces and old (hey, Fil! :) ) come up on
> the
> > list.
> >
> > Kindly,
> > Dmitry
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
> >
>


[GitHub] cordova-windows issue #187: CB-11241 Return adding BOM to www back to prepar...

2016-07-20 Thread purplecabbage
Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-windows/pull/187
  
+1 :shipit: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-windows pull request #187: CB-11241 Return adding BOM to www back to...

2016-07-20 Thread purplecabbage
Github user purplecabbage commented on a diff in the pull request:

https://github.com/apache/cordova-windows/pull/187#discussion_r71557328
  
--- Diff: template/cordova/lib/prepare.js ---
@@ -512,8 +515,6 @@ function addBOMSignature(directory) {
 });
--- End diff --

+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-windows issue #187: CB-11241 Return adding BOM to www back to prepar...

2016-07-20 Thread sgrebnov
Github user sgrebnov commented on the issue:

https://github.com/apache/cordova-windows/pull/187
  
LGTM :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-windows issue #187: CB-11241 Return adding BOM to www back to prepar...

2016-07-20 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the issue:

https://github.com/apache/cordova-windows/pull/187
  
/cc @sgrebnov, @purplecabbage. Could you please take a look?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-lib issue #465: CB-11605 Non-destructive platform update

2016-07-20 Thread codecov-io
Github user codecov-io commented on the issue:

https://github.com/apache/cordova-lib/pull/465
  
## [Current coverage][cc-pull] is **61.73%**
> Merging [#465][cc-pull] into [master][cc-base-branch] will decrease 
coverage by **18.88%**

```diff
@@ master   #465   diff @@
==
  Files68 67  -1   
  Lines  5394   5405 +11   
  Methods 855856  +1   
  Messages  0  0   
  Branches   1040   1042  +2   
==
- Hits   4349   3337   -1012   
- Misses 1045   2068   +1023   
  Partials  0  0   
```

> Powered by [Codecov](https://codecov.io?src=pr). Last updated by 
[f05874a...82de549][cc-compare]
[cc-base-branch]: 
https://codecov.io/gh/apache/cordova-lib/branch/master?src=pr
[cc-compare]: 
https://codecov.io/gh/apache/cordova-lib/compare/f05874a5420ea5fcf5b96290cb1a7fe18fe3e6d6...82de54982af0e087a16da68a813baab01882d57c?src=pr
[cc-pull]: https://codecov.io/gh/apache/cordova-lib/pull/465?src=pr


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-lib pull request #465: CB-11605 Non-destructive platform update

2016-07-20 Thread purplecabbage
GitHub user purplecabbage opened a pull request:

https://github.com/apache/cordova-lib/pull/465

CB-11605 Non-destructive platform update

backup platformId@oldVersion before updating

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/purplecabbage/cordova-lib CB-11605

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/465.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #465


commit fdda80fe572e2766d5aeeb674de0c7334553d2cc
Author: Jesse MacFadyen 
Date:   2016-07-20T07:27:30Z

backup platformId@oldVersion before updating




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org