Nightly build #97 for cordova has succeeded!

2016-08-09 Thread Apache Jenkins Server
Nightly build #97 for cordova has succeeded!
The latest nightly has been published and you can try it out with 'npm i -g 
cordova@nightly'

For details check build console at 
https://builds.apache.org/job/cordova-nightly/97/consoleFull

-
Jenkins for Apache Cordova

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera issue #228: add CAMERA and READ_EXTERNAL_STORAGE permi...

2016-08-09 Thread cordova-qa
Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-camera/pull/228
  
Cordova CI Build has one or more failures. 

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-camera/pull/228/commits/5af4ea5a13621dc5420b7d6498b306a15bf8e49f)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/59/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/59//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/59//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/59//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/59//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/59//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/59//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/59//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/59//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/59//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/59//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/59//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/59//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/59//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/59//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/59//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/59//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/59//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/59//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/59//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/59//PLATFORM=android/artifact/)
 |
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-ios issue #234: CB-9825 cocoapod integration for plugins

2016-08-09 Thread shazron
Github user shazron commented on the issue:

https://github.com/apache/cordova-ios/pull/234
  
Sadly Jasmine 1.x doesn't have an `afterAll` global function unlike Jasmine 
2.x. You would have to nest the `describe` tests in a `describe`, sandwiched 
between two `it`s, the first is the `setup`, the last is the `teardown`. See: 
http://stackoverflow.com/a/24369236


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-ios issue #234: CB-9825 cocoapod integration for plugins

2016-08-09 Thread shazron
Github user shazron commented on the issue:

https://github.com/apache/cordova-ios/pull/234
  
The `podMod.spec.js` tests should have a “cleanup” after all tests are 
run (not sure how in Jasmine 1.0) which should remove the test products 
`tests/spec/unit/fixtures/testProj/platforms/ios/Podfile` and 
`tests/spec/unit/fixtures/testProj/platforms/ios/pods.json`

The `installPodSync` test is missing a check whether `pods.json` exists 
after write.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-ios issue #234: CB-9825 cocoapod integration for plugins

2016-08-09 Thread shazron
Github user shazron commented on the issue:

https://github.com/apache/cordova-ios/pull/234
  
Upon further review - the Podfile should not be added. The unit tests 
actually show the problem -- the Podfile was not created. The `spyOn` for 
`writeFileSync` in the tests should have a `.andCallThrough();` so the actual 
implementation is called.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-camera pull request #228: add CAMERA and READ_EXTERNAL_STORAG...

2016-08-09 Thread bisrael
GitHub user bisrael opened a pull request:

https://github.com/apache/cordova-plugin-camera/pull/228

add CAMERA and READ_EXTERNAL_STORAGE permissions to the manifest file…



### Platforms affected


### What does this PR do?


### What testing has been done on this change?


### Checklist
- [ ] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and 
submitted to secret...@apache.org.
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.

… so they can be enabled/disabled in the application manager settings for 
the application (plus they are requested at runtime now too).

fixes CB-11689

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bisrael/cordova-plugin-camera 
bisrael/add-uses-permissions

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-camera/pull/228.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #228


commit 5af4ea5a13621dc5420b7d6498b306a15bf8e49f
Author: bisrael 
Date:   2016-08-09T23:48:35Z

add CAMERA and READ_EXTERNAL_STORAGE permissions to the manifest file so 
they can be enabled/disabled in the application manager settings for the 
application (plus they are requested at runtime now too).

fixes CB-11689




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: [VOTE] Cordova-common@1.4.1 release

2016-08-09 Thread Caryn Tran
+1

On 8/9/16, 4:32 PM, "Steven Gill"  wrote:

>Please review and vote on this cordova-common Release
>by replying to this email (and keep discussion on the DISCUSS thread)
>
>Release issue: https://issues.apache.org/jira/browse/CB-11690
>
>Both tools have been published to
>dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-11690/
>
>The packages were published from their corresponding git tags:
>
>cordova-lib: common-1.4.1 (46051b800b)
>
>Upon a successful vote I will upload the archives to dist/, publish
>them to npm, and post the corresponding blog post.
>
>Voting guidelines:
>https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
>
>Voting will go on for a minimum of 48 hours.
>
>I vote +1:
>* Ran coho audit-license-headers over the relevant repos
>* Ran unit tests for lib and common
>* Built and ran mobile-spec for android



[VOTE] Cordova-common@1.4.1 release

2016-08-09 Thread Steven Gill
Please review and vote on this cordova-common Release
by replying to this email (and keep discussion on the DISCUSS thread)

Release issue: https://issues.apache.org/jira/browse/CB-11690

Both tools have been published to
dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-11690/

The packages were published from their corresponding git tags:

cordova-lib: common-1.4.1 (46051b800b)

Upon a successful vote I will upload the archives to dist/, publish
them to npm, and post the corresponding blog post.

Voting guidelines:
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md

Voting will go on for a minimum of 48 hours.

I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran unit tests for lib and common
* Built and ran mobile-spec for android


[GitHub] cordova-ios issue #234: CB-9825 cocoapod integration for plugins

2016-08-09 Thread shazron
Github user shazron commented on the issue:

https://github.com/apache/cordova-ios/pull/234
  
Tests fail. I cloned cordova-ios, applied the PR patch, npm install then 
npm test.
Perhaps you forgot to check in 
`tests/spec/unit/fixtures/testProj/platforms/ios/Podfile`?

Log:
``` 
Failures:

  1) installPodSync writes to the Podfile via fs.writeFileSync
   Message:
 Error: ENOENT: no such file or directory, open 
'/Users/shaz/Desktop/cordova-ios/tests/spec/unit/fixtures/testProj/platforms/ios/Podfile'
   Stacktrace:
 Error: ENOENT: no such file or directory, open 
'/Users/shaz/Desktop/cordova-ios/tests/spec/unit/fixtures/testProj/platforms/ios/Podfile'
  at Error (native)
  at Object.fs.openSync (fs.js:634:18)
  at Object.fs.readFileSync (fs.js:502:33)
  at editPodfileSync 
(/Users/shaz/Desktop/cordova-ios/bin/templates/scripts/cordova/lib/podMod.js:33:30)
  at Object.installPodSync 
(/Users/shaz/Desktop/cordova-ios/bin/templates/scripts/cordova/lib/podMod.js:126:25)
  at . 
(/Users/shaz/Desktop/cordova-ios/tests/spec/unit/podMod.spec.js:43:10)
  at tryOnTimeout (timers.js:224:11)
  at Timer.listOnTimeout (timers.js:198:5)


  2) uninstallPodSync removes pod from Podfile
   Message:
 Error: ENOENT: no such file or directory, open 
'/Users/shaz/Desktop/cordova-ios/tests/spec/unit/fixtures/testProj/platforms/ios/Podfile'
   Stacktrace:
 Error: ENOENT: no such file or directory, open 
'/Users/shaz/Desktop/cordova-ios/tests/spec/unit/fixtures/testProj/platforms/ios/Podfile'
  at Error (native)
  at Object.fs.openSync (fs.js:634:18)
  at Object.fs.readFileSync (fs.js:502:33)
  at editPodfileSync 
(/Users/shaz/Desktop/cordova-ios/bin/templates/scripts/cordova/lib/podMod.js:33:30)
  at Object.uninstallPodSync 
(/Users/shaz/Desktop/cordova-ios/bin/templates/scripts/cordova/lib/podMod.js:140:25)
  at . 
(/Users/shaz/Desktop/cordova-ios/tests/spec/unit/podMod.spec.js:59:10)
  at tryOnTimeout (timers.js:224:11)
  at Timer.listOnTimeout (timers.js:198:5)
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-ios pull request #234: CB-9825 cocoapod integration for plugins

2016-08-09 Thread juliascript
Github user juliascript commented on a diff in the pull request:

https://github.com/apache/cordova-ios/pull/234#discussion_r74154432
  
--- Diff: tests/spec/unit/podMod.spec.js ---
@@ -0,0 +1,107 @@
+var fs = require('fs'),
+   path = require('path'),
+   cordova = require(path.resolve(__dirname, '..', '..', '..', '..', 
'cordova-lib/cordova-lib/src/cordova/cordova'));
--- End diff --

Ah, thank you! I've refactored the unit tests. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-lib issue #477: CB-11688 Fix platform.spec timeout errors

2016-08-09 Thread codecov-io
Github user codecov-io commented on the issue:

https://github.com/apache/cordova-lib/pull/477
  
## [Current 
coverage](https://codecov.io/gh/apache/cordova-lib/pull/477?src=pr) is 80.69% 
(diff: 100%)
> Merging [#477](https://codecov.io/gh/apache/cordova-lib/pull/477?src=pr) 
into [master](https://codecov.io/gh/apache/cordova-lib/branch/master?src=pr) 
will not change coverage

```diff
@@ master   #477   diff @@
==
  Files68 68  
  Lines  5407   5407  
  Methods 857857  
  Messages  0  0  
  Branches   1048   1048  
==
  Hits   4363   4363  
  Misses 1044   1044  
  Partials  0  0  
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update 
[780439c...e16a6c1](https://codecov.io/gh/apache/cordova-lib/compare/780439cd116716641cd2831236d2c416564e...e16a6c10091fc129051202b496cf168ef0eda429?src=pr)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-dialogs issue #81: CB-11677 android: fix bug with prompt text

2016-08-09 Thread cordova-qa
Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-dialogs/pull/81
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-dialogs/pull/81/commits/dfad7945d8b8ee0dbf14fe4dc0a4530a0b86d027)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/24/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/24//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/24//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/24//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/24//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/24//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/24//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/24//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/24//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/24//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/24//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/24//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/24//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/24//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/24//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/24//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/24//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/24//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/24//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/24//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/24//PLATFORM=android/artifact/)
 |
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-lib pull request #477: CB-11688 Fix platform.spec timeout errors

2016-08-09 Thread daserge
GitHub user daserge opened a pull request:

https://github.com/apache/cordova-lib/pull/477

CB-11688 Fix platform.spec timeout errors

[Jira issue](https://issues.apache.org/jira/browse/CB-11688)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/daserge/cordova-lib CB-11688

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/477.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #477


commit e16a6c10091fc129051202b496cf168ef0eda429
Author: daserge 
Date:   2016-08-09T13:46:04Z

CB-11688 Fix platform.spec timeout errors




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-dialogs pull request #81: CB-11677 android: fix bug with prom...

2016-08-09 Thread matrosovN
GitHub user matrosovN opened a pull request:

https://github.com/apache/cordova-plugin-dialogs/pull/81

CB-11677 android: fix bug with prompt text



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/matrosovN/cordova-plugin-dialogs master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-dialogs/pull/81.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #81


commit dfad7945d8b8ee0dbf14fe4dc0a4530a0b86d027
Author: Nikita Matrosov 
Date:   2016-08-09T12:52:03Z

CB-11677 android: fix bug with prompt text




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-lib pull request #476: CB-11679 Speed up save/restore tests

2016-08-09 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/476


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-lib issue #476: CB-11679 Speed up save/restore tests

2016-08-09 Thread alsorokin
Github user alsorokin commented on the issue:

https://github.com/apache/cordova-lib/pull/476
  

Nice performance increase, LGTM :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[Vote] Tools Release

2016-08-09 Thread Vladimir Kotikov (Akvelon)
Please review and vote on this Tools Release
by replying to this email (and keep discussion on the DISCUSS thread)

Release issue: https://issues.apache.org/jira/browse/CB-11685

Both tools have been published to dist/dev:
https://dist.apache.org/repos/dist/dev/cordova/CB-11685

The packages were published from their corresponding git tags:
cordova-lib: 6.3.1 (a2736f594c)
cordova-cli: 6.3.1 (d192399a01)

Upon a successful vote I will upload the archives to dist/, publish them to 
npm, and post the corresponding blog post.

Voting guidelines: 
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md

Voting will go on for a minimum of 48 hours.

I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ensured continuous build was green when repos were tagged
* Created, built and ran mobilespec app with and without --browserify option
* Ensured --nobuild option works and regression is fixed

-
Best regards, Vladimir

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-android issue #322: CB-11683 android: Fixed linking to directories

2016-08-09 Thread codecov-io
Github user codecov-io commented on the issue:

https://github.com/apache/cordova-android/pull/322
  
## [Current 
coverage](https://codecov.io/gh/apache/cordova-android/pull/322?src=pr) is 
33.78% (diff: 28.57%)
> Merging 
[#322](https://codecov.io/gh/apache/cordova-android/pull/322?src=pr) into 
[master](https://codecov.io/gh/apache/cordova-android/branch/master?src=pr) 
will decrease coverage by **0.07%**

```diff
@@ master   #322   diff @@
==
  Files11 11  
  Lines   960965 +5   
  Methods 197197  
  Messages  0  0  
  Branches156157 +1   
==
+ Hits325326 +1   
- Misses  635639 +4   
  Partials  0  0  
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update 
[d54a42f...19eec15](https://codecov.io/gh/apache/cordova-android/compare/d54a42f0f0cfdab18c89e4a29de67c81f48f60b1...19eec150161872541d9a08401ff83e2528a36208?src=pr)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-android pull request #322: CB-11683 android: Fixed linking to direct...

2016-08-09 Thread sprzedamsanki
GitHub user sprzedamsanki opened a pull request:

https://github.com/apache/cordova-android/pull/322

CB-11683 android: Fixed linking to directories

Fixed bug described in CB-11683.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sprzedamsanki/cordova-android master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-android/pull/322.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #322


commit 19eec150161872541d9a08401ff83e2528a36208
Author: Szymon Drosdzol 
Date:   2016-08-09T07:18:37Z

CB-11683 android: Fixed linking to directories during plugin installation.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org