[GitHub] cordova-plugin-statusbar pull request #64: CB-11858: Add possibility to util...
GitHub user tobiasviehweger opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/64 CB-11858: Add possibility to utilize Android M feature "LightStatusBar" ### Platforms affected Android 6.0+ ### What does this PR do? This PR adds support for the LightStatusBar style in Android. I re-used the already existing config "StatusBarStyle" for this, as it has a similar effect on iOS (changing the foreground color of the status bar to black instead of white). Something I'd like to discuss is, if "lightcontent" is the correct default value. The documentation says it is, but I don't think it actually is on iOS, is it? I think the iOS default is actually blackopaque? Let me know what you think :) ### What testing has been done on this change? Tested in emulator & on Samsung Galaxy S7. ### Checklist - [X] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to secret...@apache.org. - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/sovanta/cordova-plugin-statusbar master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-statusbar/pull/64.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #64 commit 5ff4e56a921c2cd45a64a65505a21be66ec644c4 Author: Tobias Viehweger Date: 2016-09-15T15:34:45Z CB-11858: Add possibility to utilize Android M feature "LightStatusBar" --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios issue #244: CB-11771 Deep symlink directories to target project ...
Github user mbektchiev commented on the issue: https://github.com/apache/cordova-ios/pull/244 I'm not sure if the same behavior can be reproduced with `cordova-ios`. But since the code is exactly the same as the one in `cordova-android` I thought it might be good idea to keep it consistent and fix it here as well. Basically the scenario is to install a plugin which contains a custom Android library code with `--link`. All intermediate build files are created inside a `build` sub-directory and they leak into the plugin's directory. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-statusbar issue #64: CB-11858: Add possibility to utilize And...
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/64 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-statusbar/pull/64/commits/5ff4e56a921c2cd45a64a65505a21be66ec644c4) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/26/) | Builder Name | Console Output | Test Report | Device Logs | | :---: | :---: | :---: | :---:| | [Windows 8.1 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/26//PLATFORM=windows-8.1-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/26//PLATFORM=windows-8.1-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/26//PLATFORM=windows-8.1-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/26//PLATFORM=windows-8.1-store/artifact/) | | [Windows 10 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/26//PLATFORM=windows-10-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/26//PLATFORM=windows-10-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/26//PLATFORM=windows-10-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/26//PLATFORM=windows-10-store/artifact/) | | [Windows 8.1 Phone]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/26//PLATFORM=windows-8.1-phone/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/26//PLATFORM=windows-8.1-phone/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/26//PLATFORM=windows-8.1-phone/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/26//PLATFORM=windows-8.1-phone/artifact/) | | [iOS]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/26//PLATFORM=ios/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/26//PLATFORM=ios/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/26//PLATFORM=ios/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/26//PLATFORM=ios/artifact/) | | [Android]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/26//PLATFORM=android/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/26//PLATFORM=android/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/26//PLATFORM=android/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/26//PLATFORM=android/artifact/) | --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios issue #244: CB-11771 Deep symlink directories to target project ...
Github user mbektchiev commented on the issue: https://github.com/apache/cordova-ios/pull/244 See https://github.com/Wizcorp/phonegap-facebook-plugin/tree/master/platforms/android/FacebookLib and https://github.com/Telerik-Verified-Plugins/Telerik-AppFeedback/tree/master/src/android/FeedbackLib as two examples of such libraries. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios issue #256: CB-11854 - Create Entitlements.plist file (one each ...
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-ios/pull/256 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request #258: CB-11863 - Update xcodebuild minimum version ...
GitHub user shazron opened a pull request: https://github.com/apache/cordova-ios/pull/258 CB-11863 - Update xcodebuild minimum version to 7.0.0 updates travis.yml as well to osx image with xcode 7.3 You can merge this pull request into a Git repository by running: $ git pull https://github.com/shazron/cordova-ios CB-11863 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-ios/pull/258.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #258 commit b18ae4ac5b753a7364ddbe71c6b693901849ff22 Author: Shazron Abdullah Date: 2016-09-16T10:16:21Z CB-11863 - Update xcodebuild minimum version to 7.0.0 commit 0b9287a5c3aac0b8becae9b630fd7e67dbee758b Author: Shazron Abdullah Date: 2016-09-16T10:16:49Z CB-11863 - Update travis.yml to xcode 7.3 image --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios issue #250: CB-9762 (iOS) Add launch storyboard support
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/250 re: your last commit -> https://github.com/apache/cordova-ios/pull/258 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios issue #258: CB-11863 - Update xcodebuild minimum version to 7.0....
Github user codecov-io commented on the issue: https://github.com/apache/cordova-ios/pull/258 ## [Current coverage](https://codecov.io/gh/apache/cordova-ios/pull/258?src=pr) is 56.69% (diff: 100%) > Merging [#258](https://codecov.io/gh/apache/cordova-ios/pull/258?src=pr) into [master](https://codecov.io/gh/apache/cordova-ios/branch/master?src=pr) will not change coverage ```diff @@ master #258 diff @@ == Files12 12 Lines 1090 1090 Methods 169169 Messages 0 0 Branches176176 == Hits618618 Misses 472472 Partials 0 0 ``` > Powered by [Codecov](https://codecov.io?src=pr). Last update [4a187d6...0b9287a](https://codecov.io/gh/apache/cordova-ios/compare/4a187d672d7a2986377596e41a8a910847871ffd...0b9287a5c3aac0b8becae9b630fd7e67dbee758b?src=pr) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-contacts pull request #134: CB-11855: (ios) Allow iOS to use ...
GitHub user soonahn reopened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/134 CB-11855: (ios) Allow iOS to use hasPhoneNumber ### Platforms affected iOS ### What does this PR do? Fixes https://issues.apache.org/jira/browse/CB-11855 ### What testing has been done on this change? Tested on iOS 9.3 - iPhone 6. As well as iOS Simulator of iPhone 6S ### Checklist - [ Yes ] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to secret...@apache.org. - [ Yes ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [ Yes ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ No ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/soonahn/cordova-plugin-contacts allow_ios_to_filter_for_phone_number_only Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-contacts/pull/134.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #134 commit 85b52d354caeb41ed79269cc9dce690ef41917c8 Author: Justin Ahn Date: 2016-09-15T06:39:33Z Capturing the default like the multiple option, and then continuing through the array if there are no phone numbers for the user commit 03bae62e725bb6bca4eece731d28b5e78d0326ab Author: Justin Ahn Date: 2016-09-16T16:36:01Z adding the bool option as well --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request #258: CB-11863 - Update xcodebuild minimum version ...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/258 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios issue #248: CB-11792 - Add Cocoapods .xcconfig includes to build...
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/248 @dpogue check out my proposed fix in https://issues.apache.org/jira/browse/CB-11792?focusedCommentId=15495523&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15495523 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios issue #256: CB-11854 - Create Entitlements.plist file (one each ...
Github user dpogue commented on the issue: https://github.com/apache/cordova-ios/pull/256 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-contacts issue #134: CB-11855: (ios) Allow iOS to use hasPhon...
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/134 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-contacts/pull/134/commits/03bae62e725bb6bca4eece731d28b5e78d0326ab) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/37/) | Builder Name | Console Output | Test Report | Device Logs | | :---: | :---: | :---: | :---:| | [Windows 8.1 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/37//PLATFORM=windows-8.1-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/37//PLATFORM=windows-8.1-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/37//PLATFORM=windows-8.1-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/37//PLATFORM=windows-8.1-store/artifact/) | | [Windows 10 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/37//PLATFORM=windows-10-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/37//PLATFORM=windows-10-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/37//PLATFORM=windows-10-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/37//PLATFORM=windows-10-store/artifact/) | | [Windows 8.1 Phone]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/37//PLATFORM=windows-8.1-phone/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/37//PLATFORM=windows-8.1-phone/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/37//PLATFORM=windows-8.1-phone/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/37//PLATFORM=windows-8.1-phone/artifact/) | | [iOS]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/37//PLATFORM=ios/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/37//PLATFORM=ios/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/37//PLATFORM=ios/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/37//PLATFORM=ios/artifact/) | | [Android]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/37//PLATFORM=android/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/37//PLATFORM=android/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/37//PLATFORM=android/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/37//PLATFORM=android/artifact/) | --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request #256: CB-11854 - Create Entitlements.plist file (on...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/256 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #218: CB-9696: Add possibility to use non-immersive fu...
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/218 If you still want this feature, can you change it so it merges cleanly, and works with the other code that uses non-immersive as a fallback? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios issue #244: CB-11771 Deep symlink directories to target project ...
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/244 I tested this on the `cordova-plugin-console` plugin and `phonegap-facebook-plugin`. The results before and after applying the patch are the same. In the `PROJECTNAME/plugins` folder, the folder for the plugin itself is linked, and not its contents individually (same as before the patch). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request #490: Android studio
GitHub user imhotep opened a pull request: https://github.com/apache/cordova-lib/pull/490 Android studio Adds Android Studio support Adds some logging for when patformApi fails for weird reasons. You can merge this pull request into a Git repository by running: $ git pull https://github.com/imhotep/cordova-lib android_studio Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/490.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #490 commit 6c622f51ace9a2a0bab73c5ec910e81f835199ba Author: Joe Bowser Date: 2016-02-12T22:06:42Z CB-8320: We look for a build.gradle to make sure it's Android, not an AndroidManifest, because it moved commit 062f15f52469dd438ee2831c12e28434589fc759 Author: Joe Bowser Date: 2016-07-28T19:42:47Z CB-8320: Lint commit a25ddc260bbbf2aef254fb6cf91436d6edfd3ea3 Author: Anis Kadri Date: 2016-08-29T14:28:55Z config.xml has a different location in Android Studio commit 99931eb03cc440e5fb5d7721abb92aa4938fe30e Author: Anis Kadri Date: 2016-08-29T14:29:24Z Adding error message to help debug platformApi loading errors commit 6a6821ff645490aac5f616fdf468a528ac92464d Author: Anis Kadri Date: 2016-09-15T00:04:23Z undoing android_parser changes commit 51355f71ca5ff54e727df13a5ab468c4988c0e2b Author: Anis Kadri Date: 2016-09-16T22:35:41Z Unifying quotes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request #331: Android studio
GitHub user imhotep opened a pull request: https://github.com/apache/cordova-android/pull/331 Android studio Adds support for Android Studio plugin install/uninstall You can merge this pull request into a Git repository by running: $ git pull https://github.com/imhotep/cordova-android android_studio Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-android/pull/331.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #331 commit a89cee7c602aa4e6f1ba37b004b3e9ba29b4541c Author: Anis Kadri Date: 2016-08-29T14:26:49Z First attempt at supporting Android Studio commit d2cfc3371ecf5311ced8b66de7d6678ea883516b Author: Anis Kadri Date: 2016-09-15T01:22:53Z fixing jshint issues commit 8b260655612b5376bc6aed5f7ec554bf6fcfda81 Author: Anis Kadri Date: 2016-09-15T23:18:35Z adding tests for AndroidStudio commit 7bd0d64e4cf19e840d8fbd570be26ca58d9cb680 Author: Anis Kadri Date: 2016-09-16T22:41:20Z adding tests for Android Studio --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request #490: Android studio
Github user purplecabbage commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/490#discussion_r79263894
--- Diff: cordova-common/src/ConfigChanges/ConfigFile.js ---
@@ -193,6 +193,11 @@ function resolveConfigFilePath(project_dir, platform,
file) {
return filepath;
}
+// FIXME android studio
+if(platform === 'android' && !fs.existsSync(filepath)) {
--- End diff --
Can you put a comment here to describe how this works and why it is needed.
It looks to me like if we are looking for config.xml and platform is
android, the `return filepath;` call on ln:193 is going to return before ever
getting here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
Re: Xcode 8 packaging changes
Like I mentioned in Kerri's discussion re: launch storyboard, the Xcode 6 requirement was an error in the docs unfortunately. We only support what Xcode was needed to submit to the App Store. We were waiting until Apple dropped Xcode 6, and we forgot to update the docs. So how do we determine if Apple drops support for an Xcode version? See: https://developer.apple. com/library/content/qa/qa1806/_index.html under "Testing Legacy Tool Support". Here's where it gets tricky: Xcode 7.3.1 still validates (iOS 9 SDK latest) Xcode 6.4 still validates (iOS 8 SDK latest) I used the Hello Cordova app which is pretty barebones so it validates easily. So using that rule is not foolproof. Here's a better way as a "carrot". For example, now MPMediaQuery on iOS 10 will ask for permissions before an app can scan your media library. Previously, you don't need to ask permission. Enterprising companies might try to build using the iOS 9 or older SDK, or keep using their old app to try to "get around this". But I suspect it won't work (I'll double check). It's like how they introduced Contacts permissions in iOS 9 -- apps built using older SDKs (<= 8) will just silently fail on an iOS 9 device, so your app is crippled, so it's in your best interest to upgrade to a newer SDK build. Note that this is not an Xcode limitation, but a SDK limitation -- usually to use a newer SDK you need to get the newer Xcode. On Thu, Sep 15, 2016 at 5:31 PM, Jesse wrote: > +1 to dropping 6 and moving towards 8 > What is apple's required version of xcode for submitting apps to the app > store? > > Does it make sense to always build with the developer cert unless the dev > specified otherwise? I think there might be cases where I would want to > run the release build on my own device before submitting it. > > > > > @purplecabbage > risingj.com > > On Thu, Sep 15, 2016 at 1:38 PM, Darryl Pogue wrote: > > > So Xcode 8 is out, and it simplifies some aspects of code signing, but > > complicates the process of packaging an app. > > > > Currently, cordova-ios will use the "iPhone Developer" certificate when > > building a debug build, and the "iPhone Distribution" certificate when > > making a release build. It uses xcrun with the (deprecated) > > PackageApplication option to bundle up the build into an IPA file. > > > > > > Xcode 8 has automatic provisioning, which means instead of dealing with > > specifying a bunch of certificate files, you can pretty much just give > it a > > team identifier and it will figure things out. With one catch: you need > to > > use the "iPhone Developer" certificate. Support for the team identifier > in > > build.json has already been added to cordova-ios master. > > > > However, in order to make a build in Xcode 8 with automatic provisioning > > and a distribution certificate, you need to run the xcodebuild archive > > step, and then an exportArchive step to generate the IPA. This workflow > has > > been supported since Xcode 7. > > > > Currently, since Cordova uses xcrun PackageApplication, it is packaging > up > > a release build with the development certificate. This build cannot be > > submitted to the App Store. > > > > > > My proposal is for cordova-ios to drop support for Xcode 6 with the xcrun > > packaging, and start using xcodebuild for archiving and generating the > IPA. > > I suppose that would have to wait for a major version bump of > cordova-ios, > > unless we detected the Xcode version and kept the old code around > > conditionally. > > > > As part of packaging, we would need to generate a exportOptions.plist > file, > > indicating what type of build to package (development, enterprise, > ad-hoc, > > or app-store). I'd suggest we add a "packageType" or "buildType" field to > > build.json for specifying this value (with a default of development). > > > > > > I'm happy to start prototyping this on a branch if it sounds like the > right > > approach going forward. > > > > > > Related info: > > https://pewpewthespells.com/blog/migrating_code_signing.html > > #building-for-distribution-xcode-8 > > https://dpogue.ca/articles/cordova-xcode8.html > > >
[GitHub] cordova-lib issue #490: Android studio
Github user codecov-io commented on the issue: https://github.com/apache/cordova-lib/pull/490 ## [Current coverage](https://codecov.io/gh/apache/cordova-lib/pull/490?src=pr) is 80.38% (diff: 100%) > Merging [#490](https://codecov.io/gh/apache/cordova-lib/pull/490?src=pr) into [master](https://codecov.io/gh/apache/cordova-lib/branch/master?src=pr) will increase coverage by **<.01%** ```diff @@ master #490 diff @@ == Files67 67 Lines 5183 5184 +1 Methods 835835 Messages 0 0 Branches 1005 1005 == + Hits 4166 4167 +1 Misses 1017 1017 Partials 0 0 ``` > Powered by [Codecov](https://codecov.io?src=pr). Last update [f8b58c7...51355f7](https://codecov.io/gh/apache/cordova-lib/compare/f8b58c782c71558516adbbd81929ee31ec3ded7f...51355f71ca5ff54e727df13a5ab468c4988c0e2b?src=pr) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [VOTE] Plugins Release
The vote has closed. The results are: Positive Binding Votes: 3 Steve Gill Shazron Abdullah Jesse MacFadyen The vote has passed. On Wed, Sep 14, 2016 at 11:22 AM, Jesse wrote: > +1 > > * Ran coho audit-license-headers over the relevant repos (all ok) > * Ran coho verify-archive on all the archives (all verified) > > > @purplecabbage > risingj.com > > On Wed, Sep 14, 2016 at 11:07 AM, Shazron wrote: > > > I vote +1: > > * Ran coho audit-license-headers over the relevant repos (all ok) > > * Ran coho check-license to ensure all dependencies and > > subdependencies have Apache-compatible licenses > > * Ran coho verify-archive on all the archives (all verified) > > > > On Fri, Sep 9, 2016 at 4:34 PM, Steven Gill > > wrote: > > > > > Please review and vote on the release of this plugins release > > > by replying to this email (and keep discussion on the DISCUSS thread) > > > > > > Release issue: https://issues.apache.org/jira/browse/CB-11832 > > > > > > The plugins have been published to > > > dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-11832/ > > > > > > The packages were published from their corresponding git tags: > > > cordova-plugin-battery-status: 1.2.0 (4f9044ec32) > > > cordova-plugin-camera: 2.3.0 (cc1076d3cb) > > > cordova-plugin-console: 1.0.4 (e4deaa235c) > > > cordova-plugin-contacts: 2.2.0 (31b8545e9c) > > > cordova-plugin-device: 1.1.3 (b90d1ddf9b) > > > cordova-plugin-device-motion: 1.2.2 (bf41b516cb) > > > cordova-plugin-device-orientation: 1.0.4 (c3ccdbcf48) > > > cordova-plugin-dialogs: 1.3.0 (fef904c728) > > > cordova-plugin-file: 4.3.0 (5c0f68d1cc) > > > cordova-plugin-file-transfer: 1.6.0 (60b2cd324e) > > > cordova-plugin-geolocation: 2.3.0 (b913653214) > > > cordova-plugin-globalization: 1.0.4 (6042184e3c) > > > cordova-plugin-inappbrowser: 1.5.0 (6c8106a706) > > > cordova-plugin-media: 2.4.0 (978c038603) > > > cordova-plugin-media-capture: 1.4.0 (c5b9cacf9d) > > > cordova-plugin-network-information: 1.3.0 (0e6889a09e) > > > cordova-plugin-splashscreen: 4.0.0 (6e43615e25) > > > cordova-plugin-statusbar: 2.2.0 (ad5f7d912c) > > > cordova-plugin-test-framework: 1.1.3 (d6e0248035) > > > cordova-plugin-vibration: 2.1.2 (591e034213) > > > cordova-plugin-whitelist: 1.3.0 (d51a360052) > > > cordova-plugin-wkwebview-engine: 1.1.0 (d97b63bd7a) > > > > > > Upon a successful vote I will upload the archives to dist/, upload > > > them to npm, and post the corresponding blog post. > > > > > > Voting guidelines: > > > https://github.com/apache/cordova-coho/blob/master/docs/ > > release-voting.md > > > > > > Voting will go on for a minimum of 48 hours. > > > > > > I vote +1: > > > * Ran coho audit-license-headers over the relevant repos > > > * Ran coho check-license to ensure all dependencies and > > > subdependencies have Apache-compatible licenses > > > * Ran mobile-spec, all passing except expected failing file-transfer > > tests. > > > > > >
Re: [DISCUSS] Not requiring an iCLA for contributions
Ok looks like we have consensus. I'll add a section here: http://cordova.apache.org/contribute/ and send a PR to the cordova-docs repo for comment. On Tue, Sep 13, 2016 at 11:37 AM, Steven Gill wrote: > +1 > > On Tue, Sep 13, 2016 at 11:09 AM, Simon MacDonald < > simon.macdon...@gmail.com > > wrote: > > > +1 to making it easier to allow people to contribute trivial changes. > > > > One thing Shaz just mentioned was adding a check box the the PR template > so > > that people can explicitly indicate their intent. > > > > Eventually it would be nice to be able to digitally sign the CLA. > > > > Simon Mac Donald > > http://hi.im/simonmacdonald > > > > On Tue, Sep 13, 2016 at 11:01 AM, Shazron wrote: > > > > > An easy definition of trivial IMO is "if they decide to pull this code > > away > > > from us, is it not a big deal?" > > > > > > The reasons why the code needs to be pulled, who knows what lurks in > the > > > minds of lawyers. Typos, doc changes, one liners, are not a big deal > > > usually. > > > > > > On Tue, Sep 13, 2016 at 10:53 AM, Jesse > wrote: > > > > > > > Yes, that is the point. Sending a PR is intent! > > > > BUT if it is a large change, we need insurance that it is the work of > > the > > > > contributor, and not copy/pasted from somewhere else, and that they > > > cannot > > > > retract it later. This is what the CLA offers us. > > > > Currently, as Shaz pointed out above, we state firmly that we require > > an > > > > iCLA, so this will simply state more clearly how we work with PRs. > > > > > > > > > > > > @purplecabbage > > > > risingj.com > > > > > > > > On Tue, Sep 13, 2016 at 10:46 AM, Joe Bowser > > wrote: > > > > > > > > > So, it's basically the same system that we have now. I still think > > we > > > > > should get clear intent from the author, since that's more useful > and > > > > easy > > > > > than determining whether it's trivial. I mean, isn't sending a PR > > > > through > > > > > GitHub already clear intent? > > > > > > > > > > On Tue, Sep 13, 2016 at 10:41 AM, Jesse > > > wrote: > > > > > > > > > > > You decide per pr if you think it is trivial. > > > > > > > > > > > > > > > > > > @purplecabbage > > > > > > risingj.com > > > > > > > > > > > > On Tue, Sep 13, 2016 at 10:36 AM, Joe Bowser > > > > wrote: > > > > > > > > > > > > > I'll agree to this, since I don't know what the definition of > > > trivial > > > > > is > > > > > > > w.r.t. Apache. > > > > > > > > > > > > > > +1 > > > > > > > > > > > > > > On Tue, Sep 13, 2016 at 10:30 AM, Jesse < > purplecabb...@gmail.com > > > > > > > > wrote: > > > > > > > > > > > > > > > +1 > > > > > > > > > > > > > > > > > > > > > > > > @purplecabbage > > > > > > > > risingj.com > > > > > > > > > > > > > > > > On Tue, Sep 13, 2016 at 10:27 AM, Shazron > > > > > wrote: > > > > > > > > > > > > > > > > > Bump. There can't be lazy consensus on this. Before I > > > potentially > > > > > > waste > > > > > > > > > time on drafting a proposal, trying to feel the temperature > > on > > > > this > > > > > > > > change. > > > > > > > > > > > > > > > > > > On Fri, Sep 9, 2016 at 3:34 PM, Shazron > > > > > wrote: > > > > > > > > > > > > > > > > > > > It's up to us to decide, and right now we require the > iCLA > > > > except > > > > > > for > > > > > > > > > > trivial contributions. > > > > > > > > > > > > > > > > > > > > I want to change this to a more relaxed requirement: > > > > > > > > > > 1. Non-committers do not require an iCLA (you need one > > anyway > > > > to > > > > > > get > > > > > > > an > > > > > > > > > > account, so that's really a non-issue) > > > > > > > > > > 2. Require a clear intent by the author to contribute > under > > > our > > > > > > > normal > > > > > > > > > > terms, for a non-trivial change > > > > > > > > > > > > > > > > > > > > So some of you will be wondering, what does Apache say > > about > > > > > this? > > > > > > > > > > From: http://mail-archives.apache. > > org/mod_mbox/www-infrastru > > > > > > > > > > cture-dev/201112.mbox/%3CA603FFCE-623B-43E9-87F8- > > > > > > > 39baa51c7...@gbiv.com > > > > > > > > > %3E > > > > > > > > > > > > > > > > > > > > Roy Fielding: > > > > > > > > > > "Yes, that opinion comes from me speaking as a board > member > > > and > > > > > > > > > > author of the Apache License, and has previously been > > cleared > > > > > > > > > > with Apache's legal team for a long ago discussion with > > > > > Incubator. > > > > > > > > > > We don't need a CLA on file to accept contributions from > > > > > > > > non-committers. > > > > > > > > > > We just need a clear intent by the author to contribute > > under > > > > > > > > > > our normal terms." > > > > > > > > > > > > > > > > > > > > Other opinions: http://apetro.ghost.io/apache- > > > > > contributors-no-cla/ > > > > > > > > > > > > > > > > > > > > We need to change our Contribute page: > > > > > > > > > > http://cordova.apache.org/contribute/ > > > > > > > > > > > > > > > > > > > > ... as well as any PR templates: > > > > > > > >
[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8
Github user codecov-io commented on the issue: https://github.com/apache/cordova-ios/pull/257 ## [Current coverage](https://codecov.io/gh/apache/cordova-ios/pull/257?src=pr) is 56.43% (diff: 0.00%) > Merging [#257](https://codecov.io/gh/apache/cordova-ios/pull/257?src=pr) into [master](https://codecov.io/gh/apache/cordova-ios/branch/master?src=pr) will decrease coverage by **0.25%** ```diff @@ master #257 diff @@ == Files12 12 Lines 1090 1095 +5 Methods 169171 +2 Messages 0 0 Branches176176 == Hits618618 - Misses 472477 +5 Partials 0 0 ``` > Powered by [Codecov](https://codecov.io?src=pr). Last update [b5fb016...1aa1c37](https://codecov.io/gh/apache/cordova-ios/compare/b5fb016b9f81426f9173ae36b7084fa7913dbd8f...1aa1c37dbf28a1196c3450c0172b3033594cfbf4?src=pr) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Nightly build #148 for cordova has succeeded!
Nightly build #148 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/148/consoleFull - Jenkins for Apache Cordova - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
