[GitHub] cordova-lib pull request #498: CB-11985 Check if cached platform/plugin exis...
GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-lib/pull/498 CB-11985 Check if cached platform/plugin exists before 'npm cache' ### What does this PR do? Before calling `npm cache add` when installing a platform or plugin, look for an existing `package.tgz` file in the cache directory. This avoids unnecessary `npm` call with long timeout if not connected to the internet. Background: First time build failures in Cordova tools in Visual Studio are primarily due to `npm` failures. Therefore we are working to avoid any requirement for `npm` to hit the internet in simple build scenarios. This includes pre-installing cached versions of certain platforms and plugins. But we only get the full benefit if Cordova uses these cached versions if it finds them, without calling npm cache add. A couple of things to note: * This change uses shared code for platforms and plugins, and means plugins will also be cached to the `.cordova` directory rather than the global npm cache directory. Is that a concern? * It is likely this change will be meaningless with the proposed changes to installing platforms and plugins in Cordova 7.x. We'll cross the bridge when we come to it ð. ### What testing has been done on this change? Local testing. ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. You can merge this pull request into a Git repository by running: $ git pull https://github.com/TimBarham/cordova-lib use-cached-platform Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/498.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #498 commit 667e774d46399cf97a9481c3890fa7a862871d46 Author: TimBarhamDate: 2016-10-07T22:58:35Z CB-11985 Check if cached platform/plugin exists before 'npm cache' This avoids unnecessary npm call with long timeout if not connected to the internet. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios issue #265: CB-11952 - Introduce buildFlag option
Github user adzellman commented on the issue: https://github.com/apache/cordova-ios/pull/265 I'm not sure why Travis would fail to run `n stable`. I just tried it locally and it installed v6.6.0 just fine. Can we re-trigger Travis? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Nightly build #171 for cordova has succeeded!
Nightly build #171 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/171/consoleFull - Jenkins for Apache Cordova - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request #339: CB-11964: Do a clean when installing a pl...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/339 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request #265: CB-11952 - Introduce buildFlag option
Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/265#discussion_r82491705 --- Diff: bin/templates/scripts/cordova/lib/build.js --- @@ -199,33 +219,52 @@ module.exports.findXCodeProjectIn = findXCodeProjectIn; * @param {Boolean} isDevice Flag that specify target for package (device/emulator) * @return {Array} Array of arguments that could be passed directly to spawn method */ -function getXcodeBuildArgs(projectName, projectPath, configuration, isDevice) { +function getXcodeBuildArgs(projectName, projectPath, configuration, isDevice, buildFlags) { var xcodebuildArgs; +var options; +var buildActions = [ 'build' ]; +var settings; +var customArgs = {}; +customArgs.otherFlags = []; + +if (buildFlags) { +if (typeof buildFlags === 'string' || buildFlags instanceof String) { +parseBuildFlag(buildFlags, customArgs); +} else { // buildFlags is an Array of strings +buildFlags.forEach( function(flag) { +parseBuildFlag(flag, customArgs); +}); +} +} + if (isDevice) { -xcodebuildArgs = [ -'-xcconfig', path.join(__dirname, '..', 'build-' + configuration.toLowerCase() + '.xcconfig'), -'-workspace', projectName + '.xcworkspace', -'-scheme', projectName, -'-configuration', configuration, -'-destination', 'generic/platform=iOS', -'-archivePath', projectName + '.xcarchive', -'archive', --- End diff -- The automated tests do run the build command on Travis CI `npm run e2e-tests` There is no check whether the archive artifact was created though since we can't really build for device on Travis --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request #265: CB-11952 - Introduce buildFlag option
Github user adzellman commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/265#discussion_r82491459 --- Diff: bin/templates/scripts/cordova/lib/build.js --- @@ -199,33 +219,52 @@ module.exports.findXCodeProjectIn = findXCodeProjectIn; * @param {Boolean} isDevice Flag that specify target for package (device/emulator) * @return {Array} Array of arguments that could be passed directly to spawn method */ -function getXcodeBuildArgs(projectName, projectPath, configuration, isDevice) { +function getXcodeBuildArgs(projectName, projectPath, configuration, isDevice, buildFlags) { var xcodebuildArgs; +var options; +var buildActions = [ 'build' ]; +var settings; +var customArgs = {}; +customArgs.otherFlags = []; + +if (buildFlags) { +if (typeof buildFlags === 'string' || buildFlags instanceof String) { +parseBuildFlag(buildFlags, customArgs); +} else { // buildFlags is an Array of strings +buildFlags.forEach( function(flag) { +parseBuildFlag(flag, customArgs); +}); +} +} + if (isDevice) { -xcodebuildArgs = [ -'-xcconfig', path.join(__dirname, '..', 'build-' + configuration.toLowerCase() + '.xcconfig'), -'-workspace', projectName + '.xcworkspace', -'-scheme', projectName, -'-configuration', configuration, -'-destination', 'generic/platform=iOS', -'-archivePath', projectName + '.xcarchive', -'archive', --- End diff -- Oh, it actually changed from the build command to the archive command. That's interesting. This was allowed in just a couple days ago with no automated tests. It'll take me a little bit to make sure I didn't break anything. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request #265: CB-11952 - Introduce buildFlag option
Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/265#discussion_r82490970 --- Diff: bin/templates/scripts/cordova/lib/build.js --- @@ -199,33 +219,52 @@ module.exports.findXCodeProjectIn = findXCodeProjectIn; * @param {Boolean} isDevice Flag that specify target for package (device/emulator) * @return {Array} Array of arguments that could be passed directly to spawn method */ -function getXcodeBuildArgs(projectName, projectPath, configuration, isDevice) { +function getXcodeBuildArgs(projectName, projectPath, configuration, isDevice, buildFlags) { var xcodebuildArgs; +var options; +var buildActions = [ 'build' ]; +var settings; +var customArgs = {}; +customArgs.otherFlags = []; + +if (buildFlags) { +if (typeof buildFlags === 'string' || buildFlags instanceof String) { +parseBuildFlag(buildFlags, customArgs); +} else { // buildFlags is an Array of strings +buildFlags.forEach( function(flag) { +parseBuildFlag(flag, customArgs); +}); +} +} + if (isDevice) { -xcodebuildArgs = [ -'-xcconfig', path.join(__dirname, '..', 'build-' + configuration.toLowerCase() + '.xcconfig'), -'-workspace', projectName + '.xcworkspace', -'-scheme', projectName, -'-configuration', configuration, -'-destination', 'generic/platform=iOS', -'-archivePath', projectName + '.xcarchive', -'archive', --- End diff -- I think these are missing `-archivePath` and `archive`. See this PR: https://github.com/apache/cordova-ios/pull/257 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #339: CB-11964: Do a clean when installing a plugin to...
Github user alsorokin commented on the issue: https://github.com/apache/cordova-android/pull/339 Tested it on Windows, it works! LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request #267: CB-11970 - Support CocoaPod pod specification...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/267 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios issue #267: CB-11970 - Support CocoaPod pod specification other ...
Github user codecov-io commented on the issue: https://github.com/apache/cordova-ios/pull/267 ## [Current coverage](https://codecov.io/gh/apache/cordova-ios/pull/267?src=pr) is 56.60% (diff: 87.50%) > Merging [#267](https://codecov.io/gh/apache/cordova-ios/pull/267?src=pr) into [master](https://codecov.io/gh/apache/cordova-ios/branch/master?src=pr) will increase coverage by **0.10%** ```diff @@ master #267 diff @@ == Files12 12 Lines 1230 1233 +3 Methods 198198 Messages 0 0 Branches193193 == + Hits695698 +3 Misses 535535 Partials 0 0 ``` > Powered by [Codecov](https://codecov.io?src=pr). Last update [a956c93...06dbae8](https://codecov.io/gh/apache/cordova-ios/compare/a956c93e2cf9f5f23b1880fdd0d43a9f0d113521...06dbae8dcf38ea32993519c974795fb2935910b8?src=pr) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib issue #497: CB-11976 - Add deprecated node version warning for 0...
Github user shazron commented on the issue: https://github.com/apache/cordova-lib/pull/497 Making a change so it is shown on every command, not just `prepare` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request #266: CB-11729 - template file MainViewController.m...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/266 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request #267: CB-11970 - Support CocoaPod pod specification...
GitHub user shazron opened a pull request: https://github.com/apache/cordova-ios/pull/267 CB-11970 - Support CocoaPod pod specification other than version ### Platforms affected iOS ### What does this PR do? Add support for CocoaPod specs that are not just versions, but other specifications. i.e. ``` ``` ### What testing has been done on this change? npm run unit-tests ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/shazron/cordova-ios CB-11970 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-ios/pull/267.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #267 commit a24a69d725cbc468feafd0d0a29b643541e320fd Author: Shazron AbdullahDate: 2016-10-08T00:19:16Z CB-11970 - Support CocoaPod pod specification other than version --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios issue #266: CB-11729 - template file MainViewController.m has de...
Github user codecov-io commented on the issue: https://github.com/apache/cordova-ios/pull/266 ## [Current coverage](https://codecov.io/gh/apache/cordova-ios/pull/266?src=pr) is 56.50% (diff: 100%) > Merging [#266](https://codecov.io/gh/apache/cordova-ios/pull/266?src=pr) into [master](https://codecov.io/gh/apache/cordova-ios/branch/master?src=pr) will not change coverage ```diff @@ master #266 diff @@ == Files12 12 Lines 1230 1230 Methods 198198 Messages 0 0 Branches193193 == Hits695695 Misses 535535 Partials 0 0 ``` > Powered by [Codecov](https://codecov.io?src=pr). Last update [636113f...d71cb97](https://codecov.io/gh/apache/cordova-ios/compare/636113f047ee2c7dae742dff2beafae2121ceb62...d71cb97fa31c8e59df10dffa3fc6cb927e2deb42?src=pr) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request #266: CB-11729 - template file MainViewController.m...
GitHub user shazron opened a pull request: https://github.com/apache/cordova-ios/pull/266 CB-11729 - template file MainViewController.m has deprecated override shouldAutorotateToInterfaceOrientation ### Platforms affected iOS ### What does this PR do? Remove unused selector in MainViewController subclass, add in comments the new overrides available. ### What testing has been done on this change? Local build ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. You can merge this pull request into a Git repository by running: $ git pull https://github.com/shazron/cordova-ios CB-11729 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-ios/pull/266.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #266 commit d71cb97fa31c8e59df10dffa3fc6cb927e2deb42 Author: Shazron AbdullahDate: 2016-10-07T23:26:36Z CB-11729 - template file MainViewController.m has deprecated override shouldAutorotateToInterfaceOrientation --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib issue #497: CB-11976 - Add deprecated node version warning for 0...
Github user codecov-io commented on the issue: https://github.com/apache/cordova-lib/pull/497 ## [Current coverage](https://codecov.io/gh/apache/cordova-lib/pull/497?src=pr) is 80.41% (diff: 100%) > Merging [#497](https://codecov.io/gh/apache/cordova-lib/pull/497?src=pr) into [master](https://codecov.io/gh/apache/cordova-lib/branch/master?src=pr) will increase coverage by **0.01%** ```diff @@ master #497 diff @@ == Files67 67 Lines 5189 5192 +3 Methods 836836 Messages 0 0 Branches 1005 1006 +1 == + Hits 4172 4175 +3 Misses 1017 1017 Partials 0 0 ``` > Powered by [Codecov](https://codecov.io?src=pr). Last update [4ca3b4c...65181b5](https://codecov.io/gh/apache/cordova-lib/compare/4ca3b4ca12a01ded923734e4d92d7f9325d540dc...65181b5b16f9cae3335e169bd8296e44a45aa4e7?src=pr) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #339: CB-11964: Do a clean when installing a plugin to...
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/339 @alsorokin I'm going to keep the commits exploded and as is on this PR. If this looks good to you, I'll merge this in tonight. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request #497: CB-11976 - Add deprecated node version warnin...
GitHub user shazron opened a pull request: https://github.com/apache/cordova-lib/pull/497 CB-11976 - Add deprecated node version warning for 0.x ### Platforms affected All ### What does this PR do? Prints out a warning on `prepare` that you are using a deprecated node version, if you are using any node version 0.x ### What testing has been done on this change? Tested locally. ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. You can merge this pull request into a Git repository by running: $ git pull https://github.com/shazron/cordova-lib CB-11976 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/497.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #497 commit 19031e645c1a885728c81650b55189cc311d1e13 Author: Shazron AbdullahDate: 2016-10-07T21:46:01Z CB-11976 - Add deprecated node version warning for 0.x --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #339: CB-11964: Do a clean when installing a plugin to...
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/339 I'm not getting the same errors locally when I run the same tests, could this be a weird travis timeout issue? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #339: CB-11964: Do a clean when installing a plugin to...
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/339 OK, there's something wrong with how we're cleaning in the chain. I think we need to do it later in the promise chain. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [Vote] Cordova-common@1.5.0 Release
I vote +1: * Ran coho audit-license-headers * Ran coho check-license * Ran npm test @purplecabbage risingj.com On Fri, Oct 7, 2016 at 12:38 AM, Shazronwrote: > I vote +1: > * Ran coho audit-license-headers over the relevant repos > * Ran coho check-license to ensure all dependencies and > subdependencies have Apache-compatible licenses > * Ran npm test > > On Thu, Oct 6, 2016 at 10:04 PM, Steven Gill > wrote: > > > Please review and vote on this cordova-common Release > > by replying to this email (and keep discussion on the DISCUSS thread) > > > > Release issue: https://issues.apache.org/jira/browse/CB-11969 > > > > Both tools have been published to > > dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-11969/ > > > > The packages were published from their corresponding git tags: > > > > cordova-lib: common-1.5.0 (0b56f9c6e5) > > > > Upon a successful vote I will upload the archives to dist/, publish > > them to npm, and post the corresponding blog post. > > > > Voting guidelines: > > https://github.com/apache/cordova-coho/blob/master/docs/ > release-voting.md > > > > Voting will go on for a minimum of 48 hours. > > > > I vote +1: > > * Ran coho audit-license-headers over the relevant repos > > * Ran coho check-license to ensure all dependencies and > > subdependencies have Apache-compatible licenses > > * Ran npm test > > >
[GitHub] cordova-android issue #339: CB-11964: Do a clean when installing a plugin to...
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/339 Moving the example into core, tested it locally, everything appears to check out on MacOS. Hopefully there's no weird Windows issues. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios issue #265: CB-11952 - Introduce buildFlag option
Github user adzellman commented on the issue: https://github.com/apache/cordova-ios/pull/265 @shazron Review comments addressed. Please re-review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request #339: CB-11964: Do a clean when installing a pl...
Github user alsorokin commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/339#discussion_r82400883 --- Diff: bin/templates/cordova/Api.js --- @@ -349,13 +354,24 @@ Api.prototype.run = function(runOptions) { */ Api.prototype.clean = function(cleanOptions) { var self = this; +try { --- End diff -- I think instead of doing this `try catch` in product code we could just mock `Api.prototype.clean()` in tests. Please see my attempt at doing so: https://github.com/alsorokin/cordova-android/commit/008f46a1f3e807ee0ec1b576cd1a5d84e779d838 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request #339: CB-11964: Do a clean when installing a pl...
Github user alsorokin commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/339#discussion_r82400488 --- Diff: bin/templates/cordova/Api.js --- @@ -212,6 +212,11 @@ Api.prototype.addPlugin = function (plugin, installOptions) { installOptions.android_studio = true; } +//CB-11964: Do a clean when installing the plugin code to get around +//the Gradle bug introduced by the Android Gradle Plugin Version 2.2 +//TODO: Delete when the next version of Android Gradle plugin comes out + +this.clean(); --- End diff -- Is it out of promise chain intentionally? I think that `this.clean()` returns a promise. I've tried to merge it to the promise chain, but got the following exception upon `cordova platform add`: ``` Error: ENOENT: no such file or directory, open 'C:\Cordova\foo\platforms\android\assets\www\cordova_plugins.js' at Error (native) at Object.fs.openSync (fs.js:549:18) at Object.fs.writeFileSync (fs.js:1156:15) at C:\Cordova\foo\platforms\android\cordova\node_modules\cordova-common\src\PluginManager.js:137:12 at _fulfilled (C:\Cordova\foo\platforms\android\cordova\node_modules\q\q.js:834:54) at self.promiseDispatch.done (C:\Cordova\foo\platforms\android\cordova\node_modules\q\q.js:863:30) at Promise.promise.promiseDispatch (C:\Cordova\foo\platforms\android\cordova\node_modules\q\q.js:796:13) at C:\Cordova\foo\platforms\android\cordova\node_modules\q\q.js:857:14 at runSingle (C:\Cordova\foo\platforms\android\cordova\node_modules\q\q.js:137:13) at flush (C:\Cordova\foo\platforms\android\cordova\node_modules\q\q.js:125:13) ``` I wonder why it works the way you put it and if it is dangerous to leave it like this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine issue #20: Fix handling of tel and mailto sc...
Github user boboldehampsink commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/20 The new config.xml settings fixed this for me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file issue #191: CB-11699 Read files as Data URLs properly
Github user beatgrabe commented on the issue: https://github.com/apache/cordova-plugin-file/pull/191 @vladimir-kotikov Thank you a lot, your PR fixed exactly an issue I was facing today! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera issue #170: Fix FileHelper / port cordova-plugin-filep...
Github user TanaseButcaru commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/170 Hi @davidbarre, At the moment, I don't have the time to continue upgrading my unofficial plugin with version 2.3. The last time I have made changes to my unofficial plugin, the official implementation wasn't covering all the cases. I may try to check the differences between my unofficial version and the latest official in the next days. I'll keep up updated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
RE: [Vote] Cordova-common@1.5.0 Release
I vote +1: * Ran coho audit-license-headers * Ran coho check-license * Ran npm test - Best regards, Vladimir -Original Message- From: Shazron [mailto:shaz...@gmail.com] Sent: Friday, October 7, 2016 10:38 AM To: dev@cordova.apache.org Subject: Re: [Vote] Cordova-common@1.5.0 Release I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses * Ran npm test On Thu, Oct 6, 2016 at 10:04 PM, Steven Gillwrote: > Please review and vote on this cordova-common Release by replying to > this email (and keep discussion on the DISCUSS thread) > > Release issue: > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fissue > s.apache.org%2Fjira%2Fbrowse%2FCB-11969=01%7C01%7Cv-vlkoti%40micr > osoft.com%7C1d523da98c484a4754e608d3ee84fe30%7C72f988bf86f141af91ab2d7 > cd011db47%7C1=zacc2vBpeXUzHG0QKZajPyTBhinMSJB9y%2BNo1L1eGk4%3D > eserved=0 > > Both tools have been published to > dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-11969/ > > The packages were published from their corresponding git tags: > > cordova-lib: common-1.5.0 (0b56f9c6e5) > > Upon a successful vote I will upload the archives to dist/, publish > them to npm, and post the corresponding blog post. > > Voting guidelines: > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithu > b.com%2Fapache%2Fcordova-coho%2Fblob%2Fmaster%2Fdocs%2Frelease-voting. > md=01%7C01%7Cv-vlkoti%40microsoft.com%7C1d523da98c484a4754e608d3e > e84fe30%7C72f988bf86f141af91ab2d7cd011db47%7C1=uoLoReoAgAAEneQBG > 4Xuw8fnNm30gjdmq4L0I7qqlxQ%3D=0 > > Voting will go on for a minimum of 48 hours. > > I vote +1: > * Ran coho audit-license-headers over the relevant repos > * Ran coho check-license to ensure all dependencies and > subdependencies have Apache-compatible licenses > * Ran npm test >
[GitHub] cordova-ios pull request #265: CB-11952 - Introduce buildFlag option
Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/265#discussion_r82344457 --- Diff: bin/templates/scripts/cordova/lib/build.js --- @@ -199,33 +220,54 @@ module.exports.findXCodeProjectIn = findXCodeProjectIn; * @param {Boolean} isDevice Flag that specify target for package (device/emulator) * @return {Array} Array of arguments that could be passed directly to spawn method */ -function getXcodeBuildArgs(projectName, projectPath, configuration, isDevice) { +function getXcodeBuildArgs(projectName, projectPath, configuration, isDevice, buildFlags) { var xcodebuildArgs; +var options; +var buildActions = [ 'build' ]; +var settings; +var customArgs = {}; +customArgs.otherFlags = []; + +if (buildFlags) { +if (typeof buildFlags === 'string' || buildFlags instanceof String) { +parseBuildFlag(buildFlags, customArgs); +} else { // buildFlags is an Array of strings +buildFlags.forEach( function(flag) { +parseBuildFlag(flag, customArgs); +}); +} +} + if (isDevice) { -xcodebuildArgs = [ -'-xcconfig', path.join(__dirname, '..', 'build-' + configuration.toLowerCase() + '.xcconfig'), -'-workspace', projectName + '.xcworkspace', -'-scheme', projectName, -'-configuration', configuration, -'-destination', 'generic/platform=iOS', -'-archivePath', projectName + '.xcarchive', -'archive', -'CONFIGURATION_BUILD_DIR=' + path.join(projectPath, 'build', 'device'), -'SHARED_PRECOMPS_DIR=' + path.join(projectPath, 'build', 'sharedpch') +options = [ +'-xcconfig', customArgs.xcconfig || path.join(__dirname, '..', 'build-' + configuration.toLowerCase() + '.xcconfig'), +'-project', customArgs.project || projectName + '.xcodeproj', +customArgs.archs || 'ARCHS=armv7 arm64', +'-target', customArgs.target || projectName, +'-configuration', customArgs.configuration || configuration, +'-sdk', customArgs.sdk || 'iphoneos' +]; +settings = [ +customArgs.valid_archs || 'VALID_ARCHS=armv7 arm64', +customArgs.configuration_build_dir || 'CONFIGURATION_BUILD_DIR=' + path.join(projectPath, 'build', 'device'), +customArgs.shared_precomps_dir || 'SHARED_PRECOMPS_DIR=' + path.join(projectPath, 'build', 'sharedpch') ]; } else { // emulator -xcodebuildArgs = [ -'-xcconfig', path.join(__dirname, '..', 'build-' + configuration.toLowerCase() + '.xcconfig'), -'-workspace', projectName + '.xcworkspace', -'-scheme', projectName , -'-configuration', configuration, -'-sdk', 'iphonesimulator', -'-destination', 'platform=iOS Simulator,name=iPhone 5s', -'build', -'CONFIGURATION_BUILD_DIR=' + path.join(projectPath, 'build', 'emulator'), -'SHARED_PRECOMPS_DIR=' + path.join(projectPath, 'build', 'sharedpch') +options = [ +'-xcconfig', customArgs.xcconfig || path.join(__dirname, '..', 'build-' + configuration.toLowerCase() + '.xcconfig'), +'-project', customArgs.project || projectName + '.xcodeproj', +customArgs.archs || 'ARCHS=x86_64 i386', +'-target', customArgs.target || projectName, +'-configuration', customArgs.configuration || configuration, +'-sdk', customArgs.sdk || 'iphonesimulator' +]; +settings = [ --- End diff -- Same as above. All missing flags are essential. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request #265: CB-11952 - Introduce buildFlag option
Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/265#discussion_r82344341 --- Diff: bin/templates/scripts/cordova/lib/build.js --- @@ -199,33 +220,54 @@ module.exports.findXCodeProjectIn = findXCodeProjectIn; * @param {Boolean} isDevice Flag that specify target for package (device/emulator) * @return {Array} Array of arguments that could be passed directly to spawn method */ -function getXcodeBuildArgs(projectName, projectPath, configuration, isDevice) { +function getXcodeBuildArgs(projectName, projectPath, configuration, isDevice, buildFlags) { var xcodebuildArgs; +var options; +var buildActions = [ 'build' ]; +var settings; +var customArgs = {}; +customArgs.otherFlags = []; + +if (buildFlags) { +if (typeof buildFlags === 'string' || buildFlags instanceof String) { +parseBuildFlag(buildFlags, customArgs); +} else { // buildFlags is an Array of strings +buildFlags.forEach( function(flag) { +parseBuildFlag(flag, customArgs); +}); +} +} + if (isDevice) { -xcodebuildArgs = [ -'-xcconfig', path.join(__dirname, '..', 'build-' + configuration.toLowerCase() + '.xcconfig'), -'-workspace', projectName + '.xcworkspace', -'-scheme', projectName, -'-configuration', configuration, -'-destination', 'generic/platform=iOS', -'-archivePath', projectName + '.xcarchive', -'archive', -'CONFIGURATION_BUILD_DIR=' + path.join(projectPath, 'build', 'device'), -'SHARED_PRECOMPS_DIR=' + path.join(projectPath, 'build', 'sharedpch') +options = [ +'-xcconfig', customArgs.xcconfig || path.join(__dirname, '..', 'build-' + configuration.toLowerCase() + '.xcconfig'), +'-project', customArgs.project || projectName + '.xcodeproj', +customArgs.archs || 'ARCHS=armv7 arm64', +'-target', customArgs.target || projectName, +'-configuration', customArgs.configuration || configuration, +'-sdk', customArgs.sdk || 'iphoneos' +]; +settings = [ +customArgs.valid_archs || 'VALID_ARCHS=armv7 arm64', +customArgs.configuration_build_dir || 'CONFIGURATION_BUILD_DIR=' + path.join(projectPath, 'build', 'device'), +customArgs.shared_precomps_dir || 'SHARED_PRECOMPS_DIR=' + path.join(projectPath, 'build', 'sharedpch') --- End diff -- A lot of essential flags are missing here. - workspace and scheme are essential for Cocoapods support (we don't use the project directly anymore) - archiving is essential for moving off the deprecated packaging in xcrun - destination is needed as well --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request #265: CB-11952 - Introduce buildFlag option
Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/265#discussion_r82344533 --- Diff: tests/spec/unit/build.spec.js --- @@ -0,0 +1,255 @@ +/** + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + */ + +var path = require('path'); +var rewire = require('rewire'); +var build = rewire('../../../bin/templates/scripts/cordova/lib/build'); + +describe('build', function () { +var testProjectPath = path.join('/test', 'project', 'path'); + +describe('getXcodeBuildArgs method', function() { + +var getXcodeBuildArgs = build.__get__('getXcodeBuildArgs'); +build.__set__('__dirname', path.join('/test', 'dir')); + +it('should generate appropriate args if a single buildFlag is passed in', function(done) { +var isDevice = true; +var buildFlags = '-xcconfig TestXcconfigFlag'; + +var args = getXcodeBuildArgs('TestProjectName', testProjectPath, 'TestConfiguration', isDevice, buildFlags); +expect(args[0]).toEqual('-xcconfig'); +expect(args[1]).toEqual('TestXcconfigFlag'); +expect(args[2]).toEqual('-project'); +expect(args[3]).toEqual('TestProjectName.xcodeproj'); +expect(args[4]).toEqual('ARCHS=armv7 arm64'); +expect(args[5]).toEqual('-target'); +expect(args[6]).toEqual('TestProjectName'); +expect(args[7]).toEqual('-configuration'); +expect(args[8]).toEqual('TestConfiguration'); +expect(args[9]).toEqual('-sdk'); +expect(args[10]).toEqual('iphoneos'); +expect(args[11]).toEqual('build'); +expect(args[12]).toEqual('VALID_ARCHS=armv7 arm64'); +expect(args[13]).toEqual('CONFIGURATION_BUILD_DIR=' + path.join(testProjectPath, 'build', 'device')); +expect(args[14]).toEqual('SHARED_PRECOMPS_DIR=' + path.join(testProjectPath, 'build', 'sharedpch')); +expect(args.length).toEqual(15); +done(); +}); --- End diff -- Tests need to be updated once the missing flags are put back. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [Vote] Cordova-common@1.5.0 Release
I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses * Ran npm test On Thu, Oct 6, 2016 at 10:04 PM, Steven Gillwrote: > Please review and vote on this cordova-common Release > by replying to this email (and keep discussion on the DISCUSS thread) > > Release issue: https://issues.apache.org/jira/browse/CB-11969 > > Both tools have been published to > dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-11969/ > > The packages were published from their corresponding git tags: > > cordova-lib: common-1.5.0 (0b56f9c6e5) > > Upon a successful vote I will upload the archives to dist/, publish > them to npm, and post the corresponding blog post. > > Voting guidelines: > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > > Voting will go on for a minimum of 48 hours. > > I vote +1: > * Ran coho audit-license-headers over the relevant repos > * Ran coho check-license to ensure all dependencies and > subdependencies have Apache-compatible licenses > * Ran npm test >