[GitHub] cordova-plugin-contacts pull request #143: Jasmine use of `afterAll` and lab...
Github user alsorokin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/143#discussion_r91883354
--- Diff: appium-tests/common/common.spec.js ---
@@ -242,7 +248,6 @@ describe('Contacts Android', function () {
describe('Picking contacts', function () {
afterEach(function (done) {
-checkSession(done);
--- End diff --
Why is this check removed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-contacts pull request #143: Jasmine use of `afterAll` and lab...
Github user alsorokin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/143#discussion_r91883510
--- Diff: appium-tests/common/common.spec.js ---
@@ -232,7 +232,13 @@ describe('Contacts Android', function () {
}
}
-it('contacts.ui.util configuring driver and starting a session',
function (done) {
+afterAll(function (done) {
+driver
--- End diff --
Wouldn't hurt to call `checkSession()` here too, because I believe we don't
need to call `driver.quit()` if session is not started, and if the driver is
undefined, it could lead to the error message like "undefined is not a
function".
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[BLOG POST] Dec 07 2016 Plugins Release
https://github.com/apache/cordova-docs/pull/667 +1 it, etc Pending npm package publish.
[GitHub] cordova-docs pull request #667: CB-12224 - Added plugins release blog post
GitHub user shazron opened a pull request: https://github.com/apache/cordova-docs/pull/667 CB-12224 - Added plugins release blog post ### Platforms affected None ### What does this PR do? Draft of the Dec 7 2016 Plugins Release Blog Post. ### What testing has been done on this change? Local preview ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected.  You can merge this pull request into a Git repository by running: $ git pull https://github.com/shazron/cordova-docs CB-12224 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-docs/pull/667.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #667 commit 9f05769b2a3f1afb7da1b589bb3d62cf170f6539 Author: Shazron Abdullah Date: 2016-12-11T23:11:48Z CB-12224 - Added plugins release blog post --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [DISCUSS] Plugins Release
Hi Steve Gill and/or Carlos Santana -- please give me write access to these npm modules below. Publishing is stalled until I get permissions. cordova-plugin-battery-status csantanapr stevegill cordova-plugin-camera csantanapr stevegill cordova-plugin-console csantanapr stevegill cordova-plugin-contacts csantanapr stevegill cordova-plugin-device csantanapr stevegill cordova-plugin-device-motion csantanapr stevegill cordova-plugin-device-orientation csantanapr stevegill cordova-plugin-dialogs csantanapr stevegill cordova-plugin-file kotikov.vladimir csantanapr stevegill cordova-plugin-file-transfer nikhilkh csantanapr stevegill cordova-plugin-geolocation csantanapr stevegill cordova-plugin-globalization csantanapr stevegill cordova-plugin-legacy-whitelist csantanapr stevegill cordova-plugin-media kotikov.vladimir csantanapr stevegill cordova-plugin-media-capture csantanapr stevegill cordova-plugin-network-information csantanapr stevegill cordova-plugin-screen-orientation gbenvenuti stevegill tony-- cordova-plugin-splashscreen kotikov.vladimir csantanapr stevegill cordova-plugin-statusbar kotikov.vladimir csantanapr stevegill cordova-plugin-test-framework csantanapr stevegill cordova-plugin-vibration csantanapr stevegill cordova-plugin-whitelist csantanapr stevegill -- I already have access to these: cordova-plugin-wkwebview-engine bowserj kotikov.vladimir purplecabbage shazron csantanapr stevegill cordova-plugin-inappbrowser csantanapr stevegill kotikov.vladimir sgrebnov shazron On Sun, Dec 11, 2016 at 2:11 PM, Shazron wrote: > I've already started https://issues.apache.org/jira/browse/CB-12237 > > On Sun, Dec 11, 2016 at 2:01 PM, Shazron wrote: > >> One more issue -- cordova-plugin-inappbrowser, my intent is not to call >> anyone out here (hey I'm the major source of mistakes for this release) but >> my intent is to fix the problem. The plugin minor version was incremented >> in plugin.xml to 1.6.0 but not incremented in package.json. Thus when the >> packaging automation ran, the version had a mismatch, and that this is >> reflected in cordova-plugin-inappbrowser. >> >> https://github.com/apache/cordova-plugin-inappbrowser/commit >> /cfbd3845a893df647ff39ec3c750804d775a0e57 >> >> We should have a version mismatch automation check during release as well >> in coho, and/or the tests. >> >> So now the problem is, I can't publish cordova-plugin-inappbrowser this >> release because package.json shows the version is 1.5.1 while plugin.xml is >> 1.6.0 (1.6.0 is correct). >> >> I will have to omit cordova-plugin-inappbrowser in this release, and put >> out another cordova plugins release which includes: >> >> 1) Updates in cordova-plugin-battery-status that we discussed >> 2) The package.json update in cordova-plugin-inappbrowser (same version, >> 1.6.0) >> >> >> >> >> >> >> >> On Sun, Dec 11, 2016 at 11:32 AM, Shazron wrote: >> >>> I screwed up the release notes for each plugin (RELEASENOTES.md) in each >>> plugin repo. I'll fix it after release, but will fix it for the blog post: >>> https://issues.apache.org/jira/browse/CB-12236 >>> >>> On Thu, Dec 8, 2016 at 9:03 PM, wrote: >>> Just replying to it from my apache address to bump it up from your spam folders, guys. I'll cast my +1 today. -Original Message- From: Michael Braude [mailto:mbra...@microsoft.com] Sent: Thursday, December 8, 2016 10:09 PM To: dev@cordova.apache.org Subject: RE: [DISCUSS] Plugins Release Not out of the box, no. We don't use that flag ourselves in our default build. I'm OK with this plan. We can release it with the bug and do a patch release later with a fix. Thanks, Mike -Original Message- From: Shazron [mailto:shaz...@gmail.com] Sent: Thursday, December 8, 2016 10:48 AM To: dev@cordova.apache.org Subject: Re: [DISCUSS] Plugins Release > I just found that cordova-plugin-battery-status cannot be built for windows with --browserify tag. Does this affect any downstream distributions, ie Visual Studio? IMO: If it does, I cancel the vote, put out a new vote without the battery-status plugin included. If it doesn't, we can re-release just battery-status with the fix. On Thu, Dec 8, 2016 at 10:35 AM, Jesse wrote: > We can either drop it from the release and publish it after a fix, or > just go ahead with the release and do it again next week. > > Either way, I believe the rest of the vote can proceed, and this > should not affect the overall release vote. > > I personally lean towards letting it go out, and re-releasing soon, > mainly based on the facts
Re: [DISCUSS] Plugins Release
I've already started https://issues.apache.org/jira/browse/CB-12237 On Sun, Dec 11, 2016 at 2:01 PM, Shazron wrote: > One more issue -- cordova-plugin-inappbrowser, my intent is not to call > anyone out here (hey I'm the major source of mistakes for this release) but > my intent is to fix the problem. The plugin minor version was incremented > in plugin.xml to 1.6.0 but not incremented in package.json. Thus when the > packaging automation ran, the version had a mismatch, and that this is > reflected in cordova-plugin-inappbrowser. > > https://github.com/apache/cordova-plugin-inappbrowser/commit/ > cfbd3845a893df647ff39ec3c750804d775a0e57 > > We should have a version mismatch automation check during release as well > in coho, and/or the tests. > > So now the problem is, I can't publish cordova-plugin-inappbrowser this > release because package.json shows the version is 1.5.1 while plugin.xml is > 1.6.0 (1.6.0 is correct). > > I will have to omit cordova-plugin-inappbrowser in this release, and put > out another cordova plugins release which includes: > > 1) Updates in cordova-plugin-battery-status that we discussed > 2) The package.json update in cordova-plugin-inappbrowser (same version, > 1.6.0) > > > > > > > > On Sun, Dec 11, 2016 at 11:32 AM, Shazron wrote: > >> I screwed up the release notes for each plugin (RELEASENOTES.md) in each >> plugin repo. I'll fix it after release, but will fix it for the blog post: >> https://issues.apache.org/jira/browse/CB-12236 >> >> On Thu, Dec 8, 2016 at 9:03 PM, wrote: >> >>> Just replying to it from my apache address to bump it up from your spam >>> folders, guys. I'll cast my +1 today. >>> >>> -Original Message- >>> From: Michael Braude [mailto:mbra...@microsoft.com] >>> Sent: Thursday, December 8, 2016 10:09 PM >>> To: dev@cordova.apache.org >>> Subject: RE: [DISCUSS] Plugins Release >>> >>> Not out of the box, no. We don't use that flag ourselves in our default >>> build. >>> >>> I'm OK with this plan. We can release it with the bug and do a patch >>> release later with a fix. >>> >>> Thanks, >>> Mike >>> >>> -Original Message- >>> From: Shazron [mailto:shaz...@gmail.com] >>> Sent: Thursday, December 8, 2016 10:48 AM >>> To: dev@cordova.apache.org >>> Subject: Re: [DISCUSS] Plugins Release >>> >>> > I just found that cordova-plugin-battery-status cannot be built for >>> windows with --browserify tag. >>> >>> Does this affect any downstream distributions, ie Visual Studio? >>> IMO: >>> If it does, I cancel the vote, put out a new vote without the >>> battery-status plugin included. >>> If it doesn't, we can re-release just battery-status with the fix. >>> >>> On Thu, Dec 8, 2016 at 10:35 AM, Jesse wrote: >>> >>> > We can either drop it from the release and publish it after a fix, or >>> > just go ahead with the release and do it again next week. >>> > >>> > Either way, I believe the rest of the vote can proceed, and this >>> > should not affect the overall release vote. >>> > >>> > I personally lean towards letting it go out, and re-releasing soon, >>> > mainly based on the facts that the battery-status plugin is one of our >>> > less used, and that the browserify workflow is hardly utilized. >>> > >>> > >>> > >>> > >>> > >>> > @purplecabbage >>> > risingj.com >>> > >>> > On Thu, Dec 8, 2016 at 6:24 AM, wrote: >>> > >>> > > Hey guys, >>> > > >>> > > I just found that cordova-plugin-battery-status cannot be built for >>> > > windows with --browserify tag. >>> > > Will it hold the Battery Status Plugin release back or shall we just >>> > > do a patch release later? >>> > > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fiss >>> > > ues.apache.org%2Fjira%2Fbrowse%2FCB-12227&data=02%7C01%7Cmbraude%40m >>> > > icrosoft.com%7Ca3be23faade2476077fa08d41f9afb50%7C72f988bf86f141af91 >>> > > ab2d7cd011db47%7C1%7C0%7C636168197876884508&sdata=MYVYCuf3W6dOlBZvSr >>> > > y92n%2FnDrZwYYDXSeM2MqQDcWg%3D&reserved=0 >>> > > >>> > > --Alex >>> > > >>> > > -Original Message- >>> > > From: Shazron [mailto:shaz...@gmail.com] >>> > > Sent: Thursday, December 8, 2016 3:56 AM >>> > > To: dev@cordova.apache.org >>> > > Subject: Re: [DISCUSS] Plugins Release >>> > > >>> > > https://na01.safelinks.protection.outlook.com/?url= >>> > > https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FCB- >>> > > 12224&data=02%7C01%7Cv-alsoro%40microsoft.com% >>> > > 7C5f9413fa60704ee1ed8708d41f0520d4%7C72f988bf86f141af91ab2d7cd011 >>> > > db47%7C1%7C0%7C636167554259114573&sdata=uXe5IbJ2w9v8sNT5WVzJknWg30n6 >>> > > % >>> > > 2BHBDNepSnUSrlJ0%3D&reserved=0 >>> > > >>> > > On Mon, Dec 5, 2016 at 5:42 PM, Shazron wrote: >>> > > >>> > > > Sergey - I reviewed the two PRs. >>> > > > I'll start on the Plugins Release tomorrow if there are no other >>> > issues. >>> > > > >>> > > > On Mon, Dec 5, 2016 at 1:38 AM, Sergey Shakhnazarov (Akvelon) < >>> > > > v-ses...@microsoft.com> wrote: >>> > > > >>> > > >> Hi guys, >>> > > >> >>> > > >> I would be grateful if someone could
Re: [DISCUSS] Plugins Release
One more issue -- cordova-plugin-inappbrowser, my intent is not to call anyone out here (hey I'm the major source of mistakes for this release) but my intent is to fix the problem. The plugin minor version was incremented in plugin.xml to 1.6.0 but not incremented in package.json. Thus when the packaging automation ran, the version had a mismatch, and that this is reflected in cordova-plugin-inappbrowser. https://github.com/apache/cordova-plugin-inappbrowser/commit/cfbd3845a893df647ff39ec3c750804d775a0e57 We should have a version mismatch automation check during release as well in coho, and/or the tests. So now the problem is, I can't publish cordova-plugin-inappbrowser this release because package.json shows the version is 1.5.1 while plugin.xml is 1.6.0 (1.6.0 is correct). I will have to omit cordova-plugin-inappbrowser in this release, and put out another cordova plugins release which includes: 1) Updates in cordova-plugin-battery-status that we discussed 2) The package.json update in cordova-plugin-inappbrowser (same version, 1.6.0) On Sun, Dec 11, 2016 at 11:32 AM, Shazron wrote: > I screwed up the release notes for each plugin (RELEASENOTES.md) in each > plugin repo. I'll fix it after release, but will fix it for the blog post: > https://issues.apache.org/jira/browse/CB-12236 > > On Thu, Dec 8, 2016 at 9:03 PM, wrote: > >> Just replying to it from my apache address to bump it up from your spam >> folders, guys. I'll cast my +1 today. >> >> -Original Message- >> From: Michael Braude [mailto:mbra...@microsoft.com] >> Sent: Thursday, December 8, 2016 10:09 PM >> To: dev@cordova.apache.org >> Subject: RE: [DISCUSS] Plugins Release >> >> Not out of the box, no. We don't use that flag ourselves in our default >> build. >> >> I'm OK with this plan. We can release it with the bug and do a patch >> release later with a fix. >> >> Thanks, >> Mike >> >> -Original Message- >> From: Shazron [mailto:shaz...@gmail.com] >> Sent: Thursday, December 8, 2016 10:48 AM >> To: dev@cordova.apache.org >> Subject: Re: [DISCUSS] Plugins Release >> >> > I just found that cordova-plugin-battery-status cannot be built for >> windows with --browserify tag. >> >> Does this affect any downstream distributions, ie Visual Studio? >> IMO: >> If it does, I cancel the vote, put out a new vote without the >> battery-status plugin included. >> If it doesn't, we can re-release just battery-status with the fix. >> >> On Thu, Dec 8, 2016 at 10:35 AM, Jesse wrote: >> >> > We can either drop it from the release and publish it after a fix, or >> > just go ahead with the release and do it again next week. >> > >> > Either way, I believe the rest of the vote can proceed, and this >> > should not affect the overall release vote. >> > >> > I personally lean towards letting it go out, and re-releasing soon, >> > mainly based on the facts that the battery-status plugin is one of our >> > less used, and that the browserify workflow is hardly utilized. >> > >> > >> > >> > >> > >> > @purplecabbage >> > risingj.com >> > >> > On Thu, Dec 8, 2016 at 6:24 AM, wrote: >> > >> > > Hey guys, >> > > >> > > I just found that cordova-plugin-battery-status cannot be built for >> > > windows with --browserify tag. >> > > Will it hold the Battery Status Plugin release back or shall we just >> > > do a patch release later? >> > > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fiss >> > > ues.apache.org%2Fjira%2Fbrowse%2FCB-12227&data=02%7C01%7Cmbraude%40m >> > > icrosoft.com%7Ca3be23faade2476077fa08d41f9afb50%7C72f988bf86f141af91 >> > > ab2d7cd011db47%7C1%7C0%7C636168197876884508&sdata=MYVYCuf3W6dOlBZvSr >> > > y92n%2FnDrZwYYDXSeM2MqQDcWg%3D&reserved=0 >> > > >> > > --Alex >> > > >> > > -Original Message- >> > > From: Shazron [mailto:shaz...@gmail.com] >> > > Sent: Thursday, December 8, 2016 3:56 AM >> > > To: dev@cordova.apache.org >> > > Subject: Re: [DISCUSS] Plugins Release >> > > >> > > https://na01.safelinks.protection.outlook.com/?url= >> > > https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FCB- >> > > 12224&data=02%7C01%7Cv-alsoro%40microsoft.com% >> > > 7C5f9413fa60704ee1ed8708d41f0520d4%7C72f988bf86f141af91ab2d7cd011 >> > > db47%7C1%7C0%7C636167554259114573&sdata=uXe5IbJ2w9v8sNT5WVzJknWg30n6 >> > > % >> > > 2BHBDNepSnUSrlJ0%3D&reserved=0 >> > > >> > > On Mon, Dec 5, 2016 at 5:42 PM, Shazron wrote: >> > > >> > > > Sergey - I reviewed the two PRs. >> > > > I'll start on the Plugins Release tomorrow if there are no other >> > issues. >> > > > >> > > > On Mon, Dec 5, 2016 at 1:38 AM, Sergey Shakhnazarov (Akvelon) < >> > > > v-ses...@microsoft.com> wrote: >> > > > >> > > >> Hi guys, >> > > >> >> > > >> I would be grateful if someone could take a look at the >> > > >> file-transfer plugin PRs related to chunkedMode: >> > > >> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2F >> > > >> gith >> > > >> ub.com%2Fapache%2Fcordova-plugin-file-transfer%2Fpull%2F170&data= >> > > >> 02%7 >> > > >> C
Re: [DISCUSS] Plugins Release
I screwed up the release notes for each plugin (RELEASENOTES.md) in each plugin repo. I'll fix it after release, but will fix it for the blog post: https://issues.apache.org/jira/browse/CB-12236 On Thu, Dec 8, 2016 at 9:03 PM, wrote: > Just replying to it from my apache address to bump it up from your spam > folders, guys. I'll cast my +1 today. > > -Original Message- > From: Michael Braude [mailto:mbra...@microsoft.com] > Sent: Thursday, December 8, 2016 10:09 PM > To: dev@cordova.apache.org > Subject: RE: [DISCUSS] Plugins Release > > Not out of the box, no. We don't use that flag ourselves in our default > build. > > I'm OK with this plan. We can release it with the bug and do a patch > release later with a fix. > > Thanks, > Mike > > -Original Message- > From: Shazron [mailto:shaz...@gmail.com] > Sent: Thursday, December 8, 2016 10:48 AM > To: dev@cordova.apache.org > Subject: Re: [DISCUSS] Plugins Release > > > I just found that cordova-plugin-battery-status cannot be built for > windows with --browserify tag. > > Does this affect any downstream distributions, ie Visual Studio? > IMO: > If it does, I cancel the vote, put out a new vote without the > battery-status plugin included. > If it doesn't, we can re-release just battery-status with the fix. > > On Thu, Dec 8, 2016 at 10:35 AM, Jesse wrote: > > > We can either drop it from the release and publish it after a fix, or > > just go ahead with the release and do it again next week. > > > > Either way, I believe the rest of the vote can proceed, and this > > should not affect the overall release vote. > > > > I personally lean towards letting it go out, and re-releasing soon, > > mainly based on the facts that the battery-status plugin is one of our > > less used, and that the browserify workflow is hardly utilized. > > > > > > > > > > > > @purplecabbage > > risingj.com > > > > On Thu, Dec 8, 2016 at 6:24 AM, wrote: > > > > > Hey guys, > > > > > > I just found that cordova-plugin-battery-status cannot be built for > > > windows with --browserify tag. > > > Will it hold the Battery Status Plugin release back or shall we just > > > do a patch release later? > > > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fiss > > > ues.apache.org%2Fjira%2Fbrowse%2FCB-12227&data=02%7C01%7Cmbraude%40m > > > icrosoft.com%7Ca3be23faade2476077fa08d41f9afb50%7C72f988bf86f141af91 > > > ab2d7cd011db47%7C1%7C0%7C636168197876884508&sdata=MYVYCuf3W6dOlBZvSr > > > y92n%2FnDrZwYYDXSeM2MqQDcWg%3D&reserved=0 > > > > > > --Alex > > > > > > -Original Message- > > > From: Shazron [mailto:shaz...@gmail.com] > > > Sent: Thursday, December 8, 2016 3:56 AM > > > To: dev@cordova.apache.org > > > Subject: Re: [DISCUSS] Plugins Release > > > > > > https://na01.safelinks.protection.outlook.com/?url= > > > https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FCB- > > > 12224&data=02%7C01%7Cv-alsoro%40microsoft.com% > > > 7C5f9413fa60704ee1ed8708d41f0520d4%7C72f988bf86f141af91ab2d7cd011 > > > db47%7C1%7C0%7C636167554259114573&sdata=uXe5IbJ2w9v8sNT5WVzJknWg30n6 > > > % > > > 2BHBDNepSnUSrlJ0%3D&reserved=0 > > > > > > On Mon, Dec 5, 2016 at 5:42 PM, Shazron wrote: > > > > > > > Sergey - I reviewed the two PRs. > > > > I'll start on the Plugins Release tomorrow if there are no other > > issues. > > > > > > > > On Mon, Dec 5, 2016 at 1:38 AM, Sergey Shakhnazarov (Akvelon) < > > > > v-ses...@microsoft.com> wrote: > > > > > > > >> Hi guys, > > > >> > > > >> I would be grateful if someone could take a look at the > > > >> file-transfer plugin PRs related to chunkedMode: > > > >> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2F > > > >> gith > > > >> ub.com%2Fapache%2Fcordova-plugin-file-transfer%2Fpull%2F170&data= > > > >> 02%7 > > > >> C01%7Cv-alsoro%40microsoft.com%7C5f9413fa60704ee1ed8708d41f0520d4 > > > >> %7C7 > > > >> 2f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636167554259114573&sdat > > > >> a=Yf > > > >> Yuv98kQTbK8dmKtCERRqjYxbQqwu5hWouBgiTbRKU%3D&reserved=0 > > > >> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2F > > > >> gith > > > >> ub.com%2Fapache%2Fcordova-plugin-file-transfer%2Fpull%2F169&data= > > > >> 02%7 > > > >> C01%7Cv-alsoro%40microsoft.com%7C5f9413fa60704ee1ed8708d41f0520d4 > > > >> %7C7 > > > >> 2f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636167554259124586&sdat > > > >> a=cF > > > >> wArcxOlkl0SiZwO%2BDXNa0V0wK13jdpI9PCPXK21M8%3D&reserved=0 > > > >> The changes are not breaking: > > > >> for Android we do not force chunkedMode=true for HTTPS any more > > (i.e. > > > >> if developer passed it as false in the opts thus overriding the > > > defaults), > > > >> for iOS we make chunkedMode=true progress events to be computable. > > > >> > > > >> Please let me know if you have any questions or considerations. > > > >> > > > >> Best regards, > > > >> Sergey Shakhnazarov. > > > >> > > > >> -Original Message- > > > >> From: Shazron [mailto:shaz...@gmail.com] > > > >> Sent: Thursday, December 1, 20
Re: [VOTE] Plugins Release
The vote has now closed. The results are: Positive Binding Votes: 3 Shazron Abdullah Filip Maj Alex Sorokin The vote has passed. On Fri, Dec 9, 2016 at 12:15 AM, wrote: > I vote +1. > > * Verified signatures and hashes > * Verified tags > * Verified that plugins can be added correctly to blank app > * Verified that blank app can be successfully built and ran (windows, ios > and android) > * Verified that browserified app can be successfully built and ran > (windows, ios and android) > * Ran smoke testing of mobilespec app (windows, ios and android) > > Found issues: > - Battery Status plugin cannot be built with browserify on Windows, we > agreed to just make a patch release next week > > --Alex > > -Original Message- > From: Filip Maj [mailto:maj@gmail.com] > Sent: Friday, December 9, 2016 5:10 AM > To: dev@cordova.apache.org > Subject: Re: [VOTE] Plugins Release > > I vote +1: > - created a cordova-android 6.1.0-based mobile-spec project, installed > relevant tags of plugins, ran autotests, poked around manual tests, things > seem fine. > - created a cordova-ios 4.3.1-based mobile-spec project, installed > relevant tags of plugins, ran autotests, poked around manual tests, things > seem fine. > > On Wed, Dec 7, 2016 at 5:26 PM, Shazron wrote: > > Please review and vote on the release of this plugins release by > > replying to this email (and keep discussion on the DISCUSS thread) > > > > Release issue: > > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fissue > > s.apache.org%2Fjira%2Fbrowse%2FCB-12224&data=02%7C01%7Cv-alsoro%40micr > > osoft.com%7C956cfbeeda1c4bbe17f508d41fd8915c%7C72f988bf86f141af91ab2d7 > > cd011db47%7C1%7C0%7C636168462386401020&sdata=b8Dpo%2FCy9wEDAodbj1ImTT2 > > NsflXmJCGLDnisPttUEY%3D&reserved=0 > > > > The plugins have been published to dist/dev: > > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdist. > > apache.org%2Frepos%2Fdist%2Fdev%2Fcordova%2FCB-12224%2F&data=02%7C01%7 > > Cv-alsoro%40microsoft.com%7C956cfbeeda1c4bbe17f508d41fd8915c%7C72f988b > > f86f141af91ab2d7cd011db47%7C1%7C0%7C636168462386411033&sdata=oKXsDvIDg > > iUSNYNlPZcfTHPmyT7KheY4kVQ1hlMuYbY%3D&reserved=0 > > > > The packages were published from their corresponding git tags: > > cordova-plugin-battery-status: 1.2.1 (59189285b6) > > cordova-plugin-camera: 2.3.1 (9eba35e2f6) > > cordova-plugin-console: 1.0.5 (8bf1ba18d5) > > cordova-plugin-contacts: 2.2.1 (af620d6cde) > > cordova-plugin-device: 1.1.4 (a736ae44b1) > > cordova-plugin-device-motion: 1.2.3 (5e0e28f4f2) > > cordova-plugin-device-orientation: 1.0.5 (4b5ead9000) > > cordova-plugin-dialogs: 1.3.1 (233aff26f8) > > cordova-plugin-file: 4.3.1 (db39e7ccab) > > cordova-plugin-file-transfer: 1.6.1 (aee45754a9) > > cordova-plugin-geolocation: 2.4.1 (7934ed7026) > > cordova-plugin-globalization: 1.0.5 (594651d272) > > cordova-plugin-inappbrowser: 1.6.0 (009e662c82) > > cordova-plugin-legacy-whitelist: 1.1.2 (7c561bdff1) > > cordova-plugin-media: 2.4.1 (f0a6d45120) > > cordova-plugin-media-capture: 1.4.1 (b09b24d71b) > > cordova-plugin-network-information: 1.3.1 (0079edbaa5) > > cordova-plugin-screen-orientation: 1.4.2 (fff9124669) > > cordova-plugin-splashscreen: 4.0.1 (782939f7ef) > > cordova-plugin-statusbar: 2.2.1 (a50208bda2) > > cordova-plugin-test-framework: 1.1.4 (1a9d5cd241) > > cordova-plugin-vibration: 2.1.3 (fcc6f19a08) > > cordova-plugin-whitelist: 1.3.1 (79f74a00e2) > > cordova-plugin-wkwebview-engine: 1.1.1 (91e9d74e78) > > > > Upon a successful vote I will upload the archives to dist/, upload > > them to npm, and post the corresponding blog post. > > > > Voting guidelines: > > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithu > > b.com%2Fapache%2Fcordova-coho%2Fblob%2Fmaster%2Fdocs%2Frelease-voting. > > md&data=02%7C01%7Cv-alsoro%40microsoft.com%7C956cfbeeda1c4bbe17f508d41 > > fd8915c%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C63616846238641103 > > 3&sdata=SxJlf5g5tBLOSALaEp7zAS4egRx27ZEBAijB4dtOPso%3D&reserved=0 > > > > How to vote on a plugins release at > > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithu > > b.com%2Fapache%2Fcordova-coho%2Fblob%2Fmaster%2Fdocs%2Fplugins-release > > -process.md%23voting&data=02%7C01%7Cv-alsoro%40microsoft.com%7C956cfbe > > eda1c4bbe17f508d41fd8915c%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7 > > C636168462386411033&sdata=3XihSAdYecfGxYzb%2B0zFCxmhSQKCKEp1Qo8bhPYIrR > > E%3D&reserved=0 > > > > Voting will go on for a minimum of 48 hours. > > > > I vote +1: > > * Ran coho audit-license-headers over the relevant repos > > * Ran coho check-license to ensure all dependencies and > > subdependencies have Apache-compatible licenses > > * Ensured continuous build was green when repos were tagged > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.
[GitHub] cordova-plugin-splashscreen issue #109: CB-11602: (android) Fix bug AutoHide...
Github user nbabanov commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/109 @dcousens Sadly it is still not merged in the official code base. :( --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
