date:20161221

[GitHub] cordova-plugin-screen-orientation pull request #9: CB-12286 Tests reworked

2016-12-21 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-screen-orientation/pull/9


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[VOTE] cordova-serve 1.0.1 release

2016-12-21 Thread Tim Barham

Please review and vote on this Tools Release by replying to this email (and 
keep discussion on the DISCUSS thread)

Release issue: https://issues.apache.org/jira/browse/CB-12289

The release has been published to dist/dev: 
https://dist.apache.org/repos/dist/dev/cordova/CB-12289/. It has also been 
published to npm with the "rc" tag, and can be installed for testing using 
"cordova-serve@rc"

The packages were published from their corresponding git tags:

cordova-lib: serve-1.0.1 (510a698841)

Upon a successful vote I will upload the archives to dist/, publish them to 
NPM, and post the corresponding blog post.

Voting guidelines: 
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md

Voting will go on for a minimum of 48 hours.

I vote +1:

* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and subdependencies have 
Apache-compatible licenses
* Manually verified package contents

[GitHub] cordova-plugin-media issue #116: CB-11817: (iOS) Fix unused recording settin...

2016-12-21 Thread ghenry22

Github user ghenry22 commented on the issue:

https://github.com/apache/cordova-plugin-media/pull/116
  
This is a really trivial fix could it please get merged?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: DISCUSS: cordova-serve 1.0.1 release

2016-12-21 Thread Jesse

+1 do what you need to, I'll try to make time to review and vote. 

> On Dec 21, 2016, at 2:39 PM, Tim Barham  wrote:
> 
> I'd like to do a cordova-serve 1.0.1 release that just cherry picks a single 
> commit 
> (https://github.com/apache/cordova-lib/commit/84fa8e39b22252381ed4baa6868ff6f22b7a48e2).
>  Anyone have any concerns with that?
> 
> (the reasoning behind just taking that single commit is that we'd like to 
> take that fix for an upcoming Visual Studio release, and previous commits to 
> cordova-serve since the last release add dependencies which complicates the 
> legal process)
> 
> Thanks!
> 
> Tim
> 

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

DISCUSS: cordova-serve 1.0.1 release

2016-12-21 Thread Tim Barham

I'd like to do a cordova-serve 1.0.1 release that just cherry picks a single 
commit 
(https://github.com/apache/cordova-lib/commit/84fa8e39b22252381ed4baa6868ff6f22b7a48e2).
 Anyone have any concerns with that?

(the reasoning behind just taking that single commit is that we'd like to take 
that fix for an upcoming Visual Studio release, and previous commits to 
cordova-serve since the last release add dependencies which complicates the 
legal process)

Thanks!

Tim

[GitHub] cordova-lib pull request #512: CB-12284 Include project root as additional r...

2016-12-21 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/512


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser issue #187: CB-11136: InAppBrowser fails to clos...

2016-12-21 Thread nerdmed

Github user nerdmed commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/187
  
@shazron @manucorporat, i know its christmas time but guys lets forward. 
This i hanging around long enough and people are working with forks to run in 
production, this really affects a lot of production apps!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...

2016-12-21 Thread stevengill

Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/510#discussion_r93506823
  
--- Diff: cordova-lib/spec-plugman/platforms/ios.spec.js ---
@@ -301,14 +301,8 @@ describe('ios project handler', function() {
 });
 });
 it('of two plugins should apply xcode file changes from both', 
function(){
--- End diff --

in your first comment, you had done outside the promise chain. In your 
second comment, you have done in the correct spot. Order shouldn't matter. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...

2016-12-21 Thread audreyso

Github user audreyso commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/510#discussion_r93502548
  
--- Diff: cordova-lib/spec-plugman/platforms/ios.spec.js ---
@@ -301,14 +301,8 @@ describe('ios project handler', function() {
 });
 });
 it('of two plugins should apply xcode file changes from both', 
function(){
--- End diff --

@stevengill Does the order of the test matter? If I test this way, the test 
passes just fine.

``` it('of two plugins should apply xcode file changes from both', 
function(done){
return install('ios', temp, weblessplugin)
.then(function (result) { 
var xcode = ios.parseProjectFile(temp).xcode;
// from org.test.plugins.weblessplugin
expect(xcode.hasFile(slashJoin('Resources', 
'WeblessPluginViewController.xib'))).toBeTruthy();

expect(xcode.hasFile(slashJoin('Plugins','org.test.plugins.weblessplugin','WeblessPluginCommand.h'))).toBeTruthy();

expect(xcode.hasFile(slashJoin('Plugins','org.test.plugins.weblessplugin','WeblessPluginCommand.m'))).toBeTruthy();

expect(xcode.hasFile('usr/lib/libsqlite3.dylib')).toBeTruthy();
done();
}).then(function () {
return install('ios', temp, dummyplugin)
}).then(function () {
var xcode = ios.parseProjectFile(temp).xcode;
// from org.test.plugins.dummyplugin
expect(xcode.hasFile(slashJoin('Resources', 
'DummyPlugin.bundle'))).toBeTruthy();

expect(xcode.hasFile(slashJoin('Plugins','org.test.plugins.dummyplugin', 
'DummyPluginCommand.h'))).toBeTruthy();

expect(xcode.hasFile(slashJoin('Plugins','org.test.plugins.dummyplugin', 
'DummyPluginCommand.m'))).toBeTruthy();

expect(xcode.hasFile(slashJoin('Plugins','org.test.plugins.dummyplugin','targetDir','TargetDirTest.h'))).toBeTruthy();

expect(xcode.hasFile(slashJoin('Plugins','org.test.plugins.dummyplugin','targetDir','TargetDirTest.m'))).toBeTruthy();

expect(xcode.hasFile(slashJoin('SampleApp','Plugins','org.test.plugins.dummyplugin','Custom.framework'))).toBeTruthy();
done();
});
}, 6);
}); ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...

2016-12-21 Thread audreyso

Github user audreyso commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/510#discussion_r93493946
  
--- Diff: cordova-lib/spec-plugman/platforms/ios.spec.js ---
@@ -301,14 +301,8 @@ describe('ios project handler', function() {
 });
 });
 it('of two plugins should apply xcode file changes from both', 
function(){
--- End diff --

@stevengill : if I modify this test, the console.logs both print out, but 
there are 3 failures.

``` it('of two plugins should apply xcode file changes from both', 
function(done){
 install('ios', temp, dummyplugin)
.then(function (result) { 
var xcode = ios.parseProjectFile(temp).xcode;
// from org.test.plugins.dummyplugin
expect(xcode.hasFile(slashJoin('Resources', 
'DummyPlugin.bundle'))).toBeTruthy();

expect(xcode.hasFile(slashJoin('Plugins','org.test.plugins.dummyplugin', 
'DummyPluginCommand.h'))).toBeTruthy();

expect(xcode.hasFile(slashJoin('Plugins','org.test.plugins.dummyplugin', 
'DummyPluginCommand.m'))).toBeTruthy();

expect(xcode.hasFile(slashJoin('Plugins','org.test.plugins.dummyplugin','targetDir','TargetDirTest.h'))).toBeTruthy();

expect(xcode.hasFile(slashJoin('Plugins','org.test.plugins.dummyplugin','targetDir','TargetDirTest.m'))).toBeTruthy();

expect(xcode.hasFile(slashJoin('SampleApp','Plugins','org.test.plugins.dummyplugin','Custom.framework'))).toBeTruthy();
console.log('done 1')
}).then(function (result) {
install('ios', temp, weblessplugin)
}).then(function (result) {
var xcode = ios.parseProjectFile(temp).xcode;
// from org.test.plugins.weblessplugin
// Below fails and wants false
expect(xcode.hasFile(slashJoin('Resources', 
'WeblessPluginViewController.xib'))).toBeTruthy();
// Below fails and wants false

expect(xcode.hasFile(slashJoin('Plugins','org.test.plugins.weblessplugin','WeblessPluginCommand.h'))).toBeTruthy();
// Below fails and wants false

expect(xcode.hasFile(slashJoin('Plugins','org.test.plugins.weblessplugin','WeblessPluginCommand.m'))).toBeTruthy();

expect(xcode.hasFile('usr/lib/libsqlite3.dylib')).toBeTruthy();
console.log('done 2')
});
done();
});
}); ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...

2016-12-21 Thread stevengill

Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/510#discussion_r93490653
  
--- Diff: cordova-lib/spec-plugman/platforms/windows.spec.js ---
@@ -50,18 +50,30 @@ function copyArray(arr) {
 }
 
 beforeEach(function () {
-this.addMatchers({
+jasmine.addMatchers({
 toContainXmlPath: function (xpath) {
 var xml = this.actual;
 var notText = this.isNot ? 'not ' : '';
--- End diff --

delete this


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...

2016-12-21 Thread stevengill

Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/510#discussion_r93492375
  
--- Diff: cordova-lib/spec-plugman/platforms/wp8.spec.js ---
@@ -113,22 +113,21 @@ describe('wp8 project handler', function() {
 fs.writeFileSync(target, 'some bs', 'utf-8');
 expect(function() {
 wp8['source-file'].install(source[0], dummyplugin, 
temp, dummy_id, null, proj_files);
-}).toThrow('"' + target + '" already exists!');
+}).toThrow(new Error ('"' + target + '" already exists!'));
 });
 });
 describe('of  elements', function() {
 beforeEach(function() {
 shell.cp('-rf', path.join(wp8_project, '*'), temp);
 });
-it('should process and pass the after parameter to graftXML', 
function () {
-var graftXML = spyOn(xml_helpers, 
'graftXML').andCallThrough();
-
-runs(function () { installPromise(install('wp8', temp, 
dummyplugin, plugins_dir, {})); });
-waitsFor(function () { return done; }, 'install promise 
never resolved', 500);
-runs(function () {
+it('should process and pass the after parameter to graftXML', 
function (done) {
+var graftXML = spyOn(xml_helpers, 
'graftXML').and.callThrough();
+return install('wp8', temp, dummyplugin, plugins_dir, {})
+.then(function(result) {
--- End diff --

don't need the result argument here since you don't use it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...

2016-12-21 Thread stevengill

Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/510#discussion_r93492132
  
--- Diff: cordova-lib/spec-plugman/platforms/windows.spec.js ---
@@ -50,18 +50,30 @@ function copyArray(arr) {
 }
 
 beforeEach(function () {
-this.addMatchers({
+jasmine.addMatchers({
 toContainXmlPath: function (xpath) {
 var xml = this.actual;
 var notText = this.isNot ? 'not ' : '';
-this.message = function () {
-return 'Expected xml \'' + et.tostring(xml) + '\' ' + 
notText + 'to contain elements matching \'' + xpath + '\'.';
-};
-
-return xml.find(xpath) !== null;
-}});
+// this.message = function () {
+// return 'Expected xml \'' + et.tostring(xml) + '\' ' + 
notText + 'to contain elements matching \'' + xpath + '\'.';
+// };
+return {
+compare: function(actual, expected) {
+var result = {};
+result.pass = fs.existsSync(actual);
+
+//return xml.find(xpath) !== null;
+if(result.pass) {
+result.message = "expected " + actual + " to not 
exist";
+} else {
+result.message = "expected " + actual + " to 
exist";
--- End diff --

update second message to 

`'Expected xml \'' + et.tostring(xml) + '\' ' +' to contain elements 
matching \'' + expected + '\'.';`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...

2016-12-21 Thread stevengill

Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/510#discussion_r93490510
  
--- Diff: cordova-lib/spec-plugman/platforms/windows.spec.js ---
@@ -50,18 +50,30 @@ function copyArray(arr) {
 }
 
 beforeEach(function () {
-this.addMatchers({
+jasmine.addMatchers({
 toContainXmlPath: function (xpath) {
 var xml = this.actual;
 var notText = this.isNot ? 'not ' : '';
-this.message = function () {
-return 'Expected xml \'' + et.tostring(xml) + '\' ' + 
notText + 'to contain elements matching \'' + xpath + '\'.';
-};
-
-return xml.find(xpath) !== null;
-}});
+// this.message = function () {
+// return 'Expected xml \'' + et.tostring(xml) + '\' ' + 
notText + 'to contain elements matching \'' + xpath + '\'.';
+// };
+return {
+compare: function(actual, expected) {
+var result = {};
+result.pass = fs.existsSync(actual);
--- End diff --

replace this with 
```
 result.pass = xml.find(expected) !== null;
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...

2016-12-21 Thread stevengill

Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/510#discussion_r93490083
  
--- Diff: cordova-lib/spec-plugman/platforms/ios.spec.js ---
@@ -301,14 +301,8 @@ describe('ios project handler', function() {
 });
 });
 it('of two plugins should apply xcode file changes from both', 
function(){
--- End diff --

I think you should add `done` here and call it at the end of the promise. 
See what happens. 

You can also chain the two promises (move 315 into 313). 

Add some console logs to confirm these tests are actually running


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...

2016-12-21 Thread stevengill

Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/510#discussion_r93492030
  
--- Diff: cordova-lib/spec-plugman/platforms/windows.spec.js ---
@@ -50,18 +50,30 @@ function copyArray(arr) {
 }
 
 beforeEach(function () {
-this.addMatchers({
+jasmine.addMatchers({
 toContainXmlPath: function (xpath) {
 var xml = this.actual;
 var notText = this.isNot ? 'not ' : '';
-this.message = function () {
-return 'Expected xml \'' + et.tostring(xml) + '\' ' + 
notText + 'to contain elements matching \'' + xpath + '\'.';
-};
-
-return xml.find(xpath) !== null;
-}});
+// this.message = function () {
+// return 'Expected xml \'' + et.tostring(xml) + '\' ' + 
notText + 'to contain elements matching \'' + xpath + '\'.';
+// };
+return {
+compare: function(actual, expected) {
+var result = {};
+result.pass = fs.existsSync(actual);
+
+//return xml.find(xpath) !== null;
+if(result.pass) {
+result.message = "expected " + actual + " to not 
exist";
--- End diff --

Update first message to 
`'Expected xml \'' + et.tostring(xml) + '\' ' +' not to contain elements 
matching \'' + expected + '\'.';`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...

2016-12-21 Thread stevengill

Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/510#discussion_r93491307
  
--- Diff: cordova-lib/spec-plugman/platforms/windows.spec.js ---
@@ -50,18 +50,30 @@ function copyArray(arr) {
 }
 
 beforeEach(function () {
-this.addMatchers({
+jasmine.addMatchers({
 toContainXmlPath: function (xpath) {
--- End diff --

remove xpath argument. Not needed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...

2016-12-21 Thread stevengill

Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/510#discussion_r93491264
  
--- Diff: cordova-lib/spec-plugman/platforms/windows.spec.js ---
@@ -50,18 +50,30 @@ function copyArray(arr) {
 }
 
 beforeEach(function () {
-this.addMatchers({
+jasmine.addMatchers({
 toContainXmlPath: function (xpath) {
 var xml = this.actual;
--- End diff --

Move this onto line 62 (inside compare function)

```
var xml = actual;
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-statusbar pull request #:

2016-12-21 Thread regnete

Github user regnete commented on the pull request:


https://github.com/apache/cordova-plugin-statusbar/commit/a120ba1a1ffb27d46f2ac7962648e6f8a7a5b24c#commitcomment-20262953
  
My fault. Sorry. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer issue #150: CB-11534 This plugin should support...

2016-12-21 Thread naveedahmed1

Github user naveedahmed1 commented on the issue:

https://github.com/apache/cordova-plugin-file-transfer/pull/150
  
Can this be merged? So that it can be used on Android 6 or higher.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-statusbar pull request #:

2016-12-21 Thread jcesarmobile

Github user jcesarmobile commented on the pull request:


https://github.com/apache/cordova-plugin-statusbar/commit/a120ba1a1ffb27d46f2ac7962648e6f8a7a5b24c#commitcomment-20262925
  
Well, that issue was created before this was merged, so this couldn't cause 
that issue.
But will use that as the problem seems the same


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-statusbar pull request #:

2016-12-21 Thread regnete

Github user regnete commented on the pull request:


https://github.com/apache/cordova-plugin-statusbar/commit/a120ba1a1ffb27d46f2ac7962648e6f8a7a5b24c#commitcomment-20262881
  
@jcesarmobile: Thnak you for the quick reply. I added a comment to 
https://issues.apache.org/jira/browse/CB-12196. Anything else to do?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-statusbar pull request #:

2016-12-21 Thread jcesarmobile

Github user jcesarmobile commented on the pull request:


https://github.com/apache/cordova-plugin-statusbar/commit/a120ba1a1ffb27d46f2ac7962648e6f8a7a5b24c#commitcomment-20262818
  
@regnete can you create a new issue on http://issues.cordova.io?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-statusbar pull request #:

2016-12-21 Thread regnete

Github user regnete commented on the pull request:


https://github.com/apache/cordova-plugin-statusbar/commit/a120ba1a1ffb27d46f2ac7962648e6f8a7a5b24c#commitcomment-20262561
  
This change is not compatible with cordova-plugin-statusbar: 
Invoking StatusBar.hide() after 'deviceready' event has been fired, 
produces a white bar on top of the screen. looks like a statusbar with 
background-color = foreground-color = white,
Rolling back to version 2.2.0 of the statusbar-plugin solves the issue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request #219: CB-12189: Add support for WinMD and DLL c...

2016-12-21 Thread daserge

Github user daserge commented on a diff in the pull request:

https://github.com/apache/cordova-windows/pull/219#discussion_r93464493
  
--- Diff: spec/unit/pluginHandler/windows.spec.js ---
@@ -304,6 +309,47 @@ describe('windows project handler', function () {
 xpath = 'Reference[@Include="dummy6"]/HintPath';
 validateInstalledProjects('framework', frameworks[5], 
xpath, ['windows', 'windows10', 'phone']);
 });
+
+it('with .winmd and .dll files', function() {
--- End diff --

Does this spec check that dll files have been actually copied? ([according 
to 
this](https://github.com/apache/cordova-windows/pull/219/files#diff-7bcd02ec7f03ffbb25512bd1f4a0d388R99))


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request #219: CB-12189: Add support for WinMD and DLL c...

2016-12-21 Thread daserge

Github user daserge commented on a diff in the pull request:

https://github.com/apache/cordova-windows/pull/219#discussion_r93460566
  
--- Diff: template/cordova/lib/PluginInfo.js ---
@@ -115,6 +115,33 @@ function PluginInfo(dirname) {
 var configFiles = parentGetConfigFiles(platform);
 return processChanges(configFiles);
 };
+
+this.getFrameworks = function(platform) {
--- End diff --

nit: [outdated 
comment](https://github.com/apache/cordova-windows/pull/219/files#diff-93a26ea6e269125a5b151c4176a3b42bL100)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows issue #219: CB-12189: Add support for WinMD and DLL combinat...

2016-12-21 Thread vladimir-kotikov

Github user vladimir-kotikov commented on the issue:

https://github.com/apache/cordova-windows/pull/219
  
@daserge could you take a look please?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-screen-orientation issue #9: CB-12286 Tests reworked

2016-12-21 Thread filmaj

Github user filmaj commented on the issue:

https://github.com/apache/cordova-plugin-screen-orientation/pull/9
  
Probably a good idea :D


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows issue #219: Add support for WinMD and DLL combination

2016-12-21 Thread vladimir-kotikov

Github user vladimir-kotikov commented on the issue:

https://github.com/apache/cordova-windows/pull/219
  
Documentation update: https://github.com/apache/cordova-docs/pull/671
Change to support `implementation` attribute in `cordova-common`: 
https://github.com/apache/cordova-lib/pull/513

Note - this PR has own override for `PluginInfo.getFrameworks` method to 
not depend on not-yet-released apache/cordova-lib#513 - this logic can be 
safely removed once updated `cordova-common` released


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows issue #219: Add support for WinMD and DLL combination

2016-12-21 Thread codecov-io

Github user codecov-io commented on the issue:

https://github.com/apache/cordova-windows/pull/219
  
## [Current 
coverage](https://codecov.io/gh/apache/cordova-windows/pull/219?src=pr) is 
77.00% (diff: 100%)
> Merging 
[#219](https://codecov.io/gh/apache/cordova-windows/pull/219?src=pr) into 
[master](https://codecov.io/gh/apache/cordova-windows/branch/master?src=pr) 
will increase coverage by **0.77%**

```diff
@@ master   #219   diff @@
==
  Files16 16  
  Lines  2204   +18   
  Methods 412415 +3   
  Messages  0  0  
  Branches433438 +5   
==
+ Hits   1680   1711+31   
+ Misses  524511-13   
  Partials  0  0  
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update 
[1cf27a9...99a7016](https://codecov.io/gh/apache/cordova-windows/compare/1cf27a9db5fa103228b803539ce5ede52e524aee...99a70164a3698b3d36a1ee958f5753df45b8983d?src=pr)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request #219: Add support for WinMD and DLL combination

2016-12-21 Thread matrosov-nikita

GitHub user matrosov-nikita opened a pull request:

https://github.com/apache/cordova-windows/pull/219

Add support for WinMD and DLL combination



### Platforms affected
self

### What does this PR do?
This PR adds support for .winmd and .dll combination.

### What testing has been done on this change?
Auto-test

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/matrosov-nikita/cordova-windows 
support-winmd-and-dll

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-windows/pull/219.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #219


commit 99a70164a3698b3d36a1ee958f5753df45b8983d
Author: Nikita Matrosov 
Date:   2016-12-21T12:26:40Z

Add support for WinMD and DLL combination




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib issue #513: CB-12189 windows: Add `implementation` attribute to ...

2016-12-21 Thread vladimir-kotikov

Github user vladimir-kotikov commented on the issue:

https://github.com/apache/cordova-lib/pull/513
  
Travis build failures look irrelevant to this PR


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request #671: CB-12189 windows: Document `implementation` ...

2016-12-21 Thread vladimir-kotikov

GitHub user vladimir-kotikov opened a pull request:

https://github.com/apache/cordova-docs/pull/671

CB-12189 windows: Document `implementation` attribute



### Platforms affected


### What does this PR do?


### What testing has been done on this change?


### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/vladimir-kotikov/cordova-docs CB-12189

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/671.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #671


commit d2c53d80bf240b1f416dd13483f44d86b82650db
Author: Vladimir Kotikov 
Date:   2016-12-21T11:09:29Z

CB-12189 Document `implementation` attribute




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-screen-orientation issue #9: CB-12286 Tests reworked

2016-12-21 Thread cordova-qa

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-screen-orientation/pull/9
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-screen-orientation/pull/9/commits/cd2ee4666d66190424df4efc9291c31be6d4781b)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/6/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/6//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/6//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/6//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/6//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/6//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/6//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/6//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/6//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/6//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/6//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/6//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/6//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/6//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/6//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/6//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/6//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/6//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/6//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/6//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/6//PLATFORM=android/artifact/)
 |
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-screen-orientation pull request #9: CB-12286 Tests reworked

2016-12-21 Thread alsorokin

GitHub user alsorokin opened a pull request:

https://github.com/apache/cordova-plugin-screen-orientation/pull/9

CB-12286 Tests reworked



### Platforms affected
All

### What does this PR do?
https://issues.apache.org/jira/browse/CB-12286
Tests now actually verify the plugin's methods and properties instead of 
the native built-in ones.

### What testing has been done on this change?
Paramedic run on Android and Windows.

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/alsorokin/cordova-plugin-screen-orientation 
CB-12286

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-screen-orientation/pull/9.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #9


commit cd2ee4666d66190424df4efc9291c31be6d4781b
Author: Alexander Sorokin 
Date:   2016-12-21T11:46:01Z

CB-12286 Tests reworked




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #513: CB-12189 windows: Add `implementation` attrib...

2016-12-21 Thread vladimir-kotikov

GitHub user vladimir-kotikov opened a pull request:

https://github.com/apache/cordova-lib/pull/513

CB-12189 windows: Add `implementation` attribute to frameworks

The attribute is windows-specific and allows to specify implementation for 
WinMD components, written in C++



### Platforms affected


### What does this PR do?


### What testing has been done on this change?


### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/vladimir-kotikov/cordova-lib CB-12189

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/513.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #513


commit 5be6a8166fd9785dec095c99836cba725fb4947e
Author: Vladimir Kotikov 
Date:   2016-12-21T12:00:57Z

CB-12189 Add implementation attribute to framework

The attribute is windows-specific and allows to specify implementation for 
WinMD components, written in C++




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-screen-orientation pull request #8: CB-12285 Polyfill promise...

2016-12-21 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-screen-orientation/pull/8


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-screen-orientation issue #8: CB-12285 Polyfill promises on pl...

2016-12-21 Thread cordova-qa

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-screen-orientation/pull/8
  
Cordova CI Build has one or more failures. 

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-screen-orientation/pull/8/commits/7fdc334a2f743d061937404ca31143a022e2db3d)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/5/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/5//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/5//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/5//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/5//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/5//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/5//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/5//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/5//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/5//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/5//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/5//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/5//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/5//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/5//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/5//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/5//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/5//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/5//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/5//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/5//PLATFORM=android/artifact/)
 |
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-screen-orientation issue #8: CB-12285 Polyfill promises on pl...

2016-12-21 Thread cordova-qa

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-screen-orientation/pull/8
  
Cordova CI Build has one or more failures. 

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-screen-orientation/pull/8/commits/4ab51641c26af31a08ebe578b33ad02a2e07093d)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/3/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/3//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/3//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/3//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/3//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/3//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/3//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/3//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/3//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/3//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/3//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/3//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/3//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/3//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/3//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/3//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/3//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/3//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/3//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/3//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/3//PLATFORM=android/artifact/)
 |
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-screen-orientation pull request #8: CB-12285 Polyfill promise...

2016-12-21 Thread alsorokin

GitHub user alsorokin opened a pull request:

https://github.com/apache/cordova-plugin-screen-orientation/pull/8

CB-12285 Polyfill promises on platforms that doesn't support them natâ¦

â¦ively



### Platforms affected
All platforms with webview that doesn't support promises natively. For 
example, Android API level 19.

### What does this PR do?
Includes a polyfill library so the promises (and therefore, `.lockScreen` 
function) would work everywhere.

### What testing has been done on this change?
Paramedic tests on Android API 19.

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/alsorokin/cordova-plugin-screen-orientation 
CB-12285

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-screen-orientation/pull/8.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #8


commit 4ab51641c26af31a08ebe578b33ad02a2e07093d
Author: Alexander Sorokin 
Date:   2016-12-21T09:10:19Z

CB-12285 Polyfill promises on platforms that doesn't support them natively




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-screen-orientation issue #7: test Jenkins PR job

2016-12-21 Thread cordova-qa

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-screen-orientation/pull/7
  
Cordova CI Build has one or more failures. 

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-screen-orientation/pull/7/commits/ba26294f664e637dd5f730ff3a4b2cd16e111ec4)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/2/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/2//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/2//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/2//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/2//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/2//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/2//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/2//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/2//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/2//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/2//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/2//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/2//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/2//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/2//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/2//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/2//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/2//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/2//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/2//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/2//PLATFORM=android/artifact/)
 |
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-screen-orientation pull request #7: test Jenkins PR job

2016-12-21 Thread alsorokin

Github user alsorokin closed the pull request at:

https://github.com/apache/cordova-plugin-screen-orientation/pull/7


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-screen-orientation pull request #7: test Jenkins PR job

2016-12-21 Thread alsorokin

GitHub user alsorokin opened a pull request:

https://github.com/apache/cordova-plugin-screen-orientation/pull/7

test Jenkins PR job

do not merge

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/alsorokin/cordova-plugin-screen-orientation 
do-not-merge

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-screen-orientation/pull/7.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #7


commit ba26294f664e637dd5f730ff3a4b2cd16e111ec4
Author: Alexander Sorokin 
Date:   2016-12-21T08:02:22Z

test Jenkins PR job




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

43 matches

Mail list logo