date:20170718

[GitHub] cordova-plugin-splashscreen issue #109: CB-11602: (android) Fix bug AutoHide...

2017-07-18 Thread filmaj

Github user filmaj commented on the issue:

https://github.com/apache/cordova-plugin-splashscreen/pull/109
  
See the relevant [dev mailing list discussion about integrating 
splashscreen into the 
platforms](https://lists.apache.org/thread.html/d94c0fe4bcec06ac45f1cc37978b713464faecbf7b938560cd6368e5@%3Cdev.cordova.apache.org%3E).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen pull request #109: CB-11602: (android) Fix bug A...

2017-07-18 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-splashscreen/pull/109


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser issue #82: CB-8534: Add support for auth dialogs...

2017-07-18 Thread hmusunuru

Github user hmusunuru commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/82
  
@sgrebnov will this work for both ios and android


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer issue #150: CB-11534 This plugin should support...

2017-07-18 Thread filmaj

Github user filmaj commented on the issue:

https://github.com/apache/cordova-plugin-file-transfer/pull/150

Alright, I took a look at this again after an extended break and I have
more comments, and want to bring more information to the community about the
future of this plugin as well.

First, and I think most important, we need to be clear about the future of
this plugin. A couple of months back, Cordova developers did an [audit of the
core cordova plugins](https://issues.apache.org/jira/browse/CB-12708), and one
result was the decision to [sunset the File Transfer
plugin](https://issues.apache.org/jira/browse/CB-12711) in [favour of the
increasingly-available XHR2 APIs](http://caniuse.com/#feat=xhr2). The XHR2 (now
simply merged into the core XHR spec) features that are relevant to File
Transfer plugin users are the ability to upload and to receive progress events
- giving us exact feature parity for what File Transfer provides to users
today. The benefit to sunsetting this plugin is that there would be less stuff
to maintain for Cordova as XHR2 is already widely available on most mobile
platform. With that in mind, that makes me reluctant to make many changes to
this plugin as it's essentially makework.

Second, looking at the specific code changes in here, I started wondering,
why execute the permission requesting inside this plugin? This plugin already
depends on the core cordova File plugin, which does have support for
Marshmallow permission model - why duplicate that? Turns out it is because the
read/write methods of File Transfer, on the native Android side, are completely
recreated/reproduced! I think a "proper" change to FT to support this would be
to leverage [cordova-plugin-file's `FileUtils` class and call its `execute`
method, passing in the right arguments to trigger the `write`
action](https://github.com/apache/cordova-plugin-file/blob/master/src/android/FileUtils.java#L351-L369).
Similarly, for reading files, the same could be done, using one of the
[plethora of `readAs*` methods available in cordova-plugin-file's
`FileUtils.java`
class](https://github.com/apache/cordova-plugin-file/blob/master/src/android/FileUtils.java#L310-L349).
The benefits I see to using this
approach:
1. no need to rewrite permission handling code - cordova-plugin-file's
native Android code already does that.
2. we could completely remove all file-reading and file-writing native
Android code inside cordova-plugin-file-transfer, as we'd defer all of that
work to the File plugin.

All that being said, once Cordova sunsets this plugin, the plugin code will
be open and available to the community. The community could manage this code as
it is however it seems right to them. While the patch here is not "perfect", it
works, and that is more valuable to a lot of people.

So, I think I won't take any action on this PR. I am sorry that my previous
review and comments in here made it seem like this PR would make its way into
the mainline. Things have changed, and this plugin's window of life is closing.

---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android issue #389: CB-11244: Studio Project Compatibility: Now with...

2017-07-18 Thread codecov-io

Github user codecov-io commented on the issue:

https://github.com/apache/cordova-android/pull/389
  
# 
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=h1) 
Report
> Merging 
[#389](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/cordova-android/commit/893356abcd1b005a13bb09e7467f227b52de3ae5?src=pr=desc)
 will **decrease** coverage by `0.37%`.
> The diff coverage is `34.17%`.

[![Impacted file tree 
graph](https://codecov.io/gh/apache/cordova-android/pull/389/graphs/tree.svg?height=150=650=q14nMf6C5a=pr)](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree)

```diff
@@Coverage Diff @@
##   master #389  +/-   ##
==
- Coverage   42.55%   42.17%   -0.38% 
==
  Files  17   17  
  Lines1678 1707  +29 
  Branches  304  310   +6 
==
+ Hits  714  720   +6 
- Misses964  987  +23
```


| [Impacted 
Files](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree) | 
Coverage Î | |
|---|---|---|
| 
[...n/templates/cordova/lib/builders/GenericBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9HZW5lcmljQnVpbGRlci5qcw==)
 | `30.61% <Ã¸> (-0.38%)` | :arrow_down: |
| 
[bin/templates/cordova/lib/builders/builders.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9idWlsZGVycy5qcw==)
 | `37.5% <Ã¸> (Ã¸)` | :arrow_up: |
| 
[bin/templates/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZC5qcw==)
 | `13.04% <0%> (-0.39%)` | :arrow_down: |
| 
[bin/templates/cordova/lib/device.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9kZXZpY2UuanM=)
 | `22.44% <0%> (Ã¸)` | :arrow_up: |
| 
[bin/templates/cordova/lib/AndroidStudio.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9BbmRyb2lkU3R1ZGlvLmpz)
 | `94.73% <100%> (Ã¸)` | :arrow_up: |
| 
[...in/templates/cordova/lib/builders/GradleBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9HcmFkbGVCdWlsZGVyLmpz)
 | `20% <15.78%> (-0.43%)` | :arrow_down: |
| 
[bin/templates/cordova/Api.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL0FwaS5qcw==)
 | `43.36% <25%> (-1.09%)` | :arrow_down: |
| 
[bin/lib/create.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL2xpYi9jcmVhdGUuanM=)
 | `49.26% <45.45%> (-1.57%)` | :arrow_down: |

--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=continue).
> **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
> `Î = absolute  (impact)`, `Ã¸ = not affected`, `? = missing 
data`
> Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=footer).
 Last update 
[893356a...d0dab4b](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #578: CB-12361 : added unit-tests for getPlatformDe...

2017-07-18 Thread audreyso

GitHub user audreyso opened a pull request:

https://github.com/apache/cordova-lib/pull/578

CB-12361 : added unit-tests for getPlatformDetailsFromDir



### Platforms affected


### What does this PR do?

added unit-tests for getPlatformDetailsFromDir

### What testing has been done on this change?


### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [X] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/audreyso/cordova-lib CB-12361-10

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/578.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #578


commit e8a1cf2c062fd735ffb767dcd1c249de5c35684d
Author: Audrey So 
Date:   2017-07-18T17:35:28Z

CB-12361 : added unit-tests for getPlatformDetailsFromDir




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #577: CB-12361 : added tests for platform/list.js

2017-07-18 Thread audreyso

GitHub user audreyso opened a pull request:

https://github.com/apache/cordova-lib/pull/577

CB-12361 : added tests for platform/list.js



### Platforms affected


### What does this PR do?

 Added tests for platform/list.js

### What testing has been done on this change?


### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [X] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/audreyso/cordova-lib CB-12361-8

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/577.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #577


commit 558554aea0654a4132feb057a73e3faa5a5bac1a
Author: Audrey So 
Date:   2017-07-17T23:06:37Z

CB-12361 : added tests for list platform




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-browser pull request #37: CB-12895 : replaced jshint with eslint

2017-07-18 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-browser/pull/37


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-battery-status pull request #57: CB-13028 (CI) Added browser ...

2017-07-18 Thread alsorokin

GitHub user alsorokin opened a pull request:

https://github.com/apache/cordova-plugin-battery-status/pull/57

CB-13028 (CI) Added browser platform to AppVeyor

### Platforms affected
Browser

### What does this PR do?
Enables AppVeyor to run tests on browser platform

### What testing has been done on this change?
See AppVeyor results under this PR

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/alsorokin/cordova-plugin-battery-status 
CB-13028

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-battery-status/pull/57.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #57


commit fc23fc0a265e111fdfd578f615d4bf59f61b5568
Author: Alexander Sorokin 
Date:   2017-07-18T10:30:30Z

CB-13028 (CI) Added browser platform to AppVeyor




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Nightly build #431 for cordova has succeeded!

2017-07-18 Thread Apache Jenkins Server

Nightly build #431 for cordova has succeeded!
The latest nightly has been published and you can try it out with 'npm i -g 
cordova@nightly'

For details check build console at 
https://builds.apache.org/job/cordova-nightly/431/consoleFull

-
Jenkins for Apache Cordova

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org