Nightly build #445 for cordova has failed
Nightly build #445 for cordova has failed. Please check failure details on build details page at https://builds.apache.org/job/cordova-nightly/445/ You can also take a look at build console: https://builds.apache.org/job/cordova-nightly/445/consoleFull - Jenkins for Apache Cordova - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request #588: CB-13056 : Removed parsers & platformApi poly...
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/588 CB-13056 : Removed parsers & platformApi polyfill for webos, blackberry, & ubuntu ### Platforms affected ### What does this PR do? Removed parsers & platformApi polyfill for webos, blackberry, & ubuntu. ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-lib CB-13056 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/588.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #588 commit d855daa20165487b37bed6b07fcdd5878564337f Author: Audrey SoDate: 2017-08-01T22:59:07Z CB-13056 : removed parsers and platformApi polyfill for webos, blackberry10, and ubuntu --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request #587: CB-13056 : added deprecation notice for webos
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/587 CB-13056 : added deprecation notice for webos ### Platforms affected ### What does this PR do? Added deprecation notice for webos ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-lib CB-13056-2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/587.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #587 commit d673efd5b21fc452d1343771f731021ea6b5da28 Author: Audrey SoDate: 2017-08-01T23:05:24Z CB-13056 : added deprecation notice for webos --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib issue #586: CB-13057 : Remove cordova platform save command
Github user audreyso commented on the issue: https://github.com/apache/cordova-lib/pull/586 Can I delete: 1. commented out tests or parts of tests that contain platforms.json or platform_metadata? 2. Can I delete save.js and save.spec.js? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request #586: CB-13057 : Remove cordova platform save comma...
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/586 CB-13057 : Remove cordova platform save command ### Platforms affected ### What does this PR do? Remove cordova platform save command ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-lib CB-13057-2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/586.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #586 commit 3f66326f751de7c78f1e1b544bed38cf009d5e9d Author: Audrey SoDate: 2017-08-01T22:06:41Z CB-13057 : removed save function and updated unit-tests after these changes commit 799e14d032e5c59f9dca5ad5921155572b2e246e Author: Audrey So Date: 2017-08-01T22:07:52Z CB-13057 : removed platformsJson from integration tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request #585: CB-13057 : added deprecation warning for cord...
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/585 CB-13057 : added deprecation warning for cordova platform save ### Platforms affected ### What does this PR do? Added deprecation warning for cordova platform save ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-lib CB-13057 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/585.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #585 commit 5d9e3336071d00fc550cb1b042172466a0a86704 Author: Audrey SoDate: 2017-08-01T20:46:59Z CB-13057 : added deprecation warning for cordova platform save --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #234: CB-12975: (docs) Resort and reword c...
Github user janpio commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/234 Did I miss anything or were there further, later changes that required another rebase? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request #225: CB-12975: (docs) Resort and r...
Github user janpio closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/225 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request #234: CB-12975: (docs) Resort and r...
Github user janpio closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/234 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #225: CB-12975: (docs) Resort and reword c...
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/225 @janpio I have merged in your changes to master, see 7611645469aa4f9a4b0ebeb826317030cc2900a2. Can you close this pull request? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #234: CB-12975: (docs) Resort and reword c...
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/234 OK I had to rebase your patch one more time - it is merged in in 7611645469aa4f9a4b0ebeb826317030cc2900a2. @janpio can you close this pull request now? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-test-framework pull request #26: CB-12895 : replaced jshint w...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-test-framework/pull/26 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-test-framework issue #26: CB-12895 : replaced jshint with esl...
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-test-framework/pull/26 Yep! LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-test-framework issue #26: CB-12895 : replaced jshint with esl...
Github user audreyso commented on the issue: https://github.com/apache/cordova-plugin-test-framework/pull/26 Thanks for the review! Okay to merge @filmaj? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #225: CB-12975: (docs) Resort and reword c...
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/225 Sounds good, I'll check that out. Thanks for taking that on! > because now "This branch is 3 commits ahead of apache:master. " âï¸ that's what you want! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-test-framework pull request #26: CB-12895 : replaced jshint w...
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-plugin-test-framework/pull/26 CB-12895 : replaced jshint with eslint ### Platforms affected ### What does this PR do? Replaced jshint with eslint ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-plugin-test-framework CB-12895 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-test-framework/pull/26.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #26 commit 37acdf6074e05a27768e02ab892782f97fedee24 Author: Audrey SoDate: 2017-08-01T00:00:17Z CB-12895 : replaced jshint with eslint --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file pull request #213: Add mandatory iOS 10 privacy descript...
GitHub user shishlina opened a pull request: https://github.com/apache/cordova-plugin-file/pull/213 Add mandatory iOS 10 privacy description ### Platforms affected iOS ### What does this PR do? Ensures the plugin enables users to select photos from the photoalbum in iOS10. ### What testing has been done on this change? It was a bug in my app before, and after this change, I am now able to successfully select photos from the photoalbum ### Checklist - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/shishlina/cordova-plugin-file feature Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-file/pull/213.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #213 commit bf540480aa9afbcab96896fa7182654ea7c1c7e2 Author: Shishlina EkaterinaDate: 2017-08-01T15:03:51Z Add mandatory iOS 10 privacy description --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #225: CB-12975: (docs) Resort and reword c...
Github user janpio commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/225 Yeah no, I have no idea what actually happened and why and how I could undo it :/ So if you @filmaj are ok with it, let's just go with #234. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #225: CB-12975: (docs) Resort and reword c...
Github user janpio commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/225 As a first "recovery" I branched after my now rewritten commit into patch-1b and created a pull request from there at #234. This seems to have worked and almost looked as it should. If I find no way to repair this PR, we can just merge that one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request #234: [WIP] CB-12975: (docs) Resort...
GitHub user janpio opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/234 [WIP] CB-12975: (docs) Resort and reword cordova.InAppBrowser.open `options` lists This is a followup to #225 to test if I got it working. Do not merge yet please. ### Platforms affected n/a, only docs changes ### What does this PR do? Resort and reword cordova.InAppBrowser.open `options` lists for better developer experience. More reasoning at https://issues.apache.org/jira/browse/CB-12975 ### What testing has been done on this change? n/a ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - n/a Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/janpio/cordova-plugin-inappbrowser patch-1b Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-inappbrowser/pull/234.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #234 commit 9102757ce1b97ea14ae2c59ef78a44422fe4a1bf Author: Jan PiotrowskiDate: 2017-07-01T00:41:04Z CB-12975 (docs) Resort and reword cordova.InAppBrowser.open `options` lists for better developer experience --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #225: CB-12975: (docs) Resort and reword c...
Github user janpio commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/225 Thanks for the proper explanation! I almost understood it and went to work with Sourcetree... https://www.atlassian.com/blog/sourcetree/interactive-rebase-sourcetree explains that interactive rebase is also possible with Sourcetree. But of course I couldn't rebase at the beginning because I was working on my fork which is not really connected to the apache repo any more. So I did as you said and added the apache repo again (while having checked out `patch-1`. This created this nice merge commit automatically: https://github.com/janpio/cordova-plugin-inappbrowser/commit/3066febdc723c5d0d99ab458c92038fa2f064553 This seems to be what we wanted to "rebase" my commits, because now "This branch is 3 commits ahead of apache:master. " Via the "interactive rebase" feature of Sourcetree I could now "merge" my initial commit and the whitespace commit. But then I somehow messed up, because now the commits from the merge commit are in my branch as well, additionally to that dumb merge commit in the first place... Well, I have to investigate a bit more it seems ;) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file pull request #212: CB-13028 (CI) Browser builds on Travi...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/212 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org