date:20170811

Nightly build #451 for cordova has failed

2017-08-11 Thread Apache Jenkins Server

Nightly build #451 for cordova has failed.

Please check failure details on build details page at 
https://builds.apache.org/job/cordova-nightly/451/
You can also take a look at build console: 
https://builds.apache.org/job/cordova-nightly/451/consoleFull

-
Jenkins for Apache Cordova

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] cordova-ios 4.1.1 Release

2017-08-11 Thread Shazron

 I do! yes 4.4.1

On Aug 11, 2017 at 5:40 PM, julio cesar sanchez 
wrote:


You probably mean 4.4.1

El 11 ago. 2017 3:37 p. m., "Steven Gill"  escribió:

Yay!

On Aug 11, 2017 12:19 PM, "Shazron"  wrote:

Long overdue.

The board is here:
https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=173

Any issues in the left column that absolutely need to go in? If not I

will

punt them to the next release.

[GitHub] wf9a5m75 commented on issue #302: CB-11895: openURL: is deprecated on iOS 10

2017-08-11 Thread git

wf9a5m75 commented on issue #302: CB-11895: openURL: is deprecated on iOS 10
URL: https://github.com/apache/cordova-ios/pull/302#issuecomment-321947370
 
 
   Could you tell me what the alternative method is?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] cordova-ios 4.1.1 Release

2017-08-11 Thread julio cesar sanchez

You probably mean 4.4.1

El 11 ago. 2017 3:37 p. m., "Steven Gill"  escribió:

> Yay!
>
> On Aug 11, 2017 12:19 PM, "Shazron"  wrote:
>
> > Long overdue.
> >
> > The board is here:
> > https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=173
> >
> > Any issues in the left column that absolutely need to go in? If not I
> will
> > punt them to the next release.
> >
>

[GitHub] cordova-lib pull request #574: CB-12838 : prevented sorting and alphabetizin...

2017-08-11 Thread audreyso

Github user audreyso commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/574#discussion_r132795105
  
--- Diff: src/cordova/restore-util.js ---
@@ -341,19 +340,29 @@ function installPluginsFromConfigXML (args) {
 fs.writeFileSync(pkgJsonPath, JSON.stringify(pkgJson, null, 
2), 'utf8');
 }
 }
-// Write config.xml (only if plugins exist in package.json).
+// Write to config.xml (only if it is different from package.json in 
content)
 comboPluginIdArray.forEach(function (plugID) {
+var configXMLPlugin = cfg.getPlugin(plugID);
 if (pluginIdConfig.indexOf(plugID) < 0) {
 pluginIdConfig.push(plugID);
-}
-cfg.removePlugin(plugID);
-if (mergedPluginSpecs[plugID]) {
+if (mergedPluginSpecs[plugID]) {
+cfg.removePlugin(plugID);
+cfg.addPlugin({name: plugID, spec: 
mergedPluginSpecs[plugID]}, comboObject[plugID]);
+modifiedConfigXML = true;
+} else {
+cfg.removePlugin(plugID);
+cfg.addPlugin({name: plugID}, comboObject[plugID]);
+modifiedConfigXML = true;
+}
+
+// Write only if the plugin variables or specs are different from 
pkgJson
+} else if (((pluginIdConfig.indexOf(plugID) > 0) && 
(mergedPluginSpecs[plugID]) &&
+((configXMLPlugin.variables !== comboObject[plugID]))) ||
+((mergedPluginSpecs[plugID] !== configXMLPlugin.spec) ||
--- End diff --

Yes, exactly! Also rebased and updated based on feedback. Let me know if 
there's anything else!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] kaplanmaxe opened a new pull request #239: CB-13175: fixing windows8.1 crash on startup

2017-08-11 Thread git

kaplanmaxe opened a new pull request #239: CB-13175: fixing windows8.1 crash on 
startup
URL: https://github.com/apache/cordova-windows/pull/239
 
 
   
   
   ### Platforms affected
   
   windows
   
   ### What does this PR do?
   
   Ticket: https://issues.apache.org/jira/browse/CB-13175

   This issue is a follow-up to 
[CB-12784](https://github.com/apache/cordova-windows/pull/232)
   
   The user added the fix in `cordova-js-src/splashscreen.js` however it needs 
to be added to `template/www/cordova.js` as well. This PR takes the already 
accepted fix and applies it to `cordova.js` as well.
   
   ### What testing has been done on this change?
   
   Ran on Windows 10 Creators Update (build 15063.250), Ran on Windows 8.1, Ran 
on Windows 10 mobile
   
   ### Checklist
   - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
   - [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
   - [ ] Added automated test coverage as appropriate for this change.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #581: CB-12361 : added plugin remove tests

2017-08-11 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/581


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #574: CB-12838 : prevented sorting and alphabetizin...

2017-08-11 Thread stevengill

Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/574#discussion_r132781446
  
--- Diff: src/cordova/restore-util.js ---
@@ -341,19 +340,29 @@ function installPluginsFromConfigXML (args) {
 fs.writeFileSync(pkgJsonPath, JSON.stringify(pkgJson, null, 
2), 'utf8');
 }
 }
-// Write config.xml (only if plugins exist in package.json).
+// Write to config.xml (only if it is different from package.json in 
content)
 comboPluginIdArray.forEach(function (plugID) {
+var configXMLPlugin = cfg.getPlugin(plugID);
 if (pluginIdConfig.indexOf(plugID) < 0) {
 pluginIdConfig.push(plugID);
-}
-cfg.removePlugin(plugID);
-if (mergedPluginSpecs[plugID]) {
+if (mergedPluginSpecs[plugID]) {
+cfg.removePlugin(plugID);
+cfg.addPlugin({name: plugID, spec: 
mergedPluginSpecs[plugID]}, comboObject[plugID]);
+modifiedConfigXML = true;
+} else {
+cfg.removePlugin(plugID);
+cfg.addPlugin({name: plugID}, comboObject[plugID]);
+modifiedConfigXML = true;
+}
+
+// Write only if the plugin variables or specs are different from 
pkgJson
+} else if (((pluginIdConfig.indexOf(plugID) > 0) && 
(mergedPluginSpecs[plugID]) &&
+((configXMLPlugin.variables !== comboObject[plugID]))) ||
+((mergedPluginSpecs[plugID] !== configXMLPlugin.spec) ||
--- End diff --

so to confirm, either `((pluginIdConfig.indexOf(plugID) > 0) && 
(mergedPluginSpecs[plugID]) &&(configXMLPlugin.variables !== 
comboObject[plugID]))` or `((mergedPluginSpecs[plugID] !== 
configXMLPlugin.spec) || (configXMLPlugin.variables !== comboObject[plugID]))` 
need to be true


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #574: CB-12838 : prevented sorting and alphabetizin...

2017-08-11 Thread stevengill

Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/574#discussion_r132780726
  
--- Diff: src/cordova/restore-util.js ---
@@ -341,19 +340,29 @@ function installPluginsFromConfigXML (args) {
 fs.writeFileSync(pkgJsonPath, JSON.stringify(pkgJson, null, 
2), 'utf8');
 }
 }
-// Write config.xml (only if plugins exist in package.json).
+// Write to config.xml (only if it is different from package.json in 
content)
 comboPluginIdArray.forEach(function (plugID) {
+var configXMLPlugin = cfg.getPlugin(plugID);
 if (pluginIdConfig.indexOf(plugID) < 0) {
 pluginIdConfig.push(plugID);
-}
-cfg.removePlugin(plugID);
-if (mergedPluginSpecs[plugID]) {
+if (mergedPluginSpecs[plugID]) {
+cfg.removePlugin(plugID);
+cfg.addPlugin({name: plugID, spec: 
mergedPluginSpecs[plugID]}, comboObject[plugID]);
+modifiedConfigXML = true;
+} else {
+cfg.removePlugin(plugID);
+cfg.addPlugin({name: plugID}, comboObject[plugID]);
+modifiedConfigXML = true;
+}
+
+// Write only if the plugin variables or specs are different from 
pkgJson
+} else if (((pluginIdConfig.indexOf(plugID) > 0) && 
(mergedPluginSpecs[plugID]) &&
+((configXMLPlugin.variables !== comboObject[plugID]))) ||
--- End diff --

I think you have an extra bracket around this one


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #574: CB-12838 : prevented sorting and alphabetizin...

2017-08-11 Thread stevengill

Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/574#discussion_r132780476
  
--- Diff: src/cordova/restore-util.js ---
@@ -341,19 +340,29 @@ function installPluginsFromConfigXML (args) {
 fs.writeFileSync(pkgJsonPath, JSON.stringify(pkgJson, null, 
2), 'utf8');
 }
 }
-// Write config.xml (only if plugins exist in package.json).
+// Write to config.xml (only if it is different from package.json in 
content)
 comboPluginIdArray.forEach(function (plugID) {
+var configXMLPlugin = cfg.getPlugin(plugID);
 if (pluginIdConfig.indexOf(plugID) < 0) {
 pluginIdConfig.push(plugID);
-}
-cfg.removePlugin(plugID);
-if (mergedPluginSpecs[plugID]) {
+if (mergedPluginSpecs[plugID]) {
+cfg.removePlugin(plugID);
+cfg.addPlugin({name: plugID, spec: 
mergedPluginSpecs[plugID]}, comboObject[plugID]);
+modifiedConfigXML = true;
+} else {
+cfg.removePlugin(plugID);
+cfg.addPlugin({name: plugID}, comboObject[plugID]);
+modifiedConfigXML = true;
+}
+
+// Write only if the plugin variables or specs are different from 
pkgJson
+} else if (((pluginIdConfig.indexOf(plugID) > 0) && 
(mergedPluginSpecs[plugID]) &&
--- End diff --

so this if statement, `(pluginIdConfig.indexOf(plugID) > 0)`, what if 
`plugID` is in the 0th index? I think you want `>=`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #583: CB-12361 : added tests for plugin/index.js

2017-08-11 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/583


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] shazron commented on a change in pull request #326: CB-12940: [IOS] Use deployment-target from config.xml for platform ve?

2017-08-11 Thread git

shazron commented on a change in pull request #326: CB-12940: [IOS] Use 
deployment-target from config.xml for platform ve?
URL: https://github.com/apache/cordova-ios/pull/326#discussion_r132772679
 
 

 ##
 File path: bin/templates/scripts/cordova/lib/Podfile.js
 ##
 @@ -98,8 +98,8 @@ Podfile.prototype.getTemplate = function () {
 var projectName = this.escapeSingleQuotes(this.projectName);
 return util.format(
 '# DO NOT MODIFY -- auto-generated by Apache Cordova\n' +
-'platform :ios, \'8.0\'\n' +
-'target \'%s\' do\n' +
+'platform :ios, \'%s\'\n' +
+'use_frameworks!\n' +
 
 Review comment:
   we can't use `use_frameworks!`. See: 
https://issues.apache.org/jira/browse/CB-11893
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] shazron commented on issue #321: CB-12937 - (iOS) added new method handleOpenURLWithApplicationSourceAndAnno?

2017-08-11 Thread git

shazron commented on issue #321: CB-12937 - (iOS) added new method 
handleOpenURLWithApplicationSourceAndAnno?
URL: https://github.com/apache/cordova-ios/pull/321#issuecomment-321905248
 
 
   Changing release to cordova-ios@4.4.1
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] shazron closed pull request #321: CB-12937 - (iOS) added new method handleOpenURLWithApplicationSourceAndAnno?

2017-08-11 Thread git

shazron closed pull request #321: CB-12937 - (iOS) added new method 
handleOpenURLWithApplicationSourceAndAnno?
URL: https://github.com/apache/cordova-ios/pull/321
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] shazron closed pull request #330: CB-13164: Integrated cordova-plugin-console

2017-08-11 Thread git

shazron closed pull request #330: CB-13164: Integrated cordova-plugin-console
URL: https://github.com/apache/cordova-ios/pull/330
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] cordova-ios 4.1.1 Release

2017-08-11 Thread Steven Gill

Yay!

On Aug 11, 2017 12:19 PM, "Shazron"  wrote:

> Long overdue.
>
> The board is here:
> https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=173
>
> Any issues in the left column that absolutely need to go in? If not I will
> punt them to the next release.
>

[DISCUSS] cordova-ios 4.1.1 Release

2017-08-11 Thread Shazron

Long overdue.

The board is here:
https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=173

Any issues in the left column that absolutely need to go in? If not I will
punt them to the next release.

[GitHub] cordova-lib pull request #581: CB-12361 : added plugin remove tests

2017-08-11 Thread stevengill

Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/581#discussion_r132758854
  
--- Diff: spec/cordova/plugin/remove.spec.js ---
@@ -32,18 +66,123 @@ describe('cordova/plugin/remove', function () {
 expect(e.message).toContain('No plugin specified');
 }).done(done);
 });
-it('should require that a provided plugin be installed in the 
current project');
+
+it('should require that a provided plugin be installed in the 
current project', function (done) {
+var opts = { plugins: [ undefined ] };
+remove(projectRoot, 'plugin', hook_mock, opts).then(function 
() {
+fail('success handler unexpectedly invoked');
+}).fail(function (e) {
+expect(e.message).toContain('is not present in the 
project');
+}).done(done);
+});
 });
 describe('happy path', function () {
-it('should fire the before_plugin_rm hook');
-it('should call plugman.uninstall.uninstallPlatform for each 
platform installed in the project and for each provided plugin');
-it('should trigger a prepare if 
plugman.uninstall.uninstallPlatform returned something falsy');
-it('should call plugman.uninstall.uninstallPlugin once plugin has 
been uninstalled for each platform');
+it('should fire the before_plugin_rm hook', function (done) {
+var opts = { important: 'options', plugins: [] };
+remove(projectRoot, 'cordova-plugin-splashscreen', hook_mock, 
opts).then(function () {
+
expect(hook_mock.fire).toHaveBeenCalledWith('before_plugin_rm', opts);
+}).fail(function (e) {
+fail('fail handler unexpectedly invoked');
+console.error(e);
+}).done(done);
+});
+
+it('should call plugman.uninstall.uninstallPlatform for each 
platform installed in the project and for each provided plugin', function 
(done) {
+
remove.validatePluginId.and.returnValue('cordova-plugin-splashscreen');
+var opts = {important: 'options', plugins: 
['cordova-plugin-splashscreen']};
+remove(projectRoot, 'cordova-plugin-splashscreen', hook_mock, 
opts).then(function () {
+
expect(plugman.uninstall.uninstallPlatform).toHaveBeenCalled();
+expect(events.emit).toHaveBeenCalledWith('verbose', 
jasmine.stringMatching('plugman.uninstall on plugin 
"cordova-plugin-splashscreen" for platform "ios"'));
+expect(events.emit).toHaveBeenCalledWith('verbose', 
jasmine.stringMatching('plugman.uninstall on plugin 
"cordova-plugin-splashscreen" for platform "android"'));
+}).fail(function (e) {
+fail('fail handler unexpectedly invoked');
+console.error(e);
+}).done(done);
+});
+
+it('should trigger a prepare if 
plugman.uninstall.uninstallPlatform returned something falsy', function (done) {
+
remove.validatePluginId.and.returnValue('cordova-plugin-splashscreen');
+plugman.uninstall.uninstallPlatform.and.returnValue(Q(false));
+var opts = {important: 'options', plugins: 
['cordova-plugin-splashscreen']};
+remove(projectRoot, 'cordova-plugin-splashscreen', hook_mock, 
opts).then(function () {
+
expect(plugman.uninstall.uninstallPlatform).toHaveBeenCalled();
+expect(events.emit).toHaveBeenCalledWith('verbose', 
'Calling prepare.');
--- End diff --

i'd suggest removing this expect event due to my other comment


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] iget-master commented on issue #393: Fix for Jira issue CB-12981

2017-08-11 Thread git

iget-master commented on issue #393: Fix for Jira issue CB-12981
URL: https://github.com/apache/cordova-android/pull/393#issuecomment-321877182
 
 
   Someone on this? It's impossible to run cordova over android emulator with 
Android 8 AVD due this issue
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #582: CB-12361 : added tests for plugin/search.js

2017-08-11 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/582


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #577: CB-12361 : added tests for platform/list.js

2017-08-11 Thread stevengill

Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/577#discussion_r132738598
  
--- Diff: spec/cordova/platform/list.spec.js ---
@@ -0,0 +1,75 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+http://www.apache.org/licenses/LICENSE-2.0
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+var events = require('cordova-common').events;
+var Q = require('q');
+var rewire = require('rewire');
+var platform_list = rewire('../../../src/cordova/platform/list');
--- End diff --

i don't think you use rewire anywhere in this file


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #577: CB-12361 : added tests for platform/list.js

2017-08-11 Thread stevengill

Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/577#discussion_r132742737
  
--- Diff: spec/cordova/platform/list.spec.js ---
@@ -0,0 +1,75 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+http://www.apache.org/licenses/LICENSE-2.0
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+var events = require('cordova-common').events;
+var Q = require('q');
+var rewire = require('rewire');
+var platform_list = rewire('../../../src/cordova/platform/list');
+var platform_metadata = require('../../../src/cordova/platform_metadata');
+var cordova_util = require('../../../src/cordova/util');
+var fail;
+
+describe('cordova/platform/list', function () {
+var hooks_mock;
+var projectRoot = '/some/path';
+
+beforeEach(function () {
+hooks_mock = jasmine.createSpyObj('hooksRunner mock', ['fire']);
+hooks_mock.fire.and.returnValue(Q());
+spyOn(cordova_util, 
'getInstalledPlatformsWithVersions').and.callThrough();
+spyOn(events, 'emit');
+spyOn(platform_metadata, 'save');
+spyOn(cordova_util, 'requireNoCache').and.returnValue({});
+});
+
+it('should fire the before_platform_ls hook', function () {
+platform_list(hooks_mock, projectRoot, {save: true});
+expect(hooks_mock.fire).toHaveBeenCalledWith('before_platform_ls', 
Object({ save: true }));
+});
+
+it('should file the after_platform_ls hook', function (done) {
--- End diff --

type. Should be fire


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [GitHub] shazron closed pull request #329: CB-13112 - should not create a new file reference on each "cordova prepare"

2017-08-11 Thread Steven Gill

GRR

I'm going to request the same for PRs

On Thu, Aug 10, 2017 at 3:01 PM, Filip Maj  wrote:

> Well, it's a PR-specific one (open/close PR actions send an email). We
> asked for commits to not be sent to dev, not for PR activity to not be
> sent to dev.
>
> On Thu, Aug 10, 2017 at 1:48 PM, Steven Gill 
> wrote:
> > This email shouldn't be coming to the mailing list right?
> >
> > On Thu, Aug 10, 2017 at 1:26 PM,  wrote:
> >
> >> shazron closed pull request #329: CB-13112 -  should not
> >> create a new file reference on each "cordova prepare"
> >> URL: https://github.com/apache/cordova-ios/pull/329
> >>
> >>
> >>
> >>
> >> 
> >> This is an automated message from the Apache Git Service.
> >> To respond to the message, please log on GitHub and use the
> >> URL above to go to the specific comment.
> >>
> >> For queries about this service, please contact Infrastructure at:
> >> us...@infra.apache.org
> >>
> >>
> >> With regards,
> >> Apache Git Services
> >>
> >> -
> >> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> >> For additional commands, e-mail: dev-h...@cordova.apache.org
> >>
> >>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>

[GitHub] cordova-lib pull request #582: CB-12361 : added tests for plugin/search.js

2017-08-11 Thread stevengill

Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/582#discussion_r132736159
  
--- Diff: spec/cordova/plugin/search.spec.js ---
@@ -44,7 +44,36 @@ describe('cordova/plugin/search', function () {
 console.error(e);
 }).done(done);
 });
-it('should open a link to cordova.apache.org/plugins if no plugins are 
provided as parameter');
-it('should open a link to cordova.apache.org/plugins, providing the 
plugins passed in as a query-string parameter');
-it('should fire the after_plugin_search hook');
+
+it('should open a link to cordova.apache.org/plugins if no plugins are 
provided as parameter', function (done) {
+var opts = {important: 'options', plugins: []};
+search(hook_mock, opts).then(function () {
+expect(opener_mock).toHaveBeenCalled();
+}).fail(function (e) {
+console.log(e);
+fail('fail handler unexpectedly invoked');
+console.error(e);
+}).done(done);
+});
+
+it('should open a link to cordova.apache.org/plugins, providing the 
plugins passed in as a query-string parameter', function (done) {
+var opts = {important: 'options', plugins: 
['cordova-plugin-camera', 'cordova-plugin-splashscreen']};
+search(hook_mock, opts).then(function () {
+expect(opener_mock).toHaveBeenCalled();
+}).fail(function (e) {
+console.log(e);
--- End diff --

same


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #582: CB-12361 : added tests for plugin/search.js

2017-08-11 Thread stevengill

Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/582#discussion_r132736117
  
--- Diff: spec/cordova/plugin/search.spec.js ---
@@ -44,7 +44,36 @@ describe('cordova/plugin/search', function () {
 console.error(e);
 }).done(done);
 });
-it('should open a link to cordova.apache.org/plugins if no plugins are 
provided as parameter');
-it('should open a link to cordova.apache.org/plugins, providing the 
plugins passed in as a query-string parameter');
-it('should fire the after_plugin_search hook');
+
+it('should open a link to cordova.apache.org/plugins if no plugins are 
provided as parameter', function (done) {
+var opts = {important: 'options', plugins: []};
+search(hook_mock, opts).then(function () {
+expect(opener_mock).toHaveBeenCalled();
+}).fail(function (e) {
+console.log(e);
--- End diff --

Don't think you need console.log(e) since you console.error two lines below


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] macdonst commented on issue #399: CB-12730: Compat - INTEGRATE

2017-08-11 Thread git

macdonst commented on issue #399: CB-12730: Compat - INTEGRATE
URL: https://github.com/apache/cordova-android/pull/399#issuecomment-321831462
 
 
   Got the ?  from @infil00p so I've merged this PR. Off to prevent 
cordova-plugin-compat from being installed on the next version of 
cordova-android.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] macdonst closed pull request #399: CB-12730: Compat - INTEGRATE

2017-08-11 Thread git

macdonst closed pull request #399: CB-12730: Compat - INTEGRATE
URL: https://github.com/apache/cordova-android/pull/399
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] codecov-io commented on issue #326: CB-12940: [IOS] Use deployment-target from config.xml for platform ve?

2017-08-11 Thread git

codecov-io commented on issue #326: CB-12940: [IOS] Use deployment-target from 
config.xml for platform ve?
URL: https://github.com/apache/cordova-ios/pull/326#issuecomment-321806420
 
 
   # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/326?src=pr=h1) 
Report
   > Merging 
[#326](https://codecov.io/gh/apache/cordova-ios/pull/326?src=pr=desc) into 
[master](https://codecov.io/gh/apache/cordova-ios/commit/d44cec6266f5890802268e996722a380a0e51927?src=pr=desc)
 will **increase** coverage by `0.46%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/cordova-ios/pull/326/graphs/tree.svg?src=pr=650=WomDD5jInz=150)](https://codecov.io/gh/apache/cordova-ios/pull/326?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master #326  +/-   ##
   ==
   + Coverage   63.97%   64.43%   +0.46% 
   ==
 Files  14   14  
 Lines1674 1676   +2 
 Branches  277  278   +1 
   ==
   + Hits 1071 1080   +9 
   + Misses603  596   -7
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/cordova-ios/pull/326?src=pr=tree) | 
Coverage ? | |
   |---|---|---|
   | 
[bin/templates/scripts/cordova/Api.js](https://codecov.io/gh/apache/cordova-ios/pull/326?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvQXBpLmpz)
 | `58.97% <100%> (+5.07%)` | :arrow_up: |
   | 
[bin/templates/scripts/cordova/lib/Podfile.js](https://codecov.io/gh/apache/cordova-ios/pull/326?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL1BvZGZpbGUuanM=)
 | `77.59% <100%> (+0.18%)` | :arrow_up: |
   | 
[bin/templates/scripts/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-ios/pull/326?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3ByZXBhcmUuanM=)
 | `84.63% <0%> (-0.04%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-ios/pull/326?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `? = absolute  (impact)`, `? = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-ios/pull/326?src=pr=footer). 
Last update 
[d44cec6...5593026](https://codecov.io/gh/apache/cordova-ios/pull/326?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] igormartsekha commented on issue #326: CB-12940: [IOS] Use deployment-target from config.xml for platform ve?

2017-08-11 Thread git

igormartsekha commented on issue #326: CB-12940: [IOS] Use deployment-target 
from config.xml for platform ve?
URL: https://github.com/apache/cordova-ios/pull/326#issuecomment-321805967
 
 
   I fixed problem with failed test on appveyor
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] janpio commented on issue #244: CB-10140 Use application id instead of package name when running

2017-08-11 Thread git

janpio commented on issue #244: CB-10140 Use application id instead of package 
name when running
URL: https://github.com/apache/cordova-android/pull/244#issuecomment-321799938
 
 
   Was this added via another PR in the meantime? Seems like a useful change.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-device-motion pull request #57: CB-13068: Updated README to p...

2017-08-11 Thread janpio

Github user janpio commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-device-motion/pull/57#discussion_r132629591
  
--- Diff: README.md ---
@@ -27,6 +27,18 @@ description: Access accelerometer data.
 
 # cordova-plugin-device-motion
 
+# Deprecation Notice
+
+With the [W3C Device Motion and Orientation 
API](https://www.w3.org/TR/2016/CR-orientation-event-20160818/) now
+being supported on iOS, Android and Windows devices, this plugin is not 
needed any more. Migrating from this
+plugin to the [W3C Device Motion and Orientation 
API](https://www.w3.org/TR/2016/CR-orientation-event-20160818/)
+is explained in this [PhoneGap blog 
post](https://blog.phonegap.com/migrating-from-the-cordova-device-motion-plugin-ddd8176632ed).
--- End diff --

Why a Phonegap blogpost on a Cordova plugin deprecation?

Shouldn't there at least be a Cordova "we deprecate those plugins" blog 
post linked here and then maybe additionally a Phonegap blogpost with "this is 
how you do it now" (although I would of course prefer those at Cordova as well, 
much less confusing for users re Cordova/Phonegap).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Nightly build #451 for cordova has failed

Re: [DISCUSS] cordova-ios 4.1.1 Release

[GitHub] wf9a5m75 commented on issue #302: CB-11895: openURL: is deprecated on iOS 10

Re: [DISCUSS] cordova-ios 4.1.1 Release

[GitHub] cordova-lib pull request #574: CB-12838 : prevented sorting and alphabetizin...

[GitHub] kaplanmaxe opened a new pull request #239: CB-13175: fixing windows8.1 crash on startup

[GitHub] cordova-lib pull request #581: CB-12361 : added plugin remove tests

[GitHub] cordova-lib pull request #574: CB-12838 : prevented sorting and alphabetizin...

[GitHub] cordova-lib pull request #574: CB-12838 : prevented sorting and alphabetizin...

[GitHub] cordova-lib pull request #574: CB-12838 : prevented sorting and alphabetizin...

[GitHub] cordova-lib pull request #583: CB-12361 : added tests for plugin/index.js

[GitHub] shazron commented on a change in pull request #326: CB-12940: [IOS] Use deployment-target from config.xml for platform ve?

[GitHub] shazron commented on issue #321: CB-12937 - (iOS) added new method handleOpenURLWithApplicationSourceAndAnno?

[GitHub] shazron closed pull request #321: CB-12937 - (iOS) added new method handleOpenURLWithApplicationSourceAndAnno?

[GitHub] shazron closed pull request #330: CB-13164: Integrated cordova-plugin-console

Re: [DISCUSS] cordova-ios 4.1.1 Release

[DISCUSS] cordova-ios 4.1.1 Release

[GitHub] cordova-lib pull request #581: CB-12361 : added plugin remove tests

[GitHub] iget-master commented on issue #393: Fix for Jira issue CB-12981

[GitHub] cordova-lib pull request #582: CB-12361 : added tests for plugin/search.js

[GitHub] cordova-lib pull request #577: CB-12361 : added tests for platform/list.js

[GitHub] cordova-lib pull request #577: CB-12361 : added tests for platform/list.js

Re: [GitHub] shazron closed pull request #329: CB-13112 - should not create a new file reference on each "cordova prepare"

[GitHub] cordova-lib pull request #582: CB-12361 : added tests for plugin/search.js

[GitHub] cordova-lib pull request #582: CB-12361 : added tests for plugin/search.js

[GitHub] macdonst commented on issue #399: CB-12730: Compat - INTEGRATE

[GitHub] macdonst closed pull request #399: CB-12730: Compat - INTEGRATE

[GitHub] codecov-io commented on issue #326: CB-12940: [IOS] Use deployment-target from config.xml for platform ve?

[GitHub] igormartsekha commented on issue #326: CB-12940: [IOS] Use deployment-target from config.xml for platform ve?

[GitHub] janpio commented on issue #244: CB-10140 Use application id instead of package name when running

[GitHub] cordova-plugin-device-motion pull request #57: CB-13068: Updated README to p...

31 matches

Site Navigation

Mail list logo

Footer information