Nightly build #465 for cordova has failed

[Apache Jenkins Server]

Nightly build #465 for cordova has failed.

Please check failure details on build details page at 
https://builds.apache.org/job/cordova-nightly/465/
You can also take a look at build console: 
https://builds.apache.org/job/cordova-nightly/465/consoleFull

-
Jenkins for Apache Cordova

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[VOTE] cordova-browser@5 & cordova-serve@2 (attempt 2)

[Steven Gill]

Please review and vote on this 5.0.0 cordova-browser Release & 2.0.0
cordova-serve Release
by replying to this email (and keep discussion on the DISCUSS thread)

Release issue: https://issues.apache.org/jira/browse/CB-13214

The archive has been published to
dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-13214

The package was published from its corresponding git tag:
cordova-browser: 5.0.0 (6e9cb1f7c6)
cordova-serve: 2.0.0 (4ad258947c)

Note that you can test it out via:

1) pull the latest cordova-browser down locally
2) update cordova-browser package.json `cordova-serve` dependency to:
   "cordova-serve": "https://github.com/apache/cordova-serve.git#2.0.0;
3) add your local cordova-browser
cordova platform add ../cordova-browser


Upon a successful vote I will upload the archive to dist/, publish it
to npm, and post the blog post.

Voting guidelines:
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md

Voting will go on for a minimum of 48 hours.

I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and
subdependencies have Apache-compatible licenses
* Ensured continuous build was green when repo was tagged

Re: [VOTE] cordova-browser@5 & cordova-serve@2

[Steven Gill]

I'm cancelling this vote thread. Ended up including one more PR in
cordova-browser [1] for this release. Sending out a new vote now

[1] https://github.com/apache/cordova-browser/pull/42

On Thu, Aug 24, 2017 at 11:09 PM, Steven Gill 
wrote:

> Please review and vote on this 5.0.0 cordova-browser Release & 2.0.0 
> cordova-serve Release
> by replying to this email (and keep discussion on the DISCUSS thread)
>
> Release issue: https://issues.apache.org/jira/browse/CB-13214
>
> The archive has been published to 
> dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-13214
>
> The package was published from its corresponding git tag:
> cordova-browser: 5.0.0 (7b47c78173)
> cordova-serve: 2.0.0 (4ad258947c)
>
> Note that you can test it out via:
>
> 1) pull the latest cordova-browser down locally
> 2) update cordova-browser package.json `cordova-serve` dependency to:
>"cordova-serve": "https://github.com/apache/cordova-serve.git#2.0.0;
> 3) add your local cordova-browser
> cordova platform add ../cordova-browser
>
>
> Upon a successful vote I will upload the archive to dist/, publish it to npm, 
> and post the blog post.
>
> Voting guidelines: 
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
>
> Voting will go on for a minimum of 48 hours.
>
> I vote +1:
> * Ran coho audit-license-headers over the relevant repos
> * Ran coho check-license to ensure all dependencies and subdependencies have 
> Apache-compatible licenses
> * Ensured continuous build was green when repo was tagged
>
>

[GitHub] cordova-lib pull request #569: CB-12361: added main function unit tests for ...

[stevengill]

Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/569#discussion_r135331136
  
--- Diff: spec/cordova/plugin/add.spec.js ---
@@ -21,16 +21,82 @@
 /* globals fail */
 
 var Q = require('q');
-var add = require('../../../src/cordova/plugin/add');
+var rewire = require('rewire');
+var add = rewire('../../../src/cordova/plugin/add');
+var plugman = require('../../../src/plugman/plugman');
+var cordova_util = require('../../../src/cordova/util');
+var path = require('path');
+var fs = require('fs');
+var config = require('../../../src/cordova/config');
+var events = require('cordova-common').events;
+var registry = require('../../../src/plugman/registry/registry');
+var plugin_util = require('../../../src/cordova/plugin/util');
 
-describe('cordova/plugin/add', function () {
+fdescribe('cordova/plugin/add', function () {
 var projectRoot = '/some/path';
 var hook_mock;
+var Cfg_parser_mock = function () {};
+var cfg_parser_revert_mock;
+var plugin_info_provider_mock = function () {};
+var plugin_info_provider_revert_mock;
+var plugin_info;
+var package_json_mock;
+
 beforeEach(function () {
 hook_mock = jasmine.createSpyObj('hooks runner mock', ['fire']);
 hook_mock.fire.and.returnValue(Q());
+Cfg_parser_mock.prototype = jasmine.createSpyObj('config parser 
prototype mock', ['getPlugin', 'removePlugin', 'addPlugin', 'write']);
+/* eslint-disable */
+Cfg_parser_mock.prototype.getPlugin;
+Cfg_parser_mock.prototype.getPlugin;
--- End diff --

good catch!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #569: CB-12361: added main function unit tests for ...

[audreyso]

Github user audreyso commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/569#discussion_r135308470
  
--- Diff: spec/cordova/plugin/add.spec.js ---
@@ -21,16 +21,82 @@
 /* globals fail */
 
 var Q = require('q');
-var add = require('../../../src/cordova/plugin/add');
+var rewire = require('rewire');
+var add = rewire('../../../src/cordova/plugin/add');
+var plugman = require('../../../src/plugman/plugman');
+var cordova_util = require('../../../src/cordova/util');
+var path = require('path');
+var fs = require('fs');
+var config = require('../../../src/cordova/config');
+var events = require('cordova-common').events;
+var registry = require('../../../src/plugman/registry/registry');
+var plugin_util = require('../../../src/cordova/plugin/util');
 
-describe('cordova/plugin/add', function () {
+fdescribe('cordova/plugin/add', function () {
 var projectRoot = '/some/path';
 var hook_mock;
+var Cfg_parser_mock = function () {};
+var cfg_parser_revert_mock;
+var plugin_info_provider_mock = function () {};
+var plugin_info_provider_revert_mock;
+var plugin_info;
+var package_json_mock;
+
 beforeEach(function () {
 hook_mock = jasmine.createSpyObj('hooks runner mock', ['fire']);
 hook_mock.fire.and.returnValue(Q());
+Cfg_parser_mock.prototype = jasmine.createSpyObj('config parser 
prototype mock', ['getPlugin', 'removePlugin', 'addPlugin', 'write']);
+/* eslint-disable */
+Cfg_parser_mock.prototype.getPlugin;
+Cfg_parser_mock.prototype.getPlugin;
--- End diff --

Hi! I think you have "getPlugin" twice?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[VOTE] cordova-browser@5 & cordova-serve@2

[Steven Gill]

Please review and vote on this 5.0.0 cordova-browser Release & 2.0.0
cordova-serve Release
by replying to this email (and keep discussion on the DISCUSS thread)

Release issue: https://issues.apache.org/jira/browse/CB-13214

The archive has been published to
dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-13214

The package was published from its corresponding git tag:
cordova-browser: 5.0.0 (7b47c78173)
cordova-serve: 2.0.0 (4ad258947c)

Note that you can test it out via:

1) pull the latest cordova-browser down locally
2) update cordova-browser package.json `cordova-serve` dependency to:
   "cordova-serve": "https://github.com/apache/cordova-serve.git#2.0.0;
3) add your local cordova-browser
cordova platform add ../cordova-browser


Upon a successful vote I will upload the archive to dist/, publish it
to npm, and post the blog post.

Voting guidelines:
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md

Voting will go on for a minimum of 48 hours.

I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and
subdependencies have Apache-compatible licenses
* Ensured continuous build was green when repo was tagged