[GitHub] cordova-plugin-inappbrowser issue #238: added cookies support for Android an...

2017-08-28 Thread denisx304
Github user denisx304 commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/238
  
@janpio You can send any cookie as long as the server interprets it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Nightly build #468 for cordova has failed

2017-08-28 Thread Apache Jenkins Server
Nightly build #468 for cordova has failed.

Please check failure details on build details page at 
https://builds.apache.org/job/cordova-nightly/468/
You can also take a look at build console: 
https://builds.apache.org/job/cordova-nightly/468/consoleFull

-
Jenkins for Apache Cordova

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #590: CB-13145: Create playservices version prefere...

2017-08-28 Thread stevengill
Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/590#discussion_r135664127
  
--- Diff: src/cordova/plugin/util.js ---
@@ -35,3 +40,39 @@ function saveToConfigXmlOn (config_json, options) {
 var autosave = config_json.auto_save_plugins || false;
 return autosave || options.save;
 }
+
+/*
+ * Merges cli and config.xml variables.
+ *
+ * @param   {object}pluginInfo
+ * @param   {object}config.xml
+ * @param   {object}options
+ *
+ * @return  {object}object containing the new merged variables
+ */
+
+function mergeVariables (pluginInfo, cfg, opts) {
+// Validate top-level required variables
+var pluginVariables = pluginInfo.getPreferences();
+opts.cli_variables = opts.cli_variables || {};
+var pluginEntry = cfg.getPlugin(pluginInfo.id);
+// Get variables from config.xml
+var configVariables = pluginEntry ? pluginEntry.variables : {};
+// Add config variable if it's missing in cli_variables
+Object.keys(configVariables).forEach(function (variable) {
+opts.cli_variables[variable] = opts.cli_variables[variable] || 
configVariables[variable];
+});
+var missingVariables = Object.keys(pluginVariables)
+.filter(function (variableName) {
+// discard variables with default value
+return !(pluginVariables[variableName] || 
opts.cli_variables[variableName]);
+});
+
+if (missingVariables.length) {
+events.emit('verbose', 'Removing ' + pluginInfo.dir + ' because 
mandatory plugin variables were missing.');
+shell.rm('-rf', pluginInfo.dir);
+var msg = 'Variable(s) missing (use: --variable ' + 
missingVariables.join('=value --variable ') + '=value).';
+return Q.reject(new CordovaError(msg));
--- End diff --

get rid of Q dep


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-lib pull request #590: CB-13145: Create playservices version prefere...

2017-08-28 Thread stevengill
Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/590#discussion_r135664112
  
--- Diff: src/cordova/plugin/util.js ---
@@ -35,3 +40,39 @@ function saveToConfigXmlOn (config_json, options) {
 var autosave = config_json.auto_save_plugins || false;
 return autosave || options.save;
 }
+
+/*
+ * Merges cli and config.xml variables.
+ *
+ * @param   {object}pluginInfo
+ * @param   {object}config.xml
+ * @param   {object}options
+ *
+ * @return  {object}object containing the new merged variables
+ */
+
+function mergeVariables (pluginInfo, cfg, opts) {
+// Validate top-level required variables
+var pluginVariables = pluginInfo.getPreferences();
+opts.cli_variables = opts.cli_variables || {};
+var pluginEntry = cfg.getPlugin(pluginInfo.id);
+// Get variables from config.xml
+var configVariables = pluginEntry ? pluginEntry.variables : {};
+// Add config variable if it's missing in cli_variables
+Object.keys(configVariables).forEach(function (variable) {
+opts.cli_variables[variable] = opts.cli_variables[variable] || 
configVariables[variable];
+});
+var missingVariables = Object.keys(pluginVariables)
+.filter(function (variableName) {
+// discard variables with default value
+return !(pluginVariables[variableName] || 
opts.cli_variables[variableName]);
+});
+
+if (missingVariables.length) {
+events.emit('verbose', 'Removing ' + pluginInfo.dir + ' because 
mandatory plugin variables were missing.');
+shell.rm('-rf', pluginInfo.dir);
+var msg = 'Variable(s) missing (use: --variable ' + 
missingVariables.join('=value --variable ') + '=value).';
+return Q.reject(new CordovaError(msg));
--- End diff --

Change this to `throw new CordovaError(msg)`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: [VOTE] cordova-browser@5 & cordova-serve@2 (attempt 2)

2017-08-28 Thread Jesse
I vote +1:

* ran coho audit-license-headers over the relevant repos
* ran coho check-license to ensure all dependencies have Apache-compatible
licenses
* created and ran a test project successfully
* verified that the contents of
NewProject/node_modules/cordova-browser/node_modules/cordova-serve matched
serve@2.0.0
* ran verify-archive on svn posted binaries



@purplecabbage
risingj.com

On Mon, Aug 28, 2017 at 2:02 PM, Audrey So  wrote:

> +1
>
> I did the following:
> 1. pulled the latest cordova-browser down locally
> 2. updated cordova-browser package.json `cordova-serve` dependency to:
> https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-serve%232.0.0=02%7C01%7C%
> 7C948615d0e2cd43b210e308d4ee57ba51%7Cfa7b1b5a7b34438794aed2c178de
> cee1%7C0%7C0%7C636395507937327182=2VPUwt%
> 2FdZBUaTWnzBWNZVU9KU4qz7AoF5HQ3LXVrem4%3D=0
> 3. added my local cordova-browser
> 4. ran npm test in cordova-browser (passed)
> 5. cordova run in sample project (passed)
> LGTM!
>
> Sorry sent to the wrong thread before!
>
>
> — Audrey
>
>
>
>
>
>
>
> On 8/25/17, 1:59 PM, "Steven Gill"  wrote:
>
> >Please review and vote on this 5.0.0 cordova-browser Release & 2.0.0
> >cordova-serve Release
> >by replying to this email (and keep discussion on the DISCUSS thread)
> >
> >Release issue: https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FCB-
> 13214=02%7C01%7C%7Cd98e16c9d92944d0086908d4ebfc4f58%
> 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636392916282296264=
> rlbgW6sCUf2q8Dayz3wrxLUG9BzbZ6oW3w%2F%2BsbiPfbo%3D=0
> >
> >The archive has been published to
> >dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-13214
> >
> >The package was published from its corresponding git tag:
> >cordova-browser: 5.0.0 (6e9cb1f7c6)
> >cordova-serve: 2.0.0 (4ad258947c)
> >
> >Note that you can test it out via:
> >
> >1) pull the latest cordova-browser down locally
> >2) update cordova-browser package.json `cordova-serve` dependency to:
> >   "cordova-serve": "https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-serve.git%
> 232.0.0=02%7C01%7C%7Cd98e16c9d92944d0086908d4ebfc4f58%
> 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636392916282296264=
> pw3tvj8mgBlDnaezyzDtDsb%2B4PctVvubaQi4NZE2CA4%3D=0"
> >3) add your local cordova-browser
> >cordova platform add ../cordova-browser
> >
> >
> >Upon a successful vote I will upload the archive to dist/, publish it
> >to npm, and post the blog post.
> >
> >Voting guidelines:
> >https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-coho%2Fblob%2Fmaster%2Fdocs%
> 2Frelease-voting.md=02%7C01%7C%7Cd98e16c9d92944d0086908d4ebfc4f58%
> 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636392916282296264=
> jIOdijpnZK1%2BLql0q0rpvp5bgDECBKKXYoykij%2Bl90o%3D=0
> >
> >Voting will go on for a minimum of 48 hours.
> >
> >I vote +1:
> >* Ran coho audit-license-headers over the relevant repos
> >* Ran coho check-license to ensure all dependencies and
> >subdependencies have Apache-compatible licenses
> >* Ensured continuous build was green when repo was tagged
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>


Re: [DISCUSS] Browser 5.0.0 release

2017-08-28 Thread Jesse
This is not the vote thread Audrey, discuss only here.


@purplecabbage
risingj.com

On Mon, Aug 28, 2017 at 1:59 PM, Audrey So  wrote:

> +1
>
> I did the following:
> 1. pulled the latest cordova-browser down locally
> 2. updated cordova-browser package.json `cordova-serve` dependency to:
> https://github.com/apache/cordova-serve#2.0.0
> 3. added my local cordova-browser
> 4. ran npm test in cordova-browser (passed)
> 5. cordova run in sample project (passed)
> LGTM!
>
>
> — Audrey
>
>
>
>
>
> On 8/28/17, 1:09 PM, "Steven Gill"  wrote:
>
> >Need some votes!
> >
> >On Wed, Aug 23, 2017 at 5:53 PM, Steven Gill 
> wrote:
> >
> >> Okay. Sent PRs to fix browser [1] and cordova serve [2].
> >>
> >> [1] https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-browser%
> 2Fpull%2F41=02%7C01%7C%7Cf3a91dbe264f421fa8a808d4ee50c483%
> 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636395478065312029=
> oOv7uEE4yl4wK%2Fl9SBkkVGbmHqYlQIkz0Szq3s9el1w%3D=0
> >> [2] https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-serve%
> 2Fpull%2F4=02%7C01%7C%7Cf3a91dbe264f421fa8a808d4ee50c483%
> 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636395478065312029=
> OexM9fhYXOrWO6gVftMW1iHLhmZsYgpu%2BE3OlwIykD0%3D=0
> >>
> >> I will plan to merge these in tomorrow and start a release for both.
> >>
> >> On Thu, Aug 17, 2017 at 11:40 AM, Steven Gill 
> >> wrote:
> >>
> >>> https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FCB-
> 13188=02%7C01%7C%7Cf3a91dbe264f421fa8a808d4ee50c483%
> 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636395478065312029=
> Ndc1T8CqYJQMTRdIH7iss6d0crs4b92AXsd%2FsqhzDzE%3D=0
> >>>
> >>> On Thu, Aug 17, 2017 at 11:35 AM, Steven Gill 
> >>> wrote:
> >>>
>  new project. Adding and removing browser doesn't help
> 
>  On Thu, Aug 17, 2017 at 11:32 AM, Jesse 
> wrote:
> 
> > is this a new project? does adding and removing the browser platform
> > help?
> >
> >
> >
> > @purplecabbage
> > risingj.com
> >
> > On Thu, Aug 17, 2017 at 11:21 AM, Steven Gill <
> stevengil...@gmail.com>
> > wrote:
> >
> > > Ahh I'm seeing this too :(. I'll fix it and do some more tests
> > >
> > > On Wed, Aug 16, 2017 at 9:52 PM,  wrote:
> > >
> > > > Well yeah... `cordova run browser` currently gives me this:
> > > > https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fgist.github.com%2Falsorokin%2F0c586acbfd560f50a908a9916909
> b220=02%7C01%7C%7Cf3a91dbe264f421fa8a808d4ee50c483%
> 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636395478065312029=
> iFHMrf3E32nzwvanHZVVBj%2F%2FDGYlPgfQGSA9V%2ByNESI%3D=0
> > > >
> > > > -Original Message-
> > > > From: Steven Gill [mailto:stevengil...@gmail.com]
> > > > Sent: Wednesday, August 16, 2017 8:09 PM
> > > > To: dev@cordova.apache.org
> > > > Subject: [DISCUSS] Browser 5.0.0 release
> > > >
> > > > Hey everyone!
> > > >
> > > > I want to start a new browser release. 5.0.0. It will be a major
> > because
> > > > browser has adopted the platformAPI & because it introduces the
> > creation
> > > of
> > > > manifest.json (from config.xml) for basic PWA support.
> > > >
> > > > Any issues or concerns?
> > > >
> > > >
> > > > 
> > -
> > > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > > > For additional commands, e-mail: dev-h...@cordova.apache.org
> > > >
> > > >
> > >
> >
> 
> 
> >>>
> >>
>


Re: [VOTE] cordova-browser@5 & cordova-serve@2 (attempt 2)

2017-08-28 Thread Audrey So
+1

I did the following:
1. pulled the latest cordova-browser down locally
2. updated cordova-browser package.json `cordova-serve` dependency to: 
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-serve%232.0.0=02%7C01%7C%7C948615d0e2cd43b210e308d4ee57ba51%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636395507937327182=2VPUwt%2FdZBUaTWnzBWNZVU9KU4qz7AoF5HQ3LXVrem4%3D=0
3. added my local cordova-browser
4. ran npm test in cordova-browser (passed)
5. cordova run in sample project (passed)
LGTM!

Sorry sent to the wrong thread before!


— Audrey







On 8/25/17, 1:59 PM, "Steven Gill"  wrote:

>Please review and vote on this 5.0.0 cordova-browser Release & 2.0.0
>cordova-serve Release
>by replying to this email (and keep discussion on the DISCUSS thread)
>
>Release issue: 
>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FCB-13214=02%7C01%7C%7Cd98e16c9d92944d0086908d4ebfc4f58%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636392916282296264=rlbgW6sCUf2q8Dayz3wrxLUG9BzbZ6oW3w%2F%2BsbiPfbo%3D=0
>
>The archive has been published to
>dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-13214
>
>The package was published from its corresponding git tag:
>cordova-browser: 5.0.0 (6e9cb1f7c6)
>cordova-serve: 2.0.0 (4ad258947c)
>
>Note that you can test it out via:
>
>1) pull the latest cordova-browser down locally
>2) update cordova-browser package.json `cordova-serve` dependency to:
>   "cordova-serve": 
> "https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-serve.git%232.0.0=02%7C01%7C%7Cd98e16c9d92944d0086908d4ebfc4f58%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636392916282296264=pw3tvj8mgBlDnaezyzDtDsb%2B4PctVvubaQi4NZE2CA4%3D=0;
>3) add your local cordova-browser
>cordova platform add ../cordova-browser
>
>
>Upon a successful vote I will upload the archive to dist/, publish it
>to npm, and post the blog post.
>
>Voting guidelines:
>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-coho%2Fblob%2Fmaster%2Fdocs%2Frelease-voting.md=02%7C01%7C%7Cd98e16c9d92944d0086908d4ebfc4f58%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636392916282296264=jIOdijpnZK1%2BLql0q0rpvp5bgDECBKKXYoykij%2Bl90o%3D=0
>
>Voting will go on for a minimum of 48 hours.
>
>I vote +1:
>* Ran coho audit-license-headers over the relevant repos
>* Ran coho check-license to ensure all dependencies and
>subdependencies have Apache-compatible licenses
>* Ensured continuous build was green when repo was tagged

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org


Re: [DISCUSS] Browser 5.0.0 release

2017-08-28 Thread Audrey So
+1

I did the following:
1. pulled the latest cordova-browser down locally
2. updated cordova-browser package.json `cordova-serve` dependency to: 
https://github.com/apache/cordova-serve#2.0.0
3. added my local cordova-browser
4. ran npm test in cordova-browser (passed)
5. cordova run in sample project (passed)
LGTM!


— Audrey





On 8/28/17, 1:09 PM, "Steven Gill"  wrote:

>Need some votes!
>
>On Wed, Aug 23, 2017 at 5:53 PM, Steven Gill  wrote:
>
>> Okay. Sent PRs to fix browser [1] and cordova serve [2].
>>
>> [1] 
>> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-browser%2Fpull%2F41=02%7C01%7C%7Cf3a91dbe264f421fa8a808d4ee50c483%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636395478065312029=oOv7uEE4yl4wK%2Fl9SBkkVGbmHqYlQIkz0Szq3s9el1w%3D=0
>> [2] 
>> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-serve%2Fpull%2F4=02%7C01%7C%7Cf3a91dbe264f421fa8a808d4ee50c483%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636395478065312029=OexM9fhYXOrWO6gVftMW1iHLhmZsYgpu%2BE3OlwIykD0%3D=0
>>
>> I will plan to merge these in tomorrow and start a release for both.
>>
>> On Thu, Aug 17, 2017 at 11:40 AM, Steven Gill 
>> wrote:
>>
>>> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FCB-13188=02%7C01%7C%7Cf3a91dbe264f421fa8a808d4ee50c483%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636395478065312029=Ndc1T8CqYJQMTRdIH7iss6d0crs4b92AXsd%2FsqhzDzE%3D=0
>>>
>>> On Thu, Aug 17, 2017 at 11:35 AM, Steven Gill 
>>> wrote:
>>>
 new project. Adding and removing browser doesn't help

 On Thu, Aug 17, 2017 at 11:32 AM, Jesse  wrote:

> is this a new project? does adding and removing the browser platform
> help?
>
>
>
> @purplecabbage
> risingj.com
>
> On Thu, Aug 17, 2017 at 11:21 AM, Steven Gill 
> wrote:
>
> > Ahh I'm seeing this too :(. I'll fix it and do some more tests
> >
> > On Wed, Aug 16, 2017 at 9:52 PM,  wrote:
> >
> > > Well yeah... `cordova run browser` currently gives me this:
> > > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgist.github.com%2Falsorokin%2F0c586acbfd560f50a908a9916909b220=02%7C01%7C%7Cf3a91dbe264f421fa8a808d4ee50c483%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636395478065312029=iFHMrf3E32nzwvanHZVVBj%2F%2FDGYlPgfQGSA9V%2ByNESI%3D=0
> > >
> > > -Original Message-
> > > From: Steven Gill [mailto:stevengil...@gmail.com]
> > > Sent: Wednesday, August 16, 2017 8:09 PM
> > > To: dev@cordova.apache.org
> > > Subject: [DISCUSS] Browser 5.0.0 release
> > >
> > > Hey everyone!
> > >
> > > I want to start a new browser release. 5.0.0. It will be a major
> because
> > > browser has adopted the platformAPI & because it introduces the
> creation
> > of
> > > manifest.json (from config.xml) for basic PWA support.
> > >
> > > Any issues or concerns?
> > >
> > >
> > > 
> -
> > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > > For additional commands, e-mail: dev-h...@cordova.apache.org
> > >
> > >
> >
>


>>>
>>


Re: [DISCUSS] Browser 5.0.0 release

2017-08-28 Thread Kerri Shotts
Tx for the reminder -- meant to do it this weekend and time got away from
me. I'll see what I can do tonight.

Best,
~ Kerri

*  Kerri shotts*, Developer Advocate @ Adobe
  Blog  • @kerrishotts
 • Github 
  (All opinions are my own!)

On Mon, Aug 28, 2017 at 4:09 PM, Steven Gill  wrote:

> Need some votes!
>
> On Wed, Aug 23, 2017 at 5:53 PM, Steven Gill 
> wrote:
>
> > Okay. Sent PRs to fix browser [1] and cordova serve [2].
> >
> > [1] https://github.com/apache/cordova-browser/pull/41
> > [2] https://github.com/apache/cordova-serve/pull/4
> >
> > I will plan to merge these in tomorrow and start a release for both.
> >
> > On Thu, Aug 17, 2017 at 11:40 AM, Steven Gill 
> > wrote:
> >
> >> https://issues.apache.org/jira/browse/CB-13188
> >>
> >> On Thu, Aug 17, 2017 at 11:35 AM, Steven Gill 
> >> wrote:
> >>
> >>> new project. Adding and removing browser doesn't help
> >>>
> >>> On Thu, Aug 17, 2017 at 11:32 AM, Jesse 
> wrote:
> >>>
>  is this a new project? does adding and removing the browser platform
>  help?
> 
> 
> 
>  @purplecabbage
>  risingj.com
> 
>  On Thu, Aug 17, 2017 at 11:21 AM, Steven Gill  >
>  wrote:
> 
>  > Ahh I'm seeing this too :(. I'll fix it and do some more tests
>  >
>  > On Wed, Aug 16, 2017 at 9:52 PM,  wrote:
>  >
>  > > Well yeah... `cordova run browser` currently gives me this:
>  > > https://gist.github.com/alsorokin/0c586acbfd560f50a908a9916909b2
> 20
>  > >
>  > > -Original Message-
>  > > From: Steven Gill [mailto:stevengil...@gmail.com]
>  > > Sent: Wednesday, August 16, 2017 8:09 PM
>  > > To: dev@cordova.apache.org
>  > > Subject: [DISCUSS] Browser 5.0.0 release
>  > >
>  > > Hey everyone!
>  > >
>  > > I want to start a new browser release. 5.0.0. It will be a major
>  because
>  > > browser has adopted the platformAPI & because it introduces the
>  creation
>  > of
>  > > manifest.json (from config.xml) for basic PWA support.
>  > >
>  > > Any issues or concerns?
>  > >
>  > >
>  > > 
>  -
>  > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
>  > > For additional commands, e-mail: dev-h...@cordova.apache.org
>  > >
>  > >
>  >
> 
> >>>
> >>>
> >>
> >
>


Re: [DISCUSS] Browser 5.0.0 release

2017-08-28 Thread Steven Gill
Need some votes!

On Wed, Aug 23, 2017 at 5:53 PM, Steven Gill  wrote:

> Okay. Sent PRs to fix browser [1] and cordova serve [2].
>
> [1] https://github.com/apache/cordova-browser/pull/41
> [2] https://github.com/apache/cordova-serve/pull/4
>
> I will plan to merge these in tomorrow and start a release for both.
>
> On Thu, Aug 17, 2017 at 11:40 AM, Steven Gill 
> wrote:
>
>> https://issues.apache.org/jira/browse/CB-13188
>>
>> On Thu, Aug 17, 2017 at 11:35 AM, Steven Gill 
>> wrote:
>>
>>> new project. Adding and removing browser doesn't help
>>>
>>> On Thu, Aug 17, 2017 at 11:32 AM, Jesse  wrote:
>>>
 is this a new project? does adding and removing the browser platform
 help?



 @purplecabbage
 risingj.com

 On Thu, Aug 17, 2017 at 11:21 AM, Steven Gill 
 wrote:

 > Ahh I'm seeing this too :(. I'll fix it and do some more tests
 >
 > On Wed, Aug 16, 2017 at 9:52 PM,  wrote:
 >
 > > Well yeah... `cordova run browser` currently gives me this:
 > > https://gist.github.com/alsorokin/0c586acbfd560f50a908a9916909b220
 > >
 > > -Original Message-
 > > From: Steven Gill [mailto:stevengil...@gmail.com]
 > > Sent: Wednesday, August 16, 2017 8:09 PM
 > > To: dev@cordova.apache.org
 > > Subject: [DISCUSS] Browser 5.0.0 release
 > >
 > > Hey everyone!
 > >
 > > I want to start a new browser release. 5.0.0. It will be a major
 because
 > > browser has adopted the platformAPI & because it introduces the
 creation
 > of
 > > manifest.json (from config.xml) for basic PWA support.
 > >
 > > Any issues or concerns?
 > >
 > >
 > > 
 -
 > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
 > > For additional commands, e-mail: dev-h...@cordova.apache.org
 > >
 > >
 >

>>>
>>>
>>
>