[GitHub] cordova-plugin-inappbrowser issue #238: added cookies support for Android an...

2017-08-29 Thread thesourav123
Github user thesourav123 commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/238
  
This was needed. Finally, thanks a lot. i tested and it works. Yay!!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Nightly build #469 for cordova has failed

2017-08-29 Thread Apache Jenkins Server
Nightly build #469 for cordova has failed.

Please check failure details on build details page at 
https://builds.apache.org/job/cordova-nightly/469/
You can also take a look at build console: 
https://builds.apache.org/job/cordova-nightly/469/consoleFull

-
Jenkins for Apache Cordova

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser issue #238: added cookies support for Android an...

2017-08-29 Thread thesourav123
Github user thesourav123 commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/238
  
@denisx304 i am facing an issue with the original inappbrowser not saving 
session cookies when app is closed in iOS(But, works in Android). Will this 
merge fix my issue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[Review] cordova browser and serve blog post

2017-08-29 Thread Steven Gill
Please leave any comments on the pr!
https://github.com/apache/cordova-docs/pull/723


[GitHub] cordova-docs issue #723: CB-13214: added browser and serve release blog post

2017-08-29 Thread stevengill
Github user stevengill commented on the issue:

https://github.com/apache/cordova-docs/pull/723
  
Let me know if you have any feedback!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-docs pull request #723: CB-13214: added browser and serve release bl...

2017-08-29 Thread stevengill
GitHub user stevengill opened a pull request:

https://github.com/apache/cordova-docs/pull/723

CB-13214: added browser and serve release blog post



### Platforms affected


### What does this PR do?


### What testing has been done on this change?


### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/stevengill/cordova-docs CB-13214

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/723.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #723


commit 1c939f6abc90baf128903ad8185b8d7c86a4bd42
Author: Steve Gill 
Date:   2017-08-30T00:41:05Z

CB-13214: added browser and serve release blog post




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-lib pull request #561: Cb 12870 - Check that all use cases are caugh...

2017-08-29 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/561


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: [VOTE] cordova-browser@5 & cordova-serve@2 (attempt 2)

2017-08-29 Thread Steven Gill
The vote has now closed. The results are:

Positive Binding Votes: 4
Steve Gill
Audrey So
Jesse MacFadyen
Alex Sorokin


The vote has passed.


On Tue, Aug 29, 2017 at 4:39 AM,  wrote:

> I vote +1:
>
> * ran coho verify-archive
> * manually verified git tags
> * verified versions
> * created and launched a blank app
> * ensured that paramedic can build and run test app:
> https://travis-ci.org/alsorokin/cordova-periodic-build-browser
>
> Thanks,
> Alexander Sorokin
>
> -Original Message-
> From: Jesse [mailto:purplecabb...@gmail.com]
> Sent: Tuesday, August 29, 2017 12:42 AM
> To: dev@cordova.apache.org
> Subject: Re: [VOTE] cordova-browser@5 & cordova-serve@2 (attempt 2)
>
> I vote +1:
>
> * ran coho audit-license-headers over the relevant repos
> * ran coho check-license to ensure all dependencies have Apache-compatible
> licenses
> * created and ran a test project successfully
> * verified that the contents of
> NewProject/node_modules/cordova-browser/node_modules/cordova-serve matched
> serve@2.0.0
> * ran verify-archive on svn posted binaries
>
>
>
> @purplecabbage
> risingj.com
>
> On Mon, Aug 28, 2017 at 2:02 PM, Audrey So  wrote:
>
> > +1
> >
> > I did the following:
> > 1. pulled the latest cordova-browser down locally 2. updated
> > cordova-browser package.json `cordova-serve` dependency to:
> > https://na01.safelinks.protection.outlook.com/?url=
> > https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-serve%232.0.0=02%7C01
> > %7C% 7C948615d0e2cd43b210e308d4ee57ba51%7Cfa7b1b5a7b34438794aed2c178de
> > cee1%7C0%7C0%7C636395507937327182=2VPUwt%
> > 2FdZBUaTWnzBWNZVU9KU4qz7AoF5HQ3LXVrem4%3D=0
> > 3. added my local cordova-browser
> > 4. ran npm test in cordova-browser (passed) 5. cordova run in sample
> > project (passed) LGTM!
> >
> > Sorry sent to the wrong thread before!
> >
> >
> > — Audrey
> >
> >
> >
> >
> >
> >
> >
> > On 8/25/17, 1:59 PM, "Steven Gill"  wrote:
> >
> > >Please review and vote on this 5.0.0 cordova-browser Release & 2.0.0
> > >cordova-serve Release by replying to this email (and keep discussion
> > >on the DISCUSS thread)
> > >
> > >Release issue: https://na01.safelinks.protection.outlook.com/?url=
> > https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FCB-
> > 13214=02%7C01%7C%7Cd98e16c9d92944d0086908d4ebfc4f58%
> > 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636392916282296264=
> > rlbgW6sCUf2q8Dayz3wrxLUG9BzbZ6oW3w%2F%2BsbiPfbo%3D=0
> > >
> > >The archive has been published to
> > >dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-13214
> > >
> > >The package was published from its corresponding git tag:
> > >cordova-browser: 5.0.0 (6e9cb1f7c6)
> > >cordova-serve: 2.0.0 (4ad258947c)
> > >
> > >Note that you can test it out via:
> > >
> > >1) pull the latest cordova-browser down locally
> > >2) update cordova-browser package.json `cordova-serve` dependency to:
> > >   "cordova-serve":
> > >"https://na01.safelinks.protection.outlook.com/?url=
> > https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-serve.git%
> > 232.0.0=02%7C01%7C%7Cd98e16c9d92944d0086908d4ebfc4f58%
> > 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636392916282296264=
> > pw3tvj8mgBlDnaezyzDtDsb%2B4PctVvubaQi4NZE2CA4%3D=0"
> > >3) add your local cordova-browser
> > >cordova platform add ../cordova-browser
> > >
> > >
> > >Upon a successful vote I will upload the archive to dist/, publish it
> > >to npm, and post the blog post.
> > >
> > >Voting guidelines:
> > >https://na01.safelinks.protection.outlook.com/?url=
> > https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-coho%2Fblob%2Fmaster%2Fdoc
> > s%
> > 2Frelease-voting.md=02%7C01%7C%7Cd98e16c9d92944d0086908d4ebfc4f58
> > %
> > 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636392916282296264=
> > jIOdijpnZK1%2BLql0q0rpvp5bgDECBKKXYoykij%2Bl90o%3D=0
> > >
> > >Voting will go on for a minimum of 48 hours.
> > >
> > >I vote +1:
> > >* Ran coho audit-license-headers over the relevant repos
> > >* Ran coho check-license to ensure all dependencies and
> > >subdependencies have Apache-compatible licenses
> > >* Ensured continuous build was green when repo was tagged
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>


[GitHub] cordova-plugin-file pull request #214: CB-12895 : Setup eslint and removed j...

2017-08-29 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-file/pull/214


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-inappbrowser pull request #236: CB-12895 : Added eslint and r...

2017-08-29 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/236


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: [GITHUB MOVE] Bulk move of all repos

2017-08-29 Thread Steven Gill
We can deal with jira issues -> github issues migration once all repos are
moved over.

On Tue, Aug 29, 2017 at 11:19 AM, Steven Gill 
wrote:

> do it!
>
>
> On Tue, Aug 29, 2017 at 11:18 AM, Shazron  wrote:
>
>> See: https://issues.apache.org/jira/browse/INFRA-14398
>>
>> INFRA (through Daniel Gruno) has commented on Hipchat that a bulk move
>> would be easier for us, versus a selective move.
>>
>> Ironically the proposed 3 Phase approach was to make it easier for INFRA
>> to
>> transition us.
>>
>> Updated proposal:
>> Move **all** our repos from git-wip-us.apache.org to Github?
>>
>> +1 for me.
>>
>
>


Re: [GITHUB MOVE] Bulk move of all repos

2017-08-29 Thread Steven Gill
do it!


On Tue, Aug 29, 2017 at 11:18 AM, Shazron  wrote:

> See: https://issues.apache.org/jira/browse/INFRA-14398
>
> INFRA (through Daniel Gruno) has commented on Hipchat that a bulk move
> would be easier for us, versus a selective move.
>
> Ironically the proposed 3 Phase approach was to make it easier for INFRA to
> transition us.
>
> Updated proposal:
> Move **all** our repos from git-wip-us.apache.org to Github?
>
> +1 for me.
>


[GITHUB MOVE] Bulk move of all repos

2017-08-29 Thread Shazron
See: https://issues.apache.org/jira/browse/INFRA-14398

INFRA (through Daniel Gruno) has commented on Hipchat that a bulk move
would be easier for us, versus a selective move.

Ironically the proposed 3 Phase approach was to make it easier for INFRA to
transition us.

Updated proposal:
Move **all** our repos from git-wip-us.apache.org to Github?

+1 for me.


[GitHub] cordova-lib pull request #589: removed .jscs.json

2017-08-29 Thread remcohaszing
Github user remcohaszing closed the pull request at:

https://github.com/apache/cordova-lib/pull/589


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



RE: [VOTE] cordova-browser@5 & cordova-serve@2 (attempt 2)

2017-08-29 Thread alsorokin
I vote +1:

* ran coho verify-archive
* manually verified git tags
* verified versions
* created and launched a blank app
* ensured that paramedic can build and run test app: 
https://travis-ci.org/alsorokin/cordova-periodic-build-browser

Thanks,
Alexander Sorokin

-Original Message-
From: Jesse [mailto:purplecabb...@gmail.com] 
Sent: Tuesday, August 29, 2017 12:42 AM
To: dev@cordova.apache.org
Subject: Re: [VOTE] cordova-browser@5 & cordova-serve@2 (attempt 2)

I vote +1:

* ran coho audit-license-headers over the relevant repos
* ran coho check-license to ensure all dependencies have Apache-compatible 
licenses
* created and ran a test project successfully
* verified that the contents of
NewProject/node_modules/cordova-browser/node_modules/cordova-serve matched
serve@2.0.0
* ran verify-archive on svn posted binaries



@purplecabbage
risingj.com

On Mon, Aug 28, 2017 at 2:02 PM, Audrey So  wrote:

> +1
>
> I did the following:
> 1. pulled the latest cordova-browser down locally 2. updated 
> cordova-browser package.json `cordova-serve` dependency to:
> https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-serve%232.0.0=02%7C01
> %7C% 7C948615d0e2cd43b210e308d4ee57ba51%7Cfa7b1b5a7b34438794aed2c178de
> cee1%7C0%7C0%7C636395507937327182=2VPUwt%
> 2FdZBUaTWnzBWNZVU9KU4qz7AoF5HQ3LXVrem4%3D=0
> 3. added my local cordova-browser
> 4. ran npm test in cordova-browser (passed) 5. cordova run in sample 
> project (passed) LGTM!
>
> Sorry sent to the wrong thread before!
>
>
> — Audrey
>
>
>
>
>
>
>
> On 8/25/17, 1:59 PM, "Steven Gill"  wrote:
>
> >Please review and vote on this 5.0.0 cordova-browser Release & 2.0.0 
> >cordova-serve Release by replying to this email (and keep discussion 
> >on the DISCUSS thread)
> >
> >Release issue: https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FCB-
> 13214=02%7C01%7C%7Cd98e16c9d92944d0086908d4ebfc4f58%
> 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636392916282296264=
> rlbgW6sCUf2q8Dayz3wrxLUG9BzbZ6oW3w%2F%2BsbiPfbo%3D=0
> >
> >The archive has been published to
> >dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-13214
> >
> >The package was published from its corresponding git tag:
> >cordova-browser: 5.0.0 (6e9cb1f7c6)
> >cordova-serve: 2.0.0 (4ad258947c)
> >
> >Note that you can test it out via:
> >
> >1) pull the latest cordova-browser down locally
> >2) update cordova-browser package.json `cordova-serve` dependency to:
> >   "cordova-serve": 
> >"https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-serve.git%
> 232.0.0=02%7C01%7C%7Cd98e16c9d92944d0086908d4ebfc4f58%
> 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636392916282296264=
> pw3tvj8mgBlDnaezyzDtDsb%2B4PctVvubaQi4NZE2CA4%3D=0"
> >3) add your local cordova-browser
> >cordova platform add ../cordova-browser
> >
> >
> >Upon a successful vote I will upload the archive to dist/, publish it 
> >to npm, and post the blog post.
> >
> >Voting guidelines:
> >https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-coho%2Fblob%2Fmaster%2Fdoc
> s% 
> 2Frelease-voting.md=02%7C01%7C%7Cd98e16c9d92944d0086908d4ebfc4f58
> % 
> 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636392916282296264=
> jIOdijpnZK1%2BLql0q0rpvp5bgDECBKKXYoykij%2Bl90o%3D=0
> >
> >Voting will go on for a minimum of 48 hours.
> >
> >I vote +1:
> >* Ran coho audit-license-headers over the relevant repos
> >* Ran coho check-license to ensure all dependencies and 
> >subdependencies have Apache-compatible licenses
> >* Ensured continuous build was green when repo was tagged
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>


-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-inappbrowser issue #221: CB-12834: (android) Fix bug when ope...

2017-08-29 Thread adirel
Github user adirel commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/221
  
Thank you. great work


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-inappbrowser issue #238: added cookies support for Android an...

2017-08-29 Thread denisx304
Github user denisx304 commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/238
  
Whenever you want to send cookies to one url.
For exemple keeping the user logged in from your mobile application to the 
web application.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-inappbrowser issue #238: added cookies support for Android an...

2017-08-29 Thread janpio
Github user janpio commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/238
  
May I asked what is a use case for this? What problem does this solve?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-inappbrowser issue #238: added cookies support for Android an...

2017-08-29 Thread denisx304
Github user denisx304 commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/238
  
exactly


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-inappbrowser issue #238: added cookies support for Android an...

2017-08-29 Thread janpio
Github user janpio commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/238
  
You are right, this is equivalent to messing with the local cookies with 
the developer tools of your browser.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org