[GitHub] cordova-lib issue #584: CB-12361 : added tests for plugin/save.js

[stevengill]

Github user stevengill commented on the issue:

https://github.com/apache/cordova-lib/pull/584
  
Make sure to run `npm run cover` to see the coverage report for save.js


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #584: CB-12361 : added tests for plugin/save.js

[stevengill]

Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/584#discussion_r136486774
  
--- Diff: spec/cordova/plugin/save.spec.js ---
@@ -54,15 +61,145 @@ describe('cordova/plugin/save', function () {
 });
 });
 describe('happy path', function () {
-it('should remove all plugins from config.xml and re-add new ones 
based on those retrieved from fetch.json');
-it('should only add top-level plugins to config.xml');
-it('should write individual plugin specs to config.xml');
-it('should write individual plugin variables to config.xml');
+it('should remove all plugins from config.xml and re-add new ones 
based on those retrieved from fetch.json', function (done) {
--- End diff --

This test checks that the plugins get removed but not if the new ones get 
re-added (based on description). I think the description should be updated to 
just check that existing plugins are getting removed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #584: CB-12361 : added tests for plugin/save.js

[stevengill]

Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/584#discussion_r136490386
  
--- Diff: spec/cordova/plugin/save.spec.js ---
@@ -54,15 +61,145 @@ describe('cordova/plugin/save', function () {
 });
 });
 describe('happy path', function () {
-it('should remove all plugins from config.xml and re-add new ones 
based on those retrieved from fetch.json');
-it('should only add top-level plugins to config.xml');
-it('should write individual plugin specs to config.xml');
-it('should write individual plugin variables to config.xml');
+it('should remove all plugins from config.xml and re-add new ones 
based on those retrieved from fetch.json', function (done) {
+save(projectRoot).then(function () {
+
expect(cfg_parser_mock.prototype.removePlugin).toHaveBeenCalledWith('VRPlugin');
+
expect(cfg_parser_mock.prototype.removePlugin).toHaveBeenCalledWith('MastodonSocialPlugin');
+}).fail(function (e) {
+expect(e).toBeUndefined();
+fail('did not expect fail handler to be invoked');
+}).done(done);
+});
+
+it('should only add top-level plugins to config.xml', function 
(done) {
+var fake_fetch_json =
+{'VRPlugin': {'source': {
+'type': 'registry',
+'id': 'id'
+},
+'is_top_level': true
+},
+'MastodonSocialPlugin': { 'source': {
+'type': 'registry',
+'id': 'id'
+},
+'is_top_level': false }};
+
+
fs.readFileSync.and.returnValue(JSON.stringify(fake_fetch_json));
+save(projectRoot).then(function () {
+
expect(cfg_parser_mock.prototype.addPlugin).toHaveBeenCalledWith(Object({ name: 
'VRPlugin' }), [ ]);
+expect(cfg_parser_mock.prototype.write).toHaveBeenCalled();
+}).fail(function (e) {
+expect(e).toBeUndefined();
+fail('did not expect fail handler to be invoked');
+}).done(done);
+});
+
+it('should write individual plugin specs to config.xml', function 
(done) {
+var fake_fetch_json =
+{'VRPlugin': {'source': {
+'type': 'registry',
+'id': 'id'
+},
+'is_top_level': true }};
+
fs.readFileSync.and.returnValue(JSON.stringify(fake_fetch_json));
+spyOn(save, 'getSpec').and.returnValue('1.0.0');
+save(projectRoot).then(function () {
+
expect(cfg_parser_mock.prototype.addPlugin).toHaveBeenCalledWith(Object({ name: 
'VRPlugin', spec: '1.0.0' }), jasmine.any(Object));
+expect(cfg_parser_mock.prototype.write).toHaveBeenCalled();
+}).fail(function (e) {
+expect(e).toBeUndefined();
+fail('did not expect fail handler to be invoked');
+}).done(done);
+});
+
+it('should write individual plugin variables to config.xml', 
function (done) {
+var fake_fetch_json =
+{'VRPlugin': {'source': {
+'type': 'registry',
+'id': 'id'
+},
+'is_top_level': true,
+'variables': {
+'var 1': ' '
+}}};
+
fs.readFileSync.and.returnValue(JSON.stringify(fake_fetch_json));
+save(projectRoot).then(function () {
+
expect(cfg_parser_mock.prototype.addPlugin).toHaveBeenCalledWith(jasmine.any(Object),
 [ Object({ name: 'var 1', value: ' ' }) ]);
+expect(cfg_parser_mock.prototype.write).toHaveBeenCalled();
+}).fail(function (e) {
+expect(e).toBeUndefined();
+fail('did not expect fail handler to be invoked');
+}).done(done);
+});
 });
 describe('getSpec helper method', function () {
-it('should return a plugin source\'s url or path property 
immediately');
-it('should return a version if a version was provided to plugin 
id');
-it('should return a version that includes scope if scope was part 
of plugin id');
-it('should fall back to using PluginInfoProvider to retrieve a 
version as last resort');
+it('should return a plugin source\'s url or path property 
immediately', function (done) {
+var fake_fetch_json =

[GitHub] cordova-lib pull request #584: CB-12361 : added tests for plugin/save.js

[stevengill]

Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/584#discussion_r136489451
  
--- Diff: spec/cordova/plugin/save.spec.js ---
@@ -54,15 +61,145 @@ describe('cordova/plugin/save', function () {
 });
 });
 describe('happy path', function () {
-it('should remove all plugins from config.xml and re-add new ones 
based on those retrieved from fetch.json');
-it('should only add top-level plugins to config.xml');
-it('should write individual plugin specs to config.xml');
-it('should write individual plugin variables to config.xml');
+it('should remove all plugins from config.xml and re-add new ones 
based on those retrieved from fetch.json', function (done) {
+save(projectRoot).then(function () {
+
expect(cfg_parser_mock.prototype.removePlugin).toHaveBeenCalledWith('VRPlugin');
+
expect(cfg_parser_mock.prototype.removePlugin).toHaveBeenCalledWith('MastodonSocialPlugin');
+}).fail(function (e) {
+expect(e).toBeUndefined();
+fail('did not expect fail handler to be invoked');
+}).done(done);
+});
+
+it('should only add top-level plugins to config.xml', function 
(done) {
+var fake_fetch_json =
+{'VRPlugin': {'source': {
+'type': 'registry',
+'id': 'id'
+},
+'is_top_level': true
+},
+'MastodonSocialPlugin': { 'source': {
+'type': 'registry',
+'id': 'id'
+},
+'is_top_level': false }};
+
+
fs.readFileSync.and.returnValue(JSON.stringify(fake_fetch_json));
+save(projectRoot).then(function () {
+
expect(cfg_parser_mock.prototype.addPlugin).toHaveBeenCalledWith(Object({ name: 
'VRPlugin' }), [ ]);
+expect(cfg_parser_mock.prototype.write).toHaveBeenCalled();
+}).fail(function (e) {
+expect(e).toBeUndefined();
+fail('did not expect fail handler to be invoked');
+}).done(done);
+});
+
+it('should write individual plugin specs to config.xml', function 
(done) {
+var fake_fetch_json =
+{'VRPlugin': {'source': {
+'type': 'registry',
+'id': 'id'
+},
+'is_top_level': true }};
+
fs.readFileSync.and.returnValue(JSON.stringify(fake_fetch_json));
+spyOn(save, 'getSpec').and.returnValue('1.0.0');
+save(projectRoot).then(function () {
+
expect(cfg_parser_mock.prototype.addPlugin).toHaveBeenCalledWith(Object({ name: 
'VRPlugin', spec: '1.0.0' }), jasmine.any(Object));
+expect(cfg_parser_mock.prototype.write).toHaveBeenCalled();
+}).fail(function (e) {
+expect(e).toBeUndefined();
+fail('did not expect fail handler to be invoked');
+}).done(done);
+});
+
+it('should write individual plugin variables to config.xml', 
function (done) {
+var fake_fetch_json =
+{'VRPlugin': {'source': {
+'type': 'registry',
+'id': 'id'
+},
+'is_top_level': true,
+'variables': {
+'var 1': ' '
+}}};
+
fs.readFileSync.and.returnValue(JSON.stringify(fake_fetch_json));
+save(projectRoot).then(function () {
+
expect(cfg_parser_mock.prototype.addPlugin).toHaveBeenCalledWith(jasmine.any(Object),
 [ Object({ name: 'var 1', value: ' ' }) ]);
+expect(cfg_parser_mock.prototype.write).toHaveBeenCalled();
+}).fail(function (e) {
+expect(e).toBeUndefined();
+fail('did not expect fail handler to be invoked');
+}).done(done);
+});
 });
 describe('getSpec helper method', function () {
-it('should return a plugin source\'s url or path property 
immediately');
-it('should return a version if a version was provided to plugin 
id');
-it('should return a version that includes scope if scope was part 
of plugin id');
-it('should fall back to using PluginInfoProvider to retrieve a 
version as last resort');
+it('should return a plugin source\'s url or path property 
immediately', function (done) {
+var fake_fetch_json =

[GitHub] cordova-lib pull request #584: CB-12361 : added tests for plugin/save.js

[stevengill]

Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/584#discussion_r136488898
  
--- Diff: spec/cordova/plugin/save.spec.js ---
@@ -54,15 +61,145 @@ describe('cordova/plugin/save', function () {
 });
 });
 describe('happy path', function () {
-it('should remove all plugins from config.xml and re-add new ones 
based on those retrieved from fetch.json');
-it('should only add top-level plugins to config.xml');
-it('should write individual plugin specs to config.xml');
-it('should write individual plugin variables to config.xml');
+it('should remove all plugins from config.xml and re-add new ones 
based on those retrieved from fetch.json', function (done) {
+save(projectRoot).then(function () {
+
expect(cfg_parser_mock.prototype.removePlugin).toHaveBeenCalledWith('VRPlugin');
+
expect(cfg_parser_mock.prototype.removePlugin).toHaveBeenCalledWith('MastodonSocialPlugin');
+}).fail(function (e) {
+expect(e).toBeUndefined();
+fail('did not expect fail handler to be invoked');
+}).done(done);
+});
+
+it('should only add top-level plugins to config.xml', function 
(done) {
+var fake_fetch_json =
+{'VRPlugin': {'source': {
+'type': 'registry',
+'id': 'id'
+},
+'is_top_level': true
+},
+'MastodonSocialPlugin': { 'source': {
+'type': 'registry',
+'id': 'id'
+},
+'is_top_level': false }};
+
+
fs.readFileSync.and.returnValue(JSON.stringify(fake_fetch_json));
+save(projectRoot).then(function () {
+
expect(cfg_parser_mock.prototype.addPlugin).toHaveBeenCalledWith(Object({ name: 
'VRPlugin' }), [ ]);
+expect(cfg_parser_mock.prototype.write).toHaveBeenCalled();
+}).fail(function (e) {
+expect(e).toBeUndefined();
+fail('did not expect fail handler to be invoked');
+}).done(done);
+});
+
+it('should write individual plugin specs to config.xml', function 
(done) {
+var fake_fetch_json =
+{'VRPlugin': {'source': {
+'type': 'registry',
+'id': 'id'
+},
+'is_top_level': true }};
+
fs.readFileSync.and.returnValue(JSON.stringify(fake_fetch_json));
+spyOn(save, 'getSpec').and.returnValue('1.0.0');
+save(projectRoot).then(function () {
+
expect(cfg_parser_mock.prototype.addPlugin).toHaveBeenCalledWith(Object({ name: 
'VRPlugin', spec: '1.0.0' }), jasmine.any(Object));
+expect(cfg_parser_mock.prototype.write).toHaveBeenCalled();
+}).fail(function (e) {
+expect(e).toBeUndefined();
+fail('did not expect fail handler to be invoked');
+}).done(done);
+});
+
+it('should write individual plugin variables to config.xml', 
function (done) {
+var fake_fetch_json =
+{'VRPlugin': {'source': {
+'type': 'registry',
+'id': 'id'
+},
+'is_top_level': true,
+'variables': {
+'var 1': ' '
+}}};
+
fs.readFileSync.and.returnValue(JSON.stringify(fake_fetch_json));
+save(projectRoot).then(function () {
+
expect(cfg_parser_mock.prototype.addPlugin).toHaveBeenCalledWith(jasmine.any(Object),
 [ Object({ name: 'var 1', value: ' ' }) ]);
+expect(cfg_parser_mock.prototype.write).toHaveBeenCalled();
+}).fail(function (e) {
+expect(e).toBeUndefined();
+fail('did not expect fail handler to be invoked');
+}).done(done);
+});
 });
 describe('getSpec helper method', function () {
-it('should return a plugin source\'s url or path property 
immediately');
-it('should return a version if a version was provided to plugin 
id');
-it('should return a version that includes scope if scope was part 
of plugin id');
-it('should fall back to using PluginInfoProvider to retrieve a 
version as last resort');
+it('should return a plugin source\'s url or path property 
immediately', function (done) {
+var fake_fetch_json =

[GitHub] cordova-lib pull request #584: CB-12361 : added tests for plugin/save.js

[stevengill]

Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/584#discussion_r136490187
  
--- Diff: spec/cordova/plugin/save.spec.js ---
@@ -54,15 +61,145 @@ describe('cordova/plugin/save', function () {
 });
 });
 describe('happy path', function () {
-it('should remove all plugins from config.xml and re-add new ones 
based on those retrieved from fetch.json');
-it('should only add top-level plugins to config.xml');
-it('should write individual plugin specs to config.xml');
-it('should write individual plugin variables to config.xml');
+it('should remove all plugins from config.xml and re-add new ones 
based on those retrieved from fetch.json', function (done) {
+save(projectRoot).then(function () {
+
expect(cfg_parser_mock.prototype.removePlugin).toHaveBeenCalledWith('VRPlugin');
+
expect(cfg_parser_mock.prototype.removePlugin).toHaveBeenCalledWith('MastodonSocialPlugin');
+}).fail(function (e) {
+expect(e).toBeUndefined();
+fail('did not expect fail handler to be invoked');
+}).done(done);
+});
+
+it('should only add top-level plugins to config.xml', function 
(done) {
+var fake_fetch_json =
+{'VRPlugin': {'source': {
+'type': 'registry',
+'id': 'id'
+},
+'is_top_level': true
+},
+'MastodonSocialPlugin': { 'source': {
+'type': 'registry',
+'id': 'id'
+},
+'is_top_level': false }};
+
+
fs.readFileSync.and.returnValue(JSON.stringify(fake_fetch_json));
+save(projectRoot).then(function () {
+
expect(cfg_parser_mock.prototype.addPlugin).toHaveBeenCalledWith(Object({ name: 
'VRPlugin' }), [ ]);
+expect(cfg_parser_mock.prototype.write).toHaveBeenCalled();
+}).fail(function (e) {
+expect(e).toBeUndefined();
+fail('did not expect fail handler to be invoked');
+}).done(done);
+});
+
+it('should write individual plugin specs to config.xml', function 
(done) {
+var fake_fetch_json =
+{'VRPlugin': {'source': {
+'type': 'registry',
+'id': 'id'
+},
+'is_top_level': true }};
+
fs.readFileSync.and.returnValue(JSON.stringify(fake_fetch_json));
+spyOn(save, 'getSpec').and.returnValue('1.0.0');
+save(projectRoot).then(function () {
+
expect(cfg_parser_mock.prototype.addPlugin).toHaveBeenCalledWith(Object({ name: 
'VRPlugin', spec: '1.0.0' }), jasmine.any(Object));
+expect(cfg_parser_mock.prototype.write).toHaveBeenCalled();
+}).fail(function (e) {
+expect(e).toBeUndefined();
+fail('did not expect fail handler to be invoked');
+}).done(done);
+});
+
+it('should write individual plugin variables to config.xml', 
function (done) {
+var fake_fetch_json =
+{'VRPlugin': {'source': {
+'type': 'registry',
+'id': 'id'
+},
+'is_top_level': true,
+'variables': {
+'var 1': ' '
+}}};
+
fs.readFileSync.and.returnValue(JSON.stringify(fake_fetch_json));
+save(projectRoot).then(function () {
+
expect(cfg_parser_mock.prototype.addPlugin).toHaveBeenCalledWith(jasmine.any(Object),
 [ Object({ name: 'var 1', value: ' ' }) ]);
+expect(cfg_parser_mock.prototype.write).toHaveBeenCalled();
+}).fail(function (e) {
+expect(e).toBeUndefined();
+fail('did not expect fail handler to be invoked');
+}).done(done);
+});
 });
 describe('getSpec helper method', function () {
--- End diff --

So with all of these `getSpec` tests, you want to test getSpec directly. 
Right now, you are doing `save(projectRoot)` but instead you want to do 
`save.getSpec({ url: 
'https://git-wip-us.apache.org/repos/asf/cordova-plugin-camera.git' }, 
'/some/path', 'VRPlugin')`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not 

[GitHub] cordova-lib pull request #584: CB-12361 : added tests for plugin/save.js

[stevengill]

Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/584#discussion_r136487019
  
--- Diff: spec/cordova/plugin/save.spec.js ---
@@ -54,15 +61,145 @@ describe('cordova/plugin/save', function () {
 });
 });
 describe('happy path', function () {
-it('should remove all plugins from config.xml and re-add new ones 
based on those retrieved from fetch.json');
-it('should only add top-level plugins to config.xml');
-it('should write individual plugin specs to config.xml');
-it('should write individual plugin variables to config.xml');
+it('should remove all plugins from config.xml and re-add new ones 
based on those retrieved from fetch.json', function (done) {
+save(projectRoot).then(function () {
+
expect(cfg_parser_mock.prototype.removePlugin).toHaveBeenCalledWith('VRPlugin');
+
expect(cfg_parser_mock.prototype.removePlugin).toHaveBeenCalledWith('MastodonSocialPlugin');
+}).fail(function (e) {
+expect(e).toBeUndefined();
+fail('did not expect fail handler to be invoked');
+}).done(done);
+});
+
+it('should only add top-level plugins to config.xml', function 
(done) {
+var fake_fetch_json =
+{'VRPlugin': {'source': {
+'type': 'registry',
+'id': 'id'
+},
+'is_top_level': true
+},
+'MastodonSocialPlugin': { 'source': {
+'type': 'registry',
+'id': 'id'
+},
+'is_top_level': false }};
+
+
fs.readFileSync.and.returnValue(JSON.stringify(fake_fetch_json));
+save(projectRoot).then(function () {
+
expect(cfg_parser_mock.prototype.addPlugin).toHaveBeenCalledWith(Object({ name: 
'VRPlugin' }), [ ]);
--- End diff --

Maybe add another expect to show that the non top level plugin didn't get 
installed. Something like 
```
expect(cfg_parser_mock.prototype.addPlugin).toHaveBeenCalledWith(Object({ 
name: 'MastodonSocialPlugin' }), [ ]);```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #584: CB-12361 : added tests for plugin/save.js

[stevengill]

Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/584#discussion_r136487749
  
--- Diff: spec/cordova/plugin/save.spec.js ---
@@ -54,15 +61,145 @@ describe('cordova/plugin/save', function () {
 });
 });
 describe('happy path', function () {
-it('should remove all plugins from config.xml and re-add new ones 
based on those retrieved from fetch.json');
-it('should only add top-level plugins to config.xml');
-it('should write individual plugin specs to config.xml');
-it('should write individual plugin variables to config.xml');
+it('should remove all plugins from config.xml and re-add new ones 
based on those retrieved from fetch.json', function (done) {
+save(projectRoot).then(function () {
+
expect(cfg_parser_mock.prototype.removePlugin).toHaveBeenCalledWith('VRPlugin');
+
expect(cfg_parser_mock.prototype.removePlugin).toHaveBeenCalledWith('MastodonSocialPlugin');
+}).fail(function (e) {
+expect(e).toBeUndefined();
+fail('did not expect fail handler to be invoked');
+}).done(done);
+});
+
+it('should only add top-level plugins to config.xml', function 
(done) {
+var fake_fetch_json =
+{'VRPlugin': {'source': {
+'type': 'registry',
+'id': 'id'
+},
+'is_top_level': true
+},
+'MastodonSocialPlugin': { 'source': {
+'type': 'registry',
+'id': 'id'
+},
+'is_top_level': false }};
+
+
fs.readFileSync.and.returnValue(JSON.stringify(fake_fetch_json));
+save(projectRoot).then(function () {
+
expect(cfg_parser_mock.prototype.addPlugin).toHaveBeenCalledWith(Object({ name: 
'VRPlugin' }), [ ]);
--- End diff --

Maybe for this test, you can redo the checks from the first test. That is 
confirm that these two expects are run before the addPlugin one

```

expect(cfg_parser_mock.prototype.removePlugin).toHaveBeenCalledWith('VRPlugin');

expect(cfg_parser_mock.prototype.removePlugin).toHaveBeenCalledWith('MastodonSocialPlugin');
```

I think they should pass. If they do, you can also update the description 
of this test to reflect that the plugins are being removed first and then only 
top level plugins are being restored. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Nightly build #471 for cordova has failed

[Apache Jenkins Server]

Nightly build #471 for cordova has failed.

Please check failure details on build details page at 
https://builds.apache.org/job/cordova-nightly/471/
You can also take a look at build console: 
https://builds.apache.org/job/cordova-nightly/471/consoleFull

-
Jenkins for Apache Cordova

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [Vote] Cordova-Common@2.1.0 Release

[Steven Gill]

I vote +1
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and subdependencies
have Apache-compatible licenses
* Ran npm test and it passed
* linked with cordova-lib and ran tests, passed



On Wed, Aug 30, 2017 at 3:39 PM, Audrey So  wrote:

> Hi everyone,
>
> Please review and vote on this Cordova-Common@2.1.0 Release
> by replying to this email (and keep discussion on the DISCUSS thread)
>
> Release issue: https://issues.apache.org/jira/browse/CB-13231
>
> cordova-common@2.1.0 has been published to dist/dev:
> https://dist.apache.org/repos/dist/dev/cordova/CB-13231/
>
> The packages were published from their corresponding git tags:
>
> cordova-common: 2.1.0 (e6d8e6f063)
>
> Upon a successful vote I will upload the archives to dist/, publish them
> to npm, and post the corresponding blog post.
>
> Voting guidelines: https://github.com/apache/
> cordova-coho/blob/master/docs/release-voting.md
>
> Voting will go on for a minimum of 48 hours.
>
> I vote +1:
> * Ran coho audit-license-headers over the relevant repos
> * Ran coho check-license to ensure all dependencies and subdependencies
> have Apache-compatible licenses
> * Ensured continuous build was green when repos were tagged
>
> Thank you!
>
> Audrey
>

Re: [DISCUSS] cordova-ios 4.1.1 Release

[Filip Maj]

By the way, I think we should include notes about
cordova-plugin-console being integrated in the blog post /
announcement for this release - that may trip up folks trying to
update cordova-ios, if they had the console plugin manually installed
already.

On Thu, Aug 31, 2017 at 7:21 PM, Shazron  wrote:
> Stalled on testing and fixing https://github.com/apache/cordova-ios/pull/335
> before a release can be sent for vote
>
> On Thu, Aug 24, 2017 at 4:12 PM, Shazron  wrote:
>
>> Issues on the board have been completed, the PRs need review:
>>
>> Board:
>> https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=173
>>
>> Pull requests:
>> 1. https://github.com/apache/cordova-ios/pull/326
>> 2. https://github.com/apache/cordova-ios/pull/331
>> 3. https://github.com/apache/cordova-ios/pull/332
>>
>>
>> On Tue, Aug 22, 2017 at 6:00 PM, Shazron  wrote:
>>
>>> Renamed board to 4.5.0, left Fil's issue and another that has a PR that
>>> is almost done review:
>>> https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=173
>>>
>>> On Tue, Aug 22, 2017 at 11:47 AM, Shazron  wrote:
>>>
 I'll get that in as the lone issue on the board.
 I'm also thinking this should be 4.5.0 instead of 4.4.1 because there is
 a new feature in there.

 On Tue, Aug 22, 2017 at 9:20 AM, Filip Maj  wrote:

> CB-12830 [1] is something that I think we should sneak in to the
> release, time permitting.
>
> [1] https://issues.apache.org/jira/browse/CB-12830
>
> On Sat, Aug 12, 2017 at 4:05 AM, Shazron  wrote:
> >  I do! yes 4.4.1
> >
> > On Aug 11, 2017 at 5:40 PM, julio cesar sanchez <
> jcesarmob...@gmail.com>
> > wrote:
> >
> >
> > You probably mean 4.4.1
> >
> > El 11 ago. 2017 3:37 p. m., "Steven Gill" 
> escribió:
> >
> > Yay!
> >
> > On Aug 11, 2017 12:19 PM, "Shazron"  wrote:
> >
> > Long overdue.
> >
> > The board is here:
> > https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=173
> >
> > Any issues in the left column that absolutely need to go in? If not I
> >
> > will
> >
> > punt them to the next release.
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>

>>>
>>

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer pull request #187: CB-12809: Google Play Blocke...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-file-transfer/pull/187


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer issue #187: CB-12809: Google Play Blocker: Unsa...

[filmaj]

Github user filmaj commented on the issue:

https://github.com/apache/cordova-plugin-file-transfer/pull/187
  
I think we also want to remove the stuff from the README around how 
`trustAllHosts` is supported on Android.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #590: CB-13145: Create playservices version prefere...

[audreyso]

Github user audreyso closed the pull request at:

https://github.com/apache/cordova-lib/pull/590


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-coho pull request #157: Fixed/revised tools-release-process.md

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-coho/pull/157


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-js pull request #148: CB-13232: added test for cordova's unique loca...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-js/pull/148


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-coho pull request #157: Fixed/revised tools-release-process.md

[audreyso]

GitHub user audreyso opened a pull request:

https://github.com/apache/cordova-coho/pull/157

Fixed/revised tools-release-process.md



### Platforms affected


### What does this PR do?
Fixed/revised tools-release-process.md

### What testing has been done on this change?


### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [X] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/audreyso/cordova-coho update-release-doc

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-coho/pull/157.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #157


commit 76bcbb2dface9c4d85dcd5c00ffd376bed6373ca
Author: Audrey So 
Date:   2017-08-31T17:35:04Z

: fixed tools-release-process.md




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] cordova-ios 4.1.1 Release

[Shazron]

Stalled on testing and fixing https://github.com/apache/cordova-ios/pull/335
before a release can be sent for vote

On Thu, Aug 24, 2017 at 4:12 PM, Shazron  wrote:

> Issues on the board have been completed, the PRs need review:
>
> Board:
> https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=173
>
> Pull requests:
> 1. https://github.com/apache/cordova-ios/pull/326
> 2. https://github.com/apache/cordova-ios/pull/331
> 3. https://github.com/apache/cordova-ios/pull/332
>
>
> On Tue, Aug 22, 2017 at 6:00 PM, Shazron  wrote:
>
>> Renamed board to 4.5.0, left Fil's issue and another that has a PR that
>> is almost done review:
>> https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=173
>>
>> On Tue, Aug 22, 2017 at 11:47 AM, Shazron  wrote:
>>
>>> I'll get that in as the lone issue on the board.
>>> I'm also thinking this should be 4.5.0 instead of 4.4.1 because there is
>>> a new feature in there.
>>>
>>> On Tue, Aug 22, 2017 at 9:20 AM, Filip Maj  wrote:
>>>
 CB-12830 [1] is something that I think we should sneak in to the
 release, time permitting.

 [1] https://issues.apache.org/jira/browse/CB-12830

 On Sat, Aug 12, 2017 at 4:05 AM, Shazron  wrote:
 >  I do! yes 4.4.1
 >
 > On Aug 11, 2017 at 5:40 PM, julio cesar sanchez <
 jcesarmob...@gmail.com>
 > wrote:
 >
 >
 > You probably mean 4.4.1
 >
 > El 11 ago. 2017 3:37 p. m., "Steven Gill" 
 escribió:
 >
 > Yay!
 >
 > On Aug 11, 2017 12:19 PM, "Shazron"  wrote:
 >
 > Long overdue.
 >
 > The board is here:
 > https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=173
 >
 > Any issues in the left column that absolutely need to go in? If not I
 >
 > will
 >
 > punt them to the next release.

 -
 To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
 For additional commands, e-mail: dev-h...@cordova.apache.org


>>>
>>
>

[GitHub] cordova-js issue #148: CB-13232: added test for cordova's unquie local style...

[filmaj]

Github user filmaj commented on the issue:

https://github.com/apache/cordova-js/pull/148
  
Ah, this test clarifies the style _so much better_.

I know we've thrown the idea around to change this, but until we do, I 
think it may be worth documenting this. The README, in general, I think, needs 
updating.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org