Nightly build #492 for cordova has succeeded!

[Apache Jenkins Server]

Nightly build #492 for cordova has succeeded!
The latest nightly has been published and you can try it out with 'npm i -g 
cordova@nightly'

For details check build console at 
https://builds.apache.org/job/cordova-nightly/492/consoleFull

-
Jenkins for Apache Cordova

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [Vote] 4.5.1 iOS Release

[Simon MacDonald]

I vote +1:
* created a hello-world app and deployed to emulator/device
* attempted to add cordova-plugin-console to the app and it correctly was
rejected
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and subdependencies
have Apache-compatible licenses


Simon Mac Donald
http://simonmacdonald.com

On Thu, Sep 21, 2017 at 8:06 PM, Suraj Pindoria <
suraj.pindo...@yahoo.com.invalid> wrote:

> Please review and vote on this 4.5.1 iOS Release
> by replying to this email (and keep discussion on the DISCUSS thread)
>
> Release issue: https://issues.apache.org/jira/browse/CB-13310
>
> The archive has been published to dist/dev:
> https://dist.apache.org/repos/dist/dev/cordova/CB-13310
>
> The package was published from its corresponding git tag:
> cordova-ios: 4.5.1 (236b6fb10b)
>
> Note that you can test it out via:
>
> cordova platform add https://github.com/apache/cordova-ios#4.5.1
>
> Upon a successful vote I will upload the archive to dist/, publish it to
> npm, and post the blog post.
>
> Voting guidelines: https://github.com/apache/
> cordova-coho/blob/master/docs/release-voting.md
>
> Voting will go on for a minimum of 48 hours.
>
> I vote +1:
> * created a hello-world app and deployed to emulator/device
> * Ran coho audit-license-headers over the relevant repos
> * Ran coho check-license to ensure all dependencies and subdependencies
> have Apache-compatible licenses
> * Ensured continuous build was green when repo was tagged

[Vote] 4.5.1 iOS Release

[Suraj Pindoria]

Please review and vote on this 4.5.1 iOS Release
by replying to this email (and keep discussion on the DISCUSS thread)

Release issue: https://issues.apache.org/jira/browse/CB-13310

The archive has been published to dist/dev:
https://dist.apache.org/repos/dist/dev/cordova/CB-13310

The package was published from its corresponding git tag:
cordova-ios: 4.5.1 (236b6fb10b)

Note that you can test it out via:

cordova platform add https://github.com/apache/cordova-ios#4.5.1

Upon a successful vote I will upload the archive to dist/, publish it to npm, 
and post the blog post.

Voting guidelines: 
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md

Voting will go on for a minimum of 48 hours.

I vote +1:
* created a hello-world app and deployed to emulator/device
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and subdependencies have 
Apache-compatible licenses
* Ensured continuous build was green when repo was tagged

[GitHub] cordova-lib pull request #594: CB-13288 : updated index.js and test to fix c...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/594


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-osx pull request #41: CB-13304: forward non file:// URLs to system

[albertolalama]

Github user albertolalama closed the pull request at:

https://github.com/apache/cordova-osx/pull/41


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-osx issue #41: CB-13304: forward non file:// URLs to system

[albertolalama]

Github user albertolalama commented on the issue:

https://github.com/apache/cordova-osx/pull/41
  
@tripodsan I tried using `allow-navigation` and `allow-intent` as per your 
suggestion. Unfortunately, I was not able to get it to open URLs externally.

I have submitted #42 for your consideration. Thanks!


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-osx pull request #42: CB-13304: expose preference to control WebView...

[albertolalama]

GitHub user albertolalama opened a pull request:

https://github.com/apache/cordova-osx/pull/42

CB-13304: expose preference to control WebView navigation



### Platforms affected
OSX

### What does this PR do?
Exposes a preference in config.xml, `AllowWebViewNavigation`,  to control 
navigation in the application's main WebView. If set to true (default), all URL 
requests are handled in-app; otherwise, forwards non file:// URL requests to 
the system instead of opening them inside the application.

This is a follow-up to #41.

### What testing has been done on this change?
Tested locally.

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/uProxy/cordova-osx alalama-allow-navigation

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-osx/pull/42.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #42


commit 0563f0d9ef03944f93fb7a52e80dcc3eed00adcf
Author: alberto lalama 
Date:   2017-09-21T19:24:40Z

CB-13304: expose preference to control WebView navigation




---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser issue #219: [CB-9148] (android) add setType() me...

[infil00p]

Github user infil00p commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/219
  
Agree with @jcesarmobile, this should have a new JIRA associated with this 
issue.


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request #201: (Android) Implement Download ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/201


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser issue #221: CB-12834: (android) Fix bug when ope...

[infil00p]

Github user infil00p commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/221
  
CRAP, this was a typo.  @RafaelKr can you re-open this one? I meant to 
close #201 


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request #221: CB-12834: (android) Fix bug w...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/221


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-statusbar issue #85: CB-13273: fix statusbar spacing with new...

[DavidRyu123]

Github user DavidRyu123 commented on the issue:

https://github.com/apache/cordova-plugin-statusbar/pull/85
  
With a combination of wkwebview and "viewport-fit=cover", the white area 
issue has gone. It made some pages bounce, so I should remove 'position: 
absolute' in my css. Thanks for help, folks!


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser issue #185: iOS friendlier UI

[infil00p]

Github user infil00p commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/185
  
Can you create JIRA issue to correspond to this PR? That's one of the 
things that is holding up this PR.


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request #172: [CB-5758] (android/iOS) Possi...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/172


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser issue #173: Add property enablepictureinpicture ...

[infil00p]

Github user infil00p commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/173
  
Can you add  a JIRA issue to this PR? Thanks! 


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser issue #172: [CB-5758] (android/iOS) Possibility ...

[infil00p]

Github user infil00p commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/172
  
Please re-do this PR, and please don't change the plugin.xml to be based on 
your repository.  There are too much history dragged in from the repo to accept 
this PR as-is.


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser issue #166: Fix for - Stretched tool-bar icons

[infil00p]

Github user infil00p commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/166
  
Agreed, this does look weird, but should we be hard coding this, or is 
there a better solution for this? (i.e. resizing the buttons)


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser issue #165: Enable thirdparty cookies on >=Andro...

[infil00p]

Github user infil00p commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/165
  
This needs a JIRA issue attached to it.  I don't see any conflicts, however.


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser issue #159: Adding more configuration options fo...

[infil00p]

Github user infil00p commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/159
  
There's no proposal in the cordova repo, nor is there a JIRA issue 
regarding this feature addition.  There needs to be these things before we can 
add this API change to the plugin.  That, and the conflicts with README due to 
the docs being updated are what's holding this PR back.


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser issue #156: send back loaderror when "show" fail...

[infil00p]

Github user infil00p commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/156
  
Closing this issue, since it should be sending the error as a plugin result 
on the Callback instead of sending a random JSON object.


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request #156: send back loaderror when "sho...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/156


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser issue #122: Added Android cookie sharing functio...

[infil00p]

Github user infil00p commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/122
  
So, is this functionality not working? It would help if there was a JIRA 
issue attached to this PR.  I don't see XWalk functionality being a huge issue 
since XWalk is no longer being maintained.  Because of that, it's more likely 
this will get pulled in.  However, it'd be helpful if someone could tell me if 
this actually works before I get around to testing it.


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request #116: Added support for file:/// ac...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/116


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser issue #116: Added support for file:/// access

[infil00p]

Github user infil00p commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/116
  
Closing this PR as abandoned, since it's been over a year since @shazron 
last checked in on this.


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser issue #115: Support for passing request headers ...

[infil00p]

Github user infil00p commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/115
  
This is an API change and should be discussed on the list, or at the very 
least have a JIRA issue attached to it.  Also, the conflicts are definitely 
going to prevent this from getting merged as-is.


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser issue #111: give the ability to trust a certific...

[infil00p]

Github user infil00p commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/111
  
This has the following wrong with it:
1. You changed the package.json
2. You don't have a JIRA issue attached to this
3. There are other conflicts with the current InAppBrowser code.

If you are still interested in contributing, please fix these issues, and 
we can then take a look at this.


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser issue #99: inAppBrowser custom application schem...

[infil00p]

Github user infil00p commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/99
  
The code changes in iOS are delaying this.  That being said, I don't know 
if blindly adding Application URIs in an InAppBrowser is a good idea in this 
case.


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser issue #88: CB-3750: Add loading spinner for andr...

[infil00p]

Github user infil00p commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/88
  
This still needs to merge cleanly to be added.  Please fix all the 
conflicts to add this code if you are still interested in adding this PR.


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser issue #87: CB-8552 Add toolbar option for androi...

[infil00p]

Github user infil00p commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/87
  
@cjpearson Are you still interested in contributing this? Can you fix the 
merge conflicts in this PR? Thanks


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request #77: Android enhancements

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/77


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser issue #77: Android enhancements

[infil00p]

Github user infil00p commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/77
  
You can't change the name of the plugin.  This code is also old and 
conflicts with the repo, so this PR will be closed.


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request #73: Added editablelocation option ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/73


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser issue #73: Added editablelocation option for and...

[infil00p]

Github user infil00p commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/73
  
This is a Won't Fix because you aren't supposed to be able to change the 
URI on the Address Bar of the InAppBrowser.  Closing because this is a "Won't 
Fix" and because this has conflicts and is old.


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request #62: Send 'Activity not found' as a...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/62


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser issue #62: Send 'Activity not found' as an error...

[infil00p]

Github user infil00p commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/62
  
Closing this PR since it's got too many random commits on it as @clelland 
has mentioned earlier.


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-statusbar issue #85: CB-13273: fix statusbar spacing with new...

[kbrin423]

Github user kbrin423 commented on the issue:

https://github.com/apache/cordova-plugin-statusbar/pull/85
  
After applying "viewport-fit=cover", my caret position in textarea is not 
good because textarea moved. If I scroll my caret position change 


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-statusbar issue #85: CB-13273: fix statusbar spacing with new...

[smanuel]

Github user smanuel commented on the issue:

https://github.com/apache/cordova-plugin-statusbar/pull/85
  
@mhartington this works as a charm on iPhone X but now on iPhone 8 the 
statusbar doesn't overlay the webview because frame.origin.y is 20


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-statusbar issue #85: CB-13273: fix statusbar spacing with new...

[DavidRyu123]

Github user DavidRyu123 commented on the issue:

https://github.com/apache/cordova-plugin-statusbar/pull/85
  
@mhartington Thanks for your contribution Mike.
I wonder if there is anyone who are experiencing that ion-input text moved 
20px to top after applying "viewport-fit=cover"


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request #286: CB-13307: (Android) Fixed issue whe...

[DavidBriglio]

GitHub user DavidBriglio opened a pull request:

https://github.com/apache/cordova-plugin-camera/pull/286

CB-13307: (Android) Fixed issue when unable to load image with mime t…

…ype "image/*", and failing to recognize new contentprovider uri 
authority.

### Platforms affected
Android

### What does this PR do?
Allows for image mimetype "image/*" to be accepted as a valid image.
Allows for google photos uri authority ".contentprovider" to be recognized.

### What testing has been done on this change?
When running "npm test" results in "invalid config loglevel='notice'".
When running "npm run test-build" results in "missing script: test-build".
Manual testing has been done on Android 8.0 Google Pixel with cordova cli 
6.5.0.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/DavidBriglio/cordova-plugin-camera 
CB-13307-cordova-plugin-camera-MimeType-ContentProvider

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-camera/pull/286.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #286


commit 0d0116a3ed0b593253d96cfdd705e849b4ebca61
Author: David Briglio 
Date:   2017-09-21T13:49:47Z

CB-13307: (Android) Fixed issue when unable to load image with mime type 
"image/*", and failing to recognize new contentprovider uri authority.




---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request #285: CB-13307: (Android) Fixed issue whe...

[DavidBriglio]

Github user DavidBriglio closed the pull request at:

https://github.com/apache/cordova-plugin-camera/pull/285


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request #285: CB-13307: (Android) Fixed issue whe...

[DavidBriglio]

GitHub user DavidBriglio opened a pull request:

https://github.com/apache/cordova-plugin-camera/pull/285

CB-13307: (Android) Fixed issue when unable to load image with mime t…

…ype "image/*", and failing to recognize new contentprovider uri 
authority.

### Platforms affected
Android

### What does this PR do?
Allows for image mimetype "image/*" to be accepted as a valid image.
Allows for google photos uri authority ".contentprovider" to be recognized.

### What testing has been done on this change?
When running "npm test" results in "invalid config loglevel='notice'".
When running "npm run test-build" results in "missing script: test-build".
Manual testing has been done on Android 8.0 Google Pixel with cordova cli 
6.5.0.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/DavidBriglio/cordova-plugin-camera 
CB-13307-MimeType-ContentProvider

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-camera/pull/285.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #285


commit 886ada803730c045e386ff3b643b0db8f4731277
Author: David Briglio 
Date:   2017-09-21T13:38:07Z

CB-13307: (Android) Fixed issue when unable to load image with mime type 
"image/*", and failing to recognize new contentprovider uri authority.




---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-statusbar issue #85: CB-13273: fix statusbar spacing with new...

[mhartington]

Github user mhartington commented on the issue:

https://github.com/apache/cordova-plugin-statusbar/pull/85
  
This pr does not address everything. In order to have full iPhoneX support 
you need the following


1) `viewport-fit=cover` added to your meta tag, this will tell the webview 
to use the full screen real estate 
2) A launch storyboard image for your splashscreen. This is a single 
2732x2732 image that will be cropped to fix different screen sizes. An example 
project can be found here.

https://github.com/kerrishotts/lsb-example-simple


What this PR _DOES_ is address a sizing issue for the statusbar plugin. 
Since it was hardcoded to 20px, it would create a small gap when you used 
viewport-fit and the storyboard image.

![simulator screen shot - iphone x - 2017-09-13 at 16 53 
55](https://user-images.githubusercontent.com/2835826/30698716-be64293a-9eb0-11e7-944d-79f434f247f5.png)


But applying this fix, along with the others, you can remove that gap.
![simulator screen shot - iphone x - 2017-09-18 at 12 42 
54](https://user-images.githubusercontent.com/2835826/30698788-fa3da8be-9eb0-11e7-9d44-21edc2689478.png)



---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-statusbar issue #85: CB-13273: fix statusbar spacing with new...

[DavidRyu123]

Github user DavidRyu123 commented on the issue:

https://github.com/apache/cordova-plugin-statusbar/pull/85
  
I have tried both solutions and found out those render some weird behavior 
in view. So kinda waiting for an update. @dpa99c @thefolenangel


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-statusbar issue #85: CB-13273: fix statusbar spacing with new...

[thefolenangel]

Github user thefolenangel commented on the issue:

https://github.com/apache/cordova-plugin-statusbar/pull/85
  
@dpa99c I have applied that "fix" and now my app's view can be scrolled, 
which makes the buttons that I have fixed to bottom:0px, go up with about 
10-15px, and shows my background, ideas?

@DavidRyu123 , @AshHimself  has any of you tried to use WKWebView ? For me 
I manage to fit my content UNDER the status bar after applying the suggestion 
by @dpa99c , however I can scroll my controller, which has disallowOverscroll.


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer issue #178: CB-12745: Adding support for non ba...

[Viras-]

Github user Viras- commented on the issue:

https://github.com/apache/cordova-plugin-file-transfer/pull/178
  
Are there any intentions on merging this pull or should I do it myself 
directly?


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-statusbar issue #85: CB-13273: fix statusbar spacing with new...

[dpa99c]

Github user dpa99c commented on the issue:

https://github.com/apache/cordova-plugin-statusbar/pull/85
  
@DavidRyu123 To remove the white space set `viewport-fit=cover` on the 
viewport `` tag.
See https://stackoverflow.com/a/46232813/777265


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-statusbar issue #85: CB-13273: fix statusbar spacing with new...

[AshHimself]

Github user AshHimself commented on the issue:

https://github.com/apache/cordova-plugin-statusbar/pull/85
  
I also tried and it did not work either.

On Thu, Sep 21, 2017 at 9:07 PM, DavidRyu123 
wrote:

> I have tried this PR and there is still white space issue in iPhone 7 plus
> and under with iOS11 GM.
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> 
,
> or mute the thread
> 

> .
>



---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-statusbar issue #85: CB-13273: fix statusbar spacing with new...

[DavidRyu123]

Github user DavidRyu123 commented on the issue:

https://github.com/apache/cordova-plugin-statusbar/pull/85
  
I have tried this PR and there is still white space issue in iPhone 7 plus 
and under with iOS11 GM. 


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request #241: minor grammar fix

[jezmck]

GitHub user jezmck opened a pull request:

https://github.com/apache/cordova-plugin-inappbrowser/pull/241

minor grammar fix

(I'm hoping that the JIRA etc process is not necessary for this small tweak 
to the readme.)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jezmck/cordova-plugin-inappbrowser patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/241.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #241


commit d87004f60fbac711ab3aef5020dc33f358402d9e
Author: Jez McKean 
Date:   2017-09-21T12:25:14Z

minor grammar fix




---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-statusbar issue #85: CB-13273: fix statusbar spacing with new...

[thefolenangel]

Github user thefolenangel commented on the issue:

https://github.com/apache/cordova-plugin-statusbar/pull/85
  
what is the status of this pull?


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser issue #239: Enabling Appcache for the android we...

[janpio]

Github user janpio commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/239
  
No need to apologize, I was just curious what this does and if it would 
make sense to actually have this in the plugin for all users, maybe behind a 
configuration or option.


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser issue #239: Enabling Appcache for the android we...

[walisc]

Github user walisc commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/239
  
Hi @janpio and @janpio Apologies for this pull request. Was intended for my 
company's branch. We need to enable AppCaching for the inappbrowser as we serve 
our app remotely (for security reasons) yet we still want it be available 
offline . @janpio re:- limit, yes I agree with you. the second commit removed 
this limit. 


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org