Nightly build #496 for cordova has failed
Nightly build #496 for cordova has failed. Please check failure details on build details page at https://builds.apache.org/job/cordova-nightly/496/ You can also take a look at build console: https://builds.apache.org/job/cordova-nightly/496/consoleFull - Jenkins for Apache Cordova - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-js pull request #149: CB-12895 : added eslint to repo
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-js/pull/149#discussion_r140927739
--- Diff: package.json ---
@@ -15,6 +15,7 @@
"url": "https://issues.apache.org/jira/browse/CB";
},
"scripts": {
+"eslint": "eslint src test",
"test": "grunt test",
--- End diff --
can you add `npm run eslint` to the test script here
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-js pull request #149: CB-12895 : added eslint to repo
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-js/pull/149#discussion_r140927689
--- Diff: package.json ---
@@ -15,6 +15,7 @@
"url": "https://issues.apache.org/jira/browse/CB";
},
"scripts": {
+"eslint": "eslint src test",
--- End diff --
can you also get it to run on `pkg`
`"eslint src test pkg"`
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-js pull request #149: CB-12895 : added eslint to repo
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-js/pull/149 CB-12895 : added eslint to repo ### Platforms affected ### What does this PR do? Added eslint to repo ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-js CB-12895-eslint Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-js/pull/149.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #149 commit b26580bf5cf4705c19ee00783f462e8fc4d3c958 Author: Audrey So Date: 2017-09-25T21:06:08Z CB-12895 : added eslint to repo --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[Vote] 6.3.0 Android Release
Please review and vote on this 6.3.0 Android Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB- The archive has been published to dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB- The package was published from its corresponding git tag: cordova-android: 6.3.0 (021c9c19e8) Note that you can test it out via: cordova platform add https://github.com/apache/cordova-android#6.3.0 Upon a successful vote I will upload the archive to dist/, publish it to npm, and post the blog post. Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md Voting will go on for a minimum of 48 hours. I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses * Ran mobilespec on emulator and Google Pixel device * Ran Unit Tests from IDE * Ensured continuous build was green when repo was tagged
[GitHub] cordova-lib issue #558: CB-12766 Consistently write JSON with 2 spaces inden...
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-lib/pull/558 There is also https://issues.apache.org/jira/browse/CB-13009, they are similar, not sure if duplicated --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [Vote] 4.5.1 iOS Release
The vote has now closed. The results are: Positive Binding Votes: 3 Suraj PindoriaSimon MacDonaldShazron Abdullah The vote has passed. On Saturday, September 23, 2017, 8:10:06 PM PDT, Shazron wrote: I vote +1: * created a hello-world app and deployed to emulator (with new Xcode 9 iPhone targets) and device * attempted to add cordova-plugin-console to the app and it correctly was rejected * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses On Fri, Sep 22, 2017 at 9:10 AM, Simon MacDonald wrote: > I vote +1: > * created a hello-world app and deployed to emulator/device > * attempted to add cordova-plugin-console to the app and it correctly was > rejected > * Ran coho audit-license-headers over the relevant repos > * Ran coho check-license to ensure all dependencies and subdependencies > have Apache-compatible licenses > > > Simon Mac Donald > http://simonmacdonald.com > > On Thu, Sep 21, 2017 at 8:06 PM, Suraj Pindoria < > suraj.pindo...@yahoo.com.invalid> wrote: > > > Please review and vote on this 4.5.1 iOS Release > > by replying to this email (and keep discussion on the DISCUSS thread) > > > > Release issue: https://issues.apache.org/jira/browse/CB-13310 > > > > The archive has been published to dist/dev: > > https://dist.apache.org/repos/dist/dev/cordova/CB-13310 > > > > The package was published from its corresponding git tag: > > cordova-ios: 4.5.1 (236b6fb10b) > > > > Note that you can test it out via: > > > > cordova platform add https://github.com/apache/cordova-ios#4.5.1 > > > > Upon a successful vote I will upload the archive to dist/, publish it to > > npm, and post the blog post. > > > > Voting guidelines: https://github.com/apache/ > > cordova-coho/blob/master/docs/release-voting.md > > > > Voting will go on for a minimum of 48 hours. > > > > I vote +1: > > * created a hello-world app and deployed to emulator/device > > * Ran coho audit-license-headers over the relevant repos > > * Ran coho check-license to ensure all dependencies and subdependencies > > have Apache-compatible licenses > > * Ensured continuous build was green when repo was tagged >
Re: [GitHub] cordova-lib issue #558: CB-12766 Consistently write JSON with 2 spaces inden...,
,, On Tue, May 16, 2017 at 12:20 PM stevengill wrote: > Github user stevengill commented on the issue: > > https://github.com/apache/cordova-lib/pull/558 > > really good point. We should switch to two like npm. > > > --- > If your project is set up for it, you can reply to this email and have your > reply appear on GitHub as well. If your project does not have this feature > enabled and wishes so, or if the feature is enabled but not working, please > contact infrastructure at infrastruct...@apache.org or file a JIRA ticket > with INFRA. > --- > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > > -- Sorry for the brevity, Sent from Gmail Mobile
[GitHub] cordova-lib pull request #584: CB-12361 : added tests for plugin/save.js
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/584 --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib issue #558: CB-12766 Consistently write JSON with 2 spaces inden...
Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/558 here is an existing issue https://issues.apache.org/jira/browse/CB-12810 --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib issue #558: CB-12766 Consistently write JSON with 2 spaces inden...
Github user janpio commented on the issue: https://github.com/apache/cordova-lib/pull/558 @funkyvisions You might want to create a new issue for that instead of commenting on old ones. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib issue #558: CB-12766 Consistently write JSON with 2 spaces inden...
Github user funkyvisions commented on the issue: https://github.com/apache/cordova-lib/pull/558 I don't like that my original package.json and config.xml get overwritten. I manage them myself and have lots of comments in them to detail intricacies. I also group things together so that they make logical sense for me. How can I get cordova to not touch these files? I tried --nosave on prepare and "cordova config set autosave false". Let me know if there is a better place we can have this discussion. This is the only thread I found regarding the overwriting of the configuration files. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
