Nightly build #516 for cordova has failed

[Apache Jenkins Server]

Nightly build #516 for cordova has failed.

Please check failure details on build details page at 
https://builds.apache.org/job/cordova-nightly/516/
You can also take a look at build console: 
https://builds.apache.org/job/cordova-nightly/516/consoleFull

-
Jenkins for Apache Cordova

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[Vote] 5.0.1 Browser Release

[Steven Gill]

Please review and vote on this 5.0.1 Browser Release
by replying to this email (and keep discussion on the DISCUSS thread)

Release issue: https://issues.apache.org/jira/browse/CB-13444

The archive has been published to
dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-13444

The package was published from its corresponding git tag:
cordova-browser: 5.0.1 (d118ec8e30)

Note that you can test it out via:

cordova platform add https://github.com/apache/cordova-browser#5.0.1

Upon a successful vote I will upload the archive to dist/, publish it
to npm, and post the blog post.

Voting guidelines:
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md

Voting will go on for a minimum of 48 hours.

I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and
subdependencies have Apache-compatible licenses
* Ran npm test
* created hello world app

[GitHub] cordova-lib pull request #597: CB-13451 (all platforms) "pkg not defined" ex...

[OminousWater]

Github user OminousWater closed the pull request at:

https://github.com/apache/cordova-lib/pull/597


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib issue #597: CB-13451 (all platforms) "pkg not defined" exception...

[OminousWater]

Github user OminousWater commented on the issue:

https://github.com/apache/cordova-lib/pull/597
  
I see the CI has failed, because 'package' is a reserved keyword (this 
better explains the changes made as part of the js-lint pass a few months 
back). Perhaps the better fix, then, is to rename the variable in the plugman 
source; because that, too, would presumably fail a js-lint pass.


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #597: CB-13451 (all platforms) "pkg not defined" ex...

[OminousWater]

GitHub user OminousWater opened a pull request:

https://github.com/apache/cordova-lib/pull/597

CB-13451 (all platforms) "pkg not defined" exception when running plugman 
with createpackagejson command-line

A global js-lint pass on the cordova-lib codebase on the 30/8/2017 caused 
references to the global 'package' variable in init-default.js to be renamed to 
'pkg’, presumably because the cordova-lib source doesn’t declare a global 
variable called ‘package’ but _does_ declare a global variable called 
‘pkg’ (in src/cordova/info.js). However in this case, the ‘package’ 
variable refers to the one declared in the plugman source, specifically 
main.js, so it should have stayed as 'package’. To test the fix, run:

plugman createpackagejson .

Without the fix, this will trigger the following exception: 'pkg is not 
defined'. Having patched in the fix, running the command line should work as 
expected, prompting the user with questions and then spitting out a 
package.json file.



### Platforms affected
All

### What does this PR do?
Fixes an bug where an exception would be thrown when running 'plugman 
createpackagejson .'

### What testing has been done on this change?
The command in question ('plugman createpackagejson .') has been tested 
with and without the fix to confirm that the fix fixes the problem.

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/OminousWater/cordova-lib master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/597.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #597


commit e321bc319b94c86b77d993981491f99bac6f27f9
Author: Roland 
Date:   2017-10-16T20:57:59Z

Fix for 'pkg is not defined' exception
A global js-lint pass on the cordova-lib codebase on the 30/8/2017 caused 
references to the global 'package' variable in init-default.js to be renamed to 
'pkg’, presumably because the cordova-lib source doesn’t declare a global 
variable called ‘package’ but _does_ declare a global variable called 
‘pkg’ (in cordova/info.js). However in this case, the ‘package’ 
variable refers to the one declared in the plugman source, specifically 
main.js, so it should have stayed as 'package’. To test the fix, run:

plugman createpackagejson .

Without the fix, this will trigger the following exception: 'pkg is not 
defined'. Having patched in the fix, running the command line should work as 
expected, prompting the user with questions and then spitting out a 
package.json file.




---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Cordova iOS 4.5.2 Release

[Suraj Pindoria]

Whenever someone has time, if you could please review the blog post for
this release:

https://github.com/apache/cordova-docs/pull/750

On Tue, Oct 3, 2017 at 7:55 PM, Suraj Pindoria 
wrote:

> We just did a release a few weeks ago but there were some other iOS 11 /
> Xcode 9 issues that came up shorty afterwards. That particular issue has
> been resolved and is already merged in to master.
>
> https://issues.apache.org/jira/browse/CB-13315
>
> I'd also like to include another that updates the icon mapping so we
> properly handle the new devices as well as Apple Watch icons.
>
> https://issues.apache.org/jira/browse/CB-12896
>
> Is there anything else people are aware of that should be apart of this
> next release?
>

Re: Intro

[Kelvin Dart]

Perfect - thanks so much Simon, that list is useful. I will get cracking on
those this week, and update back here when done.

Kelvin


Best regards,
Kelvin

On 14 October 2017 at 21:15, Simon MacDonald 
wrote:

> Hey Kelvin,
>
> Yeah, it should be a pretty easy change especially after you do it the
> first time. It's certainly something that is on my to do list before the
> end of the year but if you could handle it, that would be amazing. Here is
> a list of cordova plugins that use compat.
>
> cordova-plugin-camera
> cordova-plugin-contacts
> cordova-plugin-file
> cordova-plugin-file-transfer
> cordova-plugin-geolocation
> cordova-plugin-media
> cordova-plugin-media-capture
>
> Then all of those plugins should get a major version bump.
>
> Thanks…
>
> Simon Mac Donald
> http://simonmacdonald.com
>
> On Thu, Oct 12, 2017 at 11:35 AM, Kelvin Dart 
> wrote:
>
> > Thanks Simon. Is there a list of plugins which currently use it? I am
> happy
> > to spend some time to make these changes and test them?
> >
> > cordova-plugin-file is the only one I noticed so far as it's the only one
> > flagged in one of my projects. If not, I will do a search.
> >
> > Kelvin
> >
> >
> > Best regards,
> > Kelvin
> >
> > On 12 October 2017 at 16:30, Simon MacDonald 
> > wrote:
> >
> > > Sounds great Kelvin. There are a number of plugins we need to do this
> > > on and bump them to a new version.
> > >
> > > Simon Mac Donald
> > > http://simonmacdonald.com
> > >
> > >
> > > On Thu, Oct 12, 2017 at 4:59 AM, Kelvin Dart 
> > > wrote:
> > > > Hi all,
> > > >
> > > > I am looking at submitting my first PR to cordova-plugin-file hence
> > > subscribing to the dev mailing list, and introducing myself.
> > > >
> > > > I’m on Twitter and Slack both as @kelvindart and used Cordova since
> the
> > > very early days (1.5.0, when it was downloaded as a zip file), and met
> a
> > > few of the guys at a number of PGDay EU days in AMS. Now using it with
> > > Ionic and starting to give back to the community which helped me so
> much.
> > > >
> > > > Anyway, first PR will be to remove the cordova-plugin-compat
> dependency
> > > from cordova-plugin-file now it is baked into the platform. Something
> > > discussed with @filmaj on Slack.
> > > >
> > > > Kelvin
> > > > 
> -
> > > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > > > For additional commands, e-mail: dev-h...@cordova.apache.org
> > > >
> > >
> > > -
> > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > > For additional commands, e-mail: dev-h...@cordova.apache.org
> > >
> > >
> >
>