Nightly build #519 for cordova has failed

2017-10-19 Thread Apache Jenkins Server
Nightly build #519 for cordova has failed.

Please check failure details on build details page at 
https://builds.apache.org/job/cordova-nightly/519/
You can also take a look at build console: 
https://builds.apache.org/job/cordova-nightly/519/consoleFull

-
Jenkins for Apache Cordova

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib issue #597: CB-13451 (all platforms) "pkg not defined" exception...

2017-10-19 Thread stevengill
Github user stevengill commented on the issue:

https://github.com/apache/cordova-lib/pull/597
  
Thanks for all your work on this @OminousWater! 


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[ANNOUNCE] Cordova-Browser@5.0.1 Released

2017-10-19 Thread Steven Gill
Blog: https://cordova.apache.org/news/2017/10/19/browser-release.html
Tweet: https://twitter.com/apachecordova/status/921149906827411456


[GitHub] cordova-lib issue #597: CB-13451 (all platforms) "pkg not defined" exception...

2017-10-19 Thread OminousWater
Github user OminousWater commented on the issue:

https://github.com/apache/cordova-lib/pull/597
  
@stevengill I've been trying that as alternative solution, however it seems 
eslint doesn't support exceptions for parser errors. See their response to the 
issue I lodged here after a fair bit of fruitless experimentation with eslint 
exclude rules: https://github.com/eslint/eslint/issues/9483


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-lib pull request #598: CB-13123 : plugin add should use cordovaDepen...

2017-10-19 Thread audreyso
GitHub user audreyso opened a pull request:

https://github.com/apache/cordova-lib/pull/598

CB-13123 : plugin add should use cordovaDependency instead

of plugin.xml engine tag



### Platforms affected


### What does this PR do?
plugin add/ install should use cordovaDependency instead of plugin.xml 
engine tag

### What testing has been done on this change?


### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [X] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/audreyso/cordova-lib CB-13123

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/598.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #598


commit 5d6ad4a3dc4ed41b87140fcd9cf83d359b6fb798
Author: Audrey So 
Date:   2017-10-18T20:47:00Z

CB-13123 : plugin add/ install should use cordovaDependency instead of 
plugin.xml engine tag




---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: [Vote] 5.0.1 Browser Release

2017-10-19 Thread Steven Gill
The vote has now closed. The results are:

Positive Binding Votes: 4

Steve Gill
Audrey So
Suraj Pindoria
Jesse MacFadyen

The vote has passed.


On Thu, Oct 19, 2017 at 3:00 PM, Jesse  wrote:

> +1
>
> * Ran npm test, all green
> * Ran coho verify-archive
> * cordova platform add
> /repos/cordova/cordova-dist-dev/CB-13444/cordova-browser-5.0.1.tgz
>
>
> @purplecabbage
> risingj.com
>
> On Thu, Oct 19, 2017 at 1:40 PM, Suraj Pindoria 
> wrote:
>
> > +1
> >
> > * Ran npm test, all green
> > * Ran coho audit-license-headers
> > * Ran coho check-license
> > * Created hello-world and launched in browser
> >
> >
> > On Tue, Oct 17, 2017 at 9:53 AM, Audrey So 
> wrote:
> >
> > > I vote +1:
> > > * Ran npm test (passed)
> > > * Created hello world app
> > > * Ran coho audit-license-headers
> > > * Ran coho check-license
> > >
> > >
> > >
> > >
> > > - Audrey
> > >
> > > On 10/16/17, 3:51 PM, "Steven Gill"  wrote:
> > >
> > > >Please review and vote on this 5.0.1 Browser Release
> > > >by replying to this email (and keep discussion on the DISCUSS thread)
> > > >
> > > >Release issue: https://na01.safelinks.protection.outlook.com/?url=
> > > https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FCB-
> > > 13444=02%7C01%7C%7Cf73f8a55d86e437282d008d514e8700b%
> > > 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636437910917880753=
> > > PM0qviF2ORF7uqFz5ceBC8JrqChVkuVgeL8B%2BGIbIpk%3D=0
> > > >
> > > >The archive has been published to
> > > >dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-13444
> > > >
> > > >The package was published from its corresponding git tag:
> > > >cordova-browser: 5.0.1 (d118ec8e30)
> > > >
> > > >Note that you can test it out via:
> > > >
> > > >cordova platform add https://na01.safelinks.
> > > protection.outlook.com/?url=https%3A%2F%2Fgithub.com%
> > > 2Fapache%2Fcordova-browser%235.0.1=02%7C01%7C%
> > > 7Cf73f8a55d86e437282d008d514e8700b%7Cfa7b1b5a7b34438794aed2c178de
> > > cee1%7C0%7C0%7C636437910917880753=pviRi91ZjCA8t4T9W%
> > > 2FUth5bqpfNegyWp89c0FQXMkkQ%3D=0
> > > >
> > > >Upon a successful vote I will upload the archive to dist/, publish it
> > > >to npm, and post the blog post.
> > > >
> > > >Voting guidelines:
> > > >https://na01.safelinks.protection.outlook.com/?url=
> > > https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-coho%
> 2Fblob%2Fmaster%2Fdocs%
> > > 2Frelease-voting.md=02%7C01%7C%7Cf73f8a55d86e437282d008d514e8
> 700b%
> > > 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%
> 7C636437910917880753=T%
> > > 2F9u194OLhUAeWVPXtBUdbU2h%2FLeicECOaKAM6Tkfck%3D=0
> > > >
> > > >Voting will go on for a minimum of 48 hours.
> > > >
> > > >I vote +1:
> > > >* Ran coho audit-license-headers over the relevant repos
> > > >* Ran coho check-license to ensure all dependencies and
> > > >subdependencies have Apache-compatible licenses
> > > >* Ran npm test
> > > >* created hello world app
> > >
> > > -
> > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > > For additional commands, e-mail: dev-h...@cordova.apache.org
> > >
> >
>


Re: [Vote] 5.0.1 Browser Release

2017-10-19 Thread Jesse
+1

* Ran npm test, all green
* Ran coho verify-archive
* cordova platform add
/repos/cordova/cordova-dist-dev/CB-13444/cordova-browser-5.0.1.tgz


@purplecabbage
risingj.com

On Thu, Oct 19, 2017 at 1:40 PM, Suraj Pindoria 
wrote:

> +1
>
> * Ran npm test, all green
> * Ran coho audit-license-headers
> * Ran coho check-license
> * Created hello-world and launched in browser
>
>
> On Tue, Oct 17, 2017 at 9:53 AM, Audrey So  wrote:
>
> > I vote +1:
> > * Ran npm test (passed)
> > * Created hello world app
> > * Ran coho audit-license-headers
> > * Ran coho check-license
> >
> >
> >
> >
> > - Audrey
> >
> > On 10/16/17, 3:51 PM, "Steven Gill"  wrote:
> >
> > >Please review and vote on this 5.0.1 Browser Release
> > >by replying to this email (and keep discussion on the DISCUSS thread)
> > >
> > >Release issue: https://na01.safelinks.protection.outlook.com/?url=
> > https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FCB-
> > 13444=02%7C01%7C%7Cf73f8a55d86e437282d008d514e8700b%
> > 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636437910917880753=
> > PM0qviF2ORF7uqFz5ceBC8JrqChVkuVgeL8B%2BGIbIpk%3D=0
> > >
> > >The archive has been published to
> > >dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-13444
> > >
> > >The package was published from its corresponding git tag:
> > >cordova-browser: 5.0.1 (d118ec8e30)
> > >
> > >Note that you can test it out via:
> > >
> > >cordova platform add https://na01.safelinks.
> > protection.outlook.com/?url=https%3A%2F%2Fgithub.com%
> > 2Fapache%2Fcordova-browser%235.0.1=02%7C01%7C%
> > 7Cf73f8a55d86e437282d008d514e8700b%7Cfa7b1b5a7b34438794aed2c178de
> > cee1%7C0%7C0%7C636437910917880753=pviRi91ZjCA8t4T9W%
> > 2FUth5bqpfNegyWp89c0FQXMkkQ%3D=0
> > >
> > >Upon a successful vote I will upload the archive to dist/, publish it
> > >to npm, and post the blog post.
> > >
> > >Voting guidelines:
> > >https://na01.safelinks.protection.outlook.com/?url=
> > https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-coho%2Fblob%2Fmaster%2Fdocs%
> > 2Frelease-voting.md=02%7C01%7C%7Cf73f8a55d86e437282d008d514e8700b%
> > 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636437910917880753=T%
> > 2F9u194OLhUAeWVPXtBUdbU2h%2FLeicECOaKAM6Tkfck%3D=0
> > >
> > >Voting will go on for a minimum of 48 hours.
> > >
> > >I vote +1:
> > >* Ran coho audit-license-headers over the relevant repos
> > >* Ran coho check-license to ensure all dependencies and
> > >subdependencies have Apache-compatible licenses
> > >* Ran npm test
> > >* created hello world app
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
>


Re: [Vote] 5.0.1 Browser Release

2017-10-19 Thread Suraj Pindoria
+1

* Ran npm test, all green
* Ran coho audit-license-headers
* Ran coho check-license
* Created hello-world and launched in browser


On Tue, Oct 17, 2017 at 9:53 AM, Audrey So  wrote:

> I vote +1:
> * Ran npm test (passed)
> * Created hello world app
> * Ran coho audit-license-headers
> * Ran coho check-license
>
>
>
>
> - Audrey
>
> On 10/16/17, 3:51 PM, "Steven Gill"  wrote:
>
> >Please review and vote on this 5.0.1 Browser Release
> >by replying to this email (and keep discussion on the DISCUSS thread)
> >
> >Release issue: https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FCB-
> 13444=02%7C01%7C%7Cf73f8a55d86e437282d008d514e8700b%
> 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636437910917880753=
> PM0qviF2ORF7uqFz5ceBC8JrqChVkuVgeL8B%2BGIbIpk%3D=0
> >
> >The archive has been published to
> >dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-13444
> >
> >The package was published from its corresponding git tag:
> >cordova-browser: 5.0.1 (d118ec8e30)
> >
> >Note that you can test it out via:
> >
> >cordova platform add https://na01.safelinks.
> protection.outlook.com/?url=https%3A%2F%2Fgithub.com%
> 2Fapache%2Fcordova-browser%235.0.1=02%7C01%7C%
> 7Cf73f8a55d86e437282d008d514e8700b%7Cfa7b1b5a7b34438794aed2c178de
> cee1%7C0%7C0%7C636437910917880753=pviRi91ZjCA8t4T9W%
> 2FUth5bqpfNegyWp89c0FQXMkkQ%3D=0
> >
> >Upon a successful vote I will upload the archive to dist/, publish it
> >to npm, and post the blog post.
> >
> >Voting guidelines:
> >https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-coho%2Fblob%2Fmaster%2Fdocs%
> 2Frelease-voting.md=02%7C01%7C%7Cf73f8a55d86e437282d008d514e8700b%
> 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636437910917880753=T%
> 2F9u194OLhUAeWVPXtBUdbU2h%2FLeicECOaKAM6Tkfck%3D=0
> >
> >Voting will go on for a minimum of 48 hours.
> >
> >I vote +1:
> >* Ran coho audit-license-headers over the relevant repos
> >* Ran coho check-license to ensure all dependencies and
> >subdependencies have Apache-compatible licenses
> >* Ran npm test
> >* created hello world app
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>


Re: [DISCUSS] Browser@5.0.1 release

2017-10-19 Thread Steven Gill
Please review the blog post. https://github.com/apache/cordova-docs/pull/751

Also, I need one more vote for the browser release to wrap it up

On Sun, Oct 15, 2017 at 4:40 PM, Steven Gill  wrote:

> Sent a PR for a issue with the merges directory not working with the
> latest browser. Please review. https://github.com/
> apache/cordova-browser/pull/46
>
> On Fri, Oct 13, 2017 at 4:05 PM, Steven Gill 
> wrote:
>
>> I'm going to do a browser release to fix https://issues.apache.org/
>> jira/browse/CB-13228.
>>
>> Let me know if anything else should go in.
>>
>
>