Nightly build #520 for cordova has succeeded!

[Apache Jenkins Server]

Nightly build #520 for cordova has succeeded!
The latest nightly has been published and you can try it out with 'npm i -g 
cordova@nightly'

For details check build console at 
https://builds.apache.org/job/cordova-nightly/520/consoleFull

-
Jenkins for Apache Cordova

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #600: CB-13478 : Fix CRLF line endings and lint int...

[akdor1154]

GitHub user akdor1154 opened a pull request:

https://github.com/apache/cordova-lib/pull/600

CB-13478 : Fix CRLF line endings and lint integration tests.



### Platforms affected
N/A

### What does this PR do?
- Change CRLFs to LFs
- Configures eslint to whinge in future if CRLFs sneak back in
- Adds gitattributes to prevent this in future
- Adds integration-tests to the eslint script, and fixes lint errors it 
found in there (mainly line endings).

### What testing has been done on this change?
`npm run eslint`


### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/akdor1154/cordova-lib lf

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/600.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #600


commit 87ec94735455976130e2ec0dcaa0d2d72b2995de
Author: Jarrad Whitaker 
Date:   2017-10-21T00:25:36Z

eslint and gitattributes to ensure LF

commit 878c5ce45523223f3fe1c1b731367c66f87b7dcb
Author: Jarrad Whitaker 
Date:   2017-10-21T00:27:01Z

crlf -> lf with eslint

commit ce8157585db744bce82cd6f1b5224f58aa948f68
Author: Jarrad Whitaker 
Date:   2017-10-21T00:29:29Z

lint integration tests too

commit 4a5ce48dd0c7ded0429e3655c2ec0eb4e58bb2f2
Author: Jarrad Whitaker 
Date:   2017-10-21T00:32:26Z

crlf -> lf in integration tests

commit 4c6ef8a98c9147a992c70ed015fe5eed28be944e
Author: Jarrad Whitaker 
Date:   2017-10-21T00:33:27Z

eslint --fix in integration-tests

commit afee24c3e6ffe3c65015abd6180aee464434ce76
Author: Jarrad Whitaker 
Date:   2017-10-21T00:34:37Z

eqeqeq in HooksRunner




---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib issue #597: CB-13451 (all platforms) "pkg not defined" exception...

[stevengill]

Github user stevengill commented on the issue:

https://github.com/apache/cordova-lib/pull/597
  
merged! Thanks again @OminousWater!


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #597: CB-13451 (all platforms) "pkg not defined" ex...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/597


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib issue #597: CB-13451 (all platforms) "pkg not defined" exception...

[stevengill]

Github user stevengill commented on the issue:

https://github.com/apache/cordova-lib/pull/597
  
No worries @OminousWater! That is what reviews are for :)

CI gets trigged with new commits or updated commits. Looks like your PR 
triggered it. I'll wait and see how they go


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib issue #597: CB-13451 (all platforms) "pkg not defined" exception...

[OminousWater]

Github user OminousWater commented on the issue:

https://github.com/apache/cordova-lib/pull/597
  
Thanks for picking up on those problems -- how embarrassing! The lines 
removed from .eslintignore was a complete mistake on my part, thank you for 
spotting that. I've re-instated those lines, and revised the glob patterns at 
the same time, as the ones that were there didn't seem to be doing what they 
were intended to, with the latest version of eslint. I also removed the 
now-redundant eslint directives from init-default.js. Do you know how I can 
trigger another Continous Integration run on the server to check everything's 
good?


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #599: CB-13463 : prevent package.json update with -...

[audreyso]

GitHub user audreyso opened a pull request:

https://github.com/apache/cordova-lib/pull/599

CB-13463 : prevent package.json update with --nosave (for plugins)



### Platforms affected


### What does this PR do?
 
Prevent package.json update with --nosave (for plugins)

### What testing has been done on this change?


### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [X] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/audreyso/cordova-lib CB-13463

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/599.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #599


commit 2226a21bccf6a77f00ba8bdbd45c59667990
Author: Audrey So 
Date:   2017-10-20T21:10:26Z

CB-13463 : prevent package.json update plugins with --nosave




---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: PR to add native-scroll-to-top option to cordova-plugin-statusbar

[Jan Piotrowski]

Sounds like a useful change.

-J

2017-10-20 19:22 GMT+02:00 julio cesar sanchez :
> Any other opinions about this?
>
>
>
> 2017-10-01 15:56 GMT+02:00 julio cesar sanchez :
>
>> I'm +1 on this
>>
>> 2017-09-30 0:56 GMT+02:00 Lu Wang :
>>
>>> This is in regards to the following PR: https://github.com/apache/cord
>>> ova-plugin-statusbar/pull/83 >> dova-plugin-statusbar/pull/83>
>>>
>>> I was told by @jcesarmobile that it’s best if I email the dev mailing
>>> list.
>>>
>>> There’s currently a bug filed as https://issues.apache.org/jira
>>> /browse/CB-13124  where
>>> in the statusTap event is delayed until momentum scrolling is complete.
>>> This means that if you’re using custom scroll-to-top behavior written in
>>> JavaScript, it will not fire until all momentum scrolling has stopped. This
>>> can cause the UI to look sluggish. Instructions for reproducing the bug are
>>> within the filed Jira Issue.
>>>
>>> I’m proposing in the PR that we add an option to allow the native status
>>> bar tap behavior. This way, the scroll-to-top is processed by the native
>>> app and not processed in JavaScript where it has to wait for the statusTap
>>> event to fire.
>>>
>>> Let me know if there are any questions.
>>>
>>> — Lu
>>
>>
>>

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #597: CB-13451 (all platforms) "pkg not defined" ex...

[stevengill]

Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/597#discussion_r146039059
  
--- Diff: src/plugman/init-defaults.js ---
@@ -55,25 +55,26 @@ function readDeps (test) {
 };
 }
 
-var name = pkg.name || defaults.id || basename;
+/* eslint-disable */
--- End diff --

Do you need this `/* eslint-disable */`


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #597: CB-13451 (all platforms) "pkg not defined" ex...

[stevengill]

Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/597#discussion_r146038992
  
--- Diff: .eslintignore ---
@@ -1,4 +1 @@
-spec/cordova/fixtures/**
-spec/plugman/projects/**
-spec/plugman/plugins/**
-spec/cordova/temp/**
+**/init-defaults.js
--- End diff --

Why did you remove the other items from `.eslintignore`?


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #597: CB-13451 (all platforms) "pkg not defined" ex...

[stevengill]

Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/597#discussion_r146039159
  
--- Diff: src/plugman/init-defaults.js ---
@@ -149,10 +149,11 @@ if (!pkg.author) {
 }
 : prompt('author');
 }
-/* eslint-enable indent */
-var license = pkg.license ||
+var license = package.license ||
   defaults.license ||
   config.get('init.license') ||
   config.get('init-license') ||
   'ISC';
+/* eslint-enable */
--- End diff --

is this needed? `/* eslint-enable */`


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib issue #597: CB-13451 (all platforms) "pkg not defined" exception...

[OminousWater]

Github user OminousWater commented on the issue:

https://github.com/apache/cordova-lib/pull/597
  
I have committed my fix now, and think the pull-request is good to go. 
eslint is still reporting errors, but I've repro'd them locally and can confirm 
they're unrelated to my pull request.


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: PR to add native-scroll-to-top option to cordova-plugin-statusbar

[julio cesar sanchez]

Any other opinions about this?



2017-10-01 15:56 GMT+02:00 julio cesar sanchez :

> I'm +1 on this
>
> 2017-09-30 0:56 GMT+02:00 Lu Wang :
>
>> This is in regards to the following PR: https://github.com/apache/cord
>> ova-plugin-statusbar/pull/83 > dova-plugin-statusbar/pull/83>
>>
>> I was told by @jcesarmobile that it’s best if I email the dev mailing
>> list.
>>
>> There’s currently a bug filed as https://issues.apache.org/jira
>> /browse/CB-13124  where
>> in the statusTap event is delayed until momentum scrolling is complete.
>> This means that if you’re using custom scroll-to-top behavior written in
>> JavaScript, it will not fire until all momentum scrolling has stopped. This
>> can cause the UI to look sluggish. Instructions for reproducing the bug are
>> within the filed Jira Issue.
>>
>> I’m proposing in the PR that we add an option to allow the native status
>> bar tap behavior. This way, the scroll-to-top is processed by the native
>> app and not processed in JavaScript where it has to wait for the statusTap
>> event to fire.
>>
>> Let me know if there are any questions.
>>
>> — Lu
>
>
>

[GitHub] cordova-lib issue #597: CB-13451 (all platforms) "pkg not defined" exception...

[OminousWater]

Github user OminousWater commented on the issue:

https://github.com/apache/cordova-lib/pull/597
  
@stevengill I have a working fix locally now (on advice from the eslint 
devs I've added a top-level .eslintignore file with a pattern that filters out 
any init-defaults.js files). The AppVeyor continuous integration step is still 
failing, though for a seemingly unrelated reason (to do with the 'qs' 
package?). I will try to repro locally in case it's related to my change, but I 
don't _think_ it is (famous last words).


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #597: CB-13451 (all platforms) "pkg not defined" ex...

[OminousWater]

GitHub user OminousWater reopened a pull request:

https://github.com/apache/cordova-lib/pull/597

CB-13451 (all platforms) "pkg not defined" exception when running plugman 
with createpackagejson command-line

A global js-lint pass on the cordova-lib codebase on the 30/8/2017 caused 
references to the global 'package' variable in init-default.js to be renamed to 
'pkg’, presumably because the cordova-lib source doesn’t declare a global 
variable called ‘package’ but _does_ declare a global variable called 
‘pkg’ (in src/cordova/info.js). However in this case, the ‘package’ 
variable refers to the one declared in the plugman source, specifically 
main.js, so it should have stayed as 'package’. To test the fix, run:

plugman createpackagejson .

Without the fix, this will trigger the following exception: 'pkg is not 
defined'. Having patched in the fix, running the command line should work as 
expected, prompting the user with questions and then spitting out a 
package.json file.



### Platforms affected
All

### What does this PR do?
Fixes an bug where an exception would be thrown when running 'plugman 
createpackagejson .'

### What testing has been done on this change?
The command in question ('plugman createpackagejson .') has been tested 
with and without the fix to confirm that the fix fixes the problem.

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/OminousWater/cordova-lib master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/597.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #597


commit e321bc319b94c86b77d993981491f99bac6f27f9
Author: Roland 
Date:   2017-10-16T20:57:59Z

Fix for 'pkg is not defined' exception
A global js-lint pass on the cordova-lib codebase on the 30/8/2017 caused 
references to the global 'package' variable in init-default.js to be renamed to 
'pkg’, presumably because the cordova-lib source doesn’t declare a global 
variable called ‘package’ but _does_ declare a global variable called 
‘pkg’ (in cordova/info.js). However in this case, the ‘package’ 
variable refers to the one declared in the plugman source, specifically 
main.js, so it should have stayed as 'package’. To test the fix, run:

plugman createpackagejson .

Without the fix, this will trigger the following exception: 'pkg is not 
defined'. Having patched in the fix, running the command line should work as 
expected, prompting the user with questions and then spitting out a 
package.json file.

commit 91614eb341735fde77661f3643c9a328fd09ac0c
Author: Roland 
Date:   2017-10-18T19:45:23Z

Revert "Fix for 'pkg is not defined' exception"

This reverts commit e321bc319b94c86b77d993981491f99bac6f27f9.

commit 62c5d2631c56ed40fda0576bc726b61bc0eb7806
Author: Roland 
Date:   2017-10-19T20:45:23Z

Second attempt at fix for CB-13451

commit f3dec27bfe9e4e6dce2f8d5ef6d3997c1ca2b925
Author: Roland 
Date:   2017-10-20T07:00:32Z

Make eslint ignore init-defaults.js file(s) as it will fail otherwise on 
'package' keword that PromZard injects




---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org