[DISCUSS] Plugins release
Hey all, I'd like to spin up a new plugins release soon. Even though the file transfer plugin has been deprecated there is an issue with the file dependency it uses which makes it hard for folks to upgrade other plugins in their app. That is if they are still using file transfer they are stuck with file plugin 5.0.0 and that prevents folks from using the latest media, media-capture or file plugins. As well there are some fixes in the Media plugin I'd like to get out. What other plugins besides: cordova-plugin-file-transfer cordova-plugin-media need a release? Simon Mac Donald http://simonmacdonald.com
Re: [DISCUSS] Plugins release
That's good for another release. I still need to look at a fix for camera for Android 8.0, but I'm fine with doing another release later. On Mon, Jan 15, 2018 at 12:47 PM, Simon MacDonald wrote: > Hey all, > > I'd like to spin up a new plugins release soon. Even though the file > transfer plugin has been deprecated there is an issue with the file > dependency it uses which makes it hard for folks to upgrade other plugins > in their app. That is if they are still using file transfer they are stuck > with file plugin 5.0.0 and that prevents folks from using the latest media, > media-capture or file plugins. > > As well there are some fixes in the Media plugin I'd like to get out. > > What other plugins besides: > > cordova-plugin-file-transfer > cordova-plugin-media > > need a release? > > Simon Mac Donald > http://simonmacdonald.com >
Re: [DISCUSS] Plugins release
I updated splashscreen plugin for iPhone X, so we can release it too. 2018-01-15 22:35 GMT+01:00 Joe Bowser : > That's good for another release. I still need to look at a fix for camera > for Android 8.0, but I'm fine with doing another release later. > > On Mon, Jan 15, 2018 at 12:47 PM, Simon MacDonald < > simon.macdon...@gmail.com > > wrote: > > > Hey all, > > > > I'd like to spin up a new plugins release soon. Even though the file > > transfer plugin has been deprecated there is an issue with the file > > dependency it uses which makes it hard for folks to upgrade other plugins > > in their app. That is if they are still using file transfer they are > stuck > > with file plugin 5.0.0 and that prevents folks from using the latest > media, > > media-capture or file plugins. > > > > As well there are some fixes in the Media plugin I'd like to get out. > > > > What other plugins besides: > > > > cordova-plugin-file-transfer > > cordova-plugin-media > > > > need a release? > > > > Simon Mac Donald > > http://simonmacdonald.com > > >
Re: Linux Platform Integration Alpha (Api.js etc)
1. Core platforms get the reserved names. Third-party platforms are named
after what I presume is their repo name (not 100% sure on that last part).
2. I would check out a platform example, i.e. 'ios':
-
https://github.com/apache/cordova-ios/blob/8edd13aaee16d6996a4560a74d17798437b42c6f/bin/templates/scripts/cordova/Api.js#L464
-
https://github.com/apache/cordova-ios/blob/8edd13aaee16d6996a4560a74d17798437b42c6f/bin/templates/scripts/cordova/lib/check_reqs.js#L185
Is this what you were looking for?
3. What do you mean by ugly? Example. AFAIK it's just "throw new
CordovaError('error string')"
4. I couldn't find a question in there.
TBH you would be the only person working on this, and there is no point in
putting this in the dead cordova-ubuntu repo. I would keep it in your repo
for now since that will be the fastest to iterate on since you won't have
Apache committer privileges yet, and you will be blocked by us having to
pull it in. Once it gets to a usable state, send a proposal to donate your
repo to Cordova in this dev@ list and we will proceed from there.
On Mon, Jan 15, 2018 at 6:36 AM, Pat Deegan
wrote:
> Hi all,
>
> Anyone have input on my Qs from the 5th?
>
> I'm especially interested in the second question, related to setting up
> Api.prototype.requirements, and in anything else I'd need to do to
> polish things up before making a pull request.
>
> Also, which repo would this request be made on?
>
> Thanks!
> PatD
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>
Re: Linux Platform Integration Alpha (Api.js etc)
Hi,
First off, thanks for the answers.
On 2018-01-15 08:25 PM, Shazron wrote:
> 1. Core platforms get the reserved names. Third-party platforms are named
> after what I presume is their repo name (not 100% sure on that last part).
Ok, cool--I can wait for a nice reserved name, down the road.
>
> 2. I would check out a platform example, i.e. 'ios':
> Is this what you were looking for?
Yes, perfect. Will base mods on that.
>
> 3. What do you mean by ugly? Example. AFAIK it's just "throw new
> CordovaError('error string')"
Ok. By ugly I mean instead of getting some:
"Error, cannot proceed: error string"
or something similar, the output is instead:
=== snip ===
(node:1025) UnhandledPromiseRejectionWarning: Error
[ERR_UNHANDLED_ERROR]: Unhandled error. (error string)
at EventEmitter.emit (events.js:140:19)
at EventEmitter.module.exports.emit
(/tmp/SomeApp/node_modules/cordova-common/src/events.js:71:17)
at Object.module.exports.error
(/tmp/SomeApp/platforms/cordova-linux/cordova/logger.js:54:12)
at Api.rejectAndThrow
(/tmp/SomeApp/platforms/cordova-linux/cordova/Api.js:258:9)
at /tmp/SomeApp/platforms/cordova-linux/cordova/Api.js:280:8
at new Promise ()
at Api.build (/tmp/SomeApp/platforms/cordova-linux/cordova/Api.js:270:9)
at
/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/cordova/compile.js:40:30
at
/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/util/promise-util.js:30:24
at _fulfilled
(/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:787:54)
(node:1025) UnhandledPromiseRejectionWarning: Unhandled promise
rejection. This error originated either by throwing inside of an async
function without a catch block, or by rejecting a promise which was not
handled with .catch(). (rejection id: 2)
(node:1025) [DEP0018] DeprecationWarning: Unhandled promise rejections
are deprecated. In the future, promise rejections that are not handled
will terminate the Node.js process with a non-zero exit code.
=== /snip ===
Yeah, it contains the error string up there, at the top, but seems like
a pretty messy exit.
I guess I kind of expect a catch somewhere above my call to make this
output more user friendly. Maybe it's an issue with my setup?
>
> 4. I couldn't find a question in there.
Yeah, I sent the email somewhat incomplete there... the short of it was
"is it a faux pas to leave some built packages from previous versions
lying around after a 'clean'?".
It's currently setup such that all the generated files/intermediate
results of a build are cleaned up on 'clean', but the versioned packages
created are left intact (unless you actually remove the platform). I
like the "safety" of keeping older versions around, but will eliminate
them on 'clean' if it's the convention/expectation.
>
> TBH you would be the only person working on this, and there is no point in
> putting this in the dead cordova-ubuntu repo. I would keep it in your repo
> for now since that will be the fastest to iterate on since you won't have
> Apache committer privileges yet, and you will be blocked by us having to
> pull it in. Once it gets to a usable state, send a proposal to donate your
> repo to Cordova in this dev@ list and we will proceed from there.
Sounds great, will do.
Thanks,
P
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
Re: Linux Platform Integration Alpha (Api.js etc)
3. Promises, ugh. Try reject OR throw, not both.
https://github.com/psychogenic/cordova-linux/blob/69a4dc92cae54e86761ad286c38710df8693b244/src/cordova/Api.js#L256
reject does not terminate the execution, it will still throw after the
reject here...
4. "cordova clean -> Cleanup project from build artifacts". Are they
"produced" by the build? Then you clean that up.
On Tue, Jan 16, 2018 at 9:49 AM, Pat Deegan
wrote:
> Hi,
>
> First off, thanks for the answers.
>
> On 2018-01-15 08:25 PM, Shazron wrote:
> > 1. Core platforms get the reserved names. Third-party platforms are named
> > after what I presume is their repo name (not 100% sure on that last
> part).
>
> Ok, cool--I can wait for a nice reserved name, down the road.
>
> >
> > 2. I would check out a platform example, i.e. 'ios':
> > Is this what you were looking for?
>
> Yes, perfect. Will base mods on that.
>
> >
> > 3. What do you mean by ugly? Example. AFAIK it's just "throw new
> > CordovaError('error string')"
>
> Ok. By ugly I mean instead of getting some:
>
> "Error, cannot proceed: error string"
>
> or something similar, the output is instead:
>
> === snip ===
>
> (node:1025) UnhandledPromiseRejectionWarning: Error
> [ERR_UNHANDLED_ERROR]: Unhandled error. (error string)
> at EventEmitter.emit (events.js:140:19)
> at EventEmitter.module.exports.emit
> (/tmp/SomeApp/node_modules/cordova-common/src/events.js:71:17)
> at Object.module.exports.error
> (/tmp/SomeApp/platforms/cordova-linux/cordova/logger.js:54:12)
> at Api.rejectAndThrow
> (/tmp/SomeApp/platforms/cordova-linux/cordova/Api.js:258:9)
> at /tmp/SomeApp/platforms/cordova-linux/cordova/Api.js:280:8
> at new Promise ()
> at Api.build (/tmp/SomeApp/platforms/cordova-linux/cordova/Api.js:
> 270:9)
> at
> /usr/local/lib/node_modules/cordova/node_modules/cordova-
> lib/src/cordova/compile.js:40:30
> at
> /usr/local/lib/node_modules/cordova/node_modules/cordova-
> lib/src/util/promise-util.js:30:24
> at _fulfilled
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-
> lib/node_modules/q/q.js:787:54)
> (node:1025) UnhandledPromiseRejectionWarning: Unhandled promise
> rejection. This error originated either by throwing inside of an async
> function without a catch block, or by rejecting a promise which was not
> handled with .catch(). (rejection id: 2)
> (node:1025) [DEP0018] DeprecationWarning: Unhandled promise rejections
> are deprecated. In the future, promise rejections that are not handled
> will terminate the Node.js process with a non-zero exit code.
>
>
> === /snip ===
>
> Yeah, it contains the error string up there, at the top, but seems like
> a pretty messy exit.
>
> I guess I kind of expect a catch somewhere above my call to make this
> output more user friendly. Maybe it's an issue with my setup?
>
>
> >
> > 4. I couldn't find a question in there.
>
> Yeah, I sent the email somewhat incomplete there... the short of it was
> "is it a faux pas to leave some built packages from previous versions
> lying around after a 'clean'?".
>
> It's currently setup such that all the generated files/intermediate
> results of a build are cleaned up on 'clean', but the versioned packages
> created are left intact (unless you actually remove the platform). I
> like the "safety" of keeping older versions around, but will eliminate
> them on 'clean' if it's the convention/expectation.
>
>
> >
> > TBH you would be the only person working on this, and there is no point
> in
> > putting this in the dead cordova-ubuntu repo. I would keep it in your
> repo
> > for now since that will be the fastest to iterate on since you won't have
> > Apache committer privileges yet, and you will be blocked by us having to
> > pull it in. Once it gets to a usable state, send a proposal to donate
> your
> > repo to Cordova in this dev@ list and we will proceed from there.
>
>
> Sounds great, will do.
>
> Thanks,
> P
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>
Nightly build #603 for cordova has succeeded!
Nightly build #603 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/603/consoleFull - Jenkins for Apache Cordova - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [DISCUSS] Plugins release
So far we have: cordova-plugin-file-transfer cordova-plugin-media cordova-plugin-camera cordova-plugin-splashscreen Anyone else? Simon Mac Donald http://simonmacdonald.com On Mon, Jan 15, 2018 at 5:32 PM, julio cesar sanchez wrote: > I updated splashscreen plugin for iPhone X, so we can release it too. > > 2018-01-15 22:35 GMT+01:00 Joe Bowser : > > > That's good for another release. I still need to look at a fix for > camera > > for Android 8.0, but I'm fine with doing another release later. > > > > On Mon, Jan 15, 2018 at 12:47 PM, Simon MacDonald < > > simon.macdon...@gmail.com > > > wrote: > > > > > Hey all, > > > > > > I'd like to spin up a new plugins release soon. Even though the file > > > transfer plugin has been deprecated there is an issue with the file > > > dependency it uses which makes it hard for folks to upgrade other > plugins > > > in their app. That is if they are still using file transfer they are > > stuck > > > with file plugin 5.0.0 and that prevents folks from using the latest > > media, > > > media-capture or file plugins. > > > > > > As well there are some fixes in the Media plugin I'd like to get out. > > > > > > What other plugins besides: > > > > > > cordova-plugin-file-transfer > > > cordova-plugin-media > > > > > > need a release? > > > > > > Simon Mac Donald > > > http://simonmacdonald.com > > > > > >
