Re: [DISCUSS] Cordova-Android 7.1.1 patch release

2018-07-11 Thread Shazron
I realize that and that's what I did -- the error message was not
helpful because I thought it would just detect the one in Android
Studio (seems to be specific to Windows?).

Another gotcha: I had to add $ANDROID_HOME/emulator to my PATH to run
it in the emulator
On Thu, Jul 12, 2018 at 1:50 PM Darryl Pogue  wrote:
>
> I believe on macOS you'll need to install gradle through something
> like Homebrew.
>
> On Wed, Jul 11, 2018 at 10:42 PM Shazron  wrote:
> >
> > Sorry, Android newbie here.
> >
> > I have Android 3.1.3 installed on macOS, with cordova 8.0.0.
> > I did:
> > cordova platform add https://github.com/apache/cordova-android#7.1.1
> > cordova build
> >
> > I get this error:
> > https://github.com/apache/cordova-android/blob/bf29fe0e10334938d2e6ee8116f9a30c762c40b4/bin/templates/cordova/lib/check_reqs.js#L137
> >
> > Should it be able to detect and use the gradle within Android Studio.app?
> >
> > Based on code inspection here, it doesn't (isWindows is false, and
> > thus androidStudioPath is also null):
> > https://github.com/apache/cordova-android/blob/bf29fe0e10334938d2e6ee8116f9a30c762c40b4/bin/templates/cordova/lib/check_reqs.js#L122
> >
> > I know the docs say "As of Cordova-Android 6.4.0, Gradle is now
> > required to be installed to build Android." so perhaps the error
> > message needs to be tweaked.
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: [DISCUSS] Cordova-Android 7.1.1 patch release

2018-07-11 Thread Darryl Pogue
I believe on macOS you'll need to install gradle through something
like Homebrew.

On Wed, Jul 11, 2018 at 10:42 PM Shazron  wrote:
>
> Sorry, Android newbie here.
>
> I have Android 3.1.3 installed on macOS, with cordova 8.0.0.
> I did:
> cordova platform add https://github.com/apache/cordova-android#7.1.1
> cordova build
>
> I get this error:
> https://github.com/apache/cordova-android/blob/bf29fe0e10334938d2e6ee8116f9a30c762c40b4/bin/templates/cordova/lib/check_reqs.js#L137
>
> Should it be able to detect and use the gradle within Android Studio.app?
>
> Based on code inspection here, it doesn't (isWindows is false, and
> thus androidStudioPath is also null):
> https://github.com/apache/cordova-android/blob/bf29fe0e10334938d2e6ee8116f9a30c762c40b4/bin/templates/cordova/lib/check_reqs.js#L122
>
> I know the docs say "As of Cordova-Android 6.4.0, Gradle is now
> required to be installed to build Android." so perhaps the error
> message needs to be tweaked.
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[DISCUSS] Cordova-Android 7.1.1 patch release

2018-07-11 Thread Shazron
Sorry, Android newbie here.

I have Android 3.1.3 installed on macOS, with cordova 8.0.0.
I did:
cordova platform add https://github.com/apache/cordova-android#7.1.1
cordova build

I get this error:
https://github.com/apache/cordova-android/blob/bf29fe0e10334938d2e6ee8116f9a30c762c40b4/bin/templates/cordova/lib/check_reqs.js#L137

Should it be able to detect and use the gradle within Android Studio.app?

Based on code inspection here, it doesn't (isWindows is false, and
thus androidStudioPath is also null):
https://github.com/apache/cordova-android/blob/bf29fe0e10334938d2e6ee8116f9a30c762c40b4/bin/templates/cordova/lib/check_reqs.js#L122

I know the docs say "As of Cordova-Android 6.4.0, Gradle is now
required to be installed to build Android." so perhaps the error
message needs to be tweaked.

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Nightly build #780 for cordova has failed

2018-07-11 Thread Apache Jenkins Server
Nightly build #780 for cordova has failed.

Please check failure details on build details page at 
https://builds.apache.org/job/cordova-nightly/780/
You can also take a look at build console: 
https://builds.apache.org/job/cordova-nightly/780/consoleFull

-
Jenkins for Apache Cordova

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Cordova-Android 7.1.1 patch release

2018-07-11 Thread Chris Brody
Please review and vote on this Cordova-Android 7.1.1 pelease by
replying to this email (and keep discussion on the DISCUSS thread)

Release issue: https://issues.apache.org/jira/browse/CB-14203

The archive has been published to dist/dev:
https://dist.apache.org/repos/dist/dev/cordova/CB-14203/

The package was published from its corresponding git tag:

cordova-android: 7.1.1 (7a97fd7e34)

Note that you can test it out via:

cordova platform add https://github.com/apache/cordova-android#7.1.1

Upon a successful vote I will upload the archive to dist/, publish it
to npm, and post the blog post.

Voting guidelines:
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md

Voting will go on for a minimum of 48 hours.

I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and
subdependencies have Apache-compatible licenses
* Ensured continuous build was green when repo was tagged
* Tested on multiple Node.js versions
* Ran automatic plugin tests from cordova-mobile-spec according to
https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md#1-plugin-tests-with-cordova-mobile-spec-project
with less than 10% failure

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org