[GitHub] [cordova-test-platform] raphinesse commented on a change in pull request #17: pkg fixup
raphinesse commented on a change in pull request #17: URL: https://github.com/apache/cordova-test-platform/pull/17#discussion_r499161520 ## File path: package.json ## @@ -18,17 +20,6 @@ "author": "Apache Software Foundation", "license": "Apache-2.0", "bugs": "https://github.com/apache/cordova-test-platform/issues;, - "homepage": "https://github.com/cordova/cordova-test-platform#readme;, Review comment: I removed it since only four packages had this field set at all. Two of them to the default value This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] [cordova-test-platform] timbru31 merged pull request #18: chore(asf): update git notification settings
timbru31 merged pull request #18: URL: https://github.com/apache/cordova-test-platform/pull/18 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] [cordova-test-platform] timbru31 opened a new pull request #18: chore(asf): update git notification settings
timbru31 opened a new pull request #18: URL: https://github.com/apache/cordova-test-platform/pull/18 ### Platforms affected ### Motivation and Context ### Description ### Testing ### Checklist - [ ] I've run the tests to see all new and existing tests pass - [ ] I added automated test coverage as appropriate for this change - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`) - [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) - [ ] I've updated the documentation if necessary This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] [cordova-test-platform] erisu commented on a change in pull request #17: pkg fixup
erisu commented on a change in pull request #17: URL: https://github.com/apache/cordova-test-platform/pull/17#discussion_r499159095 ## File path: package.json ## @@ -18,17 +20,6 @@ "author": "Apache Software Foundation", "license": "Apache-2.0", "bugs": "https://github.com/apache/cordova-test-platform/issues;, - "homepage": "https://github.com/cordova/cordova-test-platform#readme;, Review comment: Looks like you are removing it instead from everywhere. So I approved it. Thought it might have been better to point to the actual home page so people coming from npmjs has a quick link to our home page. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] [cordova-test-platform] erisu commented on a change in pull request #17: pkg fixup
erisu commented on a change in pull request #17: URL: https://github.com/apache/cordova-test-platform/pull/17#discussion_r499158727 ## File path: package.json ## @@ -18,17 +20,6 @@ "author": "Apache Software Foundation", "license": "Apache-2.0", "bugs": "https://github.com/apache/cordova-test-platform/issues;, - "homepage": "https://github.com/cordova/cordova-test-platform#readme;, Review comment: Is this meant to be removed? Description did not mention it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] [cordova-test-platform] raphinesse opened a new pull request #17: pkg fixup
raphinesse opened a new pull request #17: URL: https://github.com/apache/cordova-test-platform/pull/17 - chore(pkg): remove field "maintainers" - fix(pkg): fix declaration for binary "create" This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
