[GitHub] cordova-windows pull request: CB-9565: Build failure for Windows 1...
Github user SomaticIT commented on the pull request:
https://github.com/apache/cordova-windows/pull/123#issuecomment-150876679
@robpaveza @nikhilkh @rakatyal
Any news on this, it's a really painful error.
The error in tests is an issue in @robpaveza fix
[here](https://github.com/MSOpenTech/cordova-windows/blob/8ea8a719848e296e2cd54b2c5479160a9467046c/template/cordova/lib/MSBuildTools.js#L83).
javascript
if (version === '14.0' && path.indexOf('amd64')) {
path = require('path').join(path, '..');
}
should be:
javascript
if (version === '14.0' && path.indexOf('amd64') !== -1) {
path = require('path').join(path, '..');
}
Could this be fixed ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file pull request: CB-6994 - Windows 8 does not sav...
Github user SomaticIT commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/54#issuecomment-61273536 It's not the same issue. This issue was only applicable to Windows 8 which tried to serialize files into plain old arrays and create stack overflow exception. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-wp8 pull request: JsonHelper testing, and use of Newtonsof...
Github user SomaticIT commented on the pull request: https://github.com/apache/cordova-wp8/pull/62#issuecomment-59523467 I just reviewed this pull request, it's a great improvement in performance and stability. Even Microsoft has replaced his __DataContractJsonSerializer__ in favor of __Newtonsoft.Json__ in ASP.NET Web Api. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file pull request: CB-6994 - Windows 8 does not sav...
Github user SomaticIT commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/54#issuecomment-58514355 @sgrebnov I reviewed your changes and it's OK for me. Thanks for merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file pull request: CB-6994 - Windows 8 does not sav...
Github user SomaticIT commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/54#issuecomment-58153363 Hi, Just to ask for review again. This bug is really blocking in Windows 8 application : the application crash with a __stackoverflow exception__ while trying to write files 1 MB. Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file pull request: CB-6994 - Windows 8 does not sav...
Github user SomaticIT commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/54#issuecomment-58157317 @sgrebnov Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file pull request: CB-6994 - Windows 8 does not sav...
Github user SomaticIT commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/54#discussion_r18526729
--- Diff: src/windows/FileProxy.js ---
@@ -518,36 +518,69 @@ module.exports = {
if (data instanceof ArrayBuffer) {
data = Array.apply(null, new Uint8Array(data));
}
-
-var writePromise = isBinary ?
Windows.Storage.FileIO.writeBytesAsync : Windows.Storage.FileIO.writeTextAsync;
-
fileName = fileName.split(/).join(\\);
-
// split path to folder and file name
var path = fileName.substring(0, fileName.lastIndexOf('\\')),
file = fileName.split('\\').pop();
-
getFolderFromPathAsync(path).done(
function(storageFolder) {
storageFolder.createFileAsync(file,
Windows.Storage.CreationCollisionOption.openIfExists).done(
function(storageFile) {
-writePromise(storageFile, data).
-done(function () {
-win(data.length);
-}, function () {
-fail(FileError.INVALID_MODIFICATION_ERR);
-});
-}, function() {
+if (data instanceof Blob || data instanceof File) {
+
storageFile.openAsync(Windows.Storage.FileAccessMode.readWrite).done(
+function (output) {
+var input = data.msDetachStream();
--- End diff --
Are you sure ?
File inherits from Blob, it should contain any methods defined in Blob
prototype.
http://msdn.microsoft.com/en-us/library/windows/apps/hh453178.aspx (Remarks
section)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file pull request: CB-6994 - Windows 8 does not sav...
Github user SomaticIT commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/54#discussion_r18530459
--- Diff: src/windows/FileProxy.js ---
@@ -518,36 +518,69 @@ module.exports = {
if (data instanceof ArrayBuffer) {
--- End diff --
I did not remove this line in my update since user can pass ArrayBuffer
directly to FileWriter.write.
In this case, we need to convert ArrayBuffer. I optimized the conversion by
using DataView to transform ArrayBuffer into Blob and use the best method to
write big files.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file pull request: CB-6994 - Windows 8 does not sav...
Github user SomaticIT commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/54#issuecomment-58211689
I created 2 shortcuts to __writeBytesAsync__ and __writeTextAsync__ and a
new function __writeBlobAsync__.
Then I do :
if (data instanceof Blob) {
writePromise = writeBlobAsync;
} else if (isBinary) {
writePromise = writeBytesAsync;
} else {
writePromise = writeTextAsync;
}
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file pull request: CB-6994 - Windows 8 does not sav...
Github user SomaticIT commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/54#discussion_r18554367
--- Diff: src/windows/FileProxy.js ---
@@ -516,38 +556,50 @@ module.exports = {
isBinary = args[3];
if (data instanceof ArrayBuffer) {
-data = Array.apply(null, new Uint8Array(data));
+var dataView = new DataView(data);
+data = new Blob([dataView]);
--- End diff --
Oh I didn't know that we can do this way, I will apply this fix tomorrow if
you want.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file pull request: CB-6994 - Windows 8 does not sav...
Github user SomaticIT commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/54#issuecomment-58274694 Ok I understand that File is Cordova specific. Is there a way to access the blob inside the File Object ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file pull request: CB-6994 - Windows 8 does not sav...
Github user SomaticIT commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/54#issuecomment-57182258 Hey @sgrebnov, I did not have any time to fix this issue before. I just rebased previous commit and add a new one to synchronize changes with the global Windows Platform. Could you review please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-inappbrowser pull request: CB- 5109 Windows 8.1 - I...
Github user SomaticIT commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/53#issuecomment-49035743 Sorry I did not see your comment on JIRA. OK for me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-inappbrowser pull request: CB- 5109 Windows 8.1 - I...
Github user SomaticIT commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/53#issuecomment-49035271 Hi Sergey, I already opened a PR on for this issue : #52 Is it normal that we duplicate this PR ? Thx --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-geolocation pull request: CB- 5114 Windows 8.1 - Us...
Github user SomaticIT commented on the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/18#issuecomment-48725418 Hi @sgrebnov, I added a note on the commit but it's only a little optimization. Apart from that, everything looks good for me ! Thx --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-geolocation pull request: CB- 5114 Windows 8.1 - Us...
Github user SomaticIT commented on the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/18#issuecomment-48738910 Super, it looks great for me, Thx. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-inappbrowser pull request: CB-5109 - Windows 8 and ...
GitHub user SomaticIT opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/52 CB-5109 - Windows 8 and 8.1 - InAppBrowser implementation In Windows 8.1, there is a new WebView control. It can be used to create an InAppBrowser implementation. http://msdn.microsoft.com/en-us/library/windows/apps/dn301831.aspx In order to meet the new ambitions about Windows code reunification, I centralized the Windows 8 and 8.1 version Inside the same proxy (located in src/windows/InAppBrowserProxy.js). You can merge this pull request into a Git repository by running: $ git pull https://github.com/Touchit/cordova-plugin-inappbrowser CB-5109 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-inappbrowser/pull/52.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #52 commit ef9ca5ad3ee121efb22f0dfceef6628805ff0c49 Author: SomaticIT cont...@somatic.fr Date: 2013-10-17T21:01:13Z Append Windows 8.1 proxy using x-ms-webview commit 863386398e6e595f103d593ab72c91712fcc373a Author: SomaticIT cont...@somatic.fr Date: 2013-10-17T21:02:59Z Append Windows 8.1 platform configuration in plugin.xml commit e5d07f14e8419dea67ec6c13d9f18a096f20a939 Author: SomaticIT cont...@somatic.fr Date: 2014-07-11T15:05:24Z Update code from remote apache repository commit 225bde271b03b39ab6bb6bac807bfae1d960f721 Author: SomaticIT cont...@somatic.fr Date: 2014-07-11T15:06:39Z Rename windows81 by windows8 in src directory commit ac9c64964e17e66075c8b9170a61916b5ac01acb Author: SomaticIT cont...@somatic.fr Date: 2014-07-11T19:43:37Z Update windows proxy to be both compatible with windows 8 and 8.1 commit ea6a4fc80a2bc5b1cc74964e921df8b367e5876f Author: SomaticIT cont...@somatic.fr Date: 2014-07-11T19:48:21Z Update doc to add Windows 8 commit 6e38667320cda5f5c199a5d6a038a001be491bdd Author: SomaticIT cont...@somatic.fr Date: 2014-07-11T19:48:31Z Update french translation commit d828197de45f724ad41135c3ca8f0767a0990582 Author: SomaticIT cont...@somatic.fr Date: 2014-07-11T19:54:25Z Clean plugin.xml --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-file pull request: CB-7027 GetMetada fails on Windo...
Github user SomaticIT commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/56#issuecomment-48501295 Hi purblecabbage, 1. @fberton is a member of the Touchify's, his name is Florian BERTON. He didn't send you the CLA, he will do it soon but he is registered to cordova developpement mailing list, he should introduce himself on it. 2. Indeed, the IDE has formatted the file including whitespaces, but you can see changes in the second commit. 3. Be careful, by mistake, Florian committed both CB-6994 (first commit, #54) and CB-7027 (second commit) in this branch. Do you want us to reformat the whole file in order to keep the spaces from the original ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
