[GitHub] cordova-ios issue #252: CB-11831 - Add missing LD_RUNPATH_SEARCH_PATHS setti...
Github user bugnano commented on the issue: https://github.com/apache/cordova-ios/pull/252 Yeah, somehow the pull request comment box was empty. However, as this is not my first patch to the Cordova project, I find a little hard to contribute small and easy fixes like this, if I have to sign a CLA, make a JIRA issue, and only then be able to fix the 1 line where the bug actually is. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request #252: Add missing LD_RUNPATH_SEARCH_PATHS setting t...
GitHub user bugnano opened a pull request: https://github.com/apache/cordova-ios/pull/252 Add missing LD_RUNPATH_SEARCH_PATHS setting to the Release build Swift support is enabled and working in the Debug build configuration, but it's broken in the Release build configuration. This patch enables Swift plugins also on the Release build configuration. You can merge this pull request into a Git repository by running: $ git pull https://github.com/bugnano/cordova-ios master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-ios/pull/252.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #252 commit dc0d5ba499cbb05e533b3905b08226e1a290603a Author: Franco Bugnano Date: 2016-09-03T12:58:21Z Add missing LD_RUNPATH_SEARCH_PATHS setting to the Release build configuration --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request #110: Fix crash on iOS when reloadi...
GitHub user bugnano opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/110 Fix crash on iOS when reloading page from remote Safari ### Platforms affected iOS ### What does this PR do? Fix a crash when calling navigator.splashscreen.hide() after reloading the page from a remote Safari ### What testing has been done on this change? - Create an application with AutoHideSplashScreen set to false - Call navigator.splashscreen.hide() from the application - Connect Safari from a Mac to debug the application - Hit the reload button from Safari - Without this patch, the application crashes - With this patch, the page is reloaded without any problem ### Checklist - [ ] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to secret...@apache.org. - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/bugnano/cordova-plugin-splashscreen master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-splashscreen/pull/110.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #110 commit 16eceaa170aae27c992728337bee3090ebed0e0d Author: Franco Bugnano Date: 2016-07-21T15:14:42Z Fix crash on iOS when reloading page from remote Safari --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
