[GitHub] cordova-plugin-camera pull request #275: CB-12593: (android) Fix potential F...
Github user cjpearson closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/275 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request #275: CB-12593: (android) Fix potential F...
GitHub user cjpearson reopened a pull request: https://github.com/apache/cordova-plugin-camera/pull/275 CB-12593: (android) Fix potential FileProvider conflicts ### Platforms affected Android ### What does this PR do? Allows more than one plugin to use a FileProvider ### What testing has been done on this change? Tested with cordova-android 6.1.2 ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cjpearson/cordova-plugin-camera CB12953 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-camera/pull/275.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #275 commit cfefa53272d48c0067bd4a71345f1d6b328ff96f Author: Connor Pearson <cpear...@b2wsoftware.com> Date: 2017-06-30T13:59:27Z CB-12593: (android) Fix potential FileProvider conflicts --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera issue #274: CB-12593: (android) Fix potential FileProv...
Github user cjpearson commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/274 Thanks, Joe. I messed up the commit and issue linking. https://github.com/apache/cordova-plugin-camera/pull/275 has the same change. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request #275: CB-12593: (android) Fix potential F...
GitHub user cjpearson opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/275 CB-12593: (android) Fix potential FileProvider conflicts ### Platforms affected Android ### What does this PR do? Allows more than one plugin to use a FileProvider ### What testing has been done on this change? Tested with cordova-android 6.1.2 ### Checklist - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cjpearson/cordova-plugin-camera CB12953 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-camera/pull/275.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #275 commit cfefa53272d48c0067bd4a71345f1d6b328ff96f Author: Connor Pearson <cpear...@b2wsoftware.com> Date: 2017-06-30T13:59:27Z CB-12593: (android) Fix potential FileProvider conflicts --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request #274: CB-12593: (android) Fix potential F...
Github user cjpearson closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/274 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera issue #257: CB-12593: (android) move management of Fil...
Github user cjpearson commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/257 I think https://github.com/apache/cordova-plugin-camera/pull/274 may be a better solution. Closing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request #257: CB-12593: (android) move management...
Github user cjpearson closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/257 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request #274: CB-12959: (android) Fix potential F...
GitHub user cjpearson opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/274 CB-12959: (android) Fix potential FileProvider conflicts ### Platforms affected Android ### What does this PR do? Allows more than one plugin to use a FileProvider ### What testing has been done on this change? ### Checklist - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cjpearson/cordova-plugin-camera CB12959 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-camera/pull/274.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #274 commit 94b6ba3d0687990c148f91ef83a33c53f8f8d4da Author: Connor Pearson <cpear...@b2wsoftware.com> Date: 2017-06-30T13:59:27Z CB-12959: (android) Fix potential FileProvider conflicts --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine issue #37: CB-10376, CB-12037: (ios) Fix bug...
Github user cjpearson commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/37 Since this plugin just swizzles the WKWebView class, you can make it separate plugin instead of a fork. It might make maintenance easier. Look in https://github.com/apache/cordova-plugin-wkwebview-engine/pull/30 for an example. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request #706: CB-12880: Remove Taco.tools from the homepag...
GitHub user cjpearson opened a pull request: https://github.com/apache/cordova-docs/pull/706 CB-12880: Remove Taco.tools from the homepage ### Platforms affected All ### What does this PR do? Removes the link to Taco.tools ### What testing has been done on this change? Tested local build ### Checklist - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cjpearson/cordova-docs master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-docs/pull/706.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #706 commit d0a86ef6b62ecfde26b8695b4f1d1764c603a32c Author: Connor Pearson <cjp...@gmail.com> Date: 2017-06-04T13:51:14Z CB-12880: Remove Taco.tools from the homepage --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera issue #257: CB-12593: (android) move management of Fil...
Github user cjpearson commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/257 @infil00p, I'm not very familiar with the internals of cordova-android. What do you mean by a tooling issue? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-network-information pull request #54: CB-12751: (ios) Fix con...
GitHub user cjpearson opened a pull request: https://github.com/apache/cordova-plugin-network-information/pull/54 CB-12751: (ios) Fix connection type when airplane mode is on ### Platforms affected iOS ### What does this PR do? Reachability does not work properly when using Wifi then turning on Airplane mode. ### What testing has been done on this change? Tested on iOS 8-10. ### Checklist - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cjpearson/cordova-plugin-network-information CB-12751 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-network-information/pull/54.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #54 commit 544d6fd065426dbbb19a234df1946fc65021ce0b Author: Connor Pearson <cpear...@b2wsoftware.com> Date: 2017-01-18T15:21:46Z CB-12751: (ios) Fix connection type when airplane mode is on --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera issue #257: CB-12953: (android) move management of Fil...
Github user cjpearson commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/257 Thanks for the feedback. I agree that it should go under the cordova umbrella somewhere. I just wanted to show a working example in the PR. We have an internal plugin in our project that also uses the FileProvider and a provider_paths file. Attempting to upgrade the camera plugin to 2.3.1 fails the build with a duplicate element error. The only work around is to define both paths in one of the plugins which makes them dependent on each other and means we have to maintain a modified version of the camera plugin. Sorry, I messed up the title. The JIRA issue is [here](https://issues.apache.org/jira/browse/CB-12593). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera issue #257: CB-12953: (android) move management of Fil...
Github user cjpearson commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/257 @stevengill could you take a look at this PR? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request #257: CB-12953: (android) move management...
GitHub user cjpearson opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/257 CB-12953: (android) move management of FileProvider out of the camera plugin ### Platforms affected Android ### What does this PR do? It allows multiple plugins to use the FileProvider. Each plugin that needs a provider path can add it using the config-file element. Another plugin will update the AndroidManifest and create the provider_paths file. I've created a stub for this other plugin at https://github.com/cjpearson/cordova-plugin-file-provider so it builds correctly. I'm not sure if this other plugin should be a new plugin or added to an existing plugin. ### What testing has been done on this change? Tested locally with cordova-android 6.1.2. ### Checklist - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cjpearson/cordova-plugin-camera provider_fix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-camera/pull/257.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #257 commit 37f0a54dbdb1c16c019c6683f519278de0d2e584 Author: Connor Pearson <cpear...@b2wsoftware.com> Date: 2017-03-21T14:04:09Z CB-12953: (android) move management of FileProvider out of the camera plugin commit bfb150efea8297406f06c12a1e0631b4ffae91f8 Author: Connor Pearson <cpear...@b2wsoftware.com> Date: 2017-03-21T15:10:00Z use github link --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine issue #30: Allow XHR to file:// and allow lo...
Github user cjpearson commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/30 I think something like [this](https://gist.github.com/cjpearson/ae2a1c12e4737549721ec3c04e617789) should work. You can add the files to your Xcode project or create a plugin that includes them as source files. `load` will automatically be called so you don't need to invoke anything. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine issue #30: Allow XHR to file:// and allow lo...
Github user cjpearson commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/30 @rubenstolk, you could try creating a plugin that swizzles `createConfigurationFromSettings` and adds your changes. Then anybody who wants this fix can just install your patch plugin and not have to worry about maintaining a local version of the wkwebview plugin. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine pull request #23: CB-11997: Add crash recove...
Github user cjpearson commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/23#discussion_r90223157
--- Diff: src/ios/CDVWKWebViewEngine.m ---
@@ -123,6 +123,32 @@ - (void)pluginInitialize
name:UIApplicationWillEnterForegroundNotification
object:nil];
NSLog(@"Using WKWebView");
+
+[self addURLObserver];
+}
+
+- (void)onReset {
+[self addURLObserver];
+}
+
+static void * KVOContext =
+
+- (void)addURLObserver {
+if(![[NSProcessInfo processInfo]
isOperatingSystemAtLeastVersion:(NSOperatingSystemVersion){.majorVersion = 9,
.minorVersion = 0, .patchVersion = 0 }]){
--- End diff --
Yeah I was using the local webserver plugin to support iOS 8.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios issue #277: CB-11243: Fix target-device and deployment-target pr...
Github user cjpearson commented on the issue: https://github.com/apache/cordova-ios/pull/277 It looks like the tests were failing because of the spy on writeFileSync. I've added a fix and pulled them into this PR. I also tried to add a test to verify the final .app is correct, but I couldn't find any examples to work with. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios issue #277: CB-11243: Fix target-device and deployment-target pr...
Github user cjpearson commented on the issue: https://github.com/apache/cordova-ios/pull/277 Regarding the tests, based on what I'm seeing they should not be failing. The settings are properly added to the project, but they are ignored in the final product. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios issue #277: CB-11243: Fix target-device and deployment-target pr...
Github user cjpearson commented on the issue: https://github.com/apache/cordova-ios/pull/277 It seems like the xcconfig settings override the buildFlag flag. When I run this command on a starter cordova-ios 4.3.0 project, the MinimumOSVersion in the App's Info.plist is still iOS 8.0. cordova compile ios --buildFlag="IPHONEOS_DEPLOYMENT_TARGET=9.0" I get a similar result with the `TARGETED_DEVICE_FAMILY` setting. I added the settings back into the pbxproj to handle the case where the user doesn't use one of these config options. Otherwise the default would be a minimum version of iOS 10 and iPhone only. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request #277: CB-11243: Fix target-device and deployment-ta...
GitHub user cjpearson opened a pull request: https://github.com/apache/cordova-ios/pull/277 CB-11243: Fix target-device and deployment-target preferences ### Platforms affected iOS ### What does this PR do? Fixes target-device and deployment-target preferences. There are several bugs reporting this issue. [CB-11243](https://issues.apache.org/jira/browse/CB-11243) [CB-11399](https://issues.apache.org/jira/browse/CB-11399) [CB-11772](https://issues.apache.org/jira/browse/CB-11772) [CB-11732](https://issues.apache.org/jira/browse/CB-11732) This change adds `IPHONEOS_DEPLOYMENT_TARGET` and `TARGETED_DEVICE_FAMILY` back to the project file. This is necessary for the preferences to work until [CB-11468](https://issues.apache.org/jira/browse/CB-11468) is completed. ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cjpearson/cordova-ios CB-11243 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-ios/pull/277.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #277 commit 73c7bf92b14cf27cc66595bad1325b18e456c3eb Author: Connor Pearson <cjp...@gmail.com> Date: 2016-11-11T14:17:19Z CB-11243: target-device and deployment-target were being ignored --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine pull request #23: CB-11997: Add crash recove...
GitHub user cjpearson opened a pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/23 CB-11997: Add crash recovery for iOS 8 ### Platforms affected iOS ### What does this PR do? Reloads the WebView when it crashes. This behavior already exists on iOS >= 9, but has not been added for iOS 8. ### What testing has been done on this change? I've tried consuming a bunch of memory in javascript to cause a crash. The app reloads successfully. ### Checklist - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cjpearson/cordova-plugin-wkwebview-engine master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/23.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #23 commit d9d30f2cf91f307b44ecc5efe1763ae7d0b3bdb3 Author: Connor Pearson <cjp...@gmail.com> Date: 2016-10-11T18:04:37Z CB-11997: Add crash recovery for iOS 8 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine pull request #12: CB-10142, CB-10732: Allow ...
Github user cjpearson closed the pull request at: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/12 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugins pull request #27: CB-11644: (ios) Set cdvtoken cookie path t...
GitHub user cjpearson opened a pull request: https://github.com/apache/cordova-plugins/pull/27 CB-11644: (ios) Set cdvtoken cookie path to root ### Platforms affected iOS ### What does this PR do? Set the cdvToken cookie's path to root, so it applies to all requests including those outside of www folder. ### What testing has been done on this change? Tested on iOS 8.4.1 ### Checklist - [X] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to secret...@apache.org. - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cjpearson/cordova-plugins CB-11644 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugins/pull/27.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #27 commit bdf8272ed6d4e6a6442956502d9417b25f1df565 Author: Connor Pearson <cjp...@gmail.com> Date: 2016-07-29T20:12:19Z CB-11644: (ios) Set cookie path to root --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugins pull request #26: CB-11643: return after sending error
GitHub user cjpearson opened a pull request:
https://github.com/apache/cordova-plugins/pull/26
CB-11643: return after sending error
### Platforms affected
iOS
### What does this PR do?
After an error is returned, we should return and not process the request.
Continuing to process the request can cause a crash.
### What testing has been done on this change?
Tested on a device with the sample app, adding the following code.
```
document.getElementById("deviceready").addEventListener("click", function
buttonClick() {
var fail = function () { console.log("failure"); }
var photoSuccess = function (uri) {
var img = document.createElement("img");
debugger;
img.src = uri;
document.getElementById("deviceready").appendChild(img);
};
navigator.camera.getPicture(photoSuccess, fail, {
destinationType:
navigator.camera.DestinationType.FILE_URI,
sourceType:
navigator.camera.PictureSourceType.CAMERA,
saveToPhotoAlbum: false
});
});
```
### Checklist
- [X] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and
submitted to secret...@apache.org.
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB- is the JIRA ID & "android" is the platform
affected.
- [] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cjpearson/cordova-plugins webserver-crash
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugins/pull/26.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #26
commit 2568693862556a712fdf760487a9d3f6f0ffb5f9
Author: Connor Pearson <cjp...@gmail.com>
Date: 2016-07-29T14:15:01Z
CB-11643: return after sending error
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine pull request #12: CB-10142: Allow opening We...
GitHub user cjpearson opened a pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/12 CB-10142: Allow opening WebSQL databases in WKWebView ### Platforms affected iOS ### What does this PR do? Allows WebSql databases to be opened when using this plugin. Right now it gives databases a quota of 50MB. ### What testing has been done on this change? Tested on iOS 9 iPhone simulator and iPad. ### Checklist - [X] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to secret...@apache.org. - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cjpearson/cordova-plugin-wkwebview-engine CB-10142 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/12.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #12 commit 7856a61866971cd2c9eb5340c65891abea70c315 Author: Connor Pearson <cjp...@gmail.com> Date: 2016-07-23T00:16:00Z CB-10142: Allow opening WebSQL databases in WKWebView --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib issue #260: CB-9371: Fix prepare deleting orientation preference...
Github user cjpearson commented on the issue: https://github.com/apache/cordova-lib/pull/260 Thanks, @shazron. I've rebased this pr and opened a new one here https://github.com/apache/cordova-ios/pull/233 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request #233: CB-9371, CB-9703: Fix how prepare handles ori...
GitHub user cjpearson opened a pull request: https://github.com/apache/cordova-ios/pull/233 CB-9371, CB-9703: Fix how prepare handles orientation on ios Relates to https://github.com/apache/cordova-lib/pull/260 This changes the behavior of the default orientation preference to match the default orientation settings for new native iOS projects. It also no longer modifies the orientation settings if the user does not specify an orientation preference. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cjpearson/cordova-ios CB-9371 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-ios/pull/233.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #233 commit 55b0a26fb2ba4186273d98fb3adcee205b2fb632 Author: Connor Pearson <cjp...@gmail.com> Date: 2016-07-01T00:27:12Z CB-9371: Fix how prepare handles orientation on ios --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #94: CB-3360: Set custom inappbrowser user...
Github user cjpearson commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/94 @shazron, just did a rebase. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib issue #260: CB-9371: Fix prepare deleting orientation preference...
Github user cjpearson commented on the issue: https://github.com/apache/cordova-lib/pull/260 @shazron, could you please take a look at this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: CB-3360: Set custom inap...
GitHub user cjpearson reopened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/94 CB-3360: Set custom inappbrowser user agent for ios This uses the same OverrideUserAgent and AppendUserAgent properties as the pull requests for cordova-ios and cordova-android. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cjpearson/cordova-plugin-inappbrowser ios-user-agent Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-inappbrowser/pull/94.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #94 commit df2e82fb92be83e18dda5c9dd0a5604c58ff58d3 Author: Connor Pearson <cjp...@gmail.com> Date: 2015-03-13T17:52:30Z CB-3360: Set custom inappbrowser user agent for ios --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: CB-3360: Set custom inap...
Github user cjpearson closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/94 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file pull request: Fixed NullPointer Exception in A...
Github user cjpearson commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/119#issuecomment-154190076 https://issues.apache.org/jira/browse/CB-9965 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file pull request: Fixed NullPointer Exception in A...
Github user cjpearson commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/119#issuecomment-154181249 @infil00p, could you take a look at this PR? I'm running into this issue when I try to open a file that was taken from the camera plugin on Android Lollipop. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file pull request: Add handling for SecurityExcepti...
GitHub user cjpearson opened a pull request: https://github.com/apache/cordova-plugin-file/pull/142 Add handling for SecurityException Instead of returning UNKNOWN_ERR, return SECURITY_ERR when a SecurityException is caught. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cjpearson/cordova-plugin-file security_err Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-file/pull/142.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #142 commit 8f07e2655b165d883b66936e747e388988afe68c Author: Connor Pearson <cjp...@gmail.com> Date: 2015-10-27T12:33:03Z Add handling for SecurityException --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-device pull request: Change UUID to use [UIDevice i...
Github user cjpearson commented on the pull request: https://github.com/apache/cordova-plugin-device/pull/36#issuecomment-122255716 I think you might still want to check in user defaults first, so the uuid value doesn't change for users who already had the app installed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9371: Don't delete orientation prefer...
GitHub user cjpearson opened a pull request: https://github.com/apache/cordova-lib/pull/260 CB-9371: Don't delete orientation preferences by default You can merge this pull request into a Git repository by running: $ git pull https://github.com/cjpearson/cordova-lib orientation-bug Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/260.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #260 commit a3c86157dd5354db26ba18eabc40cb8eaa8e0351 Author: Connor Pearson cjp...@gmail.com Date: 2015-07-15T15:06:09Z Don't delete orientation preferences by default --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: CB-9255: make getUriType case insens...
Github user cjpearson commented on the pull request: https://github.com/apache/cordova-android/pull/186#issuecomment-115784095 The file transfer plugin uses this method to ensure that a url uses http or https. We would get INVALID_URL_ERR whenever a user entered a url with a capital h in Http. We've worked around this by lowercasing the scheme automatically, but this seems like something that could cause issues again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: CB-9255: make getUriType case insens...
GitHub user cjpearson opened a pull request: https://github.com/apache/cordova-android/pull/186 CB-9255: make getUriType case insensitive You can merge this pull request into a Git repository by running: $ git pull https://github.com/cjpearson/cordova-android uri-fix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-android/pull/186.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #186 commit e0b0b2df9cadc2f695a95d44cc673dfea767cd26 Author: Connor Pearson cjp...@gmail.com Date: 2015-06-26T13:37:13Z make getUriType case insensitive --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request: * is a Right-to-left associative operato...
Github user cjpearson commented on the pull request: https://github.com/apache/cordova-ios/pull/145#issuecomment-115654625 The current style is not incorrect or a bad habit. It may not follow Apple's style, but both styles are valid and readable. Many C programmers choose to attach the asterisk to the variable, emphasizing syntax, while most C++ programmers prefer to emphasize the type by attaching the asterisk to the type. Since Objective-C, like C++, is an Object Oriented language, I think it makes much more sense to emphasize type by keeping the asterisk attached to the type. Also, there are several common situations in Objective-C where there is no variable for you to attach the asterisk to even if you wanted. Casting `(NSString*)someObject` Method Parameters `- (void)someMethod:(NSObject*)param;` Generics `NSArrayNSString** someArray;` The common defense against grouping the asterisk with the type is that one might think these two lines behave the same. int* a, b, c; int *a, *b, *c; I think that's a pretty easy situation to avoid. Just declare your variables on different lines. For whatever it's worth, I vote keeping the style the way it is. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugins pull request: CB-8337: Fix keyboardShrinksView for...
Github user cjpearson commented on the pull request: https://github.com/apache/cordova-plugins/pull/18#issuecomment-107043443 @Fmstrat these changes should be in the latest version. Cordova no longer supports this as a core plugin though. I have a fork [here](https://github.com/cjpearson/cordova-plugin-keyboard) with some other fixes if you still want to use the shrinkview behavior. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request: Change _state after creating logging str...
GitHub user cjpearson opened a pull request: https://github.com/apache/cordova-ios/pull/141 Change _state after creating logging string Currently, the code sets `_state` immediately before creating the string to log, so it will always print CDVWebViewDelegate: Navigation started when state=1. This change just moves setting `_state` to after the log statement. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cjpearson/cordova-ios log-fix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-ios/pull/141.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #141 commit 94a4cb2d686ac080f7d0a7b69e85b68c6046eb63 Author: Connor Pearson cjp...@gmail.com Date: 2015-05-13T15:31:06Z Change _state after creating error string --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-8780: Display popover using...
GitHub user cjpearson opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/81 CB-8780: Display popover using main thread. Fixes popover slowness You can merge this pull request into a Git repository by running: $ git pull https://github.com/cjpearson/cordova-plugin-camera popover-fix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-camera/pull/81.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #81 commit dd3005c1c28c50a774f307ad1821f39c3f2b63ee Author: Connor Pearson cjp...@gmail.com Date: 2015-04-01T14:34:17Z Display popover using main thread. Fixes popover slowness --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-dialogs pull request: CB-8773: Fix for iOS 8 keyboa...
GitHub user cjpearson opened a pull request: https://github.com/apache/cordova-plugin-dialogs/pull/50 CB-8773: Fix for iOS 8 keyboard not appearing on prompt You can merge this pull request into a Git repository by running: $ git pull https://github.com/cjpearson/cordova-plugin-dialogs CB-8773 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-dialogs/pull/50.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #50 commit 9570b1fa457a284923f1db80a088d638053acf6c Author: Connor Pearson cjp...@gmail.com Date: 2015-04-02T00:12:11Z CB-8773: Fix for iOS 8 keyboard not appearing on prompt --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugins pull request: CB-8337: Fix keyboardShrinksView for...
Github user cjpearson commented on the pull request: https://github.com/apache/cordova-plugins/pull/18#issuecomment-87709992 Thanks for the merge @agrieve. Unfortunately, I've just found another issue. If I recall correctly, one of the major factors was because iOS 7 shrank webviews automatically, but they reversed this in 7.1. I'll definitely bring it up again, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugins pull request: CB-8337: Fix keyboardShrinksView for...
Github user cjpearson commented on the pull request: https://github.com/apache/cordova-plugins/pull/18#issuecomment-87343580 @davidtlee If you're using the cordova command line, `cordova plugin add https://github.com/cjpearson/cordova-plugins#master:keyboard` should work --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: CB-3360: Set custom inap...
GitHub user cjpearson opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/95 CB-3360: Set custom inappbrowser user agent for android This uses the same OverrideUserAgent and AppendUserAgent properties as the pull requests for cordova-ios and cordova-android. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cjpearson/cordova-plugin-inappbrowser android-user-agent Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-inappbrowser/pull/95.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #95 commit ebac47b5619163559faf1ce4eb61ebf75485ef6c Author: Connor Pearson cjp...@gmail.com Date: 2015-03-13T18:12:40Z CB-3360: Set custom inappbrowser user agent for android --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: CB-3360: Set custom inap...
GitHub user cjpearson opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/94 CB-3360: Set custom inappbrowser user agent for ios This uses the same OverrideUserAgent and AppendUserAgent properties as the pull requests for cordova-ios and cordova-android. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cjpearson/cordova-plugin-inappbrowser ios-user-agent Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-inappbrowser/pull/94.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #94 commit df2e82fb92be83e18dda5c9dd0a5604c58ff58d3 Author: Connor Pearson cjp...@gmail.com Date: 2015-03-13T17:52:30Z CB-3360: Set custom inappbrowser user agent for ios --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request: CB-7428: Enable Swift development of Plu...
Github user cjpearson commented on the pull request: https://github.com/apache/cordova-ios/pull/133#issuecomment-82005079 That's correct. Thanks, @shazron. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: Make toolbar more iOS7 ...
Github user cjpearson commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/92#issuecomment-80476954
I'm seeing some extra grey area when hiding the location bar and showing
the toolbar on top.
`window.open('http://google.com', '_blank',
'location=no,toolbarposition=top')`
Changing TOOLBAR_HEIGHT to TOOLBAR_MARGIN_HEIGHT on line 649 fixes this,
but may open some other issues.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request: CB-7428: Enable Swift development of Plu...
Github user cjpearson commented on the pull request: https://github.com/apache/cordova-ios/pull/133#issuecomment-78029460 Thanks for the feedback, Shazron. I wasn't sure how it should be brought up, I just wanted to get the ball rolling somehow. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request: CB-7428: Enable Swift development of Plu...
GitHub user cjpearson opened a pull request: https://github.com/apache/cordova-ios/pull/133 CB-7428: Enable Swift development of Plugins I've included the changes listed under CB-7428 into the template projects. As part of these changed, I've moved up the minimum deployment target to iOS 7.0 ( a requirement for Swift.) It's also been over a year since iOS 5 support was dropped. I've been testing with this [example plugin](https://github.com/edewit/cordova-plugin-hello/tree/swift). With these changes you can now add Swift plugins without changing any settings in Xcode. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cjpearson/cordova-ios CB-7428 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-ios/pull/133.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #133 commit 40fab32f7a44f50c04758d2bb758df3fbc4a840a Author: Connor Pearson cjp...@gmail.com Date: 2015-03-09T22:40:40Z CB-7428: Update deployment target to 7.0 commit e078969543ba82465ec024b692896c0418c76051 Author: Connor Pearson cjp...@gmail.com Date: 2015-03-09T23:07:53Z CB-7428: Add bridging header. Make sure all deployment targets are 7.0 Add swift runtime to search path --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: CB-8552 Add toolbar opti...
GitHub user cjpearson opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/87 CB-8552 Add toolbar option for android This change adds the toolbar option to android. The location property determines whether or not the URL is visible while the toolbar property shows or hides the entire toolbar. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cjpearson/cordova-plugin-inappbrowser android-toolbar Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-inappbrowser/pull/87.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #87 commit 6672ee4e9cb804da32c3014d7ab455ae4fe85228 Author: Connor Pearson cjp...@gmail.com Date: 2015-02-26T14:06:06Z CB-8552: Add toolbar property to android commit 36833685330c0ce66cc26ffcd54b91341f99c9bc Author: Connor Pearson cjp...@gmail.com Date: 2015-02-26T14:08:23Z update docs for toolbar option --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: CB-3750: Add loading spi...
GitHub user cjpearson opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/89 CB-3750: Add loading spinner for ios You can merge this pull request into a Git repository by running: $ git pull https://github.com/cjpearson/cordova-plugin-inappbrowser ios-spinner Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-inappbrowser/pull/89.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #89 commit 0706240df9ac6e5ac3f73f1dade9c2128e0f711f Author: Connor Pearson cjp...@gmail.com Date: 2015-02-27T15:30:05Z CB-3750: Make spinner visible, center in webview --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: CB-3750: Add loading spi...
GitHub user cjpearson opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/88 CB-3750: Add loading spinner for android You can merge this pull request into a Git repository by running: $ git pull https://github.com/cjpearson/cordova-plugin-inappbrowser android-spinner Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-inappbrowser/pull/88.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #88 commit ef4880281d3c9e210226d808bc30e91520fb179d Author: Connor Pearson cjp...@gmail.com Date: 2015-02-27T16:35:30Z CB-3750: Add spinner for android --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-7827: Allow user to specify android a...
Github user cjpearson commented on the pull request: https://github.com/apache/cordova-lib/pull/171#issuecomment-76387512 @agrieve I've addressed your comments, could you take another look? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: CB-8534: Add support for...
GitHub user cjpearson opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/82 CB-8534: Add support for auth dialogs in inappbrowser plugin When an authentication challenge is received, the inappbrowser will now check to see if a plugin can respond to the challenge before going to the default behavior. This is the same behavior that was added to cordova-android in CB-8201. It allows plugins like [Auth Dialog](https://github.com/MSOpenTech/cordova-plugin-auth-dialog) to work with the inappbrowser. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cjpearson/cordova-plugin-inappbrowser master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-inappbrowser/pull/82.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #82 commit e607ac63eed97b420c07a328d7c6bfce6d9d49ec Author: Connor Pearson cjp...@gmail.com Date: 2015-02-24T16:51:38Z CB-8534: Allow plugins to respond to onReceivedHttpAuthRequest commit e3b1a06fe37dfdde55df7ce810c429390e25cf6f Author: Connor Pearson cjp...@gmail.com Date: 2015-02-24T18:48:14Z If getPluginManager does not work access the field directly --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: CB-7827: Allow user to specify andro...
Github user cjpearson commented on the pull request: https://github.com/apache/cordova-android/pull/160#issuecomment-75749293 @agrieve I've modified it to use --activity-name with nopt. I tried to follow the style of the iOS create script. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-7827: Allow user to specify android a...
Github user cjpearson commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/171#discussion_r25187402
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -521,19 +521,27 @@ function getCreateArgs(platDetails, projectRoot, cfg,
template_dir, opts) {
if (/android|ios/.exec(platDetails.platform)
semver.gt(platDetails.version, '3.3.0')) {
args.push('--cli');
}
-
+
var pkg = cfg.packageName().replace(/[^\w.]/g,'_');
// CB-6992 it is necessary to normalize characters
// because node and shell scripts handles unicode symbols differently
// We need to normalize the name to NFD form since iOS uses NFD
unicode form
var name = platDetails.platform == 'ios' ? unorm.nfd(cfg.name()) :
cfg.name();
args.push(output, pkg, name);
+
+var activityName = cfg.android_activityName();
+if (activityName platDetails.platform === 'android') {
+activityName = activityName.replace(/W/g, '');
--- End diff --
Yup, typo there.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: CB-7827: Allow user to specify andro...
Github user cjpearson commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/160#discussion_r25187348
--- Diff: bin/create ---
@@ -23,14 +23,15 @@ var create = require('./lib/create');
var args = require('./lib/simpleargs').getArgs(process.argv);
if (args['--help'] || args._.length === 0) {
-console.log('Usage: ' + path.relative(process.cwd(),
path.join(__dirname, 'create')) + ' path_to_new_project package_name
project_name [template_path] [--link]');
+console.log('Usage: ' + path.relative(process.cwd(),
path.join(__dirname, 'create')) + ' path_to_new_project package_name
project_name activity_name [template_path] [--link]');
--- End diff --
I wasn't sure of the best way to make both template_path and activity_name
optional. I explored using --activity-name activity_name using nopt, which
cordova-ios uses for arguments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-7827: Allow user to specify android a...
Github user cjpearson commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/171#discussion_r25187454
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -521,19 +521,27 @@ function getCreateArgs(platDetails, projectRoot, cfg,
template_dir, opts) {
if (/android|ios/.exec(platDetails.platform)
semver.gt(platDetails.version, '3.3.0')) {
args.push('--cli');
}
-
+
var pkg = cfg.packageName().replace(/[^\w.]/g,'_');
// CB-6992 it is necessary to normalize characters
// because node and shell scripts handles unicode symbols differently
// We need to normalize the name to NFD form since iOS uses NFD
unicode form
var name = platDetails.platform == 'ios' ? unorm.nfd(cfg.name()) :
cfg.name();
args.push(output, pkg, name);
+
+var activityName = cfg.android_activityName();
+if (activityName platDetails.platform === 'android') {
+activityName = activityName.replace(/W/g, '');
+ args.push(activityName);
--- End diff --
Thanks for the review. I'll add this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-7827: Allow user to specify android a...
GitHub user cjpearson opened a pull request: https://github.com/apache/cordova-lib/pull/171 CB-7827: Allow user to specify android activity name This change adds an attribute to config.xml android-activityName that can be used to specify a custom activity name. If none is specified it will still default to MainActivity. See http://markmail.org/message/pj5ig4b54nk4l7dr for a discussion of this issue. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cjpearson/cordova-lib cb7827 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/171.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #171 commit 72b98af250e4d5b69715b1c0eda7f03fd380756a Author: Connor Pearson cjp...@gmail.com Date: 2015-02-22T20:46:23Z CB-7827: Allow user to specify android activity name --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: CB-7827: Allow user to specify andro...
GitHub user cjpearson opened a pull request: https://github.com/apache/cordova-android/pull/160 CB-7827: Allow user to specify android activity name This change adds a parameter to create to allow the user to specify an activity name. If none is specified it will still default to MainActivity. See http://markmail.org/message/pj5ig4b54nk4l7dr for a discussion of this issue. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cjpearson/cordova-android master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-android/pull/160.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #160 commit 3aa381f86ec3e36b0663f2fa75c60c8e250d8310 Author: Connor Pearson cjp...@gmail.com Date: 2015-02-22T20:44:54Z CB-7827: Allow user to specify android activity name --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8457: Ignore version specifier when r...
GitHub user cjpearson opened a pull request: https://github.com/apache/cordova-lib/pull/165 CB-8457: Ignore version specifier when running hooks Trims the version specifier when running hooks. This allows platform add hooks to run when a version specific platform add command is used. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cjpearson/cordova-lib master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/165.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #165 commit 35f831604b9b2254fe8f1eac59e92eef9fdeef35 Author: Connor Pearson cjp...@gmail.com Date: 2015-02-12T00:50:32Z CB-8457: Ignore version specifier when running hooks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugins pull request: CB-8337: Fix keyboardShrinksView for...
GitHub user cjpearson opened a pull request: https://github.com/apache/cordova-plugins/pull/18 CB-8337: Fix keyboardShrinksView for external keyboards, CB-8339 enable keyboardShrinksView on iOS 7.1+ Instead of listening for keyboard show and hide events, the plugin now listens for keyboard frame change events and responds accordingly. This should also fix CB-5711 or any other case where the keyboard frame changes without firing a show or hide event. This also changes keyboardShrinksView from being a no-op on iOS = 7.0 to being a no-op on iOS = 7.0 and fixes the screen being pushed up before being resized (CB-5642.) You can merge this pull request into a Git repository by running: $ git pull https://github.com/cjpearson/cordova-plugins master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugins/pull/18.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #18 commit d1e9b85ad06af10759e68dcbc2b6af8cb1229e67 Author: Connor Pearson cjp...@gmail.com Date: 2015-01-09T17:24:53Z Change KeyboardShrinkView to use KeyboardFrameWillChange notification instead. Have animation match the keyboard animation. Support external keyboards. commit 398cca80652f6a6d0bd00440708db66b52380b81 Author: Connor Pearson cjp...@gmail.com Date: 2015-01-12T16:25:28Z Instead of adding and removing observer when _shrinkView changes, check for _shrinkView in the method that is called. Always resize the webview if the keyboard is moving off screen. This covers the case when shrinkView is disabled while the keyboard is visible. Only disable the webview push up if shrinkView is enabled. Fix regression which broke disableScrollingInShrinkView. commit 9414dbc01d109a54855f94a8d8223209ce82324f Author: Connor Pearson cjp...@gmail.com Date: 2015-01-12T17:15:58Z Take into account whether or not the accessory bar is showing when shrinking the webview. commit 2b83934c38f233253064a5c598b34dfdea7fc352 Author: Connor Pearson cjp...@gmail.com Date: 2015-01-12T18:27:58Z Handle split and undocked keyboards. They should hover over the app and not resize the webview. commit 5fb233b19ae8638c933506447bf54ffb89659c80 Author: Connor Pearson cjp...@gmail.com Date: 2015-01-12T18:38:01Z Remove empty getter/setter. Use autogenerated instead. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-statusbar pull request: update docs for StatusBarBa...
GitHub user cjpearson opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/20 update docs for StatusBarBackgroundColor The default value is no longer black. (CB-7486) You can merge this pull request into a Git repository by running: $ git pull https://github.com/cjpearson/cordova-plugin-statusbar master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-statusbar/pull/20.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #20 commit 607e5d66add7dea9f791defe97cf62c711741d5e Author: Connor Pearson cjp...@gmail.com Date: 2015-01-08T00:55:34Z update docs for StatusBarBackgroundColor The default value is no longer black. (CB-7486) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
