[GitHub] cordova-plugin-inappbrowser issue #238: added cookies support for Android an...

2017-08-29 Thread denisx304
Github user denisx304 commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/238
  
Whenever you want to send cookies to one url.
For exemple keeping the user logged in from your mobile application to the 
web application.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-inappbrowser issue #238: added cookies support for Android an...

2017-08-29 Thread denisx304
Github user denisx304 commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/238
  
exactly


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-inappbrowser issue #238: added cookies support for Android an...

2017-08-28 Thread denisx304
Github user denisx304 commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/238
  
@janpio You can send any cookie as long as the server interprets it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-inappbrowser issue #238: added cookies support for Android an...

2017-08-23 Thread denisx304
Github user denisx304 commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/238
  
I understand you now. This PR does not include that feature.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-inappbrowser issue #238: added cookies support for Android

2017-08-23 Thread denisx304
Github user denisx304 commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/238
  
@danova123 Please go through my commit. The `cordova.InAppBrowser.open` 
receives one more parameter, which is an object. The keys of this object are 
the name of the cookies that you want to set, and the values are the values of 
the cookies.

It simply sets these cookies with `CookieManager.setCookie` to the domain 
where the url belongs.

Did my comment answer your question?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-inappbrowser issue #238: added cookies support for Android

2017-08-23 Thread denisx304
Github user denisx304 commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/238
  
@danova123 what do you mean?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-inappbrowser pull request #238: added cookies support for And...

2017-08-21 Thread denisx304
GitHub user denisx304 opened a pull request:

https://github.com/apache/cordova-plugin-inappbrowser/pull/238

added cookies support for Android



### Platforms affected
Android

### What does this PR do?
Allows the `cordova.InAppBrowser.open()` function to receive another 
parameter, `cookies`, an object described like `name: value`. It sets then 
those cookies through Android native code.

### What testing has been done on this change?
`cordova.InAppBrowser.open(page, "_self", null, { "cookieName": 
"cookieValue" });`
The cookies were verified on the server-side.

### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/denisx304/cordova-plugin-inappbrowser master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/238.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #238


commit 9a6f4c4dc5164073ac183eba2954e732de92519b
Author: Denis Visan <denis.vi...@inomedica.ro>
Date:   2017-08-21T16:40:04Z

added cookies support for Android




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org