[GitHub] codecov-io commented on issue #326: CB-12940: [IOS] Use deployment-target from config.xml for platform ve?
codecov-io commented on issue #326: CB-12940: [IOS] Use deployment-target from config.xml for platform ve? URL: https://github.com/apache/cordova-ios/pull/326#issuecomment-321806420 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/326?src=pr&el=h1) Report > Merging [#326](https://codecov.io/gh/apache/cordova-ios/pull/326?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/d44cec6266f5890802268e996722a380a0e51927?src=pr&el=desc) will **increase** coverage by `0.46%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/cordova-ios/pull/326?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #326 +/- ## == + Coverage 63.97% 64.43% +0.46% == Files 14 14 Lines1674 1676 +2 Branches 277 278 +1 == + Hits 1071 1080 +9 + Misses603 596 -7 ``` | [Impacted Files](https://codecov.io/gh/apache/cordova-ios/pull/326?src=pr&el=tree) | Coverage ? | | |---|---|---| | [bin/templates/scripts/cordova/lib/Podfile.js](https://codecov.io/gh/apache/cordova-ios/pull/326?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL1BvZGZpbGUuanM=) | `77.59% <100%> (+0.18%)` | :arrow_up: | | [bin/templates/scripts/cordova/Api.js](https://codecov.io/gh/apache/cordova-ios/pull/326?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvQXBpLmpz) | `58.97% <100%> (+5.07%)` | :arrow_up: | | [bin/templates/scripts/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-ios/pull/326?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3ByZXBhcmUuanM=) | `84.63% <0%> (-0.04%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/326?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/326?src=pr&el=footer). Last update [d44cec6...fe5a049](https://codecov.io/gh/apache/cordova-ios/pull/326?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). ---- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] igormartsekha commented on a change in pull request #326: CB-12940: [IOS] Use deployment-target from config.xml for platform ve?
igormartsekha commented on a change in pull request #326: CB-12940: [IOS] Use
deployment-target from config.xml for platform ve?
URL: https://github.com/apache/cordova-ios/pull/326#discussion_r132825735
##
File path: bin/templates/scripts/cordova/lib/Podfile.js
##
@@ -98,8 +98,8 @@ Podfile.prototype.getTemplate = function () {
var projectName = this.escapeSingleQuotes(this.projectName);
return util.format(
'# DO NOT MODIFY -- auto-generated by Apache Cordova\n' +
-'platform :ios, \'8.0\'\n' +
-'target \'%s\' do\n' +
+'platform :ios, \'%s\'\n' +
+'use_frameworks!\n' +
Review comment:
It doesn't allow to add swift libraries in Podfile.
----
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] igormartsekha commented on a change in pull request #326: CB-12940: [IOS] Use deployment-target from config.xml for platform ve?
igormartsekha commented on a change in pull request #326: CB-12940: [IOS] Use
deployment-target from config.xml for platform ve?
URL: https://github.com/apache/cordova-ios/pull/326#discussion_r132825735
##
File path: bin/templates/scripts/cordova/lib/Podfile.js
##
@@ -98,8 +98,8 @@ Podfile.prototype.getTemplate = function () {
var projectName = this.escapeSingleQuotes(this.projectName);
return util.format(
'# DO NOT MODIFY -- auto-generated by Apache Cordova\n' +
-'platform :ios, \'8.0\'\n' +
-'target \'%s\' do\n' +
+'platform :ios, \'%s\'\n' +
+'use_frameworks!\n' +
Review comment:
It doesn't allow to add swift libraries in Podfile.
----
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] wf9a5m75 commented on issue #302: CB-11895: openURL: is deprecated on iOS 10
wf9a5m75 commented on issue #302: CB-11895: openURL: is deprecated on iOS 10 URL: https://github.com/apache/cordova-ios/pull/302#issuecomment-321947370 Could you tell me what the alternative method is? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] kaplanmaxe opened a new pull request #239: CB-13175: fixing windows8.1 crash on startup
kaplanmaxe opened a new pull request #239: CB-13175: fixing windows8.1 crash on startup URL: https://github.com/apache/cordova-windows/pull/239 ### Platforms affected windows ### What does this PR do? Ticket: https://issues.apache.org/jira/browse/CB-13175 This issue is a follow-up to [CB-12784](https://github.com/apache/cordova-windows/pull/232) The user added the fix in `cordova-js-src/splashscreen.js` however it needs to be added to `template/www/cordova.js` as well. This PR takes the already accepted fix and applies it to `cordova.js` as well. ### What testing has been done on this change? Ran on Windows 10 Creators Update (build 15063.250), Ran on Windows 8.1, Ran on Windows 10 mobile ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] shazron commented on a change in pull request #326: CB-12940: [IOS] Use deployment-target from config.xml for platform ve?
shazron commented on a change in pull request #326: CB-12940: [IOS] Use
deployment-target from config.xml for platform ve?
URL: https://github.com/apache/cordova-ios/pull/326#discussion_r132772679
##
File path: bin/templates/scripts/cordova/lib/Podfile.js
##
@@ -98,8 +98,8 @@ Podfile.prototype.getTemplate = function () {
var projectName = this.escapeSingleQuotes(this.projectName);
return util.format(
'# DO NOT MODIFY -- auto-generated by Apache Cordova\n' +
-'platform :ios, \'8.0\'\n' +
-'target \'%s\' do\n' +
+'platform :ios, \'%s\'\n' +
+'use_frameworks!\n' +
Review comment:
we can't use `use_frameworks!`. See:
https://issues.apache.org/jira/browse/CB-11893
----
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] shazron commented on issue #321: CB-12937 - (iOS) added new method handleOpenURLWithApplicationSourceAndAnno?
shazron commented on issue #321: CB-12937 - (iOS) added new method handleOpenURLWithApplicationSourceAndAnno? URL: https://github.com/apache/cordova-ios/pull/321#issuecomment-321905248 Changing release to cordova-ios@4.4.1 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] shazron closed pull request #321: CB-12937 - (iOS) added new method handleOpenURLWithApplicationSourceAndAnno?
shazron closed pull request #321: CB-12937 - (iOS) added new method handleOpenURLWithApplicationSourceAndAnno? URL: https://github.com/apache/cordova-ios/pull/321 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] shazron closed pull request #330: CB-13164: Integrated cordova-plugin-console
shazron closed pull request #330: CB-13164: Integrated cordova-plugin-console URL: https://github.com/apache/cordova-ios/pull/330 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] iget-master commented on issue #393: Fix for Jira issue CB-12981
iget-master commented on issue #393: Fix for Jira issue CB-12981 URL: https://github.com/apache/cordova-android/pull/393#issuecomment-321877182 Someone on this? It's impossible to run cordova over android emulator with Android 8 AVD due this issue This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] macdonst commented on issue #399: CB-12730: Compat - INTEGRATE
macdonst commented on issue #399: CB-12730: Compat - INTEGRATE URL: https://github.com/apache/cordova-android/pull/399#issuecomment-321831462 Got the ? from @infil00p so I've merged this PR. Off to prevent cordova-plugin-compat from being installed on the next version of cordova-android. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] macdonst closed pull request #399: CB-12730: Compat - INTEGRATE
macdonst closed pull request #399: CB-12730: Compat - INTEGRATE URL: https://github.com/apache/cordova-android/pull/399 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] codecov-io commented on issue #326: CB-12940: [IOS] Use deployment-target from config.xml for platform ve?
codecov-io commented on issue #326: CB-12940: [IOS] Use deployment-target from config.xml for platform ve? URL: https://github.com/apache/cordova-ios/pull/326#issuecomment-321806420 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/326?src=pr&el=h1) Report > Merging [#326](https://codecov.io/gh/apache/cordova-ios/pull/326?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/d44cec6266f5890802268e996722a380a0e51927?src=pr&el=desc) will **increase** coverage by `0.46%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/cordova-ios/pull/326?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #326 +/- ## == + Coverage 63.97% 64.43% +0.46% == Files 14 14 Lines1674 1676 +2 Branches 277 278 +1 == + Hits 1071 1080 +9 + Misses603 596 -7 ``` | [Impacted Files](https://codecov.io/gh/apache/cordova-ios/pull/326?src=pr&el=tree) | Coverage ? | | |---|---|---| | [bin/templates/scripts/cordova/Api.js](https://codecov.io/gh/apache/cordova-ios/pull/326?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvQXBpLmpz) | `58.97% <100%> (+5.07%)` | :arrow_up: | | [bin/templates/scripts/cordova/lib/Podfile.js](https://codecov.io/gh/apache/cordova-ios/pull/326?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL1BvZGZpbGUuanM=) | `77.59% <100%> (+0.18%)` | :arrow_up: | | [bin/templates/scripts/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-ios/pull/326?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3ByZXBhcmUuanM=) | `84.63% <0%> (-0.04%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/326?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/326?src=pr&el=footer). Last update [d44cec6...5593026](https://codecov.io/gh/apache/cordova-ios/pull/326?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). ---- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] igormartsekha commented on issue #326: CB-12940: [IOS] Use deployment-target from config.xml for platform ve?
igormartsekha commented on issue #326: CB-12940: [IOS] Use deployment-target from config.xml for platform ve? URL: https://github.com/apache/cordova-ios/pull/326#issuecomment-321805967 I fixed problem with failed test on appveyor This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] janpio commented on issue #244: CB-10140 Use application id instead of package name when running
janpio commented on issue #244: CB-10140 Use application id instead of package name when running URL: https://github.com/apache/cordova-android/pull/244#issuecomment-321799938 Was this added via another PR in the meantime? Seems like a useful change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] codecov-io commented on issue #330: CB-13164: Integrated cordova-plugin-console
codecov-io commented on issue #330: CB-13164: Integrated cordova-plugin-console URL: https://github.com/apache/cordova-ios/pull/330#issuecomment-321694544 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/330?src=pr&el=h1) Report > Merging [#330](https://codecov.io/gh/apache/cordova-ios/pull/330?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/0dfe4ca5d8ba446231a6247ef3bb8b1b3670e89b?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/cordova-ios/pull/330?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #330 +/- ## === Coverage 63.95% 63.95% === Files 14 14 Lines1673 1673 Branches 277 277 === Hits 1070 1070 Misses603 603 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/330?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/330?src=pr&el=footer). Last update [0dfe4ca...adabe28](https://codecov.io/gh/apache/cordova-ios/pull/330?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] codecov-io commented on issue #330: CB-13164: Integrated cordova-plugin-console
codecov-io commented on issue #330: CB-13164: Integrated cordova-plugin-console URL: https://github.com/apache/cordova-ios/pull/330#issuecomment-321694544 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/330?src=pr&el=h1) Report > Merging [#330](https://codecov.io/gh/apache/cordova-ios/pull/330?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/0dfe4ca5d8ba446231a6247ef3bb8b1b3670e89b?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/cordova-ios/pull/330?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #330 +/- ## === Coverage 63.95% 63.95% === Files 14 14 Lines1673 1673 Branches 277 277 === Hits 1070 1070 Misses603 603 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/330?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/330?src=pr&el=footer). Last update [0dfe4ca...adabe28](https://codecov.io/gh/apache/cordova-ios/pull/330?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] codecov-io commented on issue #330: CB-13164: Integrated cordova-plugin-console
codecov-io commented on issue #330: CB-13164: Integrated cordova-plugin-console URL: https://github.com/apache/cordova-ios/pull/330#issuecomment-321694544 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/330?src=pr&el=h1) Report > Merging [#330](https://codecov.io/gh/apache/cordova-ios/pull/330?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/0dfe4ca5d8ba446231a6247ef3bb8b1b3670e89b?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/cordova-ios/pull/330?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #330 +/- ## === Coverage 63.95% 63.95% === Files 14 14 Lines1673 1673 Branches 277 277 === Hits 1070 1070 Misses603 603 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/330?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/330?src=pr&el=footer). Last update [0dfe4ca...adabe28](https://codecov.io/gh/apache/cordova-ios/pull/330?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] codecov-io commented on issue #269: CB-12002 - Support LSApplicationQueriesSchemes
codecov-io commented on issue #269: CB-12002 - Support LSApplicationQueriesSchemes URL: https://github.com/apache/cordova-ios/pull/269#issuecomment-254372906 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/269?src=pr&el=h1) Report > Merging [#269](https://codecov.io/gh/apache/cordova-ios/pull/269?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/d44cec6266f5890802268e996722a380a0e51927?src=pr&el=desc) will **increase** coverage by `0.14%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/cordova-ios/pull/269?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #269 +/- ## == + Coverage 63.97% 64.12% +0.15% == Files 14 14 Lines1674 1681 +7 Branches 277 279 +2 == + Hits 1071 1078 +7 Misses603 603 ``` | [Impacted Files](https://codecov.io/gh/apache/cordova-ios/pull/269?src=pr&el=tree) | Coverage ? | | |---|---|---| | [bin/templates/scripts/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-ios/pull/269?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3ByZXBhcmUuanM=) | `84.87% <100%> (+0.21%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/269?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/269?src=pr&el=footer). Last update [d44cec6...24a0923](https://codecov.io/gh/apache/cordova-ios/pull/269?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). ---- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] filmaj commented on a change in pull request #330: CB-13164: Integrated cordova-plugin-console
filmaj commented on a change in pull request #330: CB-13164: Integrated cordova-plugin-console URL: https://github.com/apache/cordova-ios/pull/330#discussion_r132603124 ## File path: bin/templates/project/__PROJECT_NAME__/config.xml ## @@ -65,6 +65,10 @@ + Review comment: rebased + added This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] filmaj commented on a change in pull request #330: CB-13164: Integrated cordova-plugin-console
filmaj commented on a change in pull request #330: CB-13164: Integrated cordova-plugin-console URL: https://github.com/apache/cordova-ios/pull/330#discussion_r132602796 ## File path: bin/templates/project/__PROJECT_NAME__/config.xml ## @@ -65,6 +65,10 @@ + Review comment: _makes mental note as good use case for integration test_ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] shazron commented on issue #326: CB-12940: [IOS] Use deployment-target from config.xml for platform ve?
shazron commented on issue #326: CB-12940: [IOS] Use deployment-target from config.xml for platform ve? URL: https://github.com/apache/cordova-ios/pull/326#issuecomment-321710879 nvm I see that I have access to your PR branch already :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] shazron commented on a change in pull request #330: CB-13164: Integrated cordova-plugin-console
shazron commented on a change in pull request #330: CB-13164: Integrated cordova-plugin-console URL: https://github.com/apache/cordova-ios/pull/330#discussion_r132602539 ## File path: bin/templates/project/__PROJECT_NAME__/config.xml ## @@ -65,6 +65,10 @@ + Review comment: Yes, see the linked commit description. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] filmaj commented on a change in pull request #330: CB-13164: Integrated cordova-plugin-console
filmaj commented on a change in pull request #330: CB-13164: Integrated cordova-plugin-console URL: https://github.com/apache/cordova-ios/pull/330#discussion_r132601473 ## File path: bin/templates/project/__PROJECT_NAME__/config.xml ## @@ -65,6 +65,10 @@ + Review comment: oh is that a cordova-cli integration requirement or something? I was testing it without using cordova-cli, just by creating a project via `./bin/create`, etc. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] filmaj commented on a change in pull request #330: CB-13164: Integrated cordova-plugin-console
filmaj commented on a change in pull request #330: CB-13164: Integrated cordova-plugin-console URL: https://github.com/apache/cordova-ios/pull/330#discussion_r132601389 ## File path: bin/templates/project/__PROJECT_NAME__/config.xml ## @@ -65,6 +65,10 @@ + Review comment: really my locally generated project worked fine without that This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] shazron commented on issue #269: CB-12002 - Support LSApplicationQueriesSchemes
shazron commented on issue #269: CB-12002 - Support LSApplicationQueriesSchemes URL: https://github.com/apache/cordova-ios/pull/269#issuecomment-321709038 Oh I see "Add more commits by pushing to the allow-intent branch on dpogue/cordova-ios" maybe thats it This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] shazron commented on issue #269: CB-12002 - Support LSApplicationQueriesSchemes
shazron commented on issue #269: CB-12002 - Support LSApplicationQueriesSchemes URL: https://github.com/apache/cordova-ios/pull/269#issuecomment-321708845 oh? i don't see it, maybe I don't have karma -- weird, I thought we get those already. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] dpogue commented on issue #269: CB-12002 - Support LSApplicationQueriesSchemes
dpogue commented on issue #269: CB-12002 - Support LSApplicationQueriesSchemes URL: https://github.com/apache/cordova-ios/pull/269#issuecomment-321708412 It is checked already :\ I can try toggling it off and back on? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] shazron commented on issue #269: CB-12002 - Support LSApplicationQueriesSchemes
shazron commented on issue #269: CB-12002 - Support LSApplicationQueriesSchemes URL: https://github.com/apache/cordova-ios/pull/269#issuecomment-321708215 Please check the "Allow Edits from Maintainers" checkbox on this pull request. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] shazron commented on issue #326: CB-12940: [IOS] Use deployment-target from config.xml for platform ve?
shazron commented on issue #326: CB-12940: [IOS] Use deployment-target from config.xml for platform ve? URL: https://github.com/apache/cordova-ios/pull/326#issuecomment-321708176 Or you can check the "Allow Edits from Maintainers" checkbox on this pull request. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] shazron commented on issue #326: CB-12940: [IOS] Use deployment-target from config.xml for platform ve?
shazron commented on issue #326: CB-12940: [IOS] Use deployment-target from config.xml for platform ve? URL: https://github.com/apache/cordova-ios/pull/326#issuecomment-321707919 Please run `npm install && npm run eslint`, then fix the eslint issues and commit them. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] shazron commented on a change in pull request #330: CB-13164: Integrated cordova-plugin-console
shazron commented on a change in pull request #330: CB-13164: Integrated cordova-plugin-console URL: https://github.com/apache/cordova-ios/pull/330#discussion_r132598918 ## File path: bin/templates/project/__PROJECT_NAME__/config.xml ## @@ -65,6 +65,10 @@ + Review comment: You need to add this in defaults.xml as well. I tried adding the platform to a newly created CLI project, console.log failed because this wasn't in config.xml. See https://github.com/apache/cordova-ios/commit/b0c71bf63c8ce989648f0b8205befe174af37860 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] codecov-io commented on issue #330: CB-13164: Integrated cordova-plugin-console
codecov-io commented on issue #330: CB-13164: Integrated cordova-plugin-console URL: https://github.com/apache/cordova-ios/pull/330#issuecomment-321694544 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/330?src=pr&el=h1) Report > Merging [#330](https://codecov.io/gh/apache/cordova-ios/pull/330?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/7de12c84607355cdf68f4825dc6603351747158a?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/cordova-ios/pull/330?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #330 +/- ## === Coverage 63.95% 63.95% === Files 14 14 Lines1673 1673 Branches 277 277 === Hits 1070 1070 Misses603 603 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/330?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/330?src=pr&el=footer). Last update [7de12c8...14b0490](https://codecov.io/gh/apache/cordova-ios/pull/330?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] codecov-io commented on issue #330: CB-13164: Integrated cordova-plugin-console
codecov-io commented on issue #330: CB-13164: Integrated cordova-plugin-console URL: https://github.com/apache/cordova-ios/pull/330#issuecomment-321694544 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/330?src=pr&el=h1) Report > Merging [#330](https://codecov.io/gh/apache/cordova-ios/pull/330?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/7de12c84607355cdf68f4825dc6603351747158a?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/cordova-ios/pull/330?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #330 +/- ## === Coverage 63.95% 63.95% === Files 14 14 Lines1673 1673 Branches 277 277 === Hits 1070 1070 Misses603 603 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/330?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/330?src=pr&el=footer). Last update [7de12c8...14b0490](https://codecov.io/gh/apache/cordova-ios/pull/330?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] filmaj commented on issue #330: CB-13164: Integrated cordova-plugin-console
filmaj commented on issue #330: CB-13164: Integrated cordova-plugin-console URL: https://github.com/apache/cordova-ios/pull/330#issuecomment-321685892 I've rebased w/ master, let's see if that rejigs the wires. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] shazron closed pull request #329: CB-13112 - should not create a new file reference on each "cordova prepare"
shazron closed pull request #329: CB-13112 - should not create a new file reference on each "cordova prepare" URL: https://github.com/apache/cordova-ios/pull/329 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] shazron commented on issue #330: CB-13164: Integrated cordova-plugin-console
shazron commented on issue #330: CB-13164: Integrated cordova-plugin-console URL: https://github.com/apache/cordova-ios/pull/330#issuecomment-321662465 Not sure why AppVeyor is saying "AppVeyor was unable to build non-mergeable pull request", it looks mergeable to me. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] shazron commented on issue #329: CB-13112 - should not create a new file reference on each "cordova prepare"
shazron commented on issue #329: CB-13112 - should not create a new file reference on each "cordova prepare" URL: https://github.com/apache/cordova-ios/pull/329#issuecomment-321661115 Thanks Fil! Yeah the fixtures really screwed me up on this one feature This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] filmaj opened a new pull request #330: CB-13164: Integrated cordova-plugin-console
filmaj opened a new pull request #330: CB-13164: Integrated cordova-plugin-console URL: https://github.com/apache/cordova-ios/pull/330 ### What does this PR do? Adds support for `window.console` to be built in to generated cordova-ios projects. Essentially: sunsetting [cordova-plugin-console](https://github.com/apache/cordova-plugin-console) and integrating its iOS bits into cordova-ios. - added native source files for CDVLogger - updated pbxproj file for CordovaLib to take the new files into account ### What testing has been done on this change? Just `npm test` locally on my Mac. Unsure if I should add any additional tests? @shazron leaning on you for guidance on that question. ### Checklist - [x] [Reported issue CB-13147](https://issues.apache.org/jira/browse/CB-13147) - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] janpio commented on issue #389: WIP: CB-11244: Studio Project Compatibility: Now with merge commit
janpio commented on issue #389: WIP: CB-11244: Studio Project Compatibility: Now with merge commit URL: https://github.com/apache/cordova-android/pull/389#issuecomment-321304897 Just a shoutout from the sidelines: Thanks for tackling this! ?? ?? ?? Working with the current generated Android projects turns out to be a lot harder than I expected, and that's how I found this PR. Each step that gets the Cordova Android "output" closer to a standard Android project is great. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] shazron commented on issue #326: CB-12940: [IOS] Use deployment-target from config.xml for platform ve?
shazron commented on issue #326: CB-12940: [IOS] Use deployment-target from
config.xml for platform ve?
URL: https://github.com/apache/cordova-ios/pull/326#issuecomment-321110477
```
Parsing
C:\projects\cordova-ios\tests\spec\unit\fixtures\ios-config-xml\ios-config-xml\SampleApp\config.xml
failed
{ Error: ENOENT: no such file or directory, open
'C:\projects\cordova-ios\tests\spec\unit\fixtures\ios-config-xml\ios-config-xml\SampleApp\config.xml'
```
Note that it is doubling up on the `ios-config-xml` in the path. I'll have
to test in Windows to see what's up. Wait for Travis to finish testing to see
if its a common error.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] shazron commented on issue #326: CB-12940: [IOS] Use deployment-target from config.xml for platform ve?
shazron commented on issue #326: CB-12940: [IOS] Use deployment-target from
config.xml for platform ve?
URL: https://github.com/apache/cordova-ios/pull/326#issuecomment-321110477
```
Parsing
C:\projects\cordova-ios\tests\spec\unit\fixtures\ios-config-xml\ios-config-xml\SampleApp\config.xml
failed
{ Error: ENOENT: no such file or directory, open
'C:\projects\cordova-ios\tests\spec\unit\fixtures\ios-config-xml\ios-config-xml\SampleApp\config.xml'
```
Note that it is doubling up on the `ios-config-xml` in the path. I'll have
to test in Windows to see what's up.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] shazron commented on issue #269: CB-12002 - Support LSApplicationQueriesSchemes
shazron commented on issue #269: CB-12002 - Support LSApplicationQueriesSchemes URL: https://github.com/apache/cordova-ios/pull/269#issuecomment-321104510 eslint errors. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] shazron closed pull request #328: CB-13093: (iOS) Infinite looping when stressing navigation
shazron closed pull request #328: CB-13093: (iOS) Infinite looping when stressing navigation URL: https://github.com/apache/cordova-ios/pull/328 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] codecov-io commented on issue #329: CB-13112 - should not create a new file reference on each "cordova prepare"
codecov-io commented on issue #329: CB-13112 - should not create a new file reference on each "cordova prepare" URL: https://github.com/apache/cordova-ios/pull/329#issuecomment-320880876 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/329?src=pr&el=h1) Report > Merging [#329](https://codecov.io/gh/apache/cordova-ios/pull/329?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/8edd13aaee16d6996a4560a74d17798437b42c6f?src=pr&el=desc) will **decrease** coverage by `0.02%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/cordova-ios/pull/329?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #329 +/- ## == - Coverage 63.97% 63.95% -0.03% == Files 14 14 Lines1674 1673 -1 Branches 277 277 == - Hits 1071 1070 -1 Misses603 603 ``` | [Impacted Files](https://codecov.io/gh/apache/cordova-ios/pull/329?src=pr&el=tree) | Coverage ? | | |---|---|---| | [bin/templates/scripts/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-ios/pull/329?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3ByZXBhcmUuanM=) | `84.63% <100%> (-0.04%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/329?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/329?src=pr&el=footer). Last update [8edd13a...01fcaa4](https://codecov.io/gh/apache/cordova-ios/pull/329?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] codecov-io commented on issue #329: CB-13112 - should not create a new file reference on each "cordova prepare"
codecov-io commented on issue #329: CB-13112 - should not create a new file reference on each "cordova prepare" URL: https://github.com/apache/cordova-ios/pull/329#issuecomment-320880876 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/329?src=pr&el=h1) Report > Merging [#329](https://codecov.io/gh/apache/cordova-ios/pull/329?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/8edd13aaee16d6996a4560a74d17798437b42c6f?src=pr&el=desc) will **decrease** coverage by `0.02%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/cordova-ios/pull/329?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #329 +/- ## == - Coverage 63.97% 63.95% -0.03% == Files 14 14 Lines1674 1673 -1 Branches 277 277 == - Hits 1071 1070 -1 Misses603 603 ``` | [Impacted Files](https://codecov.io/gh/apache/cordova-ios/pull/329?src=pr&el=tree) | Coverage ? | | |---|---|---| | [bin/templates/scripts/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-ios/pull/329?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3ByZXBhcmUuanM=) | `84.63% <100%> (-0.04%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/329?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/329?src=pr&el=footer). Last update [8edd13a...01fcaa4](https://codecov.io/gh/apache/cordova-ios/pull/329?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] shazron opened a new pull request #329: CB-13112 - should not create a new file reference on each "cordova prepare"
shazron opened a new pull request #329: CB-13112 - should not create a new file reference on each "cordova prepare" URL: https://github.com/apache/cordova-ios/pull/329 Added new ios-config-xml project fixture based off cordova-ios@4.4.0 template. The old one doesn't reflect current project structure. prepare.spec.js Added failing test for multiple adds of the same tag Fixed failing test in prepare.js pluginHandlers.spec.js Fix failing test due to new ios-config-xml project template in addPlugin Don't need to prefix 'Resources' and 'Plugins' to the files that are from those groups. The file reference 'sourceTree' relies on its parent group, in the new template structure. ### Platforms affected self ### What does this PR do? Fix multiple file references added for a tag. This creates "cordova build" failures. ### What testing has been done on this change? npm run unit-tests npm test ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. -------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] codecov-io commented on issue #401: CB-8976: Added the `cdvVersionCodeForceAbiDigit` property
codecov-io commented on issue #401: CB-8976: Added the `cdvVersionCodeForceAbiDigit` property URL: https://github.com/apache/cordova-android/pull/401#issuecomment-320722459 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/401?src=pr&el=h1) Report > Merging [#401](https://codecov.io/gh/apache/cordova-android/pull/401?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/2b53c98cf585a2f82f9d94f9acc210f362c48f97?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/cordova-android/pull/401?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #401 +/- ## === Coverage 42.55% 42.55% === Files 17 17 Lines1678 1678 Branches 304 304 === Hits 714 714 Misses964 964 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/401?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/401?src=pr&el=footer). Last update [2b53c98...9404398](https://codecov.io/gh/apache/cordova-android/pull/401?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] feichngr opened a new pull request #401: CB-8976: Added the `cdvVersionCodeForceAbiDigit` property
feichngr opened a new pull request #401: CB-8976: Added the `cdvVersionCodeForceAbiDigit` property URL: https://github.com/apache/cordova-android/pull/401 to the template build.gradle that appends 0 to the versionCode when `cdvBuildMultipleApks` is not set ### Platforms affected Android ### What does this PR do? Adds a Gradle property that, when set to true, establishes a fallback for the 10x bigger versionCodes that were auto-generated even for non-multi-APK builds in cordova-android version before 5.2.0. ### What testing has been done on this change? Only local testing. Planned to add some automated testing and documentation but didn't get around to it. Hope someone else will pick it up. ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] filmaj commented on issue #389: CB-11244: Studio Project Compatibility: Now with merge commit
filmaj commented on issue #389: CB-11244: Studio Project Compatibility: Now with merge commit URL: https://github.com/apache/cordova-android/pull/389#issuecomment-320377633 Thanks for the repro steps there @dpogue. I think after the long weekend we'll take a look at cordova-common and make sure it can support the two differing project structures in Android. Looks like [we already have that in place for config.xml](https://github.com/apache/cordova-common/blob/master/src/ConfigChanges/ConfigFile.js#L204-L208) - we will probably need something similar for AndroidManifest.xml. One thing at a time, moving closer! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] dpogue commented on issue #389: CB-11244: Studio Project Compatibility: Now with merge commit
dpogue commented on issue #389: CB-11244: Studio Project Compatibility: Now with merge commit URL: https://github.com/apache/cordova-android/pull/389#issuecomment-320372172 I haven't dug into it particularly far, but a quick skim through the config munging stuff suggests that maybe a workaround could go here: https://github.com/apache/cordova-common/blob/master/src/ConfigChanges/ConfigKeeper.js#L40-L44 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] infil00p commented on issue #389: CB-11244: Studio Project Compatibility: Now with merge commit
infil00p commented on issue #389: CB-11244: Studio Project Compatibility: Now with merge commit URL: https://github.com/apache/cordova-android/pull/389#issuecomment-320367784 @dpogue That's the exact issue I suspected was in prepare.js. Unfortunately all the CLI magic is done in prepare.js, and I'm having a very hard time figuring out where the code that determines where AndroidManifest.xml is supposed to be is, since it's clearly pointing at the wrong AndroidManifest.xml. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] dpogue commented on issue #389: CB-11244: Studio Project Compatibility: Now with merge commit
dpogue commented on issue #389: CB-11244: Studio Project Compatibility: Now with merge commit URL: https://github.com/apache/cordova-android/pull/389#issuecomment-320340096 The generated project looks good now. I did run into one issue with plugins that I tried to install. I installed the cordova-plugin-media-capture and it didn't throw any errors, but it also didn't add any permissions to AndroidManifest: https://github.com/apache/cordova-plugin-media-capture/blob/master/plugin.xml#L77-L82 Resulting ./app/src/main/AndroidManifest.xml: ``` http://schemas.android.com/apk/res/android";> ``` I had other issues in one of my own plugins, where it threw an error about being unable to insert: https://github.com/AyogoHealth/cordova-plugin-push/blob/swift3.0/plugin.xml#L60-L69 ``` Installing "cordova-plugin-ayogo-push" for android Android Studio project detected Failed to install 'cordova-plugin-ayogo-push': Error: Unable to graft xml at selector "/manifest/application" from "/Users/dpogue/androidTest/platforms/android/app/src/main/res/xml/config.xml" during config install at ConfigFile_graft_child [as graft_child] (/Users/dpogue/androidTest/platforms/android/cordova/node_modules/cordova-common/src/ConfigChanges/ConfigFile.js:120:19) at PlatformMunger_apply_file_munge [as apply_file_munge] (/Users/dpogue/androidTest/platforms/android/cordova/node_modules/cordova-common/src/ConfigChanges/ConfigChanges.js:83:34) at munge_helper (/Users/dpogue/androidTest/platforms/android/cordova/node_modules/cordova-common/src/ConfigChanges/ConfigChanges.js:238:14) at PlatformMunger.add_plugin_changes (/Users/dpogue/androidTest/platforms/android/cordova/node_modules/cordova-common/src/ConfigChanges/ConfigChanges.js:164:12) at /Users/dpogue/androidTest/platforms/android/cordova/node_modules/cordova-common/src/PluginManager.js:126:25 at _fulfilled (/Users/dpogue/androidTest/platforms/android/cordova/node_modules/q/q.js:854:54) at self.promiseDispatch.done (/Users/dpogue/androidTest/platforms/android/cordova/node_modules/q/q.js:883:30) at Promise.promise.promiseDispatch (/Users/dpogue/androidTest/platforms/android/cordova/node_modules/q/q.js:816:13) at /Users/dpogue/androidTest/platforms/android/cordova/node_modules/q/q.js:877:14 at runSingle (/Users/dpogue/androidTest/platforms/android/cordova/node_modules/q/q.js:137:13) Error: Unable to graft xml at selector "/manifest/application" from "/Users/dpogue/androidTest/platforms/android/app/src/main/res/xml/config.xml" during config install ``` Was there intended to be some backward-compatible path aliasing or is this a known breaking change? ---- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] codecov-io commented on issue #389: CB-11244: Studio Project Compatibility: Now with merge commit
codecov-io commented on issue #389: CB-11244: Studio Project Compatibility: Now with merge commit URL: https://github.com/apache/cordova-android/pull/389#issuecomment-316205218 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr&el=h1) Report > Merging [#389](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/2b53c98cf585a2f82f9d94f9acc210f362c48f97?src=pr&el=desc) will **decrease** coverage by `0.37%`. > The diff coverage is `34.17%`. [](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #389 +/- ## == - Coverage 42.55% 42.17% -0.38% == Files 17 17 Lines1678 1707 +29 Branches 304 310 +6 == + Hits 714 720 +6 - Misses964 987 +23 ``` | [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr&el=tree) | Coverage ? | | |---|---|---| | [...n/templates/cordova/lib/builders/GenericBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9HZW5lcmljQnVpbGRlci5qcw==) | `30.61% (-0.38%)` | :arrow_down: | | [bin/templates/cordova/lib/builders/builders.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9idWlsZGVycy5qcw==) | `37.5% (?)` | :arrow_up: | | [bin/templates/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZC5qcw==) | `13.04% <0%> (-0.39%)` | :arrow_down: | | [bin/templates/cordova/lib/device.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9kZXZpY2UuanM=) | `22.44% <0%> (?)` | :arrow_up: | | [bin/templates/cordova/lib/AndroidStudio.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9BbmRyb2lkU3R1ZGlvLmpz) | `94.73% <100%> (?)` | :arrow_up: | | [...in/templates/cordova/lib/builders/GradleBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9HcmFkbGVCdWlsZGVyLmpz) | `20% <15.78%> (-0.43%)` | :arrow_down: | | [bin/templates/cordova/Api.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL0FwaS5qcw==) | `43.36% <25%> (-1.09%)` | :arrow_down: | | [bin/lib/create.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr&el=tree#diff-YmluL2xpYi9jcmVhdGUuanM=) | `49.26% <45.45%> (-1.57%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr&el=footer). Last update [2b53c98...8fdb16c](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] infil00p commented on issue #389: CB-11244: Studio Project Compatibility: Now with merge commit
infil00p commented on issue #389: CB-11244: Studio Project Compatibility: Now with merge commit URL: https://github.com/apache/cordova-android/pull/389#issuecomment-320328719 @dpogue @filmaj That should fix the CLI errors, but I think there's some CLI stuff that I'm missing, since I don't use the CLI. Want to take a quick look again? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] filmaj commented on issue #399: CB-12730: Compat - INTEGRATE
filmaj commented on issue #399: CB-12730: Compat - INTEGRATE URL: https://github.com/apache/cordova-android/pull/399#issuecomment-320116296 Sounds like lazy consensus on the tests is "nah" This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] filmaj commented on issue #389: CB-11244: Studio Project Compatibility: Now with merge commit
filmaj commented on issue #389: CB-11244: Studio Project Compatibility: Now with merge commit URL: https://github.com/apache/cordova-android/pull/389#issuecomment-320108011 https://github.com/infil00p/cordova-android/blob/StudioProjectCompat/bin/templates/cordova/lib/prepare.js#L214-L216 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] macdonst commented on issue #399: CB-12730: Compat - INTEGRATE
macdonst commented on issue #399: CB-12730: Compat - INTEGRATE URL: https://github.com/apache/cordova-android/pull/399#issuecomment-320087845 @infil00p I was thinking testing for this would be handled at the plugin level as it is what is requesting the permissions. Hard to instrument these dialogs. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] infil00p commented on issue #389: CB-11244: Studio Project Compatibility: Now with merge commit
infil00p commented on issue #389: CB-11244: Studio Project Compatibility: Now with merge commit URL: https://github.com/apache/cordova-android/pull/389#issuecomment-320080278 @dpogue No, that's definitely a bug. Only the app directory should exist, and it's clear that something else is copying over MainActivity. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] dpogue commented on issue #389: CB-11244: Studio Project Compatibility: Now with merge commit
dpogue commented on issue #389: CB-11244: Studio Project Compatibility: Now with merge commit URL: https://github.com/apache/cordova-android/pull/389#issuecomment-320067936 So I ran this branch with the following: ``` cordova create androidTest cd ./androidTest cordova platform add git://github.com/infil00p/cordova-android.git#StudioProjectCompat ``` In my platforms/android I ended up with both an app folder and a src folder, and I have a MainActivity.java in both. Is that expected? ``` android ??? app ??? ??? src ??? ??? main ??? ??? java ??? ?? ??? io ??? ?? ?? ??? cordova ??? ?? ?? ??? hellocordova ??? ?? ?? ??? MainActivity.java ??? src ??? io ??? cordova ??? hellocordova ??? MainActivity.java ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] shazron closed pull request #40: Test again, the sequel. No JIRA prefix.
shazron closed pull request #40: Test again, the sequel. No JIRA prefix. URL: https://github.com/apache/cordova-browser/pull/40 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] shazron closed pull request #39: CB-123 - Test again
shazron closed pull request #39: CB-123 - Test again URL: https://github.com/apache/cordova-browser/pull/39 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] shazron commented on issue #39: CB-123 - Test again
shazron commented on issue #39: CB-123 - Test again URL: https://github.com/apache/cordova-browser/pull/39#issuecomment-319768397 Test comment (with prefix) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] shazron commented on issue #40: Test again, the sequel. No JIRA prefix.
shazron commented on issue #40: Test again, the sequel. No JIRA prefix. URL: https://github.com/apache/cordova-browser/pull/40#issuecomment-319768329 Test comment (no prefix) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
