[GitHub] cordova-weinre pull request #15: Update README.md
Github user janpio commented on a diff in the pull request: https://github.com/apache/cordova-weinre/pull/15#discussion_r144259287 --- Diff: README.md --- @@ -17,7 +17,7 @@ * under the License. --> -weinre is WEb INspector REmote. +weinre is Web INspector REmote. --- End diff -- The capitalization is there for a reason: we = WEb in = INspector re = REmote => weinre --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-osx issue #43: CB-13424: "cordova plugin add/remove" writes changes ...
Github user janpio commented on the issue: https://github.com/apache/cordova-osx/pull/43 Yay, that was quick. Can you talk me (and everybody reading) through the changes? Where does the logic come from? ios? --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-coho pull request #159: CB-13279: Remove duplication of cordova-docs...
GitHub user janpio opened a pull request: https://github.com/apache/cordova-coho/pull/159 CB-13279: Remove duplication of cordova-docs content from other places remove blog post and cordova-docs build instructions You can merge this pull request into a Git repository by running: $ git pull https://github.com/janpio/cordova-coho patch-2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-coho/pull/159.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #159 commit 3507492c19337b50bc687d99a3c43b861148dc9f Author: Jan Piotrowski <piotrowski+git...@gmail.com> Date: 2017-09-26T15:20:42Z remove blog post and cordova-docs build instructions --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-coho pull request #158: CB-13278: remove doc-translation-process.md
GitHub user janpio opened a pull request: https://github.com/apache/cordova-coho/pull/158 CB-13278: remove doc-translation-process.md as its content was transferred to https://github.com/apache/cordova-docs/blob/master/doc/translate.md via TODO You can merge this pull request into a Git repository by running: $ git pull https://github.com/janpio/cordova-coho patch-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-coho/pull/158.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #158 commit 9b1ec4ac0a72213e36039acf26347321101017a4 Author: Jan Piotrowski <piotrowski+git...@gmail.com> Date: 2017-09-26T14:38:43Z CB-13278: remove doc-translation-process.md as its content was transferred to https://github.com/apache/cordova-docs/blob/master/doc/translate.md via TODO --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #239: Enabling Appcache for the android we...
Github user janpio commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/239 No need to apologize, I was just curious what this does and if it would make sense to actually have this in the plugin for all users, maybe behind a configuration or option. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request #730: CB-13277: (docs) Improve README
GitHub user janpio opened a pull request: https://github.com/apache/cordova-docs/pull/730 CB-13277: (docs) Improve README https://issues.apache.org/jira/browse/CB-13277 ### Platforms affected none ### What does this PR do? Improves the README of cordova-docs. See commit messages (and of course diff) for exact changes. ### What testing has been done on this change? looked at the rendered readme in my fork on Github ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [x] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/janpio/cordova-docs improve-readme Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-docs/pull/730.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #730 commit ff306f60d4a9b197e636dcd5cf47d0e1bef33af9 Author: Jan Piotrowski <piotrowski+git...@gmail.com> Date: 2017-09-14T11:25:01Z improve Introduction rephrase add links to actual pages, not just redirects commit 3fdb9332100a221b7f34f9377d7767e310c990b9 Author: Jan Piotrowski <piotrowski+git...@gmail.com> Date: 2017-09-14T11:31:22Z improve Installing reword a bit add some structure (Verify headline) commit e7a4f964e9ced0b2bdf9919ca3af151f73620554 Author: Jan Piotrowski <piotrowski+git...@gmail.com> Date: 2017-09-14T11:43:05Z rework headlines add h1 with repo name change indentation change some bold used to structure content to headlines commit 8bec7671d90ce30a516b00667f31603b9e2ee03a Author: Jan Piotrowski <piotrowski+git...@gmail.com> Date: 2017-09-14T11:47:43Z add Table of Contents generated with https://ecotrust-canada.github.io/markdown-toc/ polished manually --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-console issue #25: CB-13170 - final changes and release of po...
Github user janpio commented on the issue: https://github.com/apache/cordova-plugin-console/pull/25 Nice. Does this mean that the 2.0.0 of the console plugin can be installed on `cordova-ios` 4.5.0 without causing the build problems? --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs issue #727: CB-13247 - Blog post for Cordova iOS 4.5.0 Release
Github user janpio commented on the issue: https://github.com/apache/cordova-docs/pull/727 Now that it's published I noticed that it would have been good to include the CLI command to remove `cordova-plugin-console`: `cordova plugin rm cordova-plugin-console`. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request #727: CB-13247 - Blog post for Cordova iOS 4.5.0 R...
Github user janpio commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/727#discussion_r137941937 --- Diff: www/_posts/2017-09-08-ios-release.md --- @@ -0,0 +1,72 @@ +--- +layout: post +author: +name: Shazron Abdullah +url: https://twitter.com/shazron +title: "Cordova iOS 4.5.0" +categories: announcements +tags: news releases +--- + +We are happy to announce a minor version of `Cordova iOS 4.5.0` has been released! + +Three new features were added: +1. [CB-12937](https://issues.apache.org/jira/browse/CB-12937) - Plugins can receive `handleOpenURLWithApplicationSourceAndAnnotation:` now (new selector, that sends the URL with additional metadata) +2. [CB-13164](https://issues.apache.org/jira/browse/CB-13164) - Integrated cordova-plugin-console to build in support for window.console. +3. [CB-10916](https://issues.apache.org/jira/browse/CB-10916) - Support [display name](/docs/en/dev/config_ref/index.html#name) for **iOS** + +Note that for [CB-13164](https://issues.apache.org/jira/browse/CB-13164) if you already included `cordova-plugin-console` in your project, you must **remove** that plugin if not your project will not build. + +If you ever needed to disable the built in console plugin, comment out or remove the `Console` `` tag in your platform specific `config.xml`, and/or call this right after the `deviceready` event: --- End diff -- Oh, didn't know about these config.xml files. These never get modified normally, do they? (There is this "meme" in lots of StackOverflow, forum and blog posts that you should remove the console plugin before building a production build because "security" or "performance") --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request #727: CB-13247 - Blog post for Cordova iOS 4.5.0 R...
Github user janpio commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/727#discussion_r137936770 --- Diff: www/_posts/2017-09-08-ios-release.md --- @@ -0,0 +1,72 @@ +--- +layout: post +author: +name: Shazron Abdullah +url: https://twitter.com/shazron +title: "Cordova iOS 4.5.0" +categories: announcements +tags: news releases +--- + +We are happy to announce a minor version of `Cordova iOS 4.5.0` has been released! + +Three new features were added: +1. [CB-12937](https://issues.apache.org/jira/browse/CB-12937) - Plugins can receive `handleOpenURLWithApplicationSourceAndAnnotation:` now (new selector, that sends the URL with additional metadata) +2. [CB-13164](https://issues.apache.org/jira/browse/CB-13164) - Integrated cordova-plugin-console to build in support for window.console. +3. [CB-10916](https://issues.apache.org/jira/browse/CB-10916) - Support [display name](/docs/en/dev/config_ref/index.html#name) for **iOS** + +Note that for [CB-13164](https://issues.apache.org/jira/browse/CB-13164) if you already included `cordova-plugin-console` in your project, you must **remove** that plugin if not your project will not build. + +If you ever needed to disable the built in console plugin, comment out or remove the `Console` `` tag in your platform specific `config.xml`, and/or call this right after the `deviceready` event: --- End diff -- What is a "platform specific `config.xml`" - there is only one in my projects. Does this refer to ``? --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request #727: CB-13247 - Blog post for Cordova iOS 4.5.0 R...
Github user janpio commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/727#discussion_r137936759 --- Diff: www/_posts/2017-09-08-ios-release.md --- @@ -0,0 +1,72 @@ +--- +layout: post +author: +name: Shazron Abdullah +url: https://twitter.com/shazron +title: "Cordova iOS 4.5.0" +categories: announcements +tags: news releases +--- + +We are happy to announce a minor version of `Cordova iOS 4.5.0` has been released! + +Three new features were added: +1. [CB-12937](https://issues.apache.org/jira/browse/CB-12937) - Plugins can receive `handleOpenURLWithApplicationSourceAndAnnotation:` now (new selector, that sends the URL with additional metadata) +2. [CB-13164](https://issues.apache.org/jira/browse/CB-13164) - Integrated cordova-plugin-console to build in support for window.console. +3. [CB-10916](https://issues.apache.org/jira/browse/CB-10916) - Support [display name](/docs/en/dev/config_ref/index.html#name) for **iOS** + +Note that for [CB-13164](https://issues.apache.org/jira/browse/CB-13164) if you already included `cordova-plugin-console` in your project, you must **remove** that plugin if not your project will not build. --- End diff -- Does it really not build? As this plugin is part of many, many projects (Ionic includes it by default) this would a lot of people. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs issue #709: CB-10916 - Add documentation about display name
Github user janpio commented on the issue: https://github.com/apache/cordova-docs/pull/709 A bit late to the party, but where does this actually apply and work? (iOS, Android, Windows?) --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #239: Enabling Appcache for the android we...
Github user janpio commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/239 What exactly is AppCaching in this context? --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file pull request #207: CB-12930: (windows) Fix getDirectory ...
Github user janpio commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/207#discussion_r136139240
--- Diff: src/windows/FileProxy.js ---
@@ -751,7 +751,13 @@ module.exports = {
if (!fs || !validName(path)){
fail(FileError.ENCODING_ERR);
return;
-}
+}
+
+//check trailing "/"
--- End diff --
this actually removes a trailing slash, correct?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs issue #714: CB-12984: (docs) Add Android versions to "supported...
Github user janpio commented on the issue: https://github.com/apache/cordova-docs/pull/714 Ok, so back to your issue. Meh... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs issue #714: CB-12984: (docs) Add Android versions to "supported...
Github user janpio commented on the issue: https://github.com/apache/cordova-docs/pull/714 Is there a way to trigger this manualy rebuilding and uploading of the docs by one of the PMC members? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request #723: CB-13214: added browser and serve release bl...
Github user janpio commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/723#discussion_r135991198 --- Diff: www/_posts/2017-08-29-browser-serve-release.md --- @@ -0,0 +1,65 @@ +--- +layout: post +author: +name: Steve Gill +url: https://twitter.com/stevesgill +title: "Cordova Browser & Cordova Serve Released!" --- End diff -- Should probably contain version info to be useful to share (link preview) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #238: added cookies support for Android an...
Github user janpio commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/238 May I asked what is a use case for this? What problem does this solve? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #238: added cookies support for Android an...
Github user janpio commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/238 You are right, this is equivalent to messing with the local cookies with the developer tools of your browser. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #238: added cookies support for Android an...
Github user janpio commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/238 @denisx304 Does this PR enable me to set random cookies for e.g. google.com when opening InAppBrowser to open google.com? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request #722: Update index.md
Github user janpio commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/722#discussion_r134116008 --- Diff: www/docs/en/6.x/guide/platforms/android/index.md --- @@ -310,7 +310,7 @@ To sign an app, you need the following parameters: These parameters can be specified using the command line arguments above to the [Cordova CLI][cli_reference] `build` or `run` commands. -__Note__: You should use double `--` to indicate that these are platform-specific arguments, for example: +__Note__: You should use double `--` (followed by a space) to indicate that these are platform-specific arguments, for example: --- End diff -- maybe add an "i.e. `-- --`" in the brackets as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs issue #722: Update index.md
Github user janpio commented on the issue: https://github.com/apache/cordova-docs/pull/722 See the line above your edit: > You should use double `--` to indicate that these are platform-specific arguments, for example: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-statusbar issue #51: New feature 'styleAndroidTranslucent'
Github user janpio commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/51 The probability of merging pull requests are higher when they follow the Pull Request template of the project: https://github.com/apache/cordova-plugin-statusbar/blob/master/.github/PULL_REQUEST_TEMPLATE.md This one, for example, needs an issue at the official issue tracker. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request #720: remove duplicate information
GitHub user janpio opened a pull request: https://github.com/apache/cordova-docs/pull/720 remove duplicate information version has its own entry, no need to duplicate the explanation here. You can merge this pull request into a Git repository by running: $ git pull https://github.com/janpio/cordova-docs patch-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-docs/pull/720.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #720 commit 0b5eb75e0bb4ef10031305d0f7fb5a7f748c3bc8 Author: Jan Piotrowski <piotrowski+git...@gmail.com> Date: 2017-08-16T18:46:50Z remove duplicate information version has its own entry, no need to duplicate the explanation here. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-device-motion pull request #57: CB-13068: Updated README to p...
Github user janpio commented on a diff in the pull request: https://github.com/apache/cordova-plugin-device-motion/pull/57#discussion_r132629591 --- Diff: README.md --- @@ -27,6 +27,18 @@ description: Access accelerometer data. # cordova-plugin-device-motion +# Deprecation Notice + +With the [W3C Device Motion and Orientation API](https://www.w3.org/TR/2016/CR-orientation-event-20160818/) now +being supported on iOS, Android and Windows devices, this plugin is not needed any more. Migrating from this +plugin to the [W3C Device Motion and Orientation API](https://www.w3.org/TR/2016/CR-orientation-event-20160818/) +is explained in this [PhoneGap blog post](https://blog.phonegap.com/migrating-from-the-cordova-device-motion-plugin-ddd8176632ed). --- End diff -- Why a Phonegap blogpost on a Cordova plugin deprecation? Shouldn't there at least be a Cordova "we deprecate those plugins" blog post linked here and then maybe additionally a Phonegap blogpost with "this is how you do it now" (although I would of course prefer those at Cordova as well, much less confusing for users re Cordova/Phonegap). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs issue #717: CB-12760: (android) fix internal anchor link
Github user janpio commented on the issue: https://github.com/apache/cordova-docs/pull/717 Thanks. Missed the commit message, sorry. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request #717: CB-12760: (android) fix internal anchor link
Github user janpio closed the pull request at: https://github.com/apache/cordova-docs/pull/717 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs issue #714: CB-12984: (docs) Add Android versions to "supported...
Github user janpio commented on the issue: https://github.com/apache/cordova-docs/pull/714 (and document ð ) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs issue #714: CB-12984: (docs) Add Android versions to "supported...
Github user janpio commented on the issue: https://github.com/apache/cordova-docs/pull/714 Sure, thanks for taking care of it! How does deployment work, when will this be on https://cordova.apache.org/docs/en/dev/guide/platforms/android/index.html? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request #714: CB-12984: (docs) Add Android versions to "su...
Github user janpio closed the pull request at: https://github.com/apache/cordova-docs/pull/714 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-cli issue #284: Update readme.md - Proposal of corrections
Github user janpio commented on the issue: https://github.com/apache/cordova-cli/pull/284 Yes, there can be multiple PR for one issues, it is just that a place exists where the changes are logged. But if Filmaj told you to just go ahead, do that - he is with the project, I am just a bystander ;) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-cli issue #284: Update readme.md - Proposal of corrections
Github user janpio commented on the issue: https://github.com/apache/cordova-cli/pull/284 Ah right, I saw you on Crowdin ;) Note that normally there is this process of opening a issue at issues.cordova.io and including that in the title of the PR. You should probably create one for these as well, maybe name it "Fixing small text issues" or something like that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request #717: CB-12760: (android) fix internal anchor link
GitHub user janpio opened a pull request: https://github.com/apache/cordova-docs/pull/717 CB-12760: (android) fix internal anchor link ### Platforms affected Android, docs only ### What does this PR do? fixes an internal anchor link to work ### What testing has been done on this change? none ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. You can merge this pull request into a Git repository by running: $ git pull https://github.com/janpio/cordova-docs patch-2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-docs/pull/717.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #717 commit 688b1038f67db5057804ecc37c237c8c8fae4574 Author: Jan Piotrowski <piotrowski+git...@gmail.com> Date: 2017-08-07T09:07:21Z fix internal anchor link --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs issue #714: CB-12984: (docs) Add Android versions to "supported...
Github user janpio commented on the issue: https://github.com/apache/cordova-docs/pull/714 (1 month bump ð° ) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-cli issue #284: Update readme.md - Proposal of corrections
Github user janpio commented on the issue: https://github.com/apache/cordova-cli/pull/284 Changes seem useful. Did you open another PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #234: CB-12975: (docs) Resort and reword c...
Github user janpio commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/234 Did I miss anything or were there further, later changes that required another rebase? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request #225: CB-12975: (docs) Resort and r...
Github user janpio closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/225 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request #234: CB-12975: (docs) Resort and r...
Github user janpio closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/234 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #225: CB-12975: (docs) Resort and reword c...
Github user janpio commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/225 Yeah no, I have no idea what actually happened and why and how I could undo it :/ So if you @filmaj are ok with it, let's just go with #234. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #225: CB-12975: (docs) Resort and reword c...
Github user janpio commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/225 As a first "recovery" I branched after my now rewritten commit into patch-1b and created a pull request from there at #234. This seems to have worked and almost looked as it should. If I find no way to repair this PR, we can just merge that one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request #234: [WIP] CB-12975: (docs) Resort...
GitHub user janpio opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/234 [WIP] CB-12975: (docs) Resort and reword cordova.InAppBrowser.open `options` lists This is a followup to #225 to test if I got it working. Do not merge yet please. ### Platforms affected n/a, only docs changes ### What does this PR do? Resort and reword cordova.InAppBrowser.open `options` lists for better developer experience. More reasoning at https://issues.apache.org/jira/browse/CB-12975 ### What testing has been done on this change? n/a ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - n/a Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/janpio/cordova-plugin-inappbrowser patch-1b Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-inappbrowser/pull/234.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #234 commit 9102757ce1b97ea14ae2c59ef78a44422fe4a1bf Author: Jan Piotrowski <piotrowski+git...@gmail.com> Date: 2017-07-01T00:41:04Z CB-12975 (docs) Resort and reword cordova.InAppBrowser.open `options` lists for better developer experience --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #225: CB-12975: (docs) Resort and reword c...
Github user janpio commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/225 Thanks for the proper explanation! I almost understood it and went to work with Sourcetree... https://www.atlassian.com/blog/sourcetree/interactive-rebase-sourcetree explains that interactive rebase is also possible with Sourcetree. But of course I couldn't rebase at the beginning because I was working on my fork which is not really connected to the apache repo any more. So I did as you said and added the apache repo again (while having checked out `patch-1`. This created this nice merge commit automatically: https://github.com/janpio/cordova-plugin-inappbrowser/commit/3066febdc723c5d0d99ab458c92038fa2f064553 This seems to be what we wanted to "rebase" my commits, because now "This branch is 3 commits ahead of apache:master. " Via the "interactive rebase" feature of Sourcetree I could now "merge" my initial commit and the whitespace commit. But then I somehow messed up, because now the commits from the merge commit are in my branch as well, additionally to that dumb merge commit in the first place... Well, I have to investigate a bit more it seems ;) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-statusbar issue #82: README: Fix issue tracker link
Github user janpio commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/82 (I actually still had this tab open for a issue, rebase etc later - sorry about that. But thanks for taking the initiative.) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #225: CB-12975: (docs) Resort and reword c...
Github user janpio commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/225 Yeah, I totally get that. Can you actually post the `git` commands you would use? Then I can use this as my googling starting point. Wanted to learn that for quite some time, but always found an alternative (like redoing the changes in a new PR... lazy...) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #225: CB-12975: (docs) Resort and reword c...
Github user janpio commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/225 Sure! Well, if you tell me roughly how to do that. Some pointers would be nice, never have done something like that. Can I actually do that on Github? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-statusbar issue #82: README: Fix issue tracker link
Github user janpio commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/82 Good catch at the individual issue being linked - not intended. As long as the PULL_REQUEST_TEMPLATE.md doesn't really work for README changes (doesn't effect any platform, testing is irrelevant) I don't really see the use in the overhead for creating an issue. Or is there? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-statusbar pull request #82: README: Fix issue tracker link
GitHub user janpio opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/82 README: Fix issue tracker link wrong component name in search You can merge this pull request into a Git repository by running: $ git pull https://github.com/janpio/cordova-plugin-statusbar patch-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-statusbar/pull/82.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #82 commit 3f6ffa85a3001a82cae5fcc267aada226c6b6548 Author: Jan Piotrowski <piotrowski+git...@gmail.com> Date: 2017-07-09T11:49:36Z Fix issue tracker link wrong component name in search --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request #183: Remove broken headline and u...
GitHub user janpio opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/183 Remove broken headline and useless reference to it You can merge this pull request into a Git repository by running: $ git pull https://github.com/janpio/cordova-plugin-file-transfer patch-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-file-transfer/pull/183.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #183 commit 3b2f53db302f2af9b4fba3da041dbeb86b19bbfe Author: Jan Piotrowski <piotrowski+git...@gmail.com> Date: 2017-07-08T21:00:03Z Remove broken headline and useless reference to it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request #714: CB-12984: (docs) Add Android versions to "su...
GitHub user janpio opened a pull request: https://github.com/apache/cordova-docs/pull/714 CB-12984: (docs) Add Android versions to "supported" table in cordova-android docs ### Platforms affected n/a, docs only change ### What does this PR do? I added the supported Android versions to the ordova-android table. Source for API Level <-> Android Version was https://developer.android.com/guide/topics/manifest/uses-sdk-element.html#api-level-table and should be pretty solid. ### What testing has been done on this change? n/a ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - n/a Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/janpio/cordova-docs patch-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-docs/pull/714.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #714 commit 139a0427b1e2a2fb0295177143bd60b0dcfb0c19 Author: Jan Piotrowski <piotrowski+git...@gmail.com> Date: 2017-07-04T13:45:51Z add supported Android versions to cordova-android table Source for API Level <-> Android Version: https://developer.android.com/guide/topics/manifest/uses-sdk-element.html#api-level-table --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request #225: CB-12975: (docs) Resort and r...
GitHub user janpio opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/225 CB-12975: (docs) Resort and reword cordova.InAppBrowser.open `options` lists ### Platforms affected n/a, only docs changes ### What does this PR do? Resort and reword cordova.InAppBrowser.open `options` lists for better developer experience ### What testing has been done on this change? n/a ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - n/a Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/janpio/cordova-plugin-inappbrowser patch-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-inappbrowser/pull/225.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #225 commit 89573d90a2c32c21537362229948b12bad531cdf Author: Jan Piotrowski <piotrowski+git...@gmail.com> Date: 2017-07-01T00:41:04Z Resort and reword cordova.InAppBrowser.open `options` lists for better developer experience --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
