[GitHub] cordova-lib issue #558: CB-12766 Consistently write JSON with 2 spaces inden...
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-lib/pull/558 There is also https://issues.apache.org/jira/browse/CB-13009, they are similar, not sure if duplicated --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request #148: CB-13265 Remove ios usage descriptio...
GitHub user jcesarmobile opened a pull request: https://github.com/apache/cordova-plugin-media/pull/148 CB-13265 Remove ios usage description from media plugin ### Platforms affected ios ### What does this PR do? Removes the MICROPHONE_USAGE_DESCRIPTION preference and documents how to use edit-config to do the same ### What testing has been done on this change? ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jcesarmobile/cordova-plugin-media CB-13265 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-media/pull/148.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #148 commit 73871f84f746fe85f823f79962caa683a07a9c09 Author: Julio César Date: 2017-09-11T22:24:43Z CB-13265 Remove ios usage description from media plugin --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request #727: CB-13247 - Blog post for Cordova iOS 4.5.0 R...
Github user jcesarmobile commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/727#discussion_r137936966 --- Diff: www/_posts/2017-09-08-ios-release.md --- @@ -0,0 +1,72 @@ +--- +layout: post +author: +name: Shazron Abdullah +url: https://twitter.com/shazron +title: "Cordova iOS 4.5.0" +categories: announcements +tags: news releases +--- + +We are happy to announce a minor version of `Cordova iOS 4.5.0` has been released! + +Three new features were added: +1. [CB-12937](https://issues.apache.org/jira/browse/CB-12937) - Plugins can receive `handleOpenURLWithApplicationSourceAndAnnotation:` now (new selector, that sends the URL with additional metadata) +2. [CB-13164](https://issues.apache.org/jira/browse/CB-13164) - Integrated cordova-plugin-console to build in support for window.console. +3. [CB-10916](https://issues.apache.org/jira/browse/CB-10916) - Support [display name](/docs/en/dev/config_ref/index.html#name) for **iOS** + +Note that for [CB-13164](https://issues.apache.org/jira/browse/CB-13164) if you already included `cordova-plugin-console` in your project, you must **remove** that plugin if not your project will not build. + +If you ever needed to disable the built in console plugin, comment out or remove the `Console` `` tag in your platform specific `config.xml`, and/or call this right after the `deviceready` event: --- End diff -- Is that the only way of disabling it? should we make it configurable? Android has different log levels and can be configured via a preference in the config.xml --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request #727: CB-13247 - Blog post for Cordova iOS 4.5.0 R...
Github user jcesarmobile commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/727#discussion_r137936915 --- Diff: www/_posts/2017-09-08-ios-release.md --- @@ -0,0 +1,72 @@ +--- +layout: post +author: +name: Shazron Abdullah +url: https://twitter.com/shazron +title: "Cordova iOS 4.5.0" +categories: announcements +tags: news releases +--- + +We are happy to announce a minor version of `Cordova iOS 4.5.0` has been released! + +Three new features were added: +1. [CB-12937](https://issues.apache.org/jira/browse/CB-12937) - Plugins can receive `handleOpenURLWithApplicationSourceAndAnnotation:` now (new selector, that sends the URL with additional metadata) +2. [CB-13164](https://issues.apache.org/jira/browse/CB-13164) - Integrated cordova-plugin-console to build in support for window.console. +3. [CB-10916](https://issues.apache.org/jira/browse/CB-10916) - Support [display name](/docs/en/dev/config_ref/index.html#name) for **iOS** + +Note that for [CB-13164](https://issues.apache.org/jira/browse/CB-13164) if you already included `cordova-plugin-console` in your project, you must **remove** that plugin if not your project will not build. + +If you ever needed to disable the built in console plugin, comment out or remove the `Console` `` tag in your platform specific `config.xml`, and/or call this right after the `deviceready` event: --- End diff -- in platforms/platformName there is a platform specific config.xml for platformName --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-device issue #71: Auto Hide Splashscreen issue in android
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-device/pull/71 This is not the place to ask questions, sorry, try on cordova slack or stack overflow --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-splashscreen issue #132: Auto Hide Splashscreen issue in andr...
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/132 Hi, You have created a Pull Request by mistake, can you close it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-device issue #71: Auto Hide Splashscreen issue in android
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-device/pull/71 Hi, You have created a Pull Request by mistake, can you close it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #230: when i use cordova.InAppBrowser.open...
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/230 You have send a pull request, can you close it? You just have to add gap: to your Content-Security-Policy meta tag --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request #229: CB-12586 (iOS) fix method hid...
Github user jcesarmobile closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/229 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request #229: CB-12586 (iOS) fix method hid...
GitHub user jcesarmobile reopened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/229
CB-12586 (iOS) fix method hide doesn't work
### Platforms affected
iOS
### What does this PR do?
Fix hide method
self.viewController wasn't presenting the inAppBrowser view controller
anymore, so we can't use it to hide it, so changed to ask it's
presentingViewController to dismiss it.
### What testing has been done on this change?
Tested on real device
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB- is the JIRA ID & "android" is the platform
affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jcesarmobile/cordova-plugin-inappbrowser
CB-12586
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/229.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #229
commit 88d128f258cf9c548eb47b122a05b2a391832293
Author: Julio César
Date: 2017-07-23T16:03:06Z
CB-12586 (iOS) fix method hide doesn't work
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request #229: CB-12586 (iOS) fix method hid...
GitHub user jcesarmobile opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/229
CB-12586 (iOS) fix method hide doesn't work
### Platforms affected
iOS
### What does this PR do?
Fix hide method
self.viewController wasn't presenting the inAppBrowser view controller
anymore, so we can't use it to hide it, so changed to ask it's
presentingViewController to dismiss it.
### What testing has been done on this change?
Tested on real device
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB- is the JIRA ID & "android" is the platform
affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jcesarmobile/cordova-plugin-inappbrowser
CB-12586
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/229.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #229
commit 88d128f258cf9c548eb47b122a05b2a391832293
Author: Julio César
Date: 2017-07-23T16:03:06Z
CB-12586 (iOS) fix method hide doesn't work
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request #228: CB-13035 fix Create issue Lin...
GitHub user jcesarmobile opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/228 CB-13035 fix Create issue Link ### Platforms affected README.md ### What does this PR do? Fix the JIRA link on the README.md ### What testing has been done on this change? Clicked the link ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jcesarmobile/cordova-plugin-inappbrowser CB-13035 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-inappbrowser/pull/228.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #228 commit 1aaa5b97e6371daf000d3085109a094e10da5108 Author: Julio César Date: 2017-07-23T15:29:57Z CB-13035 fix Create issue Link --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios issue #313: CB-12856 - Skip CocoaPods check_reqs if on non-darwi...
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-ios/pull/313 @andreszs I've been reading some of your comments and issues that you have been opening in different projects and it's not the first time you publicly embarrass yourself because of your lack of knowledge. But don't get me wrong, your lack of knowledge is not the problem here, your problem is the lack of respect to other people work and the way of communicating it. If you don't fully understand how something work, you can politely ask. If you think that you understand how something work, you still have to be polite and don't disrespect the people who did the work and offered for free. We are humans and we are not perfect, so sometimes we make mistakes, and introduce bugs or don't consider all use cases. When this happen we really appreciate people reporting them. I feel your pain and I understand that you can get angry because of a bug that affects you, but that doesn't entitle you to be rude on your comments. To help you with your lack of knowledge, I'm going to explain to you how we work with jira and github. - Somebody report a bug on jira. - Somebody start working on the bug - When he finds a solution he send a pull request to github. - The pull request is reviewed and if everything is ok then it's merged - The status of the jira issue is changed to fixed and a fix version is set. After a few bugs has been fixed, then we do a release including all of them. In https://issues.apache.org/jira/browse/CB-12856 you can see that the fix version is set to cordova-ios@4.4.1. Which version do you have installed? I assume you have 4.4.0 because it's the latest released one, that means you don't have the fix yet. If you can't wait until this version is released, you can get the fix using nightly versions or installing the platform from the github master branch. I hope this helped you to understand how things work. I also hope that you start respecting other people work and be more respectful when you write your next comment or create your next issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media-capture issue #77: Suport iPhone 6
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-media-capture/pull/77 If you add a new commit to your local `patch-1` branch and push it to your remote branch `patch-1`, the changes will be added to this PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media-capture issue #77: Suport iPhone 6
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-media-capture/pull/77 @eduardokraus I saw the images on that link, but can you add them to the PR? if you don't add them to the CDVCapture.bundle they won't work --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media-capture issue #77: Suport iPhone 6
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-media-capture/pull/77 The code looks good, but the problem is those images don't exist. Could you add them to the PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-statusbar issue #82: README: Fix issue tracker link
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/82 I think it should be better to just change the component to `"cordova-plugin-statusbar"`. Right now it redirects to the one you used, but if some day CB-9742 is closed, the url will probably stop working. Also, it would be good if you report the issue and use the issue id on the title, it's good to track even small changes like this one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #101: CB-8467 provide hide method to hide ...
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/101 @bgallz there is a bug (already reported) about hide not working because of other changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios issue #246: CB-11712 - changes in config.xml does a 'sear...
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-ios/pull/246 only downgrade to previous CLI --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios issue #246: CB-11712 - changes in config.xml does a 'sear...
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-ios/pull/246 But you said that you were removing and re adding the platforms, so it shouldn't complain in that case. This might be related to Cordova CLI 7 also using the package.json for storing the platforms. Can you create a new issue on http://issues.cordova.io/? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios issue #246: CB-11712 - changes in config.xml does a 'sear...
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-ios/pull/246 What is your error exactly? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-battery-status issue #53: CI Rerun test
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-battery-status/pull/53 cordova-qa run tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-node-xcode pull request #2: CB-12844 Update pbxProject.js
Github user jcesarmobile commented on a diff in the pull request:
https://github.com/apache/cordova-node-xcode/pull/2#discussion_r118257164
--- Diff: lib/pbxProject.js ---
@@ -1546,7 +1546,7 @@ function pbxShellScriptBuildPhaseObj(obj, options,
phaseName) {
obj.inputPaths = options.inputPaths || [];
obj.outputPaths = options.outputPaths || [];
obj.shellPath = options.shellPath;
-obj.shellScript = '"' + options.shellScript.replace(/"/g, '\\"') + '"';
+obj.shellScript = '"' + options.shellScript.replace(/\\/g, '') +
'"';
--- End diff --
Doing this you remove the escaping of `"`, I should have both, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-splashscreen issue #126: On Android 7 not work
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/126 @filmaj I know, I've done it a few times, but I like to wait a few days because if the user closes it, we have less empty commits --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-splashscreen issue #126: On Android 7 not work
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/126 Hi. You have created a Pull Request. Can you close it? If you want to report a bug, you can do it on issues.cordova.io --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file-transfer issue #179: CB-12809 android
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/179 Yeah, so the solution should be to deprecate `trustAllHosts`, documenting it and then remove those methods, not to implement them with a safe implementation because that will make `trustAllHosts` to stop working --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file-transfer issue #179: CB-12809 android
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/179 Those methods are there to ignore the certificates if you pass `trustAllHosts` param set to true (default is false) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request #703: CB-12770: revise security documentation
Github user jcesarmobile commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/703#discussion_r115360483 --- Diff: www/docs/en/dev/guide/appdev/security/index.md --- @@ -27,69 +27,155 @@ description: Information and tips for building a secure application. The following guide includes some security best practices that you should consider when developing a Cordova application. Please be aware that security is a very complicated topic and therefore this guide is not exhaustive. If you believe you can contribute to this guide, please feel free to file an issue in Cordova's bug tracker under ["Documentation"](https://issues.apache.org/jira/browse/CB/component/12316407). This guide is designed to be applicable to general Cordova development (all platforms) but special platform-specific considerations will be noted. ## This guide discusses the following topics: + +* General Tips +* Plugins and Security +* Content Security Policy * Whitelist -* Iframes and the Callback Id Mechanism * Certificate Pinning * Self-signed Certificates +* Wrapping external sites and hot code push * Encrypted storage -* General Tips * Recommended Articles and Other Resources +## General Tips + +### Use InAppBrowser for outside links + +Use the InAppBrowser when opening links to any outside website. This is much safer than whitelisting a domain name and including the content directly in your application because the InAppBrowser will use the native browser's security features and will not give the website access to your Cordova environment. Even if you trust the third party website and include it directly in your application, that third party website could link to malicious web content. + +### Validate all user input + +Always validate any and all input that your application accepts. This includes usernames, passwords, dates, uploaded media, etc. Because an attacker could manipulate your HTML and JS assets (either by decompiling your application or using debugging tools like `chrome://inspect`), this validation should also be performed on your server, especially before handing the data off to any backend service. + +> **Tip**: Other sources where data should be validated: user documents, contacts, push notifications + +### Do not cache sensitive data + +If usernames, password, geolocation information, and other sensitive data is cached, then it could potentially be retrieved later by an unauthorized user or application. + +### Don't use eval() + +The JavaScript function eval() has a long history of being abused. Using it incorrectly can open your code up for injection attacks, debugging difficulties, and slower code execution. + +### Do not assume that your source code is secure + +Since a Cordova application is built from HTML and JavaScript assets that get packaged in a native container, you should not consider your code to be secure. It is possible to reverse engineer a Cordova application. + +A sampling of what you should not include in your code: + +* Authentication information (usernames, passwords, keys, etc.) +* Encryption keys +* Trade secrets + +### Do not assume storage containers are secure + +Even if a device itself is encrypted, if someone has access to the device and can unlock it, you should not assume that data stored in various formats and containers is safe. Even SQLite databases are easily human readable once access is gained. + +As long as you're storing non-sensitive information, this isn't a big deal. But if you were storing passwords, keys, and other sensitive information, the data could be easily extracted, and depending on what was stored, could be used against your app and remote servers. + +For example, on iOS, if you store data in `localStorage`, the data itself is easily readable to anyone who has access to the device. This is because `localStorage` is backed by an unencrypted SQLite database. The underlying storage of the device may in fact be encrypted (and so it would be inaccessible while the device is locked), but once the device decrypts the file, the contents themselves are mostly in the clear. As such, the contents of `localStorage` can be easily read and even changed. + +## Plugins and Security + +Due to the way the native portion of Cordova communicates with your web code, it is possible for any code executing within the main webview context to communicate with any installed plugins. This means that you should _never_ permit untrusted content within the primary webview. This can include third-party advertisements, sites within an `iframe`, and even content injected via `innerHTML`. + +If you must inject content into the primary
[GitHub] cordova-plugin-geolocation pull request #87: Update CDVLocation.m
Github user jcesarmobile commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/87#discussion_r113578907
--- Diff: src/ios/CDVLocation.m ---
@@ -94,61 +94,62 @@ - (BOOL)isLocationServicesEnabled
- (void)startLocation:(BOOL)enableHighAccuracy
{
-if (![self isLocationServicesEnabled]) {
-[self returnLocationError:PERMISSIONDENIED withMessage:@"Location
services are not enabled."];
-return;
-}
-if (![self isAuthorized]) {
-NSString* message = nil;
-BOOL authStatusAvailable = [CLLocationManager
respondsToSelector:@selector(authorizationStatus)]; // iOS 4.2+
-if (authStatusAvailable) {
-NSUInteger code = [CLLocationManager authorizationStatus];
-if (code == kCLAuthorizationStatusNotDetermined) {
-// could return POSITION_UNAVAILABLE but need to
coordinate with other platforms
-message = @"User undecided on application's use of
location services.";
-} else if (code == kCLAuthorizationStatusRestricted) {
-message = @"Application's use of location services is
restricted.";
+[self.commandDelegate runInBackground:^{
+if (![self isLocationServicesEnabled]) {
--- End diff --
I think we are abusing of the weak references to self in the plugins. In
most cases it's not really needed because we don't retain the block
http://stackoverflow.com/questions/20030873/always-pass-weak-reference-of-self-into-block-in-arc
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #219: [CB-9148] (android) add setType() me...
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/219 Please, don't reuse the same id as that issue is already closed. Create a new one telling what was broken --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media-capture issue #76: Audio Capture - added support for iP...
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-media-capture/pull/76 @momomatteo can you put the issue id (CB-12562) on the title so it's linked with the original issue on JIRA? Also, can you remove one of the `#import `? you duplicated it And finally, after those changes, can you squash all the commits into one? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera issue #253: CB-12458 - [cordova-plugin-camera] - The i...
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/253 A version with the deprecated id of the camera plugin will crash on new installs on iOS 10 devices, so everybody using camera plugin should be using at least 2.3.1, also 2.2.0 is needed to handle Android 6 permissions. This PR explains what happens when you install the plugin using the new id but using an old version of the plugin that used the deprecated id, that shouldn't happen nowadays. A legacy project that already have the plugin installed, it was installed with the old id, so it doesn't need the explanation neither. Anyway, thanks for the PR! I would like to see you contributing in other issues in the future. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera issue #253: CB-12458 - [cordova-plugin-camera] - The i...
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/253 @camilamacedo86 I just explained to you how the deprecated ID works so you could understand, but I don't think we need to document it considering version 1 is two years old and nobody should be using older versions with the deprecated id by now. I think you can close the PR and the issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios issue #296: CB-12571 - Podfile gets overwritten and some depende...
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-ios/pull/296 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-contacts issue #107: CB-10784: CDVContactsPicker finish anima...
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/107 Thanks, merged! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media issue #132: CB-12542 - Can't record to a wav file
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-media/pull/132 Can we have wav and m4a as in https://github.com/apache/cordova-plugin-media/pull/131? In any case, the README.md needs an update, right now it says that iOS only accept wav, which won't be true after this change --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media issue #116: CB-11817: (iOS) Fix unused recording settin...
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-media/pull/116 @shazron there is an issue https://issues.apache.org/jira/browse/CB-12542, and it has a PR already --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media issue #131: CB-1254: (ios) Fix wav file recording, add ...
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-media/pull/131 Hi. The title should CB-12542, you missed the 2. Change it so it's linked with the issue. Also, the PR is showing 13 commit's, that is wrong. Can you rebase your branch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-dialogs issue #92: added support for destructive Button on iO...
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-dialogs/pull/92 A change like this should be documented. Also, we usually don't accept this kind of changes to only one platform, do you know if it's possible to use destructive button styles on other platforms? I think it's more clear if you use `destructiveButtonLabel` instead of `addDestructiveButtonWithLabel` in the javascript and in some places of the .m like when you pick the command arguments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios issue #293: CB-12523 - Remove iOS 8 support
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-ios/pull/293 A few tests are set to iOS 8 like https://github.com/apache/cordova-ios/blob/master/tests/spec/unit/fixtures/test-config-2.xml#L15 Should them also be updated? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-contacts issue #107: CB-10784: CDVContactsPicker finish anima...
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/107 can you rebase and squash the commits into one? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-contacts issue #107: CB-10784: CDVContactsPicker finish anima...
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/107 I think the PR is ok and I don't think that we need the weakSelf in this case. In fact, I think we are overusing it in most cases, we should only use it when we might have a retain cycle. The only thing that might be changed on the PR is to create the PluginResult inside all the blocks, but just for consistency, there is one inside and the other two outside. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #209: CB-12366: (ios) Reduce tmpWindow lev...
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/209 Thanks for the PR, I've merged it after making sure that changing the window level doesn't break the changes introduced in #187 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #121: Fixed issues causing spinner to not ...
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/121 Closed the PR, it was already covered by #89 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #88: CB-3750: Add loading spinner for andr...
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/88 @cjpearson as this was never merged for CB-3750, I've created CB-12479 to track the Android spinner. Can you change the title to link CB-12479 and also rebase fixing the conflicts? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media issue #128: CB-12422: (iOS) Fix readme issue on backgro...
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-media/pull/128 Changes look good, not sure why CI fails now. Can you squash the commits? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media issue #128: CB-12422: (iOS) Fix readme issue on backgro...
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-media/pull/128 "iOS doesn't allow background audio unless you enable it in the info.plist file" can be rephrased to something like "To allow playback with the screen locked or background audio you have to add audio to UIBackgroundModes in the info.plist file" And maybe adding a link to Apple doc about background modes might help. (https://developer.apple.com/library/content/documentation/iPhone/Conceptual/iPhoneOSProgrammingGuide/BackgroundExecution/BackgroundExecution.html#//apple_ref/doc/uid/TP40007072-CH4-SW23) No need to link a 3rd party plugin as there are a few and we shouldn't "promote" one above the others, is up to the user how to write in the info.plist (manually or with a plugin), and hopefully we will be able to do it soon from the config.xml without the need of a 3rd party plugin. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media issue #127: CB-12434 (Android) fix Stoping a Paused Rec...
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-media/pull/127 @macdonst can you take a look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request #127: CB-12434 (Android) fix Stoping a Pau...
GitHub user jcesarmobile opened a pull request:
https://github.com/apache/cordova-plugin-media/pull/127
CB-12434 (Android) fix Stoping a Paused Recording throws exception
### Platforms affected
Android
### What does this PR do?
When you pause the recording and the stop it, the audio is added twice to
the tempFiles list, so when it's moved it's moved twice, but the second time it
no longer exits. This PR checks if the file is already on the list and doesn't
add it if it's already there.
### What testing has been done on this change?
Manual testing on Android 5 and 6 phones
### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB- is the JIRA ID & "android" is the platform
affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jcesarmobile/cordova-plugin-media CB-12434
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-media/pull/127.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #127
commit ffeb17feb2d4a6493a3395d4db09f7e54144b6ae
Author: Julio César
Date: 2017-02-09T22:49:10Z
CB-12434 (Android) fix Stoping a Paused Recording throws exception
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera issue #168: CB-10369: Added getVideo() feature with th...
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/168 @infil00p see comments on https://issues.apache.org/jira/browse/CB-10369, I commented that in the 2015 plugin audit there were recommendations to deprecate the media-capture plugin and use camera instead for the video, so this PR might be a good starting point. But maybe it should be discussed again on the mail list --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera issue #251: CB-12368: Fix permission check on Android
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/251 Thanks, I've merged it. BTW, how did you do to get READ_EXTERNAL_STORAGE permission asked? I get it granted and it never ask for it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #342: CB-12028: (android) update distributionUrl , cur...
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-android/pull/342 @hye This has landed in another commit, can you close the PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media-capture issue #65: CB-10180: (iOS) implement the 'quali...
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-media-capture/pull/65 You can read there that there are 3 different pull requests to add quality and all of them want to do it in a different way. We voted and decided that the quality should be 0 - Low ... // Other possible values in the future 0.5 - Medium // Only iOS ... // Other possible values in the future 1 - High So, one of the 3 PRs should be changed to work this way, or a new PR should be created to work this way. Once that is done I'll merge it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media-capture issue #65: CB-10180: (iOS) implement the 'quali...
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-media-capture/pull/65 I started a discussion on the developer list about the quality https://lists.apache.org/thread.html/e115b2a47b4e72e114825dedc5de8e55eaba76f7865f377907cf1df9@%3Cdev.cordova.apache.org%3E --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-statusbar pull request #:
Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/commit/fa57e92c5582d0edc7fc4b1f4be7f5e3380d93cf#commitcomment-2054 `statusBarOverlaysWebView` has never affected InAppBrowser plugin or any other plugin, it only applies to the Cordova WebView. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #187: CB-11136: InAppBrowser fails to clos...
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/187 @reidab Can you create a new issue for that on issues.cordova.io? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #205: CB-9148 - (android) Add support for ...
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/205 @infil00p `openFileChooser` wasn't a public API, but it was working before Android 4.4.0. In android 4.4.0 they decided to remove it and said that it wasn't a public API https://code.google.com/p/android/issues/detail?id=62220 Then they added it back in 4.4.3, so on 4.4.0, 4.4.1 and 4.4.2 it won't work. And finally in Android 5 they added the public API `onShowFileChooser` I agree, this should be a new issue. @darron1217, BTW, you can take a look into the implementation in the Cordova webview, I think it works fine with Android 4.3 https://github.com/apache/cordova-android/blob/master/framework/src/org/apache/cordova/engine/SystemWebChromeClient.java --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media issue #124: CB-12319: (Android&iOS) Fix bug that record...
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-media/pull/124 AAC_ADTS is API level 16, which is fine as is the min used in cordova-android 6.1.0, but then you should make the plugin require that cordova-android version on the engine tag, and requiring that version might also require a major or minor bump on the plugin version. Also, the README.md should be changed as right now it says that Android records in Adaptive Multi-Rate format, which won't be true after merging this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine issue #25: CB-12317: Allow to configure navi...
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/25 You should also document it on the README.md --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request #205: CB-9148 - (android) Add suppo...
Github user jcesarmobile commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/205#discussion_r94507888
--- Diff: src/android/InAppBrowser.java ---
@@ -722,7 +729,57 @@ public void onClick(View v) {
inAppWebView = new WebView(cordova.getActivity());
inAppWebView.setLayoutParams(new
LinearLayout.LayoutParams(LayoutParams.MATCH_PARENT,
LayoutParams.MATCH_PARENT));
inAppWebView.setId(Integer.valueOf(6));
-inAppWebView.setWebChromeClient(new
InAppChromeClient(thatWebView));
+// File Chooser Implemented ChromeClient
+inAppWebView.setWebChromeClient(new
InAppChromeClient(thatWebView) {
+// For Android 5.0+
+public boolean onShowFileChooser (WebView webView,
ValueCallback filePathCallback, WebChromeClient.FileChooserParams
fileChooserParams)
+{
+Log.d(LOG_TAG, "File Chooser 5.0+");
--- End diff --
We use LOG instead of Log to use Cordova LOG instead of default Log, so it
can be disabled with a preference.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request #205: CB-9148 - (android) Add suppo...
Github user jcesarmobile commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/205#discussion_r94467650
--- Diff: src/android/InAppBrowser.java ---
@@ -722,7 +729,57 @@ public void onClick(View v) {
inAppWebView = new WebView(cordova.getActivity());
inAppWebView.setLayoutParams(new
LinearLayout.LayoutParams(LayoutParams.MATCH_PARENT,
LayoutParams.MATCH_PARENT));
inAppWebView.setId(Integer.valueOf(6));
-inAppWebView.setWebChromeClient(new
InAppChromeClient(thatWebView));
+// File Chooser Implemented ChromeClient
+inAppWebView.setWebChromeClient(new
InAppChromeClient(thatWebView) {
+// For Android 5.0+
+public boolean onShowFileChooser (WebView webView,
ValueCallback filePathCallback, WebChromeClient.FileChooserParams
fileChooserParams)
+{
+Log.d(LOG_TAG, "File Chooser 5.0+");
+// If callback exists, finish it.
+if(mUploadCallbackLollipop != null) {
+mUploadCallbackLollipop.onReceiveValue(null);
+}
+mUploadCallbackLollipop = filePathCallback;
+
+// Create File Chooser Intent
+Intent content = new
Intent(Intent.ACTION_GET_CONTENT);
+content.addCategory(Intent.CATEGORY_OPENABLE);
+content.setType("*/*");
+
+// [important] Register ActvityResultCallback on
Cordova
+
cordova.setActivityResultCallback(InAppBrowser.this);
+
cordova.getActivity().startActivityForResult(content,
FILECHOOSER_REQUESTCODE_LOLLIPOP);
+return true;
+}
+
+// For Android 4.1+
+public void openFileChooser(ValueCallback
uploadMsg, String acceptType, String capture)
+{
+Log.d(LOG_TAG, "File Chooser 4.1+");
+// Call file chooser for Android 3.0+
+openFileChooser(uploadMsg, acceptType);
+}
+
+// For Android 3.0+
+public void openFileChooser(ValueCallback
uploadMsg, String acceptType)
+{
+Log.d(LOG_TAG, "File Chooser 3.0+");
+mUploadCallback = uploadMsg;
+Intent i = new Intent(Intent.ACTION_GET_CONTENT);
+i.addCategory(Intent.CATEGORY_OPENABLE);
+
+
cordova.setActivityResultCallback(InAppBrowser.this);
+cordova.getActivity().startActivityForResult(
Intent.createChooser(i, "File Chooser"), FILECHOOSER_REQUESTCODE);
+}
+
+// For Android < 3.0
+public void openFileChooser(ValueCallback
uploadMsg) {
+Log.d(LOG_TAG, "File Chooser 3.0 <");
+// Call file chooser for Android 3.0+
+openFileChooser(uploadMsg, "");
+}
+
--- End diff --
Well, latest cordova-android doesn't support Android versions below 4.1,
but the plugin can be used with older versions of cordova-android as we have
the engine set to cordova >=3.1.0. We should bump the engine version to the one
that started setting the SDK version to 16 if we are not going to support older
Android versions in plugins.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-network-information issue #49: CB-11838 ios: Unregister callb...
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-network-information/pull/49 Let there be tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-network-information issue #48: --save flag
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-network-information/pull/48 Thanks for the PR, but I don't think this is necessary --save flag is documented, but I don't think we should use --save in every example of plugin install. I'm closing the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request #123: Fix getCurrentAmplitude definition, ...
Github user jcesarmobile commented on a diff in the pull request: https://github.com/apache/cordova-plugin-media/pull/123#discussion_r94079923 --- Diff: README.md --- @@ -104,7 +104,7 @@ The following constants are reported as the only parameter to the ### Methods -- `media.getCurrentAmplitude`: Returns the current position within an audio file. +- `media.getCurrentAmplitude`: Returns the current amplitude of the current recording. --- End diff -- Because that definition is also wrong, you are not recording, so the "of the current recording" makes no sense. And all the other function definitions say "within an audio file" or "of an audio file" --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request #123: Fix getCurrentAmplitude definition, ...
Github user jcesarmobile commented on a diff in the pull request: https://github.com/apache/cordova-plugin-media/pull/123#discussion_r94078703 --- Diff: README.md --- @@ -104,7 +104,7 @@ The following constants are reported as the only parameter to the ### Methods -- `media.getCurrentAmplitude`: Returns the current position within an audio file. +- `media.getCurrentAmplitude`: Returns the current amplitude of the current recording. --- End diff -- I saw the issue when you created it, but I don't think the new definition is right. I think it should be "Returns the current amplitude within an audio file." as this is not a recording, you should also change the other occurrence of "Returns the current amplitude of the current recording" --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-statusbar pull request #74: CB-12196 (iOS) fix Status Bar Not...
GitHub user jcesarmobile opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/74 CB-12196 (iOS) fix Status Bar Not Hiding ### Platforms affected iOS ### What does this PR do? Fix the statusbar not hiding when overlaysWebView is false. ### What testing has been done on this change? Manual testing ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jcesarmobile/cordova-plugin-statusbar CB-12196 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-statusbar/pull/74.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #74 commit 90507a8cd092980cadca1030977b1e1cf2c42d1b Author: Julio César Date: 2016-12-27T19:32:54Z CB-12196 (iOS) fix Status Bar Not Hiding --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-statusbar pull request #:
Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/commit/a120ba1a1ffb27d46f2ac7962648e6f8a7a5b24c#commitcomment-20262925 Well, that issue was created before this was merged, so this couldn't cause that issue. But will use that as the problem seems the same --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-statusbar pull request #:
Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/commit/a120ba1a1ffb27d46f2ac7962648e6f8a7a5b24c#commitcomment-20262818 @regnete can you create a new issue on http://issues.cordova.io? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request #203: CB-10799 (ios) fix toolbar in...
GitHub user jcesarmobile opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/203 CB-10799 (ios) fix toolbar in incorrect position when in-call status bar ### Platforms affected iOS ### What does this PR do? Fix the incorrect position of the toolbar when the inAppBrowser is presented while in-call status bar is show. ### What testing has been done on this change? ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jcesarmobile/cordova-plugin-inappbrowser CB-10799 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-inappbrowser/pull/203.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #203 commit a0bcc6a48d39d1eb8689a799f51fbbd8b55036d1 Author: Julio César Date: 2016-12-20T23:39:25Z CB-10799 (ios) fix toolbar is shown in incorrect position when in-call status bar --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request #282: CB-11810 (ios) fix unable to load index page ...
GitHub user jcesarmobile opened a pull request: https://github.com/apache/cordova-ios/pull/282 CB-11810 (ios) fix unable to load index page from frameworkpath ### Platforms affected iOS ### What does this PR do? In cordova-ios 4.2.0 it was included the possibility to start the app from a .framework or .bundle, but only if the files were in the root. This PR adds the possibility to use a folder inside the .framework or .bundle ### What testing has been done on this change? manual testing ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jcesarmobile/cordova-ios CB-11810 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-ios/pull/282.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #282 commit 9e58001c23c164d6779ae8ca8dad96cef9057d4d Author: Julio César Date: 2016-12-17T16:14:09Z CB-11810 (ios) fix unable to load index page from frameworkpath --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-statusbar pull request #73: CB-12141 (ios) fix white app scre...
GitHub user jcesarmobile opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/73 CB-12141 (ios) fix white app screen after camera overlay shown on iPad ### Platforms affected iOS ### What does this PR do? fix white app screen after camera overlay shown on iPad. removes all the hackish code we added to fix specific cases, this simpler code seems to fix all of them. ### What testing has been done on this change? ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jcesarmobile/cordova-plugin-statusbar CB-12141-3 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-statusbar/pull/73.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #73 commit 579a5a692b718a4bcabb255d9e4a7b59b3334b1d Author: Julio César Date: 2016-12-08T23:18:23Z CB-12141 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs issue #664: Update images.md
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-docs/pull/664 Yes @shazron, the icon problem is fixed in cordova-android 6.1.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-statusbar issue #72: Update plugin.xml
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/72 Those are the default values, if you provide your own values in the config.xml the app should use those. If that isn't working then create an issue about it in http://issues.cordova.io/ so we can fix it, but removing them from the plugin.xml is not the solution. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #350: 6.1.x App Crash when put number input
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-android/pull/350 You can start by creating a proper issue on http://issues.cordova.io/ and closing the PR you created, because opening PRs is not the way of creating issues. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request #197: CB-12132: (android & ios) imp...
Github user jcesarmobile commented on a diff in the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/197#discussion_r90834795 --- Diff: README.md --- @@ -131,6 +132,7 @@ instance, or the system browser. - __presentationstyle__: Set to `pagesheet`, `formsheet` or `fullscreen` to set the [presentation style](http://developer.apple.com/library/ios/documentation/UIKit/Reference/UIViewController_Class/Reference/Reference.html#//apple_ref/occ/instp/UIViewController/modalPresentationStyle) (defaults to `fullscreen`). - __transitionstyle__: Set to `fliphorizontal`, `crossdissolve` or `coververtical` to set the [transition style](http://developer.apple.com/library/ios/#documentation/UIKit/Reference/UIViewController_Class/Reference/Reference.html#//apple_ref/occ/instp/UIViewController/modalTransitionStyle) (defaults to `coververtical`). - __toolbarposition__: Set to `top` or `bottom` (default is `bottom`). Causes the toolbar to be at the top or bottom of the window. +- __hidenotclose__: set to 'yes' to make the done/close button hide the browser window rather than closing the browser (defaults to 'no') --- End diff -- yeah, it's for both, but the preference is documented for both too, so in the iOS section it should say "done" and in the Android section it should say "close" instead of saying "done/close" on both --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request #197: CB-12132: (android & ios) imp...
Github user jcesarmobile commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/197#discussion_r90559621
--- Diff: src/ios/CDVInAppBrowser.m ---
@@ -246,25 +246,11 @@ - (void)show:(CDVInvokedUrlCommand*)command
- (void)hide:(CDVInvokedUrlCommand*)command
--- End diff --
Just make it
```- (void)hide:(CDVInvokedUrlCommand*)command
{
[self browserHide];
}
There is no need to create a new hide method, you can call browserHide
directly
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request #197: CB-12132: (android & ios) imp...
Github user jcesarmobile commented on a diff in the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/197#discussion_r90559723 --- Diff: src/ios/CDVInAppBrowser.m --- @@ -815,6 +827,13 @@ - (void)close }); } +- (void)hide --- End diff -- As I said before, you can just remove this method if you call browserHide from the another hide --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request #197: CB-12132: (android & ios) imp...
Github user jcesarmobile commented on a diff in the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/197#discussion_r90559822 --- Diff: src/ios/CDVInAppBrowser.h --- @@ -96,6 +97,7 @@ @property (nonatomic) NSURL* currentURL; - (void)close; +- (void)hide; --- End diff -- There is no need for this method --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request #197: CB-12132: (android & ios) imp...
Github user jcesarmobile commented on a diff in the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/197#discussion_r90559216 --- Diff: README.md --- @@ -131,6 +132,7 @@ instance, or the system browser. - __presentationstyle__: Set to `pagesheet`, `formsheet` or `fullscreen` to set the [presentation style](http://developer.apple.com/library/ios/documentation/UIKit/Reference/UIViewController_Class/Reference/Reference.html#//apple_ref/occ/instp/UIViewController/modalPresentationStyle) (defaults to `fullscreen`). - __transitionstyle__: Set to `fliphorizontal`, `crossdissolve` or `coververtical` to set the [transition style](http://developer.apple.com/library/ios/#documentation/UIKit/Reference/UIViewController_Class/Reference/Reference.html#//apple_ref/occ/instp/UIViewController/modalTransitionStyle) (defaults to `coververtical`). - __toolbarposition__: Set to `top` or `bottom` (default is `bottom`). Causes the toolbar to be at the top or bottom of the window. +- __hidenotclose__: set to 'yes' to make the done/close button hide the browser window rather than closing the browser (defaults to 'no') --- End diff -- Change done/close to just done as iOS has no close button --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request #197: CB-12132: (android & ios) imp...
Github user jcesarmobile commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/197#discussion_r90560844
--- Diff: src/ios/CDVInAppBrowser.m ---
@@ -568,7 +576,11 @@ - (void)createViews
self.spinner.userInteractionEnabled = NO;
[self.spinner stopAnimating];
-self.closeButton = [[UIBarButtonItem alloc]
initWithBarButtonSystemItem:UIBarButtonSystemItemDone target:self
action:@selector(close)];
+if (_browserOptions.hidenotclose != nil) {
--- End diff --
This shows a warning
> Comparison between pointer and integer ('int' and 'void *')
Take a look how the other options are parsed and converted to booleans and
do the same so you can use `if (browserOptions.hidenotclose)`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request #197: CB-12132: (android & ios) imp...
Github user jcesarmobile commented on a diff in the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/197#discussion_r90559136 --- Diff: README.md --- @@ -114,6 +114,7 @@ instance, or the system browser. - __hardwareback__: set to `yes` to use the hardware back button to navigate backwards through the `InAppBrowser`'s history. If there is no previous page, the `InAppBrowser` will close. The default value is `yes`, so you must set it to `no` if you want the back button to simply close the InAppBrowser. - __mediaPlaybackRequiresUserAction__: Set to `yes` to prevent HTML5 audio or video from autoplaying (defaults to `no`). - __shouldPauseOnSuspend__: Set to `yes` to make InAppBrowser WebView to pause/resume with the app to stop background audio (this may be required to avoid Google Play issues like described in [CB-11013](https://issues.apache.org/jira/browse/CB-11013)). +- __hidenotclose__: set to 'yes' to make the done/close button hide the browser window rather than closing the browser (defaults to 'no') --- End diff -- change done/close to just close as the done button is for iOS --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request #200: CB-7608 (android) document us...
GitHub user jcesarmobile opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/200 CB-7608 (android) document useWidthViewPort ### Platforms affected Android ### What does this PR do? Documents new feature added in https://github.com/apache/cordova-plugin-inappbrowser/pull/66 ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jcesarmobile/cordova-plugin-inappbrowser CB-7608-doc Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-inappbrowser/pull/200.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #200 commit 55abe85e25e6b7ed2cff6fc241e664f43c550529 Author: Julio César Date: 2016-12-01T22:45:49Z CB-7608 (android) document useWidthViewPort --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib issue #468: CB-8978 Add resource-file parsing to config.xml
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-lib/pull/468 Then looks good to me, I can't think any example right now where the same file should be needed for all platforms --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib issue #468: CB-8978 Add resource-file parsing to config.xml
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-lib/pull/468 I think top level might make sense here if it's a file that the IDE needs but not the app (configuration file like google-services.json/plist) Can the launch images and icons be outside the www folder? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request #199: CB-12184 executeScript leads ...
GitHub user jcesarmobile opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/199 CB-12184 executeScript leads to a null pointer on exception on Android. ### Platforms affected Android ### What does this PR do? Avoid null pointer exception when executeScript is used with _system target Also documented better that you can't use executeScript with _system target ### What testing has been done on this change? ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jcesarmobile/cordova-plugin-inappbrowser CB-12184 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-inappbrowser/pull/199.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #199 commit 93c056efd86a5faed7ff08d4456b6ba68db3174f Author: Julio César Date: 2016-11-24T17:50:49Z CB-12184 executeScript leads to a null pointer on exception on Android. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #196: CB-12140: (android) Content descript...
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/196 Yes, it's ok, I'll merge it later, thanks for the PR! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera issue #240: CB-12086: Added NSPhotoLibraryUsageDescrip...
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/240 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera issue #240: CB-12086: Added NSPhotoLibraryUsageDescrip...
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/240 @vladimir-kotikov I have tried to generate the README.md from the TEMPLATE.md, but it's failing. Can you take a look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-statusbar issue #62: CB-10288: statusbar plugin interaction w...
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/62 Thanks, merged! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-statusbar issue #62: CB-10288: statusbar plugin interaction w...
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/62 Let there be tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #107: CB-9274 Adds missing methods to InAp...
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/107 Ok, I've merged this in case there were still people using amazon-fireos, but it's deprecated and the plugin code might be deleted in future releases --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #66: CB-7608 : add option useWidthViewPort...
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/66 @sebastienblanc I would like to merge this, can you fix the conflicts? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #187: CB-11136: InAppBrowser fails to clos...
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/187 I agree with @jonathanli2, as this way is a bit hackish, I think it's better doing it were it's strictly necessary to fix the bug --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #196: CB-NONE: (android) Set correct conte...
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/196 @PhilippeMorier, can you create an issue on issues.cordova.io and use the id you get as start of the title of this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-statusbar issue #62: CB-10288: statusbar plugin interaction w...
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/62 @jonathanli2 can you rebase your PR squashing the 3 commits into one? I'm having trouble merging this with the tool we use to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-statusbar issue #62: CB-10288: statusbar plugin interaction w...
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/62 I had the chance to test this on a real device and looks good, so I'm merging it in --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #197: CB-12132: (android & ios) implement ...
Github user jcesarmobile commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/197
I didn't meant to reuse the existing hide, but make the old hide just call
the new browserHide as browserHide has the exact same code
```- (void)hide:(CDVInvokedUrlCommand*)command
{
[self browserHide];
}```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #197: CB-12132: (android & ios) implement ...
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/197 The existing hide and the new browserHide do exactly the same, can you make the old hide just call browserHide instead of duplicating code. Can you try adding this to other platforms too? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera issue #238: targetWidth and targetHeight bigger than o...
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/238 I think it makes more sense for photo gallery images, as you might have downloaded them with a low resolution, or maybe when using the front camera in some devices with less than a 1MP. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-statusbar issue #68: CB-10158: (ios) StatusBar issue when rec...
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/68 Ah, didn't think about the pause event and good to know about the webkitDisplayingFullscreen. Anyway, I fixed the issue last weekend, you can close the PR now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
