from:"martincgg"

Github user martincgg commented on the pull request:

https://github.com/apache/cordova-plugin-file/pull/77#issuecomment-53815400
  
Tested over Android and WP8, it works pretty good.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-file pull request: [CB-7375][Entry] set proper file...

Github user martincgg commented on the pull request:

https://github.com/apache/cordova-plugin-file/pull/76#issuecomment-53815245
  
I've tested this over Android and WP8, it looks great.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-file pull request: [CB-7422][File Tests] Use proper...

GitHub user martincgg opened a pull request:

https://github.com/apache/cordova-plugin-file/pull/77

[CB-7422][File Tests] Use proper fileSystem to create fullPath

The filesystem uses root filesystem (PERSISTENT) to compare with a 
TEMPORARY filesystem.
This is wrong, if TEMPORARY, var 'temp_root' should be used to assign value 
to fullPath.
Tested over android & WP8, everything OK.

This wasn't caught before, because android : 
fullPath is: /file, and (root.fullPath + file) returns ---> /file.
although for Windows Phone: the fullPath provides the nativePath as 
/tmp//file, when it tries to compare with (root.fullPath + file) gives //file. 
But tmp_root.fullPath provides the right path: /tmp/ to compare with.

Android it doesn't provide any different fullPath property if temporary or 
persistent, the right path it's contained over the Native or Internal path.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/martincgg/cordova-plugin-file CB-7422

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-file/pull/77.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #77


commit 690cbdf3edf2daf273bd7d18ce51e0b9cc76b8c1
Author: Martin Gonzalez 
Date:   2014-08-28T22:18:34Z

[CB-7422][File Tests] Use proper fileSystem to create fullPath

The filesystem uses root filesystem (PERSISTENT) to compare with a
TEMPORARY filesystem.
This is wrong, if TEMPORARY, temp_root, should be used to assign value
to fullPath.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-file pull request: [CB-7375][Entry] set proper file...

GitHub user martincgg opened a pull request:

https://github.com/apache/cordova-plugin-file/pull/76

[CB-7375][Entry] set proper filesystem in Entry, when moveTo or copyTo

When the native side it doesn't return any kind of value related directly 
related with the fileSystem, it has to be recreated after a copy, however, it 
makes perfect sense, that when the entry for the copied or moved file if 
there's no value in entry.fileSystem, it takes the filesystem property from the 
parent directory that it has been moved to or copied to. So instead of return a 
null object or take the previous filesystem(origin) from wherever location it 
was copied or moved from. It would be better take the parent filesystem name 
and recreate it.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/martincgg/cordova-plugin-file CB-7375

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-file/pull/76.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #76


commit 84ea94a94e68c2f4ef5c28ec91338b5932f44610
Author: Martin Gonzalez 
Date:   2014-08-28T21:53:10Z

[CB-7375][Entry] get proper filesystem in Entry

When the native side it doesn't return any kind of value related
directly with the fileSystem, it has to be recreated after a copy,
however, it makes perfect sense that, when the entry for the copied or
moved file if there's no value in entry.fileSystem, it takes the
filesystem property from the parent directory that it has been moved to
or copied to. So instead of return a null object or take the previous
filesystem(origin) from whatever location it was copied from. It would
be better take the parent filesystem name and recreate it.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-file pull request: [CB-7375] Remove leading slash s...

GitHub user martincgg opened a pull request:

https://github.com/apache/cordova-plugin-file/pull/75

[CB-7375] Remove leading slash statement from condition

Windows Phone file paths starts with a leading slash, if the path is an 
invalid one, the native side it will report a error callback with the 
respective error code.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/martincgg/cordova-plugin-file CB-7375

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-file/pull/75.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #75


commit 36134d48c1864278eb99add9db5a7ca8a4445f74
Author: Martin Gonzalez 
Date:   2014-08-28T16:26:24Z

[CB-7375] Remove leading slash statement from condition

Windows Phone file paths starts with a leading slash, if the path is an
invalid one, the native side it will report a error callback with the
respective error code.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-file pull request: [CB-7419][WP8] Added support to ...

2014-08-27 Thread martincgg

GitHub user martincgg opened a pull request:

https://github.com/apache/cordova-plugin-file/pull/74

[CB-7419][WP8] Added support to get metada from directory

The error CODE 1, in the callback it was about the failed attempt to get 
the size of a directory using 'IsolatedStorageFileStream', throwing a 
SystemException 'DirectoryNotFoundException'.

Instead 'IsolatedStorageFileStream' to get that information from a 
directory, now uses Application.GetResourceStream, to get that information from 
the provided path, only if directory. If other file it would use 
'IsolatedStorageFileStream'.



You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/martincgg/cordova-plugin-file CB-7419

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-file/pull/74.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #74


commit 1dd70b3fe92f2371dc2f8ab3666fc25c1ce488c8
Author: Martin Gonzalez 
Date:   2014-08-27T22:54:27Z

[CB-7419][WP8] Added support to get metada from dir

The error CODE 1, in the callback it was about the a failed attempt to
get the size of a directory using IsolatedStorageFileStream, get that
information, throwing a SystemException 'DirectoryNotFoundException'.
Instead IsolatedStorageFileStream to get that information from a
directory, now uses Application.GetResourceStream, to that information
from the provided path, only if directory. If other file it would use
'IsolatedStorageFileStream'




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-file pull request: [CB-7418][DirectoryEntry] Added ...

2014-08-27 Thread martincgg

GitHub user martincgg opened a pull request:

https://github.com/apache/cordova-plugin-file/pull/73

[CB-7418][DirectoryEntry] Added fullPath variable as part of condition

As well as nativeUrl property, the fullPath variable should be part of the 
condition to avoid that a null value becoming a path, by adding a slash at the 
end of the undefined string, resulting in 'undefined/'.

So in order to add a slash to it, fullPath should contain a value.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/martincgg/cordova-plugin-file CB-7418

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-file/pull/73.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #73


commit ab42f3e7c6c2282ac303e32260e8d68fdd2e18e3
Author: Martin Gonzalez 
Date:   2014-08-27T22:34:05Z

[CB-7418][DirectoryEntry] Added fullPath variable as part of condition

As well as NativeURL property, the fullPath variable should be part of
the condition to avoid that a null value becomes a path, by adding a
slash at the end of the undefined string.
So in order to add a slash to it, fullPath should contain a value.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-file pull request: [CB-7417][File tests] added prop...

2014-08-27 Thread martincgg

GitHub user martincgg opened a pull request:

https://github.com/apache/cordova-plugin-file/pull/72

[CB-7417][File tests] added proper matcher to compare fullPath property

Specs : 111, 112 & 121-124, were using [toBe, toEqual] to compare a Entry's 
fullPath property.
The right matcher to use is toCanonicallyMatch, that it makes a fair and 
right comparison across platforms.

In addition, special case to compare Windows Phone entries, was removed.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/martincgg/cordova-plugin-file CB-7417

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-file/pull/72.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #72


commit b15778749f7487cc4a8fb66c33a86a1a48594430
Author: Martin Gonzalez 
Date:   2014-08-27T22:20:43Z

[CB-7417][File tests] added proper matcher to compare fullPath property

Specs : 111, 112 & 121-124, were using [toBe, toEqual] to compare a
fullPath property from an Entry.
The right matcher to use is toCanonicallyMatch, that it makes a fair and
right comparison across platforms.

In addition, special case to compare Windows Phone entries, was removed.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-mobile-spec pull request: [CB-7374] Use nodejs exec to run...

2014-08-25 Thread martincgg

GitHub user martincgg opened a pull request:

https://github.com/apache/cordova-mobile-spec/pull/106

[CB-7374] Use nodejs exec to run grunt in Windows

Windows requires the specific path and file of the program to run the 
script, the nodejs binary file should be part of the command to run the grunt 
task over the cordova-js repository, in order to create the cordova.js files

If not, the execution stops.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/martincgg/cordova-mobile-spec CB-7374

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-mobile-spec/pull/106.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #106


commit ea12b905f385c06b7615a226574dc11e7199c46d
Author: Martin Gonzalez 
Date:   2014-08-25T16:37:17Z

[CB-7374] Use nodejs exec to run grunt in Windows

Windows requires the specific path and file of the program to run the
script, the nodejs binary file should be part of the command to run the
grunt task.
If not, the execution stops.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-android pull request: [CB-6837][Android] Fix: leaked windo...

GitHub user martincgg opened a pull request:

https://github.com/apache/cordova-android/pull/117

[CB-6837][Android] Fix: leaked window when hitting back button while alert 
being rendered

Created arrayList on ChromeClient that it will register all showed 
AlertDialog, using CordovaChromeClient class, this applies to AlertDialogs 
object, included messages, prompts and confirm AlertDialog objects.

When onDestroy() method is called on the CordovaActivity, it will perform a 
call to ChromeClient class to destroy all AlerDialogs objects registered on the 
arrayList.
This would perform a cleanup before the CordovaActivity is destroyed.

dlg.show() returns an AlertDialog object, to be added to the arrayList.
It can be: 
dialogsManager.add(dlg.show());

But I think it looks cleaner as is already.

Tested on 4.2.2 & 4.4.2.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/martincgg/cordova-android CB-6837

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-android/pull/117.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #117


commit 1dcadbcbb28053b5f9ec81feb2d40660d2978974
Author: Martin Gonzalez 
Date:   2014-08-22T22:43:04Z

[CB-6837 - Android] Fix leaked window when hitting back button while alert 
being rendered




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-android pull request: [CB-7371 -Android] Fixed: app crash ...

GitHub user martincgg opened a pull request:

https://github.com/apache/cordova-android/pull/116

[CB-7371 -Android] Fixed: app crash after phone language change


The main reason of this behavior is the config.xml, origin="" tag, 
specifies access to all kind of resources on the network and makes the 
whiteList object on the WhiteList class a null object, indicating that when 
origin="", there's no whiteList, all is allowed.

When it tries to resume the application it checks:
if (url.startsWith("file://") || url.startsWith("javascript:") || 
whitelist.isUrlWhiteListed(url))
This condition passes and triggers the load for 'about:blank'
The condition passes because, whitelist.isUrlWhiteListed(url) statement 
returns true.
When the origin="*" is processed by the WhiteList class, it sets a null to 
the whiteList object, which it should contain the access to resources allowed, 
however when whitelist.isUrlWhiteListed(url) it returns a true if the whiteList 
object is null, therefore the condition passes and continues to the loadurl 
method on webClient, stopping the application, because of the 'about:blank' url.

Adding another condition along with that statement for when whiteList = 
null, but url= about:blank, in that way it won't be able to load the url.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/martincgg/cordova-android CB-7371

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-android/pull/116.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #116


commit f3e9d46e533d7915876c09c6f95afcea7d842323
Author: Martin Gonzalez 
Date:   2014-08-22T21:04:25Z

[CB-7371 -Android] Fixed: app crash after phone language change




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-android pull request: [CB-7371] Fixed: app crash after pho...

Github user martincgg closed the pull request at:

https://github.com/apache/cordova-android/pull/115


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-android pull request: [CB-7371] Fixed: app crash after pho...

GitHub user martincgg opened a pull request:

https://github.com/apache/cordova-android/pull/115

[CB-7371] Fixed: app crash after phone language change

The main reason of this behavior is the config.xml, origin="*" tag, 
specifies access to all kind of resources on the network and makes the 
whiteList object on the WhiteList class a null object, indicating that when 
origin="*", there's no whiteList, all is allowed.

When it tries to resume the application it checks:
if (url.startsWith("file://") || url.startsWith("javascript:") || 
whitelist.isUrlWhiteListed(url))
This condition passes and triggers the load for 'about:blank'
The condition passes because, whitelist.isUrlWhiteListed(url) statement 
returns true.
 When the origin="*" is processed by the WhiteList class, it sets a null to 
the whiteList object, which it should contain the access to resources allowed, 
however when whitelist.isUrlWhiteListed(url) it returns a true if the whiteList 
object is null, therefore the condition passes and continues to the loadurl 
method on webClient, stopping the application, because of the 'about:blank' url.

Adding another condition along with that statement for when whiteList = 
null, but url= about:blank, in that way it won't be able to load the url.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/martincgg/cordova-android master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-android/pull/115.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #115


commit f9c23ec8711719db86843e944e7749e758b2a3f4
Author: Martin Gonzalez 
Date:   2014-08-22T18:09:42Z

CB-7371 Fixed: app crash after phone language change




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-wp8 pull request: [CB-7338]Remove unwanted slashes in URL,...

2014-08-19 Thread martincgg

GitHub user martincgg opened a pull request:

https://github.com/apache/cordova-wp8/pull/50

[CB-7338]Remove unwanted slashes in URL, and handle Exceptions when a 
resource is not found

The URL result of a XHR request, at times contains some unwanted extra 
slashes, like: 'x-wmapp0: /www or //www'. that URL starting with those slashes, 
is not well processed by the URI class, so it's required remove them when the 
'basePath' is obtained.
Added, regExp to the js script code to remove any >  ':/, ://, :///' , 
any slash after 'x-wmapp0:', in that way the URI class it will be successfully 
resolved and provide the file requested.
Removing unwanted slashes after x-wmapp0 from the basePath, URI cannot 
process x-wmapp0: /www or //www.

Also added two try-catch statements, over the 'Browser.InvokeScript' 
statements, if those are not present it throws: 'A first chance exception of 
type 'System.OutOfMemoryException' occurred in Microsoft.Phone.Interop.ni.dll', 
stopping the application.
The try-catch statement it would throw this trace when a requested resource 
is not available, found or not well resolved by the URI class:

ERROR: Exception in HandleCommand: System.OutOfMemoryException: 
Insufficient memory to continue the execution of the program.
   at Microsoft.Phone.Controls.NativeMethods.ValidateHResult(Int32 hr)
   at Microsoft.Phone.Controls.WebBrowserInterop.InvokeScript(String 
scriptName, String[] args)
   at Microsoft.Phone.Controls.WebBrowser.InvokeScript(String scriptName, 
String[] args)
   at WPCordovaClassLib.CordovaLib.XHRHelper.HandleCommand(String 
commandStr)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/martincgg/cordova-wp8 CB-7338

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-wp8/pull/50.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #50


commit 8829719bbbca1e92670f4576f7baa5e6e4701b9a
Author: Martin Gonzalez 
Date:   2014-08-19T18:15:43Z

Remove unwanted slashes and handle Exceptions




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-mobile-spec pull request: CB-7008 changed duplicated spec ...

Github user martincgg commented on the pull request:

https://github.com/apache/cordova-mobile-spec/pull/74#issuecomment-51419478
  
no longer valid, closing


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-mobile-spec pull request: CB-7009 (WP8) use proper path if...

Github user martincgg closed the pull request at:

https://github.com/apache/cordova-mobile-spec/pull/75


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-mobile-spec pull request: CB-7242 Added wp8 subdirectory t...

Github user martincgg commented on the pull request:

https://github.com/apache/cordova-mobile-spec/pull/84#issuecomment-51419510
  
This one is valid, currently createmobilespec module doesn't support wp8, 
if this small change is not added.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-mobile-spec pull request: CB-7008 changed duplicated spec ...

Github user martincgg closed the pull request at:

https://github.com/apache/cordova-mobile-spec/pull/74


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-mobile-spec pull request: CB-7009 (WP8) use proper path if...

Github user martincgg commented on the pull request:

https://github.com/apache/cordova-mobile-spec/pull/75#issuecomment-51419471
  
no longer valid, closing


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-mobile-spec pull request: CB-7010 (WP8) compare proper str...

Github user martincgg commented on the pull request:

https://github.com/apache/cordova-mobile-spec/pull/76#issuecomment-51419463
  
no longer valid, closing


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-mobile-spec pull request: CB-7011 (WP8) proper file name i...

Github user martincgg closed the pull request at:

https://github.com/apache/cordova-mobile-spec/pull/77


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-mobile-spec pull request: CB-7010 (WP8) compare proper str...

Github user martincgg closed the pull request at:

https://github.com/apache/cordova-mobile-spec/pull/76


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-mobile-spec pull request: CB-7011 (WP8) proper file name i...

Github user martincgg commented on the pull request:

https://github.com/apache/cordova-mobile-spec/pull/77#issuecomment-51419444
  
no longer valid, closing


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-mobile-spec pull request: CB-7012, WP8 it doesn't support ...

Github user martincgg closed the pull request at:

https://github.com/apache/cordova-mobile-spec/pull/78


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-mobile-spec pull request: CB-7012, WP8 it doesn't support ...

Github user martincgg commented on the pull request:

https://github.com/apache/cordova-mobile-spec/pull/78#issuecomment-51419409
  
no longer valid, closing


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-mobile-spec pull request: CB-7013 (WP8) use proper string ...

Github user martincgg commented on the pull request:

https://github.com/apache/cordova-mobile-spec/pull/79#issuecomment-51419364
  
Yeah, this was for the mobile spec tests, is not longer valid


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-mobile-spec pull request: CB-7013 (WP8) use proper string ...

Github user martincgg closed the pull request at:

https://github.com/apache/cordova-mobile-spec/pull/79


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-vibration pull request: CB-6966 Ported Vibration au...

Github user martincgg commented on the pull request:


https://github.com/apache/cordova-plugin-vibration/pull/19#issuecomment-50857537
  
https://github.com/apache/cordova-mobile-spec/pull/88


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-mobile-spec pull request: CB-6966 Removed old vibration te...

GitHub user martincgg opened a pull request:

https://github.com/apache/cordova-mobile-spec/pull/88

CB-6966 Removed old vibration tests



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/martincgg/cordova-mobile-spec CB-6966

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-mobile-spec/pull/88.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #88


commit d640abfb35f657ef72793048576e476dcdb8909c
Author: Martin Gonzalez 
Date:   2014-08-01T07:30:32Z

CB-6966 Removed old vibration tests




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-mobile-spec pull request: CB-6957 Removed old battery-stat...

GitHub user martincgg opened a pull request:

https://github.com/apache/cordova-mobile-spec/pull/87

CB-6957 Removed old battery-status tests



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/martincgg/cordova-mobile-spec CB-6957

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-mobile-spec/pull/87.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #87


commit df403a2144acd31f46cdfb6693f20b53707b51b0
Author: Martin Gonzalez 
Date:   2014-08-01T07:14:38Z

CB-6957 Removed battery-status tests




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-battery-status pull request: CB-6957 Style improvem...

Github user martincgg commented on the pull request:


https://github.com/apache/cordova-plugin-battery-status/pull/15#issuecomment-50857488
  
Removed old battery-status tests
https://github.com/apache/cordova-mobile-spec/pull/87


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-file pull request: CB-7094 Ported File manual tests

Github user martincgg commented on the pull request:

https://github.com/apache/cordova-plugin-file/pull/62#issuecomment-50857437
  
Removed old file tests
https://github.com/apache/cordova-mobile-spec/pull/86


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-mobile-spec pull request: CB-7094 Removed old file tests

GitHub user martincgg opened a pull request:

https://github.com/apache/cordova-mobile-spec/pull/86

CB-7094 Removed old file tests



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/martincgg/cordova-mobile-spec CB-7094

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-mobile-spec/pull/86.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #86


commit 3920e2044f0fbc4c9da09d2875626bb589c16d07
Author: Martin Gonzalez 
Date:   2014-08-01T07:17:26Z

CB-7094 Removed old file tests

commit 4866870e5f2f0428a0450cf6cff7b2e88800b2b2
Author: Martin Gonzalez 
Date:   2014-08-01T07:25:40Z

Removed remaining button on index.html




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-media pull request: CB-6963 Port Media manual & aut...

Github user martincgg commented on the pull request:

https://github.com/apache/cordova-plugin-media/pull/21#issuecomment-50857321
  
Removed old media tests:
https://github.com/apache/cordova-mobile-spec/pull/85


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-mobile-spec pull request: CB-6963 Removed old media tests

GitHub user martincgg opened a pull request:

https://github.com/apache/cordova-mobile-spec/pull/85

CB-6963 Removed old media tests



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/martincgg/cordova-mobile-spec CB-6963

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-mobile-spec/pull/85.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #85


commit 76e257085bdee5503817a10b75adbc0b375542f9
Author: Martin Gonzalez 
Date:   2014-08-01T07:24:33Z

CB-6963 Removed old media tests




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-battery-status pull request: CB-6957 Style improvem...

GitHub user martincgg opened a pull request:

https://github.com/apache/cordova-plugin-battery-status/pull/15

CB-6957 Style improvements on Manual tests

Usage of info, which is wired a css class, aimed to only show results.
Reorganization of titles and tables.
Just organization of labes, and html elements.
Requires the changes on this PR:
apache/cordova-plugin-test-framework#3

To get a better look.

Also, renamed folder to tests + added nested plugin.xml

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/martincgg/cordova-plugin-battery-status 
CB-6957

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-battery-status/pull/15.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #15


commit f6079cdb6a718ba03a6a5246a5fd0cd423dd2378
Author: Martin Gonzalez 
Date:   2014-07-17T21:27:57Z

CB-6957 Style improvements on Manual tests

Usage of info, which is wired a css class, aimed to only show results.
Reorganization of titles and tables.
Just organization of labes, and html elements.
Requires the changes on this PR:
https://github.com/apache/cordova-plugin-test-framework/pull/3

To get a better look.

commit f01bb645668133ee100e3275a8c933fb5fad1723
Author: Martin Gonzalez 
Date:   2014-08-01T06:36:36Z

CB-6957 renamed folder to tests + added nested plugin.xml




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-vibration pull request: CB-6966 Ported Vibration au...

GitHub user martincgg opened a pull request:

https://github.com/apache/cordova-plugin-vibration/pull/19

CB-6966 Ported Vibration automated & manual tests

Ported tests from Mobilespec.
Jasmine version: ported from v1.3 to v2.0

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/martincgg/cordova-plugin-vibration CB-6966

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-vibration/pull/19.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #19


commit 6c21d194f7caff17d8043065d685bc12577e4654
Author: Martin Gonzalez 
Date:   2014-07-17T21:47:01Z

CB-6966 Ported Vibration automated & manual tests

Ported tests from Mobilespec.
Jasmine version: ported from v1.3 to v2.0

commit 6bb38e581ed60c72cff7adaa17e9e3945d3e8221
Author: Martin Gonzalez 
Date:   2014-08-01T06:09:54Z

CB-6966 renamed folder to tests + added nested plugin.xml




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-mobile-spec pull request: CB-7242 Added wp8 subdirectory t...

2014-07-31 Thread martincgg

GitHub user martincgg opened a pull request:

https://github.com/apache/cordova-mobile-spec/pull/84

CB-7242 Added wp8 subdirectory to localPlatforms variable

createmobilespec --wp8 fails, because the path for wp8 on localPlatforms
is incomplete, it requires the wp8 subdirectory to work properly.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/martincgg/cordova-mobile-spec CB-7242

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-mobile-spec/pull/84.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #84


commit 5bba7a0fdc40d1a4f5595325a25d3314c5749ba7
Author: Martin Gonzalez 
Date:   2014-07-31T20:58:03Z

CB-7242 Added wp8 subdirectory to localPlatforms variable

createmobilespec --wp8 fails, because the path for wp8 on localPlatforms
is incomplete, it requires the wp8 subdirectory to work properly.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-vibration pull request: CB-6966 Ported Vibration au...

2014-07-24 Thread martincgg

Github user martincgg closed the pull request at:

https://github.com/apache/cordova-plugin-vibration/pull/15


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-vibration pull request: CB-6966 Ported Vibration au...

2014-07-24 Thread martincgg

Github user martincgg commented on the pull request:


https://github.com/apache/cordova-plugin-vibration/pull/15#issuecomment-50022161
  
This PR:https://github.com/apache/cordova-plugin-vibration/pull/17
Involves this commit.
Closing pr.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-file pull request: CB-6923 [WP8] Adding support to ...

2014-07-23 Thread martincgg

Github user martincgg commented on the pull request:

https://github.com/apache/cordova-plugin-file/pull/65#issuecomment-49847041
  
Given some of the variations on valid paths for Windows Phone, when a 
single '/' , '/dir//someDir and '///someDir' are valid paths, however a 
'/someDir' is not.
However when the native side always returns a fileEntry as '//someDir or 
//someFile.ext, the double slash at the beginning it makes difficult to make a 
combination to get the full path and resolve a relative path(Path.GetFullPath), 
ignoring completely the two points in the path('..'), when more than one slash 
is present at the beginning of the string parent path.
The RemoveExtraSlash, is a recursive function that removes the extra 
slashes from the beginning of the parent path, returning a proper path in order 
to be combined and resolved to an absolute path.

The Path.GetFullPath it always returns a full path with a drive letter, 
which it will be replaced by the double slash to make it a valid path.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-file pull request: CB-6923 [WP8] Adding support to ...

2014-07-22 Thread martincgg

GitHub user martincgg opened a pull request:

https://github.com/apache/cordova-plugin-file/pull/65

CB-6923 [WP8] Adding support to handle relative paths

Added support to resolve relative paths on Windows Phone 8

When the path received is relative, it will combine and obtain a full path 
before it becomes processed by IsolatedStorageFile and determine if exists.

Two private methods were added to handle this, it won't affect the regular 
workflow if the path is absolute and it will combine them as usual.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/martincgg/cordova-plugin-file CB-6923

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-file/pull/65.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #65


commit 4152181c99251360eeddd8ec54795e4b8874d48e
Author: Martin Gonzalez 
Date:   2014-07-22T20:09:20Z

CB-6923 Adding support to handle relative paths

Added support to resolve relative paths.
When the path received is relative, it will combine and obtain a full
path before it becomes proceced by IsolatedStorageFile and determine if
exists.

Two private methods were added to handle this, it won't affect the
regular workflow if the path is absolute and it will combine it as
usual.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-media pull request: CB-6963 Port Media manual & aut...

2014-07-18 Thread martincgg

GitHub user martincgg opened a pull request:

https://github.com/apache/cordova-plugin-media/pull/21

CB-6963 Port Media manual & automated tests for plugin-test-framework

Ported 17 Media automated & manual tests from mobilespec.

This commit adds the work done by javierbb31

Jasmine version: ported from v1.3 to v2.0

Features(automated tests):
-No spies.
-Tests failing faster, when a error callback or unexpected success
callback is received, the test fails immediately.
-Jasmine report with more information about the failed operation, which
contains the operation and a description about it.
-Jasmine reports include error callback object.
-Two timeout statement to just wait until the a media file is
reproduced, there are no more timeouts than those.
-Added a control variable to ensure that a callback is reached only
once.

Bugs:
There are two bugs reported as direct result of this porting activity.

CB-7092:

https://github.com/martincgg/cordova-plugin-media/blob/9fab60a8a3de2b68cb96fdcdd36cbdbfff73ce8e/test/tests.js#L158

This one it's about a conditional added in case that the platform is
windows phone, on that platform it has an unexpected behavior at the
error callback. If the platform is windows phone the test is going to
fail, until the bug is fixed, this specific problem causes a mess with
the rest of the test.
All details related to this:
https://issues.apache.org/jira/browse/CB-7092

CB-7099:

https://github.com/martincgg/cordova-plugin-media/blob/9fab60a8a3de2b68cb96fdcdd36cbdbfff73ce8e/test/tests.js#L188


https://github.com/martincgg/cordova-plugin-media/blob/9fab60a8a3de2b68cb96fdcdd36cbdbfff73ce8e/test/tests.js#L215

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/martincgg/cordova-plugin-media CB-6963

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-media/pull/21.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #21


commit fda53f588b7e2ccefabaabc691abdec5f660ee53
Author: javierbb31 
Date:   2014-07-18T19:34:08Z

CB-6963. Port media tests to plugin-test-framework

Ported media test form mobilespec to the new test-framework in jasmine
2.0
Added test folder
Added tests.js file inside the test folder.

commit 3317891cc7e2071a6e0ab81f223e2a9210ebb66f
Author: Martin Gonzalez 
Date:   2014-07-18T21:51:58Z

CB-6963 Port Media manual & automated tests

Ported 17 Media automated & manual tests from mobilespec.

This commit adds the work done by javierbb31

Jasmine version: ported from v1.3 to v2.0

Features(automated tests):
-No spies.
-Tests failing faster, when a error callback or unexpected success
callback is received, the test fails immediately.
-Jasmine report with more information about the failed operation, which
contains the operation and a description about it.
-Jasmine reports include error callback object.
-Two timeout statement to just wait until the a media file is
reproduced, there are no more timeouts than those.
-Added a control variable to ensure that a callback is reached only
once.

Bugs:
There are two bugs reported as direct result of this porting activity.

CB-7092

    
https://github.com/martincgg/cordova-plugin-media/blob/9fab60a8a3de2b68cb96fdcdd36cbdbfff73ce8e/test/tests.js#L158

This one it's about a conditional added in case that the platform is
windows phone, on that platform it has an unexpected behavior at the
error callback. If the platform is windows phone the test is going to
fail, until the bug is fixed, this specific problem causes a mess with
the rest of the test.
All details related to this:
https://issues.apache.org/jira/browse/CB-7092

CB-7099
    

https://github.com/martincgg/cordova-plugin-media/blob/9fab60a8a3de2b68cb96fdcdd36cbdbfff73ce8e/test/tests.js#L188
    

https://github.com/martincgg/cordova-plugin-media/blob/9fab60a8a3de2b68cb96fdcdd36cbdbfff73ce8e/test/tests.js#L215




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-vibration pull request: CB-6966 Ported Vibration au...

GitHub user martincgg opened a pull request:

https://github.com/apache/cordova-plugin-vibration/pull/15

CB-6966 Ported Vibration automated & manual tests

Ported tests from Mobilespec.
Jasmine version: ported from v1.3 to v2.0


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/martincgg/cordova-plugin-vibration CB-6966

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-vibration/pull/15.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #15


commit 6c21d194f7caff17d8043065d685bc12577e4654
Author: Martin Gonzalez 
Date:   2014-07-17T21:47:01Z

CB-6966 Ported Vibration automated & manual tests

Ported tests from Mobilespec.
Jasmine version: ported from v1.3 to v2.0




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-vibration pull request: CB-6963 Ported Vibration au...

Github user martincgg closed the pull request at:

https://github.com/apache/cordova-plugin-vibration/pull/14


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-file pull request: CB-7094 Ported File manual tests

Github user martincgg commented on the pull request:

https://github.com/apache/cordova-plugin-file/pull/62#issuecomment-49370393
  
Screenshot:

![filescreenshot](https://cloud.githubusercontent.com/assets/6596402/3620009/b8dc513a-0dfa-11e4-8fc3-6bdbd1f80b4b.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-file pull request: CB-7094 Ported File manual tests

GitHub user martincgg reopened a pull request:

https://github.com/apache/cordova-plugin-file/pull/62

CB-7094 Ported File manual tests

Only contains file manual tests for android and iOS.
Both tested and validated.
All outputs and results to log content.

createActionButton it depends of this PR:
https://github.com/apache/cordova-plugin-test-framework/pull/1

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/martincgg/cordova-plugin-file CB-7094

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-file/pull/62.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #62


commit 21b568f3a25d5a10f231fbf5989ca07242da6e81
Author: Martin Gonzalez 
Date:   2014-07-16T12:52:40Z

CB-7094 Ported File manual tests

Only contains file manual tests for android and iOS.
Both tested and validated.
All outputs and results to log content.

createActionButton it depends of this PR:
https://github.com/apache/cordova-plugin-test-framework/pull/1

commit 83041f438b9f58c5ee3c53496a2e0a41a7bf80ff
Author: Martin Gonzalez 
Date:   2014-07-17T21:35:39Z

Style improvements on Manual tests

Usage of info, which is wired a css class, aimed to only show results.
Reorganization of titles and tables.
Just organization of labes, and html elements.
Removed comment from automated tests.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-battery-status pull request: CB-6957 Style improvem...

GitHub user martincgg opened a pull request:

https://github.com/apache/cordova-plugin-battery-status/pull/14

CB-6957 Style improvements on Manual tests

Usage of info, which is wired a css class, aimed to only show results.
Reorganization of titles and tables.
Just organization of labes, and html elements.
Requires the changes on this PR:
https://github.com/apache/cordova-plugin-test-framework/pull/3

To get a better look.


![battery-status](https://cloud.githubusercontent.com/assets/6596402/3619908/bf064ff8-0df9-11e4-9ed9-cf4c35109e09.png)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/martincgg/cordova-plugin-battery-status master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-battery-status/pull/14.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #14


commit f6079cdb6a718ba03a6a5246a5fd0cd423dd2378
Author: Martin Gonzalez 
Date:   2014-07-17T21:27:57Z

CB-6957 Style improvements on Manual tests

Usage of info, which is wired a css class, aimed to only show results.
Reorganization of titles and tables.
Just organization of labes, and html elements.
Requires the changes on this PR:
https://github.com/apache/cordova-plugin-test-framework/pull/3

To get a better look.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-vibration pull request: CB-6963 Ported Vibration au...

GitHub user martincgg reopened a pull request:

https://github.com/apache/cordova-plugin-vibration/pull/14

CB-6963 Ported Vibration automated & manual tests

Ported tests from Mobilespec.
Jasmine version: ported from v1.3 to v2.0

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/martincgg/cordova-plugin-vibration CB-6963

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-vibration/pull/14.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #14


commit 53760ccbf19964d20e9a6693cb1f52050f2c5391
Author: Martin Gonzalez 
Date:   2014-07-15T20:33:20Z

CB-6963, ported vibration automated & manual tests

Ported tests from mobilespec.

Jasmine version: ported from v1.3 to v2.0

commit d19f7539b2add88db649aa1f4fdbe5b032029f3f
Author: Martin Gonzalez 
Date:   2014-07-15T22:41:54Z

Adding comment




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-file pull request: CB-7094 Ported File manual tests

Github user martincgg closed the pull request at:

https://github.com/apache/cordova-plugin-file/pull/62


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-vibration pull request: CB-6963 Ported Vibration au...

Github user martincgg closed the pull request at:

https://github.com/apache/cordova-plugin-vibration/pull/14


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-media pull request: CB-6963 Port Media automated te...

Github user martincgg closed the pull request at:

https://github.com/apache/cordova-plugin-media/pull/20


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-battery-status pull request: CB-6957 Ported Battery...

2014-07-16 Thread martincgg

GitHub user martincgg opened a pull request:

https://github.com/apache/cordova-plugin-battery-status/pull/13

CB-6957 Ported Battery-status manual & automated tests

Ported tests from Mobilespec.
Jasmine version: ported from v1.3 to v2.0

Features:
-No spies.
-Tests failing faster, when a error callback or unexpected success
callback is received, the test fails immediately.
-Jasmine report with more information about the failed operation, which
contains the operation and a description about it.
-Short timeouts for listeners and event listeners.
-Ported manual tests.

Tested and validated over device.

createActionButton it depends of this PR:
https://github.com/apache/cordova-plugin-test-framework/pull/1

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/martincgg/cordova-plugin-battery-status 
CB-6957

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-battery-status/pull/13.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #13


commit 8ff34324139ed68e64a927e21086beb424da4cb7
Author: Martin Gonzalez 
Date:   2014-07-16T13:11:10Z

CB-6957 Ported Battery-status manual & automated

Ported tests from Mobilespec.
Jasmine version: ported from v1.3 to v2.0

Features:
-No spies.
-Tests failing faster, when a error callback or unexpected success
callback is received, the test fails immediately.
-Jasmine report with more information about the failed operation, which
contains the operation and a description about it.
-Short timeouts for listeners and event listeners.
-Ported manual tests.

Tested and validated over device.

createActionButton it depends of this PR:
https://github.com/apache/cordova-plugin-test-framework/pull/1




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-vibration pull request: CB-6963 Ported Vibration au...

2014-07-16 Thread martincgg

GitHub user martincgg opened a pull request:

https://github.com/apache/cordova-plugin-vibration/pull/14

CB-6963 Ported Vibration automated & manual tests

Ported tests from Mobilespec.
Jasmine version: ported from v1.3 to v2.0

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/martincgg/cordova-plugin-vibration CB-6963

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-vibration/pull/14.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #14


commit 53760ccbf19964d20e9a6693cb1f52050f2c5391
Author: Martin Gonzalez 
Date:   2014-07-15T20:33:20Z

CB-6963, ported vibration automated & manual tests

Ported tests from mobilespec.

Jasmine version: ported from v1.3 to v2.0

commit d19f7539b2add88db649aa1f4fdbe5b032029f3f
Author: Martin Gonzalez 
Date:   2014-07-15T22:41:54Z

Adding comment




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-file pull request: CB-7094 Ported File manual tests

2014-07-16 Thread martincgg

GitHub user martincgg opened a pull request:

https://github.com/apache/cordova-plugin-file/pull/62

CB-7094 Ported File manual tests

Only contains file manual tests for android and iOS.
Both tested and validated.
All outputs and results to log content.

createActionButton it depends of this PR:
https://github.com/apache/cordova-plugin-test-framework/pull/1

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/martincgg/cordova-plugin-file CB-7094

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-file/pull/62.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #62


commit 21b568f3a25d5a10f231fbf5989ca07242da6e81
Author: Martin Gonzalez 
Date:   2014-07-16T12:52:40Z

CB-7094 Ported File manual tests

Only contains file manual tests for android and iOS.
Both tested and validated.
All outputs and results to log content.

createActionButton it depends of this PR:
https://github.com/apache/cordova-plugin-test-framework/pull/1




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-file pull request: CB-7093 Ported automated File te...

2014-07-14 Thread martincgg

Github user martincgg commented on the pull request:

https://github.com/apache/cordova-plugin-file/pull/60#issuecomment-48954105

The last commit on which is based is after this one:
https://git-wip-us.apache.org/repos/asf?p=cordova-mobile-spec.git;a=commit;h=005641907754e04895135e502ef9fcb6f24d353f

Made on 2014-06-23 by Martin Bektchiev- Fix failing battery tests. Add a
dummy battery listener
There's no file tests after that commit.
Based on some fixes that I've sent to mobile-spec.
https://github.com/apache/cordova-mobile-spec/pull/79
https://github.com/apache/cordova-mobile-spec/pull/75

By the way, your changes were good, I tried to remove most of the comments
and old content, some of them escaped from my sight, also it makes perfect
sense use URL instead of URI since is deprecated.

Ian, about the change that you made on plugin.xml, I think Andrew Grieve
point out that those changes would be made by adding some improvements to the
CLI, and avoid include tests in the release version of the plugin.
Check this comment on this PR.
https://github.com/apache/cordova-plugin-media-capture/pull/19

Thanks for taking this on, I'll be delivering the manual tests shortly.
Thanks @clelland

---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-media pull request: CB-6963 Port Media automated te...

2014-07-08 Thread martincgg

GitHub user martincgg opened a pull request:

https://github.com/apache/cordova-plugin-media/pull/20

CB-6963 Port Media automated tests for cordova-plugin-test-framework

Ported 17 Media automated tests from mobilespec.

Jasmine version: ported from v1.3 to v2.0

Features:
-No spies.
-Tests failing faster, when a error callback or unexpected success callback 
is received, the test fails immediately.
-Jasmine report with more information about the failed operation, which 
contains the operation and a description about it.
-Jasmine reports include error callback object.
-Two timeout statement to just wait until the a media file is reproduced, 
there are no more timeouts than those.
-Added a control variable to ensure that a callback is reached only once.

Bugs:
There are two bugs reported as direct result of this porting activity.

CB-7092

https://github.com/martincgg/cordova-plugin-media/blob/9fab60a8a3de2b68cb96fdcdd36cbdbfff73ce8e/test/tests.js#L158

This one it's about a conditional added in case that the platform is 
windows phone, on that platform it has an unexpected behavior at the error 
callback. If the platform is windows phone the test is going to fail, until the 
bug is fixed, this specific problem causes a mess with the rest of the test.
All details related to this: https://issues.apache.org/jira/browse/CB-7092

CB-7099

https://github.com/martincgg/cordova-plugin-media/blob/9fab60a8a3de2b68cb96fdcdd36cbdbfff73ce8e/test/tests.js#L188


https://github.com/martincgg/cordova-plugin-media/blob/9fab60a8a3de2b68cb96fdcdd36cbdbfff73ce8e/test/tests.js#L215

A variable it was added to ensure an extra security statement, the callback 
it  will be processed only once,in case that for some reason the statusChange 
callback is reached more than one time with the same status code.
This kind of behavior it can be triggered by several variables, such as 
another media file been played, a busy resource and network connection(Online 
media resource).
An specific bug was reported for an specific behavior over Windows Phone 
related with this behavior. More information and details:
 https://issues.apache.org/jira/browse/CB-7099

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/martincgg/cordova-plugin-media CB-6963

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-media/pull/20.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #20


commit 9fab60a8a3de2b68cb96fdcdd36cbdbfff73ce8e
Author: Martin Gonzalez 
Date:   2014-07-08T22:32:05Z

CB-6963 Port Media automated tests

Ported 17 Media automated tests from mobilespec.

Jasmine version: ported from v1.3 to v2.0

Features:
-No spies.
-Tests failing faster, when a error callback or unexpected success
callback is received, the test fails immediately.
-Jasmine report with more information about the failed operation, which
contains the operation and a description about it.
-Jasmine reports include error callback object.
-Two timeout statement to just wait until the a media file is
reproduced, there are no more timeouts than those.
Added a control flag variable to ensure that a callback is reached only
once.

Bugs:
There are two bugs reported as direct result of this porting activity.

CB-7092
CB-7099




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-file pull request: CB-7093 Ported automated File te...

2014-07-08 Thread martincgg

GitHub user martincgg opened a pull request:

https://github.com/apache/cordova-plugin-file/pull/60

CB-7093 Ported automated File tests for cordova-plugin-test-framework

Ported 131 File automated tests from mobilespec.

Jasmine version: ported from v1.3 to v2.0

Features:
-No spies.
-No timeouts.
-Tests failing faster, when a error callback or unexpected success callback 
is received, the test fails immediately.
-Jasmine report with more information about the failed operation, which 
contains the operation and a description about it.
-Jasmine reports include error callback object.
-Code reduced and simplified.

Bugs:
Found problem described in the code at:

https://github.com/martincgg/cordova-plugin-file/blob/dcc34b628c9896084b886747308171e63f684270/test/tests.js#L2057


https://github.com/martincgg/cordova-plugin-file/blob/dcc34b628c9896084b886747308171e63f684270/test/tests.js#L2110

Issue related (file spec 85 & 92): CB-7095

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/martincgg/cordova-plugin-file CB-7093

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-file/pull/60.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #60


commit dcc34b628c9896084b886747308171e63f684270
Author: Martin Gonzalez 
Date:   2014-07-08T22:05:38Z

CB-7093 Ported automated file tests

Ported File plugin automated tests from mobilespec,
Jasmine version: ported from 1.3 to 2.0
Features:
-No spies.
-No timeouts.
-Tests fails faster, when a error callback or unexpected callback is
received the test fails imediately.
-Jasmine report with more information about the failed operation, which
contains the operation and a description about it.
-Jasmine reports include error callback object.
-Code reduced and simplified.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-file pull request: CB-6571 Fix getParentForLocalURL...

2014-06-30 Thread martincgg

Github user martincgg commented on the pull request:

https://github.com/apache/cordova-plugin-file/pull/58#issuecomment-47558500
  
Ok, good.
I have the latest test failing, spec 129, it is failing for you as well?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-file pull request: CB-6571 Fix getParentForLocalURL...

2014-06-30 Thread martincgg

Github user martincgg commented on the pull request:

https://github.com/apache/cordova-plugin-file/pull/58#issuecomment-47549670
  
It fixes file.spec.49, that was the only that I had failing, which other 
was failing @mbektchiev ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-file pull request: CB-6571 Fix getParentForLocalURL...

2014-06-30 Thread martincgg

Github user martincgg commented on the pull request:

https://github.com/apache/cordova-plugin-file/pull/58#issuecomment-47548810
  
Which unit tests are failing?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-mobile-spec pull request: CB-7010 (WP8) compare proper str...

Github user martincgg commented on the pull request:

https://github.com/apache/cordova-mobile-spec/pull/76#issuecomment-47003313
  
It's possible of course, call the decodeURIComponent in the test, I can get 
it done.
Now in WP8 native side, it's possible add logic to:
public FileEntry(string filePath, bool bIsRes=false) {}
to return a entry file with the URI encoded, using the 
Uri.EscapeUriString/Uri.EscapeDataString, this will force the user to decode 
the path in the web side.
Also we can use the Uri.UnescapedDataString to decode the paths in the 
native side.
Any suggestions?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-mobile-spec pull request: CB-7010 (WP8) compare proper str...

Github user martincgg commented on the pull request:

https://github.com/apache/cordova-mobile-spec/pull/76#issuecomment-46960316
  
Hi @purplecabbage ,
I've been working on the File API and the mobile spec test as well, this 
specific PR, the native side is not returning the path with the URL-encoding as 
%20, I thought that it was totally acceptable if spaces were returned instead.
Let me report some of my findings:

![file api 
mobilespec](https://cloud.githubusercontent.com/assets/6596402/3370432/4d0b80a6-fb90-11e3-8bcb-6cd3bda912c9.png)

In the image at left is mostly after this fix: 
https://issues.apache.org/jira/browse/CB-6980
in the right that was before of it. Several were failing because 
resolveLocalFileSystemURI it was losing information about the filesystem 
property.
The first square marked on the image it belongs to 4 tests (spec 67, 68, 69 
and 78) which are failing when a file is moved and the filesystem information 
is lost at some point, the issue related is CB-6901.
The second square is related with support of readAsBinaryString & 
readAsArrayBuffer, issues CB-6988 & CB-6989, I've been working to setup those 
methods on the native side.
The third square is related with the issue CB-6923 (I'm working on that one 
too), the native side is not able to handle the resolve navigation a parent 
directory using a relative path, e.g.:
fileName = ../resolve.file.uri
I'll continue working on those issues
About the mobile spec conditions some of them are about join paths for 
Windows Phone and some others are to compare the path retrieved from the native 
side something like: //native instead of file://.
Tests on Windows Phone 8 & 8.1 emulator as well as physical device, both 
are consistent behavior related with the mentioned issues.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-mobile-spec pull request: CB-7013 (WP8) use proper string ...

GitHub user martincgg opened a pull request:

https://github.com/apache/cordova-mobile-spec/pull/79

CB-7013 (WP8) use proper string to compare

if the platform is windows phone, it will use a proper string to compare 
(//nativ) instead of the default 'file://' that it won't match with the 
platform.
This solves the problem for file.spec.114 and file.spec.115.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/martincgg/cordova-mobile-spec CB-7013

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-mobile-spec/pull/79.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #79


commit 34072f2d2f4b98f1e84973dbe387d0788d524ae9
Author: Martin Gonzalez 
Date:   2014-06-24T10:17:33Z

CB-7013 (WP8) use proper string to compare

if the platform is windows phone, it will use a proper string to compare
(//nativ) instead of the default 'file://' that it won't match with the
platform.
This solves the problem for file.spec.114 and file.spec.115.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-mobile-spec pull request: CB-7012, WP8 it doesn't support ...

GitHub user martincgg opened a pull request:

https://github.com/apache/cordova-mobile-spec/pull/78

CB-7012, WP8 it doesn't support write binary

If the platform is windowsphone it will skip the test, windows phone it 
doesn't support write binary data from a file at the moment.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/martincgg/cordova-mobile-spec CB-7012

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-mobile-spec/pull/78.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #78


commit 27c42eee8747ad138d235cca6aaee2a28556483f
Author: Martin Gonzalez 
Date:   2014-06-24T10:14:14Z

CB-7012, WP8 it doesn't support write binary

If the platform is windowsphone it will skip the test, windows phone it
doesn't support write binary data from a file at the moment.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-mobile-spec pull request: CB-7011 (WP8) proper file name i...

GitHub user martincgg opened a pull request:

https://github.com/apache/cordova-mobile-spec/pull/77

CB-7011 (WP8) proper file name if windowsphone

in case of platformId === 'windowsphone' it will use a proper path to 
determine if the file exists or not, instead of just thow a ENCODING_ERR error 
code.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/martincgg/cordova-mobile-spec CB-7011

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-mobile-spec/pull/77.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #77


commit 0364c92f193268823dec293e36dae6ad4b20cc57
Author: Martin Gonzalez 
Date:   2014-06-24T10:07:33Z

CB-7011 (WP8) proper file name if windowsphone

in case of platformId === 'windowsphone' it will use a proper path to
determine if exists or not, instead of just thow a ENCODING_ERR error
code.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-mobile-spec pull request: CB-7010 (WP8) compare proper str...

GitHub user martincgg opened a pull request:

https://github.com/apache/cordova-mobile-spec/pull/76

CB-7010 (WP8) compare proper string for path

In case of platformId === 'windowsphone', compare with proper string('//num 
1/num 2'),
the test fails because WP8 platform it doesn't recognize
/num%201/num%202/.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/martincgg/cordova-mobile-spec CB-7010

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-mobile-spec/pull/76.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #76


commit b58ecf493c38a373adb70c05f685efc5b335ca99
Author: Martin Gonzalez 
Date:   2014-06-24T10:03:02Z

CB-7010 (WP8) compare proper string for path

In case of platformId === 'windowsphone', compare with proper string,
the test fails because WP8 platform it doesn't recognize
/num%201/num%202/.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-mobile-spec pull request: CB-7009 (WP8) use proper path if...

GitHub user martincgg opened a pull request:

https://github.com/apache/cordova-mobile-spec/pull/75

CB-7009 (WP8) use proper path if windowsphone

Use a proper filepath to determine if the file exists or not, instead of 
just throw a ENCODING_ERR error code.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/martincgg/cordova-mobile-spec CB-7009

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-mobile-spec/pull/75.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #75


commit b88d103fdc49c00b561f6cb77246be0a91de53c7
Author: Martin Gonzalez 
Date:   2014-06-24T10:00:18Z

CB-7009 (WP8) use proper path if windowsphone

Use a proper filename to determine if exists or not, instead of just
throw a ENCODING_ERR error code.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-mobile-spec pull request: CB-7008 changed duplicated spec ...

GitHub user martincgg opened a pull request:

https://github.com/apache/cordova-mobile-spec/pull/74

CB-7008 changed duplicated spec name



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/martincgg/cordova-mobile-spec CB-7008

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-mobile-spec/pull/74.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #74


commit d594675600240510b7586ce566e884ca058b2712
Author: Martin Gonzalez 
Date:   2014-06-24T09:54:26Z

CB-7008 changed duplicated spec name




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-file pull request: CB-6980 Fixing filesystem:null p...

2014-06-19 Thread martincgg

Github user martincgg commented on the pull request:

https://github.com/apache/cordova-plugin-file/pull/53#issuecomment-46649607
  
Good to know that it was useful @mhujer 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-file pull request: CB-6980 Fixing filesystem:null p...

2014-06-19 Thread martincgg

GitHub user martincgg opened a pull request:

https://github.com/apache/cordova-plugin-file/pull/53

CB-6980 Fixing filesystem:null property in Entry

when resolveLocalFileSystemURI or resolveLocalFileSystemURL is called on
the File Plugin under Windows Phone 8, on success it should return a
Entry with several properties, as it is the filesystem information,
which returns as null.
on resolveLocalFileSystemURI.js it calls fileSystem.getFS the object
retrieved it should contain the filesystem information.
Since the fix, CB-6525, only adds support for Android and iOS, for other
platform it retrieves a null object, so adding a condition to retrieve
the information if the object from the callback is null.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/martincgg/cordova-plugin-file CB-6980

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-file/pull/53.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #53


commit 4f455ac3efe64caede6cbaff9d7c638caf6e5392
Author: Martin Gonzalez 
Date:   2014-06-19T15:38:20Z

CB-6980 Fixing filesystem:null property in Entry

when resolveLocalFileSystemURI or resolveLocalFileSystemURL is called on
the File Plugin under Windows Phone 8, on success it should return a
Entry with several properties, as it is the filesystem information,
which returns as null.
on resolveLocalFileSystemURI.js it calls fileSystem.getFS the object
retrieved it should contain the filesystem information.
Since the fix, CB-6525, only adds support for Android and iOS, for other
platform it retrieves a null object, so adding a condition to retrieve
the information if the object from the callback is null.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-lib pull request: CB-5082 [cordova info] Add support for B...

Github user martincgg commented on the pull request:

https://github.com/apache/cordova-lib/pull/7#issuecomment-45021216
  
Hi @jsoref , here is the PR: https://github.com/apache/cordova-lib/pull/7 
with a single commit: 
https://github.com/martincgg/cordova-lib/commit/f964956b9c90db36325fb6acfe36e619463367e9.
If you can merged this in, it would be great.
Thanks. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-lib pull request: CB-5082 [cordova info] Add support for B...

Github user martincgg commented on the pull request:

https://github.com/apache/cordova-lib/pull/7#issuecomment-44997019
  
@jsoref  Clean commit as requested.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-lib pull request: CB-5082 [cordova info] Add support for B...

Github user martincgg commented on the pull request:

https://github.com/apache/cordova-lib/pull/7#issuecomment-44980697
  
Some changes:

- Added targetUtils variable
- Removed unrelated changes
- Removed unrelated whitespaces
-Added some comments
-Changed Blackberry for BlackBerry


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-lib pull request: CB-5082 [cordova info] Add support for B...

Github user martincgg commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/7#discussion_r13337982
  
--- Diff: cordova-lib/src/cordova/info.js ---
@@ -31,23 +31,50 @@ var cordova_util = require('./util'),
 
 // Execute using a child_process exec, for any async command
 function execSpawn(command, args, resultMsg, errorMsg) {
-return superspawn.spawn(command, args).then(function(result) {
+return superspawn.spawn(command, args).then(function (result) {
 return resultMsg + result;
-}, function(error) {
+}, function (error) {
 return errorMsg + error;
 });
 }
 
+//Collects data from promise, and it returns a promise
+function preparePromise(promise, headline) {
+var output = "";
+resultList = promise.state === 'fullfilled' ? promise.value : 
promise.reason;
+if (resultList.length > 0) {
+resultList.map(function (result) {
+output += result.name + ' ip: ' + result.ip + '\n';
+});
+return Q(headline + ':\n' + output);
+}
+return Q(headline + ':\n' + 'Not found');
+}
+
 function getPlatformInfo(platform, projectRoot) {
 switch (platform) {
 case 'ios':
 return execSpawn('xcodebuild', ['-version'], 'iOS platform:\n\n', 
'Error retrieving iOS platform information: ');
 case 'android':
 return execSpawn('android', ['list', 'target'], 'Android 
platform:\n\n', 'Error retrieving Android platform information: ');
+case 'blackberry10':
+var bbUtilsPath = path.join(projectRoot, 'platforms', platform, 
'cordova');
+return Q.allSettled([
+Q.nfcall(require(path.join(bbUtilsPath, 'lib', 
'target-utils')).getTargetList, 'emulator', false),
+Q.nfcall(require(path.join(bbUtilsPath, 'lib', 
'target-utils')).getTargetList, 'device', false)
--- End diff --

Yeah, my mistake, adding to a var, no problem.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-lib pull request: CB-5082 [cordova info] Add support for B...

Github user martincgg commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/7#discussion_r13337337
  
--- Diff: cordova-lib/src/cordova/info.js ---
@@ -31,23 +31,50 @@ var cordova_util = require('./util'),
 
 // Execute using a child_process exec, for any async command
 function execSpawn(command, args, resultMsg, errorMsg) {
-return superspawn.spawn(command, args).then(function(result) {
+return superspawn.spawn(command, args).then(function (result) {
 return resultMsg + result;
-}, function(error) {
+}, function (error) {
 return errorMsg + error;
 });
 }
 
+//Collects data from promise, and it returns a promise
+function preparePromise(promise, headline) {
+var output = "";
+resultList = promise.state === 'fullfilled' ? promise.value : 
promise.reason;
+if (resultList.length > 0) {
+resultList.map(function (result) {
+output += result.name + ' ip: ' + result.ip + '\n';
+});
+return Q(headline + ':\n' + output);
+}
+return Q(headline + ':\n' + 'Not found');
+}
+
 function getPlatformInfo(platform, projectRoot) {
 switch (platform) {
 case 'ios':
 return execSpawn('xcodebuild', ['-version'], 'iOS platform:\n\n', 
'Error retrieving iOS platform information: ');
 case 'android':
 return execSpawn('android', ['list', 'target'], 'Android 
platform:\n\n', 'Error retrieving Android platform information: ');
+case 'blackberry10':
+var bbUtilsPath = path.join(projectRoot, 'platforms', platform, 
'cordova');
+return Q.allSettled([
+Q.nfcall(require(path.join(bbUtilsPath, 'lib', 
'target-utils')).getTargetList, 'emulator', false),
+Q.nfcall(require(path.join(bbUtilsPath, 'lib', 
'target-utils')).getTargetList, 'device', false)
--- End diff --

Ok, basically it's calling the target-utils.js file, to get the target 
list, one of it it's emulator and the other one it's to retrieve the list of 
devices.
nfcall, it's because the existent blackberry code on that are 
callback-based, not promises, and in info.js promises are required.

I can add some comment lines in there. No problem at all.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-lib pull request: CB-5082 [cordova info] Add support for B...

Github user martincgg commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/7#discussion_r13335471
  
--- Diff: cordova-lib/src/cordova/info.js ---
@@ -31,23 +31,50 @@ var cordova_util = require('./util'),
 
 // Execute using a child_process exec, for any async command
 function execSpawn(command, args, resultMsg, errorMsg) {
-return superspawn.spawn(command, args).then(function(result) {
+return superspawn.spawn(command, args).then(function (result) {
 return resultMsg + result;
-}, function(error) {
+}, function (error) {
 return errorMsg + error;
 });
 }
 
+//Collects data from promise, and it returns a promise
+function preparePromise(promise, headline) {
+var output = "";
+resultList = promise.state === 'fullfilled' ? promise.value : 
promise.reason;
+if (resultList.length > 0) {
+resultList.map(function (result) {
+output += result.name + ' ip: ' + result.ip + '\n';
+});
+return Q(headline + ':\n' + output);
+}
+return Q(headline + ':\n' + 'Not found');
+}
+
 function getPlatformInfo(platform, projectRoot) {
 switch (platform) {
 case 'ios':
 return execSpawn('xcodebuild', ['-version'], 'iOS platform:\n\n', 
'Error retrieving iOS platform information: ');
 case 'android':
 return execSpawn('android', ['list', 'target'], 'Android 
platform:\n\n', 'Error retrieving Android platform information: ');
+case 'blackberry10':
+var bbUtilsPath = path.join(projectRoot, 'platforms', platform, 
'cordova');
+return Q.allSettled([
+Q.nfcall(require(path.join(bbUtilsPath, 'lib', 
'target-utils')).getTargetList, 'emulator', false),
+Q.nfcall(require(path.join(bbUtilsPath, 'lib', 
'target-utils')).getTargetList, 'device', false)
+]).spread(function (emu, dev) {
+return Q.all([
+execSpawn(path.join(bbUtilsPath,'bb10-ndk-version'), 
'', 'Blackberry 10 Native SDK version: ', 'Error retrieving Blackberry 10 
Native SDK version'),
+preparePromise(emu, 'Blackberry 10 deployed 
emulators:'),
--- End diff --

I can spell it correctly, no problem



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-lib pull request: CB-5082 [cordova info] Add support for B...

Github user martincgg commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/7#discussion_r13335220
  
--- Diff: cordova-lib/src/cordova/info.js ---
@@ -62,15 +89,15 @@ module.exports = function info() {
 //Get Node version
 Q('Node version: ' + process.version),
 //Get Cordova version
-Q('Cordova version: ' + package.version),
-//Get project config.xml file using ano
--- End diff --

Ok, you're right, I can fix it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-lib pull request: CB-5082 [cordova info] Add support for B...

2014-06-02 Thread martincgg

Github user martincgg commented on the pull request:

https://github.com/apache/cordova-lib/pull/7#issuecomment-44895119
  
Hey @jsoref can you take a look at this, please?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-mobile-spec pull request: [CB-6822] plugman compatible on ...

2014-05-30 Thread martincgg

GitHub user martincgg opened a pull request:

https://github.com/apache/cordova-mobile-spec/pull/66

[CB-6822] plugman compatible on Windows platforms

When createmobilespec module is used and the --plugman argument is
present, it will determine if the development platform is windows to add
node as part of the command.

process.argv[0] it will retrieve the node from the current process, and
it will cover the scenario where the nodejs installation it has a custom
path or it's not present in system PATH environmental variable.

If:
/path/to/nodejs/node createmobilespec.js [args]
process.argv[0] it will retrieve: /path/to/nodejs/node
to invoke plugman main.js file.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/martincgg/cordova-mobile-spec CB-6822

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-mobile-spec/pull/66.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #66


commit 1b140bca76c826d3eae09b35da2d1d84face3a0c
Author: Martin Gonzalez 
Date:   2014-05-30T16:26:40Z

[CB-6822] plugman compatible with windows

When createmobilespec module is used and the --plugman argument is
present, it will determine if the development platform is windows to add
node as part of the command.

process.argv[0] it will retrieve the node from the current process, and
it will cover the scenario where the nodejs installation it has a custom
path or it's not present in system PATH environmental variable.

If:
/path/to/nodejs/node createmobilespec.js [args]
process.argv[0] it will retrieve: /path/to/nodejs/node
to invoke plugman main.js file.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-blackberry pull request: CB-5654 Log 'native' Cordova vers...

2014-05-30 Thread martincgg

Github user martincgg commented on the pull request:

https://github.com/apache/cordova-blackberry/pull/159#issuecomment-44660029
  
This will keep it consistent with the others platforms output.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-blackberry pull request: CB-5654 Log 'native' Cordova vers...

2014-05-30 Thread martincgg

Github user martincgg commented on the pull request:

https://github.com/apache/cordova-blackberry/pull/159#issuecomment-44659940
  
Yes I worked on something like it to print it out, and be able to see it 
using the webinspector.
You may want to use this proposed output:
Apache Cordova native platform version X.Y.Z is starting.
console.log("Apache Cordova native platform version " + 
config.cordovaVersion + " is starting")




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-wp8 pull request: [CB-5653][WP8] make visible cordova vers...

2014-05-26 Thread martincgg

Github user martincgg commented on the pull request:

https://github.com/apache/cordova-wp8/pull/35#issuecomment-44220176
  
Ohh that's a better, I didn't know the possibility of include content 
during the build. It a cleaner way to do it.
Thanks Jesse.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-ubuntu pull request: [Ubuntu] make visible cordova version...

2014-05-23 Thread martincgg

GitHub user martincgg opened a pull request:

https://github.com/apache/cordova-ubuntu/pull/7

[Ubuntu] make visible cordova version(native)

Standard print to console when the application is launched.

-Using constant in header file
-Invoked from main

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/martincgg/cordova-ubuntu CB-5655

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-ubuntu/pull/7.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #7


commit d51967cfbd7e989cddbbac1ebaa32412a3add01e
Author: Martin Gonzalez 
Date:   2014-05-23T09:32:41Z

[Ubuntu] make visible cordova version(native)

Standard print to console when the application is launched.

-Using constant in header file
-Invoked from main cpp.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-wp8 pull request: [CB-5653][WP8] make visible cordova vers...

2014-05-20 Thread martincgg

GitHub user martincgg opened a pull request:

https://github.com/apache/cordova-wp8/pull/35

[CB-5653][WP8] make visible cordova version

Added static class to record the cordova version on the native side,
keep in it clean, and consistent.
Class added to Lib & template to get it compiled.

The varible it will be printed in console, during execution of CordovaView.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/martincgg/cordova-wp8 CB-5653

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-wp8/pull/35.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #35


commit efd7625e361068383514c859f4ebabc2d6f30aac
Author: Martin Gonzalez 
Date:   2014-05-20T09:04:50Z

[CB-5653][WP8] make visible cordova version

Added static class to record the cordova version on the native side,
keep in it clean, and consistent.
Class added to Lib & template to get it compiled.

The varible it will be printed in console, during execution of
CordovaView.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-android pull request: [CB-5652] make visible cordova versi...

2014-05-16 Thread martincgg

GitHub user martincgg opened a pull request:

https://github.com/apache/cordova-android/pull/101

[CB-5652] make visible cordova version

https://issues.apache.org/jira/browse/CB-5652

Log the cordova version using version string from CordovaWebView.java


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/martincgg/cordova-android CB-5652

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-android/pull/101.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #101


commit e553bf7024c8046dd29af8bbd936d89264930438
Author: Martin Gonzalez 
Date:   2014-05-15T16:55:42Z

[CB-5652] make visible cordova version

Log the cordova version using version string from CordovaWebView.java

commit 65598c381c59b2703caf27ac684dcfb1596ec05b
Author: Martin Gonzalez 
Date:   2014-05-15T17:18:58Z

CordovaActivity make cordova version visible

Log the version onCreate(...), in CordovaActivity.java

commit a302bcddc818ff5864f7a3286222fbd5a416df15
Author: Martin Gonzalez 
Date:   2014-05-15T17:21:00Z

Removed whitespaces




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-cli pull request: CB-6415 [Blackberry] added path.join at ...

Github user martincgg commented on the pull request:

https://github.com/apache/cordova-cli/pull/158#issuecomment-42867986
  
Excellent, Thanks @bryanhiggins 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-mobile-spec pull request: CB-6669 Fix blackberry10 path

Github user martincgg commented on the pull request:

https://github.com/apache/cordova-mobile-spec/pull/63#issuecomment-42853073
  
Small fix, to use the subdirectory.
Related: 
https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/metadata/wp8_parser.js#L53




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-mobile-spec pull request: CB-6669 Fix blackberry10 path

Github user martincgg commented on the pull request:

https://github.com/apache/cordova-mobile-spec/pull/63#issuecomment-42868002
  
Awesome thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-cli pull request: CB-6415 [Blackberry] added path.join at ...

Github user martincgg closed the pull request at:

https://github.com/apache/cordova-cli/pull/158


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-mobile-spec pull request: CB-6669 Fix blackberry10 path