from:"omefire"

[GitHub] cordova-cli issue #255: CLI Refactor

2016-10-26 Thread omefire

Github user omefire commented on the issue:

https://github.com/apache/cordova-cli/pull/255
  
@stevengill sure, plz review it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: Code Refactor & Cleanup

2016-05-26 Thread omefire

Github user omefire commented on the pull request:

https://github.com/apache/cordova-cli/pull/254#issuecomment-221936305
  
Opened another PR with these changes here: 
https://github.com/apache/cordova-cli/pull/255


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: Code Refactor & Cleanup

2016-05-26 Thread omefire

Github user omefire closed the pull request at:

https://github.com/apache/cordova-cli/pull/254


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: CLI Refactor

2016-05-26 Thread omefire

GitHub user omefire opened a pull request:

https://github.com/apache/cordova-cli/pull/255

CLI Refactor



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/omefire/cordova-cli CLI_Refactor

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-cli/pull/255.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #255


commit 1934364d84d9a9e8349f8c5c3e93432f268fe61e
Author: Omar Mefire <omef...@gmail.com>
Date:   2016-05-17T20:45:44Z

CLI Refactor




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: Code Refactor & Cleanup

2016-05-25 Thread omefire

GitHub user omefire opened a pull request:

https://github.com/apache/cordova-cli/pull/254

Code Refactor & Cleanup



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/omefire/cordova-cli CB-11284

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-cli/pull/254.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #254


commit 91d6fddcd789d1262b1f0c7bd524771e916ea580
Author: Omar Mefire <omef...@gmail.com>
Date:   2016-05-17T20:45:44Z

WIP

commit a30f45970b1b0a17820cc9783a7457d556794106
Author: Omar Mefire <omef...@gmail.com>
Date:   2016-05-18T18:38:35Z

WIP

commit 81e7b9ecac88df733fe141e76c4670c526363fa5
Author: Omar Mefire <omef...@gmail.com>
Date:   2016-05-18T20:35:42Z

WIP

commit 5af9bd1c5b09b26bf610c2d65112842b1da73305
Author: Omar Mefire <omef...@gmail.com>
Date:   2016-05-18T20:50:50Z

Introducing utils module

commit 6fda34332da9569db02f30295bef0c4e4ad269cd
Author: Omar Mefire <omef...@gmail.com>
Date:   2016-05-20T05:12:06Z

Refactored stuff into utils module

commit c6a4b22bb885d342c443c95d31c44282083297bb
Author: Omar Mefire <omef...@gmail.com>
Date:   2016-05-21T18:37:18Z

CB-11284: Clean args passed to PlatformAPI




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: CB-11284 Telemetry: Track platforms/plug...

2016-05-20 Thread omefire

GitHub user omefire opened a pull request:

https://github.com/apache/cordova-cli/pull/253

CB-11284 Telemetry: Track platforms/plugins subcommands(add/rm/etc...)



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/omefire/cordova-cli CB-11284-2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-cli/pull/253.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #253


commit 10b08ae956388774dd3216254906f82bd1404619
Author: Omar Mefire <omef...@gmail.com>
Date:   2016-05-20T16:32:55Z

CB-11284 Telemetry: Track platforms/plugins subcommands(add/rm/etc...)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-coho pull request: CB-11279 Support arbitrary repositories...

2016-05-17 Thread omefire

Github user omefire commented on a diff in the pull request:

https://github.com/apache/cordova-coho/pull/122#discussion_r63578645
  
--- Diff: src/nightly.js ---
@@ -60,36 +62,26 @@ module.exports = function*(argv) {
 }
 
 // Clone and update Repos
-yield repoclone.cloneRepos(repos, /*silent=*/true);
-yield repoupdate.updateRepos(repos);
-
-//remove local changes and sync up with remote master
-yield repoutil.forEachRepo(repos, function*() {
-yield gitutil.gitClean();
-yield gitutil.resetFromOrigin();
-});
+yield prepareRepos(argv.r);
--- End diff --

:nit it's a bit hard to reason about these yields (especially the nested 
ones).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Snapshotting dev to 6.x

2016-05-16 Thread omefire

Github user omefire commented on the pull request:

https://github.com/apache/cordova-docs/pull/603#issuecomment-219551255
  
LGTM! 
Changes to CLI reference are effectively in this PR. 
I'm OK with not making any changes related to my earlier comments as those 
were separate PRs. 

Thanks for doing this, @rakatyal 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: Telemetry

2016-05-16 Thread omefire

Github user omefire commented on the pull request:

https://github.com/apache/cordova-cli/pull/247#issuecomment-219530078
  
@purplecabbage , could you please file a JIRA issue for what you've 
encountered ?
I just did the same for the issues I just mentioned: 
https://issues.apache.org/jira/browse/CB-11276


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Snapshotting dev to 6.x

2016-05-16 Thread omefire

Github user omefire commented on the pull request:

https://github.com/apache/cordova-docs/pull/603#issuecomment-219526115
  
However, I don't see the privacy policy changes: 
```www/privacy/index.md```: 
https://github.com/apache/cordova-docs/commit/0d5f185c45f11a46e3dc5b720e23d4b38a40779a


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Snapshotting dev to 6.x

2016-05-16 Thread omefire

Github user omefire commented on the pull request:

https://github.com/apache/cordova-docs/pull/603#issuecomment-219525124
  
Changes related to telemetry are definitely part of this snapshot.
Thanks Raghav!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Snapshotting dev to 6.x

2016-05-16 Thread omefire

Github user omefire commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/603#discussion_r63411548
  
--- Diff: www/docs/en/6.x/config_ref/images.md ---
@@ -137,15 +140,17 @@ For Windows the recommended approach to define app 
icons is to use `target` attr
 
 ```
 
-where `source` is the path to the icon which needs to be added.
+where `src` is the path to the icon which needs to be added.
+
+The Windows platform handles MRT icons automatically, so if you specify 
`src="res/windows/storelogo.png"` the following files will be copied into the 
application's `images` folder: `res/windows/storelogo.scale-100.png`, 
`res/windows/storelogo.scale-200.png`, etc.
 
-Please note that Windows platform handles MRT icons automatically, so if 
you specify `src="res/windows/storelogo.png"` the following files will be 
copied into app's `images` folder: `res/windows/storelogo.scale-100.png`, 
`res/windows/storelogo.scale-200.png`, etc.
+TODO Define what MRT is.
 
-The `target` attribute specifies the base name for resultant icons. For 
every icon file destination filename is calculated as `target + '.' + 
MRT_qualifiers + extension(src)`. For the icons to display properly in 
resultant app every `target` value should be the one of icon filenames, defined 
in application's `.appxmanifest` file.
+The `target` attribute specifies the base name for the resultant icons. 
For every icon file, its destination filename is calculated as `target + '.' + 
MRT_qualifiers + extension(src)`. For the icons to display properly in the 
application, every `target` value should be one of the icon filenames defined 
in the application's `.appxmanifest` file.
 
-Summarizing the above, using `target` attribute it is possible to:
+Summarizing the above... using the `target` attribute it is possible to:
--- End diff --

why '...' instead of ',' ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Snapshotting dev to 6.x

2016-05-16 Thread omefire

Github user omefire commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/603#discussion_r63411414
  
--- Diff: www/docs/en/6.x/config_ref/images.md ---
@@ -137,15 +140,17 @@ For Windows the recommended approach to define app 
icons is to use `target` attr
 
 ```
 
-where `source` is the path to the icon which needs to be added.
+where `src` is the path to the icon which needs to be added.
+
+The Windows platform handles MRT icons automatically, so if you specify 
`src="res/windows/storelogo.png"` the following files will be copied into the 
application's `images` folder: `res/windows/storelogo.scale-100.png`, 
`res/windows/storelogo.scale-200.png`, etc.
 
-Please note that Windows platform handles MRT icons automatically, so if 
you specify `src="res/windows/storelogo.png"` the following files will be 
copied into app's `images` folder: `res/windows/storelogo.scale-100.png`, 
`res/windows/storelogo.scale-200.png`, etc.
+TODO Define what MRT is.
--- End diff --

Should this go in a JIRA ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Snapshotting dev to 6.x

2016-05-16 Thread omefire

Github user omefire commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/603#discussion_r63410912
  
--- Diff: www/docs/en/6.x/config_ref/images.md ---
@@ -19,17 +19,17 @@ license: >
 
 title: Customize app icons
--- End diff --

'app' -> 'application'


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: Telemetry

2016-05-16 Thread omefire

Github user omefire commented on the pull request:

https://github.com/apache/cordova-cli/pull/247#issuecomment-219521656
  
@purplecabbage , I can't repro this with git-bash shell on Win10 because 
I'm running into another issue:   https://github.com/nodejs/node/issues/3006

The gist of my issue is that the process is not recognized to be running as 
TTY, which leads to insight ending the process and opting out: 

Furthermore, commenting that code out, leads to yet another error: 
https://github.com/SBoudrias/Inquirer.js/issues/290

Insight, which we depend on doesn't play well with git-bash/MinGW.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: Telemetry

2016-05-16 Thread omefire

Github user omefire commented on the pull request:

https://github.com/apache/cordova-cli/pull/247#issuecomment-219495292
  
@purplecabbage, I didn't create a JIRA issue to track the telemetry work, I 
should have. My bad.
I've tested this on MAC(El Capitan) and Windows10, but couldn't repro your 
issue.
What OS are you using ? I suspect this could be an issue with bash. I 
checked and couldn't find any such issue reported for inquirer, the underlying 
package that handles this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: CB-11204: Catch when SDK not present...

2016-05-13 Thread omefire

Github user omefire commented on a diff in the pull request:

https://github.com/apache/cordova-windows/pull/177#discussion_r63237158
  
--- Diff: bin/lib/check_reqs.js ---
@@ -362,6 +362,36 @@ module.exports.run = function () {
 });
 };
 
+/** Checks if Windows SDK required to build the target_platform is present
+ * @param {String}  target_platormTarget platform ('8.1' or '10.0')
+ * @return {Boolean}  Whether the min SDK required to 
build the platform is present  
+ *
+ */ 
+module.exports.isWinSDKPresent = function (target_platform) {
+return getInstalledWindowsSdks()
+.then(function (installedSdks) {
+var reqVersion = 
Version.tryParse(REQUIRED_VERSIONS[target_platform].windowssdk);
+var hasSdkInstalled = installedSdks.some(function (installedSdk) {
--- End diff --

same goes for ```isPhoneSDKPresent()```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: CB-11204: Catch when SDK not present...

2016-05-13 Thread omefire

Github user omefire commented on a diff in the pull request:

https://github.com/apache/cordova-windows/pull/177#discussion_r63236780
  
--- Diff: bin/lib/check_reqs.js ---
@@ -362,6 +362,36 @@ module.exports.run = function () {
 });
 };
 
+/** Checks if Windows SDK required to build the target_platform is present
+ * @param {String}  target_platormTarget platform ('8.1' or '10.0')
+ * @return {Boolean}  Whether the min SDK required to 
build the platform is present  
+ *
+ */ 
+module.exports.isWinSDKPresent = function (target_platform) {
+return getInstalledWindowsSdks()
+.then(function (installedSdks) {
+var reqVersion = 
Version.tryParse(REQUIRED_VERSIONS[target_platform].windowssdk);
+var hasSdkInstalled = installedSdks.some(function (installedSdk) {
--- End diff --

It seems like ```getInstalledWindowsSdks()``` doesn't return an array in 
all cases, i.e: when an exception occurs while running the registry query. 
Maybe, modify it to return an empty array in such a case, otherwise we'll error 
out here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: CB-11263: 'cordova telemetry help' shoul...

2016-05-13 Thread omefire

Github user omefire commented on the pull request:

https://github.com/apache/cordova-cli/pull/252#issuecomment-219109613
  
travis-ci failure is not related to this change, it's related to 
cordova-fetch not being in npm.
I ran the tests locally and they do pass.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: CB-11263: 'cordova telemetry help' shoul...

2016-05-13 Thread omefire

Github user omefire commented on the pull request:

https://github.com/apache/cordova-cli/pull/252#issuecomment-219108920
  
@riknoll to review


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: CB-11263: 'cordova telemetry help' shoul...

2016-05-13 Thread omefire

GitHub user omefire opened a pull request:

https://github.com/apache/cordova-cli/pull/252

CB-11263: 'cordova telemetry help' should display help text



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/omefire/cordova-cli CB-11263

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-cli/pull/252.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #252


commit 9158085fd98c6fc20d7e9e4d762dbfc3c6043e44
Author: Omar Mefire <omef...@gmail.com>
Date:   2016-05-13T17:32:24Z

CB-11263: 'cordova telemetry help' should display help text




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: Telemetry

2016-05-12 Thread omefire

Github user omefire commented on a diff in the pull request:

https://github.com/apache/cordova-cli/pull/247#discussion_r63066803
  
--- Diff: src/telemetry.js ---
@@ -0,0 +1,122 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+/* jshint node:true, bitwise:true, undef:true, trailing:true, 
quotmark:true,
+  indent:4, unused:vars, latedef:nofunc,
+  laxcomma:true
+*/
+
+
+
+// For further details on telemetry, see:
+// https://github.com/cordova/cordova-discuss/pull/43
+
+var Q = require('q');
+
+// Google Analytics tracking code
+var GA_TRACKING_CODE = 'UA-64283057-7';
+
+var pkg = require('../package.json');
+var Insight = require('insight');
+var insight = new Insight({
+trackingCode: GA_TRACKING_CODE,
+pkg: pkg
+});
+
+/**
+ * Returns true if the user opted in, and false otherwise
+ */
+function showPrompt() {
+
+var deferred = Q.defer();
+
+var msg = "May Cordova anonymously report usage statistics to improve 
the tool over time?";
+insight.askPermission(msg, function (unused, optIn) {
+var EOL = require('os').EOL;
+if (optIn) {
+console.log(EOL + "Thanks for opting into telemetry to help us 
improve cordova.");
--- End diff --

We can derive this percentage, noo ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: Telemetry

2016-05-12 Thread omefire

Github user omefire commented on a diff in the pull request:

https://github.com/apache/cordova-cli/pull/247#discussion_r63066442
  
--- Diff: doc/cordova.txt ---
@@ -5,6 +5,7 @@ Synopsis
 Global Commands
 create . Create a project
 help ... Get help for a command
+telemetry .. Turn telemetry collection on or 
off
--- End diff --

Yes, I've already updated it. thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: Telemetry

2016-05-12 Thread omefire

Github user omefire commented on a diff in the pull request:

https://github.com/apache/cordova-cli/pull/247#discussion_r63065751
  
--- Diff: doc/cordova.txt ---
@@ -5,6 +5,7 @@ Synopsis
 Global Commands
 create . Create a project
 help ... Get help for a command
+telemetry .. Turn telemetry collection on or 
off
--- End diff --

Hmm, I thought it was generated from these files. Anyway, it's been updated.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: Telemetry

2016-05-12 Thread omefire

Github user omefire commented on the pull request:

https://github.com/apache/cordova-cli/pull/247#issuecomment-218826259
  
I first wanted to go that route, but I then realized doing it in CLI 
minimizes polluting LIB for a functionality that's not intended to be used by 
downstream tools. It seems cleaner to handle it here, as mentioned by 
@purplecabbage 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: Telemetry

2016-05-11 Thread omefire

Github user omefire commented on the pull request:

https://github.com/apache/cordova-cli/pull/247#issuecomment-218664005
  
ping ...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: Telemetry

2016-05-11 Thread omefire

Github user omefire commented on a diff in the pull request:

https://github.com/apache/cordova-cli/pull/247#discussion_r62894363
  
--- Diff: src/cli.js ---
@@ -235,41 +317,58 @@ function cli(inputArgs) {
 throw new CordovaError(msg);
 }
 
-cordova.raw[cmd].call(null, opts.platforms)
-.then(function (platformChecks) {
+var result = cordova.raw[cmd].call(null, opts.platforms)
+.then(function(platformChecks) {
 
-var someChecksFailed = 
Object.keys(platformChecks).map(function (platformName) {
-events.emit('log', '\nRequirements check results for ' + 
platformName + ':');
-var platformCheck = platformChecks[platformName];
-if (platformCheck instanceof CordovaError) {
-events.emit('warn', 'Check failed for ' + platformName 
+ ' due to ' + platformCheck);
-return true;
-}
-
-var someChecksFailed = false;
-platformCheck.forEach(function (checkItem) {
-var checkSummary = checkItem.name + ': ' +
-(checkItem.installed ? 'installed ' : 
'not installed ') +
-(checkItem.metadata.version || '');
-events.emit('log', checkSummary);
-if (!checkItem.installed) {
-someChecksFailed = true;
-events.emit('warn', checkItem.metadata.reason);
+var someChecksFailed = 
Object.keys(platformChecks).map(function(platformName) {
+events.emit('log', '\nRequirements check results for ' 
+ platformName + ':');
+var platformCheck = platformChecks[platformName];
+if (platformCheck instanceof CordovaError) {
+events.emit('warn', 'Check failed for ' + 
platformName + ' due to ' + platformCheck);
+return true;
 }
+
+var someChecksFailed = false;
+platformCheck.forEach(function(checkItem) {
+var checkSummary = checkItem.name + ': ' +
+(checkItem.installed ? 'installed ' : 'not 
installed ') +
+(checkItem.metadata.version || '');
+events.emit('log', checkSummary);
+if (!checkItem.installed) {
+someChecksFailed = true;
+events.emit('warn', checkItem.metadata.reason);
+}
+});
+
+return someChecksFailed;
+}).some(function(isCheckFailedForPlatform) {
+return isCheckFailedForPlatform;
 });
 
-return someChecksFailed;
-}).some(function (isCheckFailedForPlatform) {
-return isCheckFailedForPlatform;
+if (someChecksFailed) throw new CordovaError('Some of 
requirements check failed');
 });
-
-if (someChecksFailed) throw new CordovaError('Some of 
requirements check failed');
-}).done();
+return result.finally(function() {
+if (shouldCollectTelemetry) {
+telemetry.track(cmd, result.isFulfilled() ? 'successful' : 
'unsuccessful');
+}
+return result;
+});   
 } else if (cmd == 'serve') {
 var port = undashed[1];
-cordova.raw.serve(port).done();
+var result = cordova.raw.serve(port);
+return result.finally(function() {
+if(shouldCollectTelemetry) {
+telemetry.track(cmd, result.isFulfilled() ? 'successful' : 
'unsuccessful');
+}
+});
 } else if (cmd == 'create') {
-create();
+var result = create();
+return result.finally(function() {
+if (shouldCollectTelemetry) {
--- End diff --

As discussed offline, I'm going ahead with this refactoring. but it will 
require retesting the whole CLI as it affects everything. Looking at things 
from the benefits/costs perspective, I'm not sure if that's the best route, but 
...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA

[GitHub] cordova-cli pull request: Telemetry

2016-05-11 Thread omefire

Github user omefire commented on a diff in the pull request:

https://github.com/apache/cordova-cli/pull/247#discussion_r62882068
  
--- Diff: src/cli.js ---
@@ -235,41 +317,58 @@ function cli(inputArgs) {
 throw new CordovaError(msg);
 }
 
-cordova.raw[cmd].call(null, opts.platforms)
-.then(function (platformChecks) {
+var result = cordova.raw[cmd].call(null, opts.platforms)
+.then(function(platformChecks) {
 
-var someChecksFailed = 
Object.keys(platformChecks).map(function (platformName) {
-events.emit('log', '\nRequirements check results for ' + 
platformName + ':');
-var platformCheck = platformChecks[platformName];
-if (platformCheck instanceof CordovaError) {
-events.emit('warn', 'Check failed for ' + platformName 
+ ' due to ' + platformCheck);
-return true;
-}
-
-var someChecksFailed = false;
-platformCheck.forEach(function (checkItem) {
-var checkSummary = checkItem.name + ': ' +
-(checkItem.installed ? 'installed ' : 
'not installed ') +
-(checkItem.metadata.version || '');
-events.emit('log', checkSummary);
-if (!checkItem.installed) {
-someChecksFailed = true;
-events.emit('warn', checkItem.metadata.reason);
+var someChecksFailed = 
Object.keys(platformChecks).map(function(platformName) {
+events.emit('log', '\nRequirements check results for ' 
+ platformName + ':');
+var platformCheck = platformChecks[platformName];
+if (platformCheck instanceof CordovaError) {
+events.emit('warn', 'Check failed for ' + 
platformName + ' due to ' + platformCheck);
+return true;
 }
+
+var someChecksFailed = false;
+platformCheck.forEach(function(checkItem) {
+var checkSummary = checkItem.name + ': ' +
+(checkItem.installed ? 'installed ' : 'not 
installed ') +
+(checkItem.metadata.version || '');
+events.emit('log', checkSummary);
+if (!checkItem.installed) {
+someChecksFailed = true;
+events.emit('warn', checkItem.metadata.reason);
+}
+});
+
+return someChecksFailed;
+}).some(function(isCheckFailedForPlatform) {
+return isCheckFailedForPlatform;
 });
 
-return someChecksFailed;
-}).some(function (isCheckFailedForPlatform) {
-return isCheckFailedForPlatform;
+if (someChecksFailed) throw new CordovaError('Some of 
requirements check failed');
 });
-
-if (someChecksFailed) throw new CordovaError('Some of 
requirements check failed');
-}).done();
+return result.finally(function() {
+if (shouldCollectTelemetry) {
+telemetry.track(cmd, result.isFulfilled() ? 'successful' : 
'unsuccessful');
+}
+return result;
+});   
 } else if (cmd == 'serve') {
 var port = undashed[1];
-cordova.raw.serve(port).done();
+var result = cordova.raw.serve(port);
+return result.finally(function() {
+if(shouldCollectTelemetry) {
+telemetry.track(cmd, result.isFulfilled() ? 'successful' : 
'unsuccessful');
+}
+});
 } else if (cmd == 'create') {
-create();
+var result = create();
+return result.finally(function() {
+if (shouldCollectTelemetry) {
+telemetry.track(cmd, result.isFulfilled() ? 'successful' : 
'unsuccessful');
+}
+return result;
--- End diff --

returning result is done for consistency's sake. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr

[GitHub] cordova-cli pull request: Telemetry

2016-05-11 Thread omefire

Github user omefire commented on a diff in the pull request:

https://github.com/apache/cordova-cli/pull/247#discussion_r62880886
  
--- Diff: src/cli.js ---
@@ -235,41 +317,58 @@ function cli(inputArgs) {
 throw new CordovaError(msg);
 }
 
-cordova.raw[cmd].call(null, opts.platforms)
-.then(function (platformChecks) {
+var result = cordova.raw[cmd].call(null, opts.platforms)
+.then(function(platformChecks) {
 
-var someChecksFailed = 
Object.keys(platformChecks).map(function (platformName) {
-events.emit('log', '\nRequirements check results for ' + 
platformName + ':');
-var platformCheck = platformChecks[platformName];
-if (platformCheck instanceof CordovaError) {
-events.emit('warn', 'Check failed for ' + platformName 
+ ' due to ' + platformCheck);
-return true;
-}
-
-var someChecksFailed = false;
-platformCheck.forEach(function (checkItem) {
-var checkSummary = checkItem.name + ': ' +
-(checkItem.installed ? 'installed ' : 
'not installed ') +
-(checkItem.metadata.version || '');
-events.emit('log', checkSummary);
-if (!checkItem.installed) {
-someChecksFailed = true;
-events.emit('warn', checkItem.metadata.reason);
+var someChecksFailed = 
Object.keys(platformChecks).map(function(platformName) {
+events.emit('log', '\nRequirements check results for ' 
+ platformName + ':');
+var platformCheck = platformChecks[platformName];
+if (platformCheck instanceof CordovaError) {
+events.emit('warn', 'Check failed for ' + 
platformName + ' due to ' + platformCheck);
+return true;
 }
+
+var someChecksFailed = false;
+platformCheck.forEach(function(checkItem) {
+var checkSummary = checkItem.name + ': ' +
+(checkItem.installed ? 'installed ' : 'not 
installed ') +
+(checkItem.metadata.version || '');
+events.emit('log', checkSummary);
+if (!checkItem.installed) {
+someChecksFailed = true;
+events.emit('warn', checkItem.metadata.reason);
+}
+});
+
+return someChecksFailed;
+}).some(function(isCheckFailedForPlatform) {
+return isCheckFailedForPlatform;
 });
 
-return someChecksFailed;
-}).some(function (isCheckFailedForPlatform) {
-return isCheckFailedForPlatform;
+if (someChecksFailed) throw new CordovaError('Some of 
requirements check failed');
 });
-
-if (someChecksFailed) throw new CordovaError('Some of 
requirements check failed');
-}).done();
--- End diff --

I've refactored and introduced ```done()``` into the main function. This 
required introducing a callback into the main/exported function for testing 
purposes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: Telemetry

2016-05-11 Thread omefire

Github user omefire commented on a diff in the pull request:

https://github.com/apache/cordova-cli/pull/247#discussion_r62870553
  
--- Diff: src/cli.js ---
@@ -235,41 +317,58 @@ function cli(inputArgs) {
 throw new CordovaError(msg);
 }
 
-cordova.raw[cmd].call(null, opts.platforms)
-.then(function (platformChecks) {
+var result = cordova.raw[cmd].call(null, opts.platforms)
+.then(function(platformChecks) {
 
-var someChecksFailed = 
Object.keys(platformChecks).map(function (platformName) {
-events.emit('log', '\nRequirements check results for ' + 
platformName + ':');
-var platformCheck = platformChecks[platformName];
-if (platformCheck instanceof CordovaError) {
-events.emit('warn', 'Check failed for ' + platformName 
+ ' due to ' + platformCheck);
-return true;
-}
-
-var someChecksFailed = false;
-platformCheck.forEach(function (checkItem) {
-var checkSummary = checkItem.name + ': ' +
-(checkItem.installed ? 'installed ' : 
'not installed ') +
-(checkItem.metadata.version || '');
-events.emit('log', checkSummary);
-if (!checkItem.installed) {
-someChecksFailed = true;
-events.emit('warn', checkItem.metadata.reason);
+var someChecksFailed = 
Object.keys(platformChecks).map(function(platformName) {
+events.emit('log', '\nRequirements check results for ' 
+ platformName + ':');
+var platformCheck = platformChecks[platformName];
+if (platformCheck instanceof CordovaError) {
+events.emit('warn', 'Check failed for ' + 
platformName + ' due to ' + platformCheck);
+return true;
 }
+
+var someChecksFailed = false;
+platformCheck.forEach(function(checkItem) {
+var checkSummary = checkItem.name + ': ' +
+(checkItem.installed ? 'installed ' : 'not 
installed ') +
+(checkItem.metadata.version || '');
+events.emit('log', checkSummary);
+if (!checkItem.installed) {
+someChecksFailed = true;
+events.emit('warn', checkItem.metadata.reason);
+}
+});
+
+return someChecksFailed;
+}).some(function(isCheckFailedForPlatform) {
+return isCheckFailedForPlatform;
 });
 
-return someChecksFailed;
-}).some(function (isCheckFailedForPlatform) {
-return isCheckFailedForPlatform;
+if (someChecksFailed) throw new CordovaError('Some of 
requirements check failed');
 });
-
-if (someChecksFailed) throw new CordovaError('Some of 
requirements check failed');
-}).done();
--- End diff --

Good point. This will end up requiring a rework of how the tests are 
structured, since calling ```done()``` will end the promise chain.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: Telemetry

2016-05-10 Thread omefire

Github user omefire commented on a diff in the pull request:

https://github.com/apache/cordova-cli/pull/247#discussion_r62777073
  
--- Diff: src/telemetry.js ---
@@ -0,0 +1,132 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+/* jshint node:true, bitwise:true, undef:true, trailing:true, 
quotmark:true,
+  indent:4, unused:vars, latedef:nofunc,
+  laxcomma:true
+*/
+
+
+
+// For further details on telemetry, see:
+// https://github.com/cordova/cordova-discuss/pull/43
+
+var Q = require('q');
+
+// Google Analytics tracking code
+var GA_TRACKING_CODE = 'UA-64283057-7';
+
+var pkg = require('../package.json');
+var Insight = require('insight');
+var insight = new Insight({
+trackingCode: GA_TRACKING_CODE,
+pkg: pkg
+});
+
+/**
+ * Returns true if the user opted in, and false otherwise
+ */
+function showPrompt() {
+
+var deferred = Q.defer();
+
+var msg = "May Cordova anonymously report usage statistics to improve 
the tool over time?";
+insight.askPermission(msg, function (unused, optIn) {
+var EOL = require('os').EOL;
+if (optIn) {
+console.log(EOL + "Thanks for opting into telemetry to help us 
better cordova");
+} else {
+console.log(EOL + "You have been opted out of telemetry. To 
change this, run: cordova telemetry on");
+// Always track telemetry opt-outs! (whether opted-in or 
opted-out)
+track('telemetry-opt-out', 'via-cli-prompt-choice');
+}
+
+deferred.resolve(optIn); 
+});
+
+return deferred.promise;
+}
+
+function track() {
+insight.track.apply(insight, arguments);
+}
+
+function trackEvent(category, action, label, value) {
+insight.trackEvent({
+category: category,
+action: action,
+label: label,
+value: value
+});
+}
+
+function turnOn() {
+insight.optOut = false;
+}
+
+function turnOff() {
+insight.optOut = true;
+}
+
+/**
+ * Clears telemetry setting
+ * Has the same effect as if user never answered the telemetry prompt
+ * Useful for testing purposes
+ */
+function clear() {
+insight.optOut = undefined;
+}
+
+function isOptedIn() {
+return !insight.optOut;
+}
+
+/**
+ * Has the user already answered the telemetry prompt? (thereby opting in 
or out?)
+ */
+function hasUserOptedInOrOut() {
+return !(insight.optOut === undefined);
--- End diff --

If ```undefined``` was to be redefined, that wouldn't be our biggest 
concern. Plus, modern webviews/browsers don't allow that anymore.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Telemetry: Privacy Policy

2016-05-10 Thread omefire

Github user omefire commented on the pull request:

https://github.com/apache/cordova-docs/pull/599#issuecomment-218331338
  
Thanks, comments addressed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Telemetry: Privacy Policy

2016-05-10 Thread omefire

Github user omefire commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/599#discussion_r62776600
  
--- Diff: www/privacy/index.md ---
@@ -0,0 +1,22 @@
+---
+layout: page 
+title: Privacy Policy 
+---
+
+# Privacy Policy
+
+When you opt into telemetry, information about your usage of Apache 
Cordova CLI is collected. The collected information consists of the following:
+
+* IP address
+* OS type and version
+* Node version
+* Cordova version
+* Commands executed, time of execution and status (success/failure)
+
+This information is saved in Google Analytics and handled by Google as 
described in their [privacy policy](http://www.google.com/policies/privacy/). 
See the documentation for instructions on how to disable telemetry if you 
prefer not to share your data.
--- End diff --

+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: Telemetry

2016-05-10 Thread omefire

Github user omefire commented on a diff in the pull request:

https://github.com/apache/cordova-cli/pull/247#discussion_r62759764
  
--- Diff: src/telemetry.js ---
@@ -0,0 +1,132 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+/* jshint node:true, bitwise:true, undef:true, trailing:true, 
quotmark:true,
+  indent:4, unused:vars, latedef:nofunc,
+  laxcomma:true
+*/
+
+
+
+// For further details on telemetry, see:
+// https://github.com/cordova/cordova-discuss/pull/43
+
+var Q = require('q');
+
+// Google Analytics tracking code
+var GA_TRACKING_CODE = 'UA-64283057-7';
+
+var pkg = require('../package.json');
+var Insight = require('insight');
+var insight = new Insight({
+trackingCode: GA_TRACKING_CODE,
+pkg: pkg
+});
+
+/**
+ * Returns true if the user opted in, and false otherwise
+ */
+function showPrompt() {
+
+var deferred = Q.defer();
+
+var msg = "May Cordova anonymously report usage statistics to improve 
the tool over time?";
+insight.askPermission(msg, function (unused, optIn) {
+var EOL = require('os').EOL;
+if (optIn) {
+console.log(EOL + "Thanks for opting into telemetry to help us 
better cordova");
+} else {
+console.log(EOL + "You have been opted out of telemetry. To 
change this, run: cordova telemetry on");
+// Always track telemetry opt-outs! (whether opted-in or 
opted-out)
+track('telemetry-opt-out', 'via-cli-prompt-choice');
+}
+
+deferred.resolve(optIn); 
+});
+
+return deferred.promise;
+}
+
+function track() {
+insight.track.apply(insight, arguments);
+}
+
+function trackEvent(category, action, label, value) {
+insight.trackEvent({
+category: category,
+action: action,
+label: label,
+value: value
+});
+}
+
+function turnOn() {
+insight.optOut = false;
+}
+
+function turnOff() {
+insight.optOut = true;
+}
+
+/**
+ * Clears telemetry setting
+ * Has the same effect as if user never answered the telemetry prompt
+ * Useful for testing purposes
+ */
+function clear() {
+insight.optOut = undefined;
+}
+
+function isOptedIn() {
+return !insight.optOut;
+}
+
+/**
+ * Has the user already answered the telemetry prompt? (thereby opting in 
or out?)
+ */
+function hasUserOptedInOrOut() {
+return !(insight.optOut === undefined);
--- End diff --

Quesiton: Why do we 'have' to use 'typeof' ? According to the same link, it 
seems like this way is fine as well, with the difference between the two being 
that one throws when the variable is undeclared.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: Telemetry

2016-05-10 Thread omefire

Github user omefire commented on a diff in the pull request:

https://github.com/apache/cordova-cli/pull/247#discussion_r62758588
  
--- Diff: spec/cli.spec.js ---
@@ -50,19 +56,34 @@ describe("cordova cli", function () {
 beforeEach(function () {
 });
 
-it("will spit out the version with -v", function () {
-cli(["node", "cordova", "-v"]);
-
expect(console.log.mostRecentCall.args[0]).toMatch(version);
+it("will spit out the version with -v", function (done) {
+cli(["node", "cordova", "-v"]).then(function() {
+
expect(console.log.mostRecentCall.args[0]).toMatch(version);
+done();
+}).fail(function() {
--- End diff --

They have changed because ```telemetry.showPrompt()``` is async, therefore 
the return of ```cli``` turned into async, and the tests had to be updated to 
reflect that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: Telemetry

2016-05-10 Thread omefire

Github user omefire commented on a diff in the pull request:

https://github.com/apache/cordova-cli/pull/247#discussion_r62758273
  
--- Diff: doc/telemetry.txt ---
@@ -0,0 +1,24 @@
+Synopsis
+
+cordova-cli telemetry [STATE]
+
+  STATE: on|off
+
+Turns telemetry collection on or off
+
+on ... Turns telemetry collection on
+off .. Turns telemetry collection off  
+
+Details
+A timed prompt asking the user to opt-in or out is displayed the first 
time cordova is run.
--- End diff --

It reinforces that they have options.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: Telemetry

2016-05-10 Thread omefire

Github user omefire commented on the pull request:

https://github.com/apache/cordova-cli/pull/247#issuecomment-218299896
  
Related: https://github.com/apache/cordova-docs/pull/599


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Telemetry: Privacy Policy

2016-05-10 Thread omefire

Github user omefire commented on the pull request:

https://github.com/apache/cordova-docs/pull/599#issuecomment-218299426
  
What it looks like: http://imgur.com/FSDAifF


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Telemetry: Privacy Policy

2016-05-10 Thread omefire

Github user omefire commented on the pull request:

https://github.com/apache/cordova-docs/pull/599#issuecomment-218298615
  
http://imgur.com/FSDAifF


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Telemetry: Privacy Policy

2016-05-10 Thread omefire

Github user omefire commented on the pull request:

https://github.com/apache/cordova-docs/pull/599#issuecomment-218296850
  
@axemclion, @nikhilkh  to review


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Telemetry: Privacy Policy

2016-05-10 Thread omefire

GitHub user omefire opened a pull request:

https://github.com/apache/cordova-docs/pull/599

Telemetry: Privacy Policy



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/omefire/cordova-docs TelemetryPrivacyPolicy

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/599.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #599


commit b46a042f39518368ea787820d0ea7b1c62d0c5cf
Author: Omar Mefire <omef...@gmail.com>
Date:   2016-05-10T20:55:12Z

Telemetry: Privacy Notice




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: Telemetry

2016-05-08 Thread omefire

Github user omefire commented on the pull request:

https://github.com/apache/cordova-cli/pull/247#issuecomment-217747793
  
This code relies on the insight package: 
https://www.npmjs.com/package/insight
However, due to a bug within insight, when the command prompt timeout 
expires, it won't automatically opt the user out, leading to the prompt being 
displayed again the next time cordova is run.

I have a patch to fix this issue here: 
https://github.com/omefire/insight/tree/AutomaticallyOptOutAfterTimeOut 

Use the patch to test this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request: [CB-11223] Better check for ...

2016-05-06 Thread omefire

Github user omefire commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/125#discussion_r62398237
  
--- Diff: www/convertUtils.js ---
@@ -28,10 +28,19 @@ module.exports = {
 */
 toCordovaFormat: function (contact) {
 var value = contact.birthday;
-try {
-  contact.birthday = new Date(parseFloat(value));
-} catch (exception){
-  console.log("Cordova Contact toCordovaFormat error: exception 
creating date.");
+if (value !== null) {
+try {
+  contact.birthday = new Date(parseFloat(value));
+  
+  //we might get 'Invalid Date' which does not throw an error
+  //and is an instance of Date.
+  if (isNaN(contact.birthday.getTime())) {
+contact.birthday = null;
--- End diff --

code looks good to me, could you please add a comment about the fact that 
when birthday is null, native side(iOS, Android,etc...) will return an 'Invalid 
Date' ? That will make it easier for others to grasp the reason behind this.
After that, we'll be good to go.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request: [CB-11223] Better check for ...

2016-05-06 Thread omefire

Github user omefire commented on the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/125#issuecomment-217576715
  
LGTM!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request: [CB-11223] Better check for ...

2016-05-06 Thread omefire

Github user omefire commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/125#discussion_r62397911
  
--- Diff: www/convertUtils.js ---
@@ -28,10 +28,19 @@ module.exports = {
 */
 toCordovaFormat: function (contact) {
 var value = contact.birthday;
-try {
-  contact.birthday = new Date(parseFloat(value));
-} catch (exception){
-  console.log("Cordova Contact toCordovaFormat error: exception 
creating date.");
+if (value !== null) {
+try {
+  contact.birthday = new Date(parseFloat(value));
+  
+  //we might get 'Invalid Date' which does not throw an error
+  //and is an instance of Date.
+  if (isNaN(contact.birthday.getTime())) {
+contact.birthday = null;
--- End diff --

Thanks for the explanation, makes sense.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request: [CB-11223] Better check for ...

2016-05-06 Thread omefire

Github user omefire commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/125#discussion_r62395371
  
--- Diff: www/convertUtils.js ---
@@ -28,10 +28,19 @@ module.exports = {
 */
 toCordovaFormat: function (contact) {
 var value = contact.birthday;
-try {
-  contact.birthday = new Date(parseFloat(value));
-} catch (exception){
-  console.log("Cordova Contact toCordovaFormat error: exception 
creating date.");
+if (value !== null) {
--- End diff --

:+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request: [CB-11223] Better check for ...

2016-05-06 Thread omefire

Github user omefire commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/125#discussion_r62395046
  
--- Diff: www/convertUtils.js ---
@@ -28,10 +28,19 @@ module.exports = {
 */
 toCordovaFormat: function (contact) {
 var value = contact.birthday;
-try {
-  contact.birthday = new Date(parseFloat(value));
-} catch (exception){
-  console.log("Cordova Contact toCordovaFormat error: exception 
creating date.");
+if (value !== null) {
+try {
+  contact.birthday = new Date(parseFloat(value));
+  
+  //we might get 'Invalid Date' which does not throw an error
+  //and is an instance of Date.
+  if (isNaN(contact.birthday.getTime())) {
+contact.birthday = null;
--- End diff --

Instead of setting it to null, should an exception be raised instead ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request: [CB-11223] Better check for ...

2016-05-06 Thread omefire

Github user omefire commented on the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/125#issuecomment-217565470
  
Do you know why is iOS setting an 'Invalid Date' in the first place ? I 
feel like this fix might end up just masking an issue on the native side.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request: [CB-11223] Better check for ...

2016-05-06 Thread omefire

Github user omefire commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/125#discussion_r62393819
  
--- Diff: www/convertUtils.js ---
@@ -28,10 +28,19 @@ module.exports = {
 */
 toCordovaFormat: function (contact) {
 var value = contact.birthday;
-try {
-  contact.birthday = new Date(parseFloat(value));
-} catch (exception){
-  console.log("Cordova Contact toCordovaFormat error: exception 
creating date.");
+if (value !== null) {
--- End diff --

Why the null check ? If null was returned from the native side, this case 
will be handled by the ```if (isNaN(contact.birthday.getTime()))``` check 
you've got below


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-mobile-spec pull request: CB-11050 Removing the flaky XHR ...

2016-05-06 Thread omefire

Github user omefire commented on the pull request:


https://github.com/apache/cordova-mobile-spec/pull/140#issuecomment-217527951
  
Haha, I just realized we should have updated the title to 'Fixing flaky XHR 
Test' instead of 'Removing ...'.
Oh well, ...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-mobile-spec pull request: CB-11050 Removing the flaky XHR ...

2016-05-06 Thread omefire

Github user omefire commented on the pull request:


https://github.com/apache/cordova-mobile-spec/pull/140#issuecomment-217527093
  
LGTM!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-11134: Removing duplicated warning

2016-05-06 Thread omefire

Github user omefire commented on the pull request:

https://github.com/apache/cordova-lib/pull/436#issuecomment-217521367
  
Ok. I've created an issue to track it here: 
https://issues.apache.org/jira/browse/CB-11219


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-11134: Removing duplicated warning

2016-05-06 Thread omefire

Github user omefire commented on the pull request:

https://github.com/apache/cordova-lib/pull/436#issuecomment-217510255
  
(Though not related to this change) it seems like the ```--force``` flag 
wouldn't work as advertised ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-11134: Removing duplicated warning

2016-05-06 Thread omefire

Github user omefire commented on the pull request:

https://github.com/apache/cordova-lib/pull/436#issuecomment-217510027
  
LGTM!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-mobile-spec pull request: CB-11050 Removing the flaky XHR ...

2016-05-06 Thread omefire

Github user omefire commented on the pull request:


https://github.com/apache/cordova-mobile-spec/pull/140#issuecomment-217509068
  
@rakatyal Is the flakiness related to the host we're XHR'ing to ? Would 
switching from 'http://cordova-filetransfer.jitsu.com' to something else(e.g: 
'http://google.com') solve this ? If so, let's replace instead of removing the 
test.

Also, Please add a comment to the tests with @purplecabbage 's comment. It 
would clarify why these tests are needed and remind us not to think about 
removing them in the future.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-mobile-spec pull request: CB-11050 Removing the flaky XHR ...

2016-05-06 Thread omefire

Github user omefire commented on the pull request:


https://github.com/apache/cordova-mobile-spec/pull/140#issuecomment-217508257
  
Thanks @purplecabbage for confirming.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-mobile-spec pull request: CB-11050 Removing the flaky XHR ...

2016-05-05 Thread omefire

Github user omefire commented on the pull request:


https://github.com/apache/cordova-mobile-spec/pull/140#issuecomment-217334128
  
It seems like this whole test suite is only about checking browser/webview 
functionality.
Do we still really need them ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-device-motion pull request: CB-11188: cordova-plugi...

2016-05-05 Thread omefire

Github user omefire commented on the pull request:


https://github.com/apache/cordova-plugin-device-motion/pull/43#issuecomment-217259632
  
a comment would also be great 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-device-motion pull request: CB-11188: cordova-plugi...

2016-05-05 Thread omefire

Github user omefire commented on the pull request:


https://github.com/apache/cordova-plugin-device-motion/pull/43#issuecomment-217239510
  
Other than the minor stuff mentioned, LGTM!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-device-motion pull request: CB-11188: cordova-plugi...

2016-05-05 Thread omefire

Github user omefire commented on the pull request:


https://github.com/apache/cordova-plugin-device-motion/pull/43#issuecomment-217238656
  
+1 . Introducing a delta for this kind of comparisons is a good strategy 
for this issue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-device-motion pull request: CB-11188: cordova-plugi...

2016-05-05 Thread omefire

Github user omefire commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-device-motion/pull/43#discussion_r62233809
  
--- Diff: tests/tests.js ---
@@ -122,6 +122,7 @@ exports.defineAutoTests = function () {
 
 describe("watchAcceleration", function() {
   var id;
+  var ACCEPTABLE_PERCENT_RANGE = 95;
--- End diff --

Plz, Move this variable to within spec.9 as it's the only test that 
currently uses it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen pull request: Statusbar color

2016-05-05 Thread omefire

Github user omefire commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-splashscreen/pull/102#discussion_r62209585
  
--- Diff: src/android/SplashScreen.java ---
@@ -300,6 +304,23 @@ public void run() {
 
 // Create and show the dialog
 splashDialog = new Dialog(context, 
android.R.style.Theme_Translucent_NoTitleBar);
+
+if (Build.VERSION.SDK_INT >= 21)
+{
+Window window = splashDialog.getWindow();
+
+window.clearFlags(0x0400);
--- End diff --

It'd be great to add comments as to what flags are being cleared and set.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: Telemetry

2016-05-02 Thread omefire

GitHub user omefire opened a pull request:

https://github.com/apache/cordova-cli/pull/247

Telemetry

Work In Progress...

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/omefire/cordova-cli Telemetry

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-cli/pull/247.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #247


commit d139503abe1f7f9a7d5aad579756e4c8a3cc157a
Author: Omar Mefire <omef...@gmail.com>
Date:   2016-04-29T19:05:40Z

telemetry util

commit 3a9ab1576efc478b5d19d8cf3a2df3b6b8be4c04
Author: Omar Mefire <omef...@gmail.com>
Date:   2016-04-29T19:06:02Z

Telemetry Approach 1

commit 325502f64358e45415fcc0f2c94c350a7ac765eb
Author: Omar Mefire <omef...@gmail.com>
Date:   2016-05-01T21:09:53Z

Telemetry: Approach 2

commit 4221bcc885092d66f5f9aa14b5f947723efb5f1b
Author: Omar Mefire <omef...@gmail.com>
Date:   2016-05-02T19:08:30Z

Telemetry: Cleanup




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-medic pull request: CB-11168: Fix the appName in cordova-m...

2016-04-28 Thread omefire

Github user omefire commented on the pull request:

https://github.com/apache/cordova-medic/pull/101#issuecomment-215512291
  
Merging this without the suggested variable name changes, as we'll be 
moving away from cordova-medic soon anyway.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-medic pull request: CB-11168: Fix the appName in cordova-m...

2016-04-28 Thread omefire

Github user omefire commented on the pull request:

https://github.com/apache/cordova-medic/pull/101#issuecomment-215503182
  
@sarangan12 a quick search through the repo yields only 4 files with less 
than 10 instances that would need to be updated. 
I think it is worth the effort, :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-medic pull request: CB-11168: Fix the appName in cordova-m...

2016-04-28 Thread omefire

Github user omefire commented on the pull request:

https://github.com/apache/cordova-medic/pull/101#issuecomment-215501596
  
Hmm, we've got a case of confusing naming here. I think we should rename 
```argv.app``` to ```argv.appName```. That will make the intent clearer and 
prevent such mistakes in the future.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-medic pull request: CB-11135 If folder is pre-existent, do...

2016-04-21 Thread omefire

GitHub user omefire opened a pull request:

https://github.com/apache/cordova-medic/pull/98

CB-11135 If folder is pre-existent, don't error out



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/omefire/cordova-medic CB-11135

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-medic/pull/98.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #98


commit 8be0f93abd9342c18b0155c4066cb4f62779c7a9
Author: Omar Mefire <omef...@gmail.com>
Date:   2016-04-21T21:05:52Z

CB-11135 iOS Contacts Perms: Handle case where 'cordova-cli' install not 
global

commit 67e9b519986a3c853aa7d6b5d80a3f413c00d13a
Author: Omar Mefire <omef...@gmail.com>
Date:   2016-04-22T01:53:39Z

CB-11135 If folder is pre-existent, don't error out




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-medic pull request: CB-11135 iOS Contacts Perms: Handle ca...

2016-04-21 Thread omefire

Github user omefire commented on a diff in the pull request:

https://github.com/apache/cordova-medic/pull/96#discussion_r60666920
  
--- Diff: lib/util.js ---
@@ -81,8 +92,8 @@ module.exports = (function() {
 return numDevices;
 }
 
-function getSimId() {
-var findSimCommand = "cordova run --list --emulator | grep ^iPhone 
| tail -n1";
+function getSimId(localCLI) {
--- End diff --

sure, we could do that too


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-medic pull request: CB-10475 (cordova-plugin-contacts) Gra...

2016-04-21 Thread omefire

Github user omefire commented on the pull request:

https://github.com/apache/cordova-medic/pull/94#issuecomment-213118959
  
Related PR: https://github.com/apache/cordova-medic/pull/96


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-medic pull request: CB-11135 iOS Contacts Perms: Handle ca...

2016-04-21 Thread omefire

GitHub user omefire opened a pull request:

https://github.com/apache/cordova-medic/pull/96

CB-11135 iOS Contacts Perms: Handle case where 'cordova-cli' install â¦

â¦not global

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/omefire/cordova-medic CB-11135

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-medic/pull/96.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #96






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-test-framework pull request: CB-11124 Fixing cordov...

2016-04-20 Thread omefire

Github user omefire commented on the pull request:


https://github.com/apache/cordova-plugin-test-framework/pull/20#issuecomment-212679043
  
LGTM!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-medic pull request: CB-10475 (cordova-plugin-contacts) Gra...

2016-04-20 Thread omefire

Github user omefire commented on the pull request:

https://github.com/apache/cordova-medic/pull/94#issuecomment-212592382
  
Rebased on top of master and ready to be merged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-paramedic pull request: Code changes for Collecting Device...

2016-04-20 Thread omefire

Github user omefire commented on a diff in the pull request:

https://github.com/apache/cordova-paramedic/pull/4#discussion_r60480780
  
--- Diff: lib/utils/utilities.js ---
@@ -0,0 +1,123 @@
+#!/usr/bin/env node
+
+var shelljs = require('shelljs');
+var verbose = undefined;
+var fs  = require('fs');
+var os  = require("os");
+var util= require('util');
+var path= require("path-extra");
+var logger  = require('cordova-common').CordovaLogger.get();
+
+var HEADING_LINE_PATTERN = /List of devices/m;
+var DEVICE_ROW_PATTERN   = /(emulator|device|host)/m;
+
+function isWindows () {
+return /^win/.test(os.platform());
+}
+
+function countAndroidDevices() {
+var listCommand = "adb devices";
+
+logger.info("running:");
+logger.info("" + listCommand);
+
+var numDevices = 0;
+var result = shelljs.exec(listCommand, {silent: false, async: false});
+result.output.split('\n').forEach(function (line) {
+if (!HEADING_LINE_PATTERN.test(line) && 
DEVICE_ROW_PATTERN.test(line)) {
+numDevices += 1;
+}
+});
+return numDevices;
+}
+
+function secToMin (seconds) {
+return Math.ceil(seconds / 60);
+}
+
+function getSimulatorsFolder() {
+var simulatorsFolderPath = path.join(path.homedir(), "Library", 
"Developer", "CoreSimulator", "Devices");
+return simulatorsFolderPath;
+}
+
+function getSimId() {
+var findSimCommand = "cordova run --list --emulator | grep ^iPhone | 
tail -n1";
+
+logger.info("running:");
+logger.info("" + findSimCommand);
+
+var findSimResult = shelljs.exec(findSimCommand, {silent: true, async: 
false});
+
+if (findSimResult.code > 0) {
+logger.error("Failed to find simulator we deployed to");
+return;
+}
+
+var split = findSimResult.output.split(", ");
+
+// Format of the output is "iPhone-6s-Plus, 9.1"
+// Extract the device name and the version number
+var device = split[0].replace(/-/g, " ").trim();
+var version = split[1].trim();
+
+// Next, figure out the ID of the simulator we found
+var instrCommand = "instruments -s devices | grep ^iPhone";
+logger.info("running:");
+logger.info("" + instrCommand);
+
+var instrResult = shelljs.exec(instrCommand, {silent: true, async: 
false});
+
+if (instrResult.code > 0) {
+logger.error("Failed to get the list of simulators");
+return;
+}
+
+// This matches  () []
+var simIdRegex = /^([a-zA-Z\d ]+) \(([\d.]+)\) \[([a-zA-Z\d\-]*)\]$/;
+
+var simId = null;
+var lines = instrResult.output.split(/\n/);
+lines.forEach(function(line) {
+var simIdMatch = simIdRegex.exec(line);
+if (simIdMatch && simIdMatch.length === 4 && simIdMatch[1] === 
device && simIdMatch[2] === version) {
+simId = encodeURIComponent(simIdMatch[3]);
+}
+});
+
+return simId;
+}
--- End diff --

So, turns out this regex breaks in Xcode 7.3, because of the 
```(Simulator)``` added at the end, I still think this code is too fragile as 
it depends on specific Xcode output, which might change in the future. Maybe, 
we should go back to searching through all folders like before ? 

In the meantime, reajusting the regex to ```var simIdRegex = /^([a-zA-Z\d 
]+) \(([\d.]+)\) \[([a-zA-Z\d\-]*)\].*$/;``` fixes this issue.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-paramedic pull request: Code changes for Collecting Device...

2016-04-20 Thread omefire

Github user omefire commented on a diff in the pull request:

https://github.com/apache/cordova-paramedic/pull/4#discussion_r60472155
  
--- Diff: lib/utils/utilities.js ---
@@ -0,0 +1,123 @@
+#!/usr/bin/env node
+
+var shelljs = require('shelljs');
+var verbose = undefined;
+var fs  = require('fs');
+var os  = require("os");
+var util= require('util');
+var path= require("path-extra");
+var logger  = require('cordova-common').CordovaLogger.get();
+
+var HEADING_LINE_PATTERN = /List of devices/m;
+var DEVICE_ROW_PATTERN   = /(emulator|device|host)/m;
+
+function isWindows () {
+return /^win/.test(os.platform());
+}
+
+function countAndroidDevices() {
+var listCommand = "adb devices";
+
+logger.info("running:");
+logger.info("" + listCommand);
+
+var numDevices = 0;
+var result = shelljs.exec(listCommand, {silent: false, async: false});
+result.output.split('\n').forEach(function (line) {
+if (!HEADING_LINE_PATTERN.test(line) && 
DEVICE_ROW_PATTERN.test(line)) {
+numDevices += 1;
+}
+});
+return numDevices;
+}
+
+function secToMin (seconds) {
+return Math.ceil(seconds / 60);
+}
+
+function getSimulatorsFolder() {
+var simulatorsFolderPath = path.join(path.homedir(), "Library", 
"Developer", "CoreSimulator", "Devices");
+return simulatorsFolderPath;
+}
+
+function getSimId() {
+var findSimCommand = "cordova run --list --emulator | grep ^iPhone | 
tail -n1";
+
+logger.info("running:");
+logger.info("" + findSimCommand);
+
+var findSimResult = shelljs.exec(findSimCommand, {silent: true, async: 
false});
+
+if (findSimResult.code > 0) {
+logger.error("Failed to find simulator we deployed to");
+return;
+}
+
+var split = findSimResult.output.split(", ");
+
+// Format of the output is "iPhone-6s-Plus, 9.1"
+// Extract the device name and the version number
+var device = split[0].replace(/-/g, " ").trim();
+var version = split[1].trim();
+
+// Next, figure out the ID of the simulator we found
+var instrCommand = "instruments -s devices | grep ^iPhone";
+logger.info("running:");
+logger.info("" + instrCommand);
+
+var instrResult = shelljs.exec(instrCommand, {silent: true, async: 
false});
+
+if (instrResult.code > 0) {
+logger.error("Failed to get the list of simulators");
+return;
+}
+
+// This matches  () []
+var simIdRegex = /^([a-zA-Z\d ]+) \(([\d.]+)\) \[([a-zA-Z\d\-]*)\]$/;
+
+var simId = null;
+var lines = instrResult.output.split(/\n/);
+lines.forEach(function(line) {
+var simIdMatch = simIdRegex.exec(line);
+if (simIdMatch && simIdMatch.length === 4 && simIdMatch[1] === 
device && simIdMatch[2] === version) {
+simId = encodeURIComponent(simIdMatch[3]);
+}
+});
+
+return simId;
+}
--- End diff --

So, running this code, I face an issue where the simId returned is null.
Here's the output of various bash commands executed here:
- 
```
nstruments -s devices | grep ^iPhone
iPhone 4s (9.3) [93EC91E3-2679-49DC-AC6B-CAB279E462AF] (Simulator)
iPhone 5 (9.3) [830AC555-1986-4B48-82C7-898849A50541] (Simulator)
iPhone 5s (9.3) [17726EFF-F3B9-435E-8882-CC6ED589C213] (Simulator)
iPhone 6 (9.3) [3BDE39CD-7998-4959-B2D8-7C08C33B20B1] (Simulator)
iPhone 6 Plus (9.3) [7235ADB5-8730-4D0A-821F-5469D1ED47D7] (Simulator)
iPhone 6s (9.3) [32745196-42F6-4927-ADA0-16BACE15FC99] (Simulator)
iPhone 6s (9.3) + Apple Watch - 38mm (2.2) 
[6A868DF2-F36A-4AEE-9EC1-B956375934B9] (Simulator)
iPhone 6s Plus (9.3) [A949CB17-350F-4B28-AD64-425339ACEDBF] (Simulator)
iPhone 6s Plus (9.3) + Apple Watch - 42mm (2.2) 
[E0C9BC62-83AA-45C5-B411-FBCB557DE32B] (Simulator)
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-11117: Add FileUpdater module to cord...

2016-04-19 Thread omefire

Github user omefire commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/429#discussion_r60314872
  
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+"use strict";
+
+var fs = require("fs");
+var path = require("path");
+var shell = require("shelljs");
+var minimatch = require("minimatch");
+
+/**
+ * Updates a target file or directory with a source file or directory. 
(Directory updates are
+ * not recursive.) Stats for target and source items must be passed in. 
This is an internal
+ * helper function used by other methods in this module.
+ *
+ * @param {string|null} rootDir Root directory (such as a project) to 
which target and source
+ * path parameters are relative, or null if the paths are absolute. 
The rootDir is omitted
+ * from any logged paths, to make the logs easier to read.
+ * @param {string} targetPath Destination file or directory to be updated. 
If it does not exist,
+ * it will be created.
+ * @param {fs.Stats|null} targetStats An instance of fs.Stats for the 
target path, or null if
+ * the target does not exist.
+ * @param {string|null} sourcePath Source file or directory to be used to 
update the
+ * destination. If the source is null, then the destination is deleted 
if it exists.
+ * @param {fs.Stats|null} sourceStats An instance of fs.Stats for the 
source path, or null if
+ * the source does not exist.
+ * @param {boolean} force If target and source are both files, and the 
force flag is not
+ * set, then the file will not be copied unless the source is newer 
than the target.
+ * @param {function} [log] Optional logging callback that takes a string 
message describing any
+ * file operations that are performed.
+ * @return {boolean} true if any changes were made, or false if the force 
flag is not set
+ * and everything was up to date
+ */
+function updatePathWithStats(
+rootDir, targetPath, targetStats, sourcePath, sourceStats, force, 
log) {
+log = log || function(message) { };
--- End diff --

If no 'log' is specified, we should log to the console.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-medic pull request: CB-10475 (cordova-plugin-contacts) Gra...

2016-04-19 Thread omefire

Github user omefire commented on the pull request:

https://github.com/apache/cordova-medic/pull/94#issuecomment-212074252
  
@sarangan12 could you please review ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-medic pull request: CB-10475 (cordova-plugin-contacts) Gra...

2016-04-19 Thread omefire

Github user omefire commented on the pull request:

https://github.com/apache/cordova-medic/pull/94#issuecomment-212074104
  
This PR ports part of the following paramedic PR to medic:
https://github.com/apache/cordova-paramedic/pull/4


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-medic pull request: CB-10475 (cordova-plugin-contacts) Gra...

2016-04-19 Thread omefire

GitHub user omefire opened a pull request:

https://github.com/apache/cordova-medic/pull/94

CB-10475 (cordova-plugin-contacts) Grant 'Contacts' permissions whileâ¦

â¦ running on iOS simulator

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/omefire/cordova-medic CB-10475

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-medic/pull/94.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #94


commit 9f873ac80e52388faeb24cca6afcc0ba2ac20e29
Author: Omar Mefire <omef...@gmail.com>
Date:   2016-04-19T18:54:25Z

CB-10475 (cordova-plugin-contacts) Grant 'Contacts' permissions while 
running on iOS simulator




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-paramedic pull request: Code changes for Collecting Device...

2016-04-18 Thread omefire

Github user omefire commented on a diff in the pull request:

https://github.com/apache/cordova-paramedic/pull/4#discussion_r60128184
  
--- Diff: lib/ParamedicPermissions.js ---
@@ -0,0 +1,60 @@
+#!/usr/bin/env node
+
+/* jshint node: true */
+var path= require('path');
+var fs  = require('fs');
+var shelljs  = require("shelljs");
+var logger  = require('./utils').logger;
+
+function ParamedicPermissions(appName, simulatorsFolder, dbPath) {
+   this.appName = appName;
+   this.simulatorsFolder = simulatorsFolder;
+   this.dbPath = dbPath;
--- End diff --

nitpick: 'dbPath' -> 'tccDbPath'


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: Protect setVolume call in case ...

2016-04-18 Thread omefire

Github user omefire commented on the pull request:


https://github.com/apache/cordova-plugin-media/pull/93#issuecomment-211529912
  
Should you instead use the ```readyPlayer(...)``` followed by seeking to 
the end of the file in this case ? It seems like a pattern used by 
```startPlaying(...)``` and ```seekToPlaying(...)```.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-paramedic pull request: Code changes for Collecting Device...

2016-04-15 Thread omefire

Github user omefire commented on a diff in the pull request:

https://github.com/apache/cordova-paramedic/pull/4#discussion_r59903675
  
--- Diff: lib/ParamedicLog.js ---
@@ -0,0 +1,154 @@
+#!/usr/bin/env node
+
+/* jshint node: true */
+
+"use strict";
+
+var shelljs  = require("shelljs");
+var fs   = require("fs");
+var path = require("path");
+var util = require('./utils').utilities;
+var logger   = require('./utils').logger;
+
+
+function ParamedicLog(platform, appPath, logPath){
+this.platform = platform;
+this.appPath = appPath;
+this.logPath = logPath;
+}
+
+ParamedicLog.prototype.logIOS = function (appPath) {
+// We need to print out the system log for the simulator app. In order 
to figure
+// out the path to that file, we need to find the ID of the simulator 
running
+// mobilespec
+
+// First, figure out the simulator that ran mobilespec. "cordova run"" 
just chooses
--- End diff --

I find this to be very fragile code because it depends on internal 
implementation details of ```cordova run --list```. Those could well change in 
the future. I think it  might be better to just copy the logic that deals with 
listing the simulators in this project.
What do you think ? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-paramedic pull request: Code changes for Collecting Device...

2016-04-14 Thread omefire

Github user omefire commented on a diff in the pull request:

https://github.com/apache/cordova-paramedic/pull/4#discussion_r59769584
  
--- Diff: lib/ParamedicKill.js ---
@@ -0,0 +1,95 @@
+#!/usr/bin/env node
+
+"use strict";
+
+var shelljs = require("shelljs");
+var util= require("./utils").utilities;
+var logger  = require('./utils').logger;
+
+function ParamedicKill(platform) {
+this.platform = platform;
+}
+
+ParamedicKill.prototype.kill = function() {
+// shell config
+shelljs.config.fatal  = false;
+shelljs.config.silent = false;
+
+// get platform tasks
+var platformTasks = this.tasksOnPlatform(this.platform);
+
+if (platformTasks.length < 1) {
+console.warn("no known tasks to kill");
+}
+
+// kill them
+this.killTasks(platformTasks);
+
+if (this.platform === util.ANDROID) {
+this.killAdbServer();
+}
+
+}
+
+ParamedicKill.prototype.tasksOnPlatform = function (platformName) {
+switch (platformName) {
+case util.WINDOWS:
+return ["WWAHost.exe", "Xde.exe"];
+case util.IOS:
+return ["Simulator"];
+case util.ANDROID:
+if (util.isWindows()) {
+return ["emulator-arm.exe"];
+} else {
+return ["emulator64-x86", "emulator64-arm"];
+}
+break;
--- End diff --

this ```break``` statement will never be reached.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-paramedic pull request: Code changes for Collecting Device...

2016-04-14 Thread omefire

Github user omefire commented on a diff in the pull request:

https://github.com/apache/cordova-paramedic/pull/4#discussion_r59762195
  
--- Diff: lib/ParamedicKill.js ---
@@ -0,0 +1,95 @@
+#!/usr/bin/env node
+
+"use strict";
+
+var shelljs = require("shelljs");
+var util= require("./utils").utilities;
+var logger  = require('./utils').logger;
+
+function ParamedicKill(platform) {
+this.platform = platform;
+}
+
+ParamedicKill.prototype.kill = function() {
+// shell config
+shelljs.config.fatal  = false;
+shelljs.config.silent = false;
+
+// get platform tasks
+var platformTasks = this.tasksOnPlatform(this.platform);
+
+if (platformTasks.length < 1) {
+console.warn("no known tasks to kill");
--- End diff --

in this case, we want to stop processing and bail out of the ```kill``` 
function.
Please, add a ```return``` statement here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-paramedic pull request: Code changes for Collecting Device...

2016-04-14 Thread omefire

Github user omefire commented on a diff in the pull request:

https://github.com/apache/cordova-paramedic/pull/4#discussion_r59762070
  
--- Diff: lib/ParamedicKill.js ---
@@ -0,0 +1,95 @@
+#!/usr/bin/env node
+
+"use strict";
+
+var shelljs = require("shelljs");
+var util= require("./utils").utilities;
+var logger  = require('./utils').logger;
+
+function ParamedicKill(platform) {
+this.platform = platform;
+}
+
+ParamedicKill.prototype.kill = function() {
+// shell config
+shelljs.config.fatal  = false;
+shelljs.config.silent = false;
+
+// get platform tasks
+var platformTasks = this.tasksOnPlatform(this.platform);
+
+if (platformTasks.length < 1) {
+console.warn("no known tasks to kill");
+}
+
+// kill them
+this.killTasks(platformTasks);
+
+if (this.platform === util.ANDROID) {
+this.killAdbServer();
+}
+
+}
+
+ParamedicKill.prototype.tasksOnPlatform = function (platformName) {
+switch (platformName) {
+case util.WINDOWS:
+return ["WWAHost.exe", "Xde.exe"];
+case util.IOS:
+return ["Simulator"];
--- End diff --

consider returning an empty array if none of the platforms match this list.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-11070 Document SplashScreenBackgroun...

2016-04-14 Thread omefire

Github user omefire commented on the pull request:

https://github.com/apache/cordova-docs/pull/578#issuecomment-209993540
  
ACK!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: CB-11042: Add cordova run option to skip...

2016-04-13 Thread omefire

Github user omefire commented on the pull request:

https://github.com/apache/cordova-cli/pull/244#issuecomment-209579313
  
ok, now I get it. apparently, the website content will be generated from 
this readme.md, so we're fine.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: CB-11042: Add cordova run option to skip...

2016-04-13 Thread omefire

Github user omefire commented on the pull request:

https://github.com/apache/cordova-cli/pull/244#issuecomment-209579344
  
LGTM!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: CB-11042: Add cordova run option to skip...

2016-04-13 Thread omefire

Github user omefire commented on the pull request:

https://github.com/apache/cordova-cli/pull/244#issuecomment-209578035
  
@nikhilkh , if that's the case don't we need a JIRA to track updating the 
docs website ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-10873 Avoid crash due to us...

2016-04-13 Thread omefire

Github user omefire commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-camera/pull/205#discussion_r59598321
  
--- Diff: src/ios/CDVCamera.m ---
@@ -358,6 +358,7 @@ - (NSData*)processImage:(UIImage*)image 
info:(NSDictionary*)info options:(CDVPic
 // use image unedited as requested , don't resize
 data = UIImageJPEGRepresentation(image, 1.0);
 } else {
+data = UIImageJPEGRepresentation(image, [options.quality 
floatValue] / 100.0f);
 if (options.usesGeolocation) {
--- End diff --

@jasongin I suspect it might not be correct behavior.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-10873 Avoid crash due to us...

2016-04-13 Thread omefire

Github user omefire commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/205#issuecomment-209575841
  
I agree on an appium test to cover this scenario, but I think it should go 
further than just making sure no crash happens and also validate that the EXIF 
header is correctly written: 
- https://github.com/gomfunkel/node-exif

I have the feeling that code path might not be well tested/exercised.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: CB-11042: Add cordova run option to skip...

2016-04-13 Thread omefire

Github user omefire commented on the pull request:

https://github.com/apache/cordova-cli/pull/244#issuecomment-209572705
  
It's located elsewhere, in the cordova-docs repo: 
https://github.com/apache/cordova-docs/blob/1f35df99b7cf77aa5889c2ecb9a3c3ab71542ee6/www/docs/en/6.x/reference/cordova-cli/index.md


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: CB-11042: Add cordova run option to skip...

2016-04-13 Thread omefire

Github user omefire commented on the pull request:

https://github.com/apache/cordova-cli/pull/244#issuecomment-209564718
  
@jasongin consider also updating the docs: 
http://cordova.apache.org/docs/en/latest/reference/cordova-cli/index.html


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-11042: Add cordova run option to skip...

2016-04-13 Thread omefire

Github user omefire commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/426#discussion_r59592544
  
--- Diff: cordova-lib/src/cordova/run.js ---
@@ -32,8 +32,10 @@ module.exports = function run(options) {
 var hooksRunner = new HooksRunner(projectRoot);
 return hooksRunner.fire('before_run', options)
 .then(function() {
-// Run a prepare first, then shell out to run
-return require('./cordova').raw.prepare(options);
+if (!options.options.noprepare) {
+// Run a prepare first, then shell out to run
+return require('./cordova').raw.prepare(options);
+}
--- End diff --

Please add ```return Q();``` in the alternative code path


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-medic pull request: CB-10898 Kill simulator Xcode6 style

2016-04-12 Thread omefire

GitHub user omefire opened a pull request:

https://github.com/apache/cordova-medic/pull/88

CB-10898 Kill simulator Xcode6 style



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/omefire/cordova-medic CB-10898

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-medic/pull/88.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #88


commit 5694808d6ba42c3124664720004c8226aa66729f
Author: Omar Mefire <omef...@gmail.com>
Date:   2016-04-13T01:04:26Z

CB-10898 Kill simulator Xcode6 style




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-medic pull request: CB-10898 Kill iOS Simulator, Xcode7 st...

2016-04-12 Thread omefire

Github user omefire commented on the pull request:

https://github.com/apache/cordova-medic/pull/86#issuecomment-209170685
  
@dblotsky yeah, might be a good idea to add both, since the former string 
handles Xcode 6 if someone were to be still using it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-10873 Avoid crash due to us...

2016-04-12 Thread omefire

Github user omefire commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/205#issuecomment-209169845
  
For more details, see: https://issues.apache.org/jira/browse/CB-10873


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-10873 Avoid crash due to us...

2016-04-12 Thread omefire

Github user omefire commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/205#issuecomment-209168919
  
What happens is that when trying to write the image source, we do it with a 
null/nil variable ```self.data```:

https://github.com/omefire/cordova-plugin-camera/blob/CB-10873/src/ios/CDVCamera.m#L669-L671


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-10873 Avoid crash due to us...

2016-04-12 Thread omefire

GitHub user omefire opened a pull request:

https://github.com/apache/cordova-plugin-camera/pull/205

CB-10873 Avoid crash due to usage of uninitialized variable when writâ¦

â¦ing geolocation data to image destination

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/omefire/cordova-plugin-camera CB-10873

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-camera/pull/205.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #205


commit f16dbff7138bc235615c5539ae7e5f8e0968e681
Author: Omar Mefire <omef...@gmail.com>
Date:   2016-04-13T00:46:42Z

CB-10873 Avoid crash due to usage of uninitialized variable when writing 
geolocation data to image destination




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request: CB-10957 Remove build-*.xcconfig files f...

2016-04-12 Thread omefire

Github user omefire commented on the pull request:

https://github.com/apache/cordova-ios/pull/214#issuecomment-209017316
  
@shazron I'm merging this in. I've addressed your CR notes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-medic pull request: CB-10898 Kill iOS Simulator, Xcode7 st...

2016-04-12 Thread omefire

GitHub user omefire opened a pull request:

https://github.com/apache/cordova-medic/pull/86

CB-10898 Kill iOS Simulator, Xcode7 style

With Xcode7, the way to kill the simulator is now by running: "killall -9 
Simulator"

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/omefire/cordova-medic CB-10898

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-medic/pull/86.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #86


commit 7bd4a4fe45b0c05cc84329d7e5462f558eeeb214
Author: Omar Mefire <omef...@gmail.com>
Date:   2016-04-12T17:13:03Z

CB-10898 Kill iOS Simulator, Xcode7 style
 With Xcode7, the way to kill the simulator is now by running: 
"killall -9 Simulator"




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

1 2 3 4 5 6 7 >

1 - 100 of 605 matches

Mail list logo