[GitHub] cordova-lib pull request #589: removed .jscs.json
Github user remcohaszing closed the pull request at: https://github.com/apache/cordova-lib/pull/589 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request #589: removed .jscs.json
GitHub user remcohaszing opened a pull request: https://github.com/apache/cordova-lib/pull/589 removed .jscs.json ### Platforms affected none ### What does this PR do? Cleanup an unused file. ### What testing has been done on this change? None ### Checklist - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/remcohaszing/cordova-lib remove-jscs.json Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/589.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #589 commit 2539bfeb4f9ae4b2f27383e30f0d6277b11918af Author: Remco Haszing <remcohasz...@gmail.com> Date: 2017-08-07T20:50:50Z removed .jscs.json It is no longer used --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib issue #558: CB-12766 Consistently write JSON with 2 spaces inden...
Github user remcohaszing commented on the issue: https://github.com/apache/cordova-lib/pull/558 @piotrowski I did a regex replace to replace all occurrences of `JSON.stringify`, so basically this affects all JSON files that are modified by Cordova. I think this is a pretty complete list of the files affected: - *.cordova/config.json* - *plugins/fetch.json* - *plugins/[platform].json* - *package.json* --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request #558: CB-12766 Consistently write JSON with 2 space...
GitHub user remcohaszing opened a pull request: https://github.com/apache/cordova-lib/pull/558 CB-12766 Consistently write JSON with 2 spaces indentation ### Platforms affected None really. ### What does this PR do? JSON was written with 4 spaces indentation and even a tab at some point. Most NodeJS tools write their JSON configuration with an indentation of 2 spaces. Most notably npm does this, which writes to package.json, as does Cordova. This caused unnecessary changes in package.json. ### What testing has been done on this change? None, this is mostly stylistic. ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [x] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/remcohaszing/cordova-lib master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/558.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #558 commit 7431e36fee775f0383ad3c3dae396a2a95c4bc05 Author: Remco Haszing <remcohasz...@gmail.com> Date: 2017-05-16T07:58:54Z CB-12766 Consistently write JSON with 2 spaces indentation JSON was written with 4 spaces indentation and even a tab at some point. Most NodeJS tools write their JSON configuration with an indentation of 2 spaces. Most notably npm does this, which writes to package.json, as does Cordova. This caused unnecessary changes in package.json. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
