[GitHub] cordova-plugin-inappbrowser pull request: CB-9158 - InAppBrowser z...
Github user syndbg commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/104#issuecomment-113228209 Alright. Sorry for the delays guys. Rebased latest upstream master, didn't commit the iOS file and updated the commit message to make more sense. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: CB-9158 - InAppBrowser z...
Github user syndbg commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/104#issuecomment-112974072 @purplecabbage Good catch. In the JIRA ticket, unfortunately I've pasted the wrong option parameter, `location`, when in fact I meant `zoom`. This PR fixes `zoom=true` or `zoom=false` not making a difference in the android app. Can we agree on the fact that fixing (in my opinion) non-formatted code, even in the iOS section of the plugin, should not be a blocker to merge this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: CB-9158 - InAppBrowser z...
Github user syndbg commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/104#issuecomment-112385310 The white spaces are automatically stripped by my text editor. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: CB-9158 - InAppBrowser z...
Github user syndbg commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/104#discussion_r32199198
--- Diff: src/android/InAppBrowser.java ---
@@ -656,7 +647,7 @@ public void onClick(View v) {
WebSettings settings = inAppWebView.getSettings();
settings.setJavaScriptEnabled(true);
settings.setJavaScriptCanOpenWindowsAutomatically(true);
-settings.setBuiltInZoomControls(getShowZoomControls());
+settings.setBuiltInZoomControls(showZoomControls);
--- End diff --
here's the issue
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: [] Fix zoom option not r...
GitHub user syndbg opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/104 [] Fix zoom option not respected on Android. Also minor whitespaces fixes. You can merge this pull request into a Git repository by running: $ git pull https://github.com/syndbg/cordova-plugin-inappbrowser master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-inappbrowser/pull/104.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #104 commit fe0dcc5f2e7a5c046f5c6a9a3e5e39471b0a4592 Author: aantonov Date: 2015-06-11T08:23:45Z Fix zoom option not respected on Android. Also minor whitespaces fixes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: CB-3750: Add loading spi...
Github user syndbg commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/89#issuecomment-99841604 I suggest that this is a bit more flexible. Don't force the color and spinner to be always visible. Instead introduce two options ex. `spinnerColor` and `spinnerHidden` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
