Re: [Android] Framework Fixes POC - Adding ability for Plugins to be written as Android Library Modules

2016-07-18 Thread julio cesar sanchez 
Looks good to me

2016-07-19 0:17 GMT+02:00 Joe Bowser :

> Hey
>
> I recently got around the brittleness with the framework_fixes branch of
> cordova-android adding modules by reading in the module's gradle file and
> checking for the dependency.  It slows down plugin installation, but since
> the GradleBuilder.js is super simple, I really don't think there's a better
> way to do this without re-engineering the builders.
>
> The branches are here:
> https://github.com/infil00p/cordova-android/tree/framework_fixes
>
> And for the plugin:
> https://github.com/infil00p/cordova-plugin-inappbrowser/tree/aar_poc
>
> The framework_fixes branch works with old plugins and it would be good to
> be able to add this functionality into the 6.0.x version of
> Cordova-Android.  However, if people can find a better way of handling this
> issue, I'm open to that as well.
>
> Joe
>

[Android] Framework Fixes POC - Adding ability for Plugins to be written as Android Library Modules

2016-07-18 Thread Joe Bowser 
Hey

I recently got around the brittleness with the framework_fixes branch of
cordova-android adding modules by reading in the module's gradle file and
checking for the dependency.  It slows down plugin installation, but since
the GradleBuilder.js is super simple, I really don't think there's a better
way to do this without re-engineering the builders.

The branches are here:
https://github.com/infil00p/cordova-android/tree/framework_fixes

And for the plugin:
https://github.com/infil00p/cordova-plugin-inappbrowser/tree/aar_poc

The framework_fixes branch works with old plugins and it would be good to
be able to add this functionality into the 6.0.x version of
Cordova-Android.  However, if people can find a better way of handling this
issue, I'm open to that as well.

Joe