[GitHub] cordova-android issue #339: CB-11964: Do a clean when installing a plugin to...
Github user alsorokin commented on the issue: https://github.com/apache/cordova-android/pull/339 Tested it on Windows, it works! LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #339: CB-11964: Do a clean when installing a plugin to...
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/339 @alsorokin I'm going to keep the commits exploded and as is on this PR. If this looks good to you, I'll merge this in tonight. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #339: CB-11964: Do a clean when installing a plugin to...
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/339 I'm not getting the same errors locally when I run the same tests, could this be a weird travis timeout issue? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #339: CB-11964: Do a clean when installing a plugin to...
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/339 OK, there's something wrong with how we're cleaning in the chain. I think we need to do it later in the promise chain. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #339: CB-11964: Do a clean when installing a plugin to...
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/339 Moving the example into core, tested it locally, everything appears to check out on MacOS. Hopefully there's no weird Windows issues. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #339: CB-11964: Do a clean when installing a plugin to...
Github user codecov-io commented on the issue: https://github.com/apache/cordova-android/pull/339 ## [Current coverage](https://codecov.io/gh/apache/cordova-android/pull/339?src=pr) is 34.85% (diff: 45.45%) > Merging [#339](https://codecov.io/gh/apache/cordova-android/pull/339?src=pr) into [master](https://codecov.io/gh/apache/cordova-android/branch/master?src=pr) will decrease coverage by **0.30%** ```diff @@ master #339 diff @@ == Files12 13 +1 Lines 1007 1142 +135 Methods 198219+21 Messages 0 0 Branches168186+18 == + Hits354398+44 - Misses 653744+91 Partials 0 0 ``` > Powered by [Codecov](https://codecov.io?src=pr). Last update [37384c5...333b30f](https://codecov.io/gh/apache/cordova-android/compare/37384c583d5a2e5b9b5c5d2cbf150f07f329d16c...333b30f3961fc269cda064c7f8ff3812fdc4a9ca?src=pr) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #339: CB-11964: Do a clean when installing a plugin to...
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/339 OK, so, WTF was that? It appears that we have a test suite problem. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
