[GitHub] cordova-android issue #340: CB-8722 - Move app icons from drawable to mipmap
Github user dpogue commented on the issue: https://github.com/apache/cordova-android/pull/340 That is a known issue with cordova-android@6.0.0, unrelated to this change. It has been fixed in master, and will be included in cordova-android@6.1.0 which is due to be released this week or next. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #340: CB-8722 - Move app icons from drawable to mipmap
Github user ghenry22 commented on the issue: https://github.com/apache/cordova-android/pull/340 I have the same problem, after upgrading the platform I now get default cordova icons for my android build, even though with the previous version of the platform all icons and splash screen images were in place and all specified in config.xml. I use ionic framework to auto generate all splash / icon images and insert them into the config.xml --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #340: CB-8722 - Move app icons from drawable to mipmap
Github user AxelNennker commented on the issue: https://github.com/apache/cordova-android/pull/340 Does not work for me. Steps to reproduce are in the CB-8722 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #340: CB-8722 - Move app icons from drawable to mipmap
Github user codecov-io commented on the issue: https://github.com/apache/cordova-android/pull/340 ## [Current coverage](https://codecov.io/gh/apache/cordova-android/pull/340?src=pr) is 35.15% (diff: 100%) > Merging [#340](https://codecov.io/gh/apache/cordova-android/pull/340?src=pr) into [master](https://codecov.io/gh/apache/cordova-android/branch/master?src=pr) will not change coverage ```diff @@ master #340 diff @@ == Files12 12 Lines 1007 1007 Methods 198198 Messages 0 0 Branches168168 == Hits354354 Misses 653653 Partials 0 0 ``` > Powered by [Codecov](https://codecov.io?src=pr). Last update [37384c5...9785501](https://codecov.io/gh/apache/cordova-android/compare/37384c583d5a2e5b9b5c5d2cbf150f07f329d16c...97855018e9aeb955f3dd7e31c91fb6b8f67e0c29?src=pr) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #340: CB-8722 - Move app icons from drawable to mipmap
Github user dpogue commented on the issue: https://github.com/apache/cordova-android/pull/340 If they were specifying icons via config.xml, this should just work. If they had the platform already installed and had modified files, this shouldn't affect those existing files. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #340: CB-8722 - Move app icons from drawable to mipmap
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/340 If someone knew nothing about Android, and they just fiddled with their icons, would this change, or would we have to delete their old drawable for this to work? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
