[GitHub] cordova-android pull request: CB-8382 Make CordovaActivity not imp...

2015-02-25 Thread agrieve
Github user agrieve closed the pull request at:

https://github.com/apache/cordova-android/pull/152


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-android pull request: CB-8382 Make CordovaActivity not imp...

2015-01-29 Thread agrieve
GitHub user agrieve opened a pull request:

https://github.com/apache/cordova-android/pull/152

CB-8382 Make CordovaActivity not implement CordovaInterface

Instead, use a CordovaInterfaceImpl class. This also makes it easier
for apps to implement the interface without extending CordovaActivity.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/agrieve/cordova-android cordova-interface

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-android/pull/152.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #152


commit e27fd72d52b136d820e1e07c86fdcc5cdbf197ad
Author: Andrew Grieve 
Date:   2015-01-30T01:42:44Z

CB-8382 Make CordovaActivity not implement CordovaInterface

Instead, use a CordovaInterfaceImpl class. This also makes it easier
for apps to implement the interface without extending CordovaActivity.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org