[GitHub] cordova-android pull request: Make JUnit tests to test pluggable w...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/140 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: Make JUnit tests to test pluggable w...
Github user fujunwei commented on the pull request: https://github.com/apache/cordova-android/pull/140#issuecomment-70243782 ping @clelland PTAL, Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: Make JUnit tests to test pluggable w...
Github user fujunwei commented on the pull request: https://github.com/apache/cordova-android/pull/140#issuecomment-69277448 ping @clelland Could you please help me review this PR? Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: Make JUnit tests to test pluggable w...
Github user fujunwei commented on the pull request: https://github.com/apache/cordova-android/pull/140#issuecomment-67446387 Could someone help me to review this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: Make JUnit tests to test pluggable w...
GitHub user fujunwei opened a pull request: https://github.com/apache/cordova-android/pull/140 Make JUnit tests to test pluggable webview The JUnit tests can only test Android webView now, the XWalk is a pluggable webView, we want to reuse the tests to test the pluggable webView after install cordova-crosswalk-engine plugin. You can merge this pull request into a Git repository by running: $ git pull https://github.com/fujunwei/cordova-android pluggable_test Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-android/pull/140.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #140 commit aee0822dec701417df22e0af366326a25ccf82df Author: fujunwei junwei...@intel.com Date: 2014-12-17T01:13:43Z Make JUnit tests to test pluggable webview The JUnit tests can only test Android webView now, the XWalk is a pluggable webView, we want to reuse the tests to test the pluggable webView after install cordova-crosswalk-engine plugin. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: Make JUnit tests to test pluggable w...
Github user huningxin commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/140#discussion_r21949451
--- Diff: test/src/org/apache/cordova/test/SabotagedActivity.java ---
@@ -33,10 +34,9 @@ Licensed to the Apache Software Foundation (ASF) under
one
import android.util.Log;
public class SabotagedActivity extends CordovaActivity {
-
--- End diff --
no necessary removal.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: Make JUnit tests to test pluggable w...
Github user huningxin commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/140#discussion_r21949465
--- Diff: test/src/org/apache/cordova/test/backgroundcolor.java ---
@@ -33,5 +33,4 @@ public void onCreate(Bundle savedInstanceState) {
super.loadUrl(file:///android_asset/www/backgroundcolor/index.html);
}
-
--- End diff --
no necessary line removing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: Make JUnit tests to test pluggable w...
Github user huningxin commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/140#discussion_r21949468
--- Diff: test/src/org/apache/cordova/test/errorurl.java ---
@@ -22,12 +22,14 @@ Licensed to the Apache Software Foundation (ASF) under
one
import org.apache.cordova.*;
public class errorurl extends CordovaActivity {
+public CordovaWebView cordovaWebView;
+
@Override
public void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
preferences.set(errorUrl,
file:///android_asset/www/htmlnotfound/error.html);
super.loadUrl(file:///android_asset/www/htmlnotfound/index.html);
+
+cordovaWebView = this.appView;
}
-
-
}
--- End diff --
ditto.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: Make JUnit tests to test pluggable w...
Github user huningxin commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/140#discussion_r21949530
--- Diff: test/src/org/apache/cordova/test/splashscreen.java ---
@@ -30,6 +32,8 @@ public void onCreate(Bundle savedInstanceState) {
// Show splashscreen
preferences.set(splashscreen, sandy);
-super.loadUrl(file:///android_asset/www/splashscreen/index.html,
2000);
+super.loadUrl(file:///android_asset/www/splashscreen/index.html);
--- End diff --
why remove the 2000 timeout?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
