[GitHub] cordova-cli pull request: CB-10748 Use cordova-common.CordovaLogge...

[daserge]

Github user daserge commented on the pull request:

https://github.com/apache/cordova-cli/pull/235#issuecomment-193655233
  
@nikhilkh 

> Are there still some test failures?
No, tests should be green now.

> Could you also add the travis badge for cordova-cli? 
Sure, will do.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: CB-10748 Use cordova-common.CordovaLogge...

[nikhilkh]

Github user nikhilkh commented on the pull request:

https://github.com/apache/cordova-cli/pull/235#issuecomment-192373606
  
Are there still some test failures? @daserge Could you also add the travis 
badge for cordova-cli


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: CB-10748 Use cordova-common.CordovaLogge...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-cli/pull/235


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: CB-10748 Use cordova-common.CordovaLogge...

[daserge]

Github user daserge commented on the pull request:

https://github.com/apache/cordova-cli/pull/235#issuecomment-192122950
  
@nikhilkh, I'm investigating it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: CB-10748 Use cordova-common.CordovaLogge...

[nikhilkh]

Github user nikhilkh commented on the pull request:

https://github.com/apache/cordova-cli/pull/235#issuecomment-192109284
  
What about the Travis CI failures?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: CB-10748 Use cordova-common.CordovaLogge...

[vladimir-kotikov]

Github user vladimir-kotikov commented on the pull request:

https://github.com/apache/cordova-cli/pull/235#issuecomment-190716715
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: CB-10748 Use cordova-common.CordovaLogge...

[daserge]

GitHub user daserge opened a pull request:

https://github.com/apache/cordova-cli/pull/235

CB-10748 Use cordova-common.CordovaLogger in CLI

[Jira issue](https://issues.apache.org/jira/browse/CB-10748)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-cli CB-10748

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-cli/pull/235.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #235


commit d333c1f5c5488012bdcee885fa83c0dfd83c37ad
Author: daserge 
Date:   2016-03-01T12:32:22Z

CB-10748 Use cordova-common.CordovaLogger in CLI




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org