[GitHub] cordova-cli pull request: Print stack trace when possible on `prep...

2014-03-12 Thread alFReD-NSH
Github user alFReD-NSH commented on the pull request:

https://github.com/apache/cordova-cli/pull/139#issuecomment-37489892
  
Yes, I wanted to mention it's better to crash the process with a non-zero 
code, but I forgot :P


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cordova-cli pull request: Print stack trace when possible on `prep...

2014-03-12 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-cli/pull/139


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cordova-cli pull request: Print stack trace when possible on `prep...

2014-03-12 Thread agrieve
Github user agrieve commented on the pull request:

https://github.com/apache/cordova-cli/pull/139#issuecomment-37418719
  
Thanks for tracking this down. I think a better fix is to just delete the 
fail() clause. I tested that doing so shows the stacktrace, and so have gone 
with that instead.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cordova-cli pull request: Print stack trace when possible on `prep...

2014-03-12 Thread alFReD-NSH
GitHub user alFReD-NSH opened a pull request:

https://github.com/apache/cordova-cli/pull/139

Print stack trace when possible on `prepare` error



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/alFReD-NSH/cordova-cli stack-trace

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-cli/pull/139.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #139


commit 7d9ca083bfb3f5564329398258b34b745e79721f
Author: Farid Neshat 
Date:   2014-03-12T16:00:54Z

Print stack trace when possible on `prepare` error




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---