[GitHub] cordova-docs pull request: Fixing consistency and grammatical erro...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/346 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Fixing consistency and grammatical erro...
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/346#issuecomment-140504901 My thoughts: - I think we're referring to Terminal.app on OS X, which is capitalized. - Yep, the second "to create ..." is redundant and I'll remove it. - I think we can remove that sentence; the previous point already gives the examples. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Fixing consistency and grammatical erro...
GitHub user riknoll opened a pull request: https://github.com/apache/cordova-docs/pull/346 Fixing consistency and grammatical errors on front page Other possible improvements: * In the first bullet, is "Terminal" capitalized for a reason? * In the second bullet, "Create a Cordova project using the command-line tool to create a blank project" is redundant * In the fourth bullet, "You can replace browser with the platform that you would like to run (e.g. ios, android, windows)" seems unnecessary (and if it is necessary, should also be mentioned in the preceding bullet) You can merge this pull request into a Git repository by running: $ git pull https://github.com/riknoll/cordova-docs cordova-website-grammar Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-docs/pull/346.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #346 commit 362666ad9e88162faa64a50aa3311c83dc8ab714 Author: riknoll Date: 2015-09-15T16:46:53Z Fixing consistency and grammatical errors on front page --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
