[GitHub] cordova-docs pull request: Making windows guide single page
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/512#discussion_r53843979
--- Diff: www/_data/redirects.yml ---
@@ -13,6 +13,8 @@ docs:
- {old: "dev/guide/platforms/ios/config.html", new:
"dev/config_ref/index.html"}
- {old: "latest/guide/platforms/ios/tools.html", new:
"latest/guide/platforms/ios/index.html"}
- {old: "latest/guide/platforms/ios/config.html", new:
"latest/config_ref/index.html"}
+- {old: "dev/guide/platforms/win8/packaging.html", new:
"dev/guide/platforms/win8/index.html#signing-an-app"}
+- {old: "dev/guide/platforms/win8/win10-support.html", new:
"dev/guide/platforms/win8/index.html"}
--- End diff --
@rakatyal: @r@riknoll just pointed out to me that adding `/latest/`
redirects before we do the whole `6.x` thing will kill pages in `6.0.0`. Please
then add the `/latest/` redirects commented-out.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Making windows guide single page
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/512#discussion_r53843320
--- Diff: www/_data/redirects.yml ---
@@ -13,6 +13,8 @@ docs:
- {old: "dev/guide/platforms/ios/config.html", new:
"dev/config_ref/index.html"}
- {old: "latest/guide/platforms/ios/tools.html", new:
"latest/guide/platforms/ios/index.html"}
- {old: "latest/guide/platforms/ios/config.html", new:
"latest/config_ref/index.html"}
+- {old: "dev/guide/platforms/win8/packaging.html", new:
"dev/guide/platforms/win8/index.html#signing-an-app"}
+- {old: "dev/guide/platforms/win8/win10-support.html", new:
"dev/guide/platforms/win8/index.html"}
--- End diff --
For what it's worth, you can just add both.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Making windows guide single page
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/512#discussion_r53826023
--- Diff: www/_data/redirects.yml ---
@@ -13,6 +13,8 @@ docs:
- {old: "dev/guide/platforms/ios/config.html", new:
"dev/config_ref/index.html"}
- {old: "latest/guide/platforms/ios/tools.html", new:
"latest/guide/platforms/ios/index.html"}
- {old: "latest/guide/platforms/ios/config.html", new:
"latest/config_ref/index.html"}
+- {old: "dev/guide/platforms/win8/packaging.html", new:
"dev/guide/platforms/win8/index.html#signing-an-app"}
+- {old: "dev/guide/platforms/win8/win10-support.html", new:
"dev/guide/platforms/win8/index.html"}
--- End diff --
Okay. The packaging one has been live since long so I will keep that one.
Win10 support didn't went out so I will change it to latest.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Making windows guide single page
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/512#discussion_r53748270
--- Diff: www/_data/redirects.yml ---
@@ -13,6 +13,8 @@ docs:
- {old: "dev/guide/platforms/ios/config.html", new:
"dev/config_ref/index.html"}
- {old: "latest/guide/platforms/ios/tools.html", new:
"latest/guide/platforms/ios/index.html"}
- {old: "latest/guide/platforms/ios/config.html", new:
"latest/config_ref/index.html"}
+- {old: "dev/guide/platforms/win8/packaging.html", new:
"dev/guide/platforms/win8/index.html#signing-an-app"}
+- {old: "dev/guide/platforms/win8/win10-support.html", new:
"dev/guide/platforms/win8/index.html"}
--- End diff --
Yeah, either published to the site or printed in a blog post. My
understanding is that the current `dev` redirects are there because there was a
blog post about Android stuff that linked to `dev`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Making windows guide single page
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/512#discussion_r53740132
--- Diff: www/_data/redirects.yml ---
@@ -13,6 +13,8 @@ docs:
- {old: "dev/guide/platforms/ios/config.html", new:
"dev/config_ref/index.html"}
- {old: "latest/guide/platforms/ios/tools.html", new:
"latest/guide/platforms/ios/index.html"}
- {old: "latest/guide/platforms/ios/config.html", new:
"latest/config_ref/index.html"}
+- {old: "dev/guide/platforms/win8/packaging.html", new:
"dev/guide/platforms/win8/index.html#signing-an-app"}
+- {old: "dev/guide/platforms/win8/win10-support.html", new:
"dev/guide/platforms/win8/index.html"}
--- End diff --
By went out you mean published to the site?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Making windows guide single page
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/512#discussion_r53735092
--- Diff: www/_data/redirects.yml ---
@@ -13,6 +13,8 @@ docs:
- {old: "dev/guide/platforms/ios/config.html", new:
"dev/config_ref/index.html"}
- {old: "latest/guide/platforms/ios/tools.html", new:
"latest/guide/platforms/ios/index.html"}
- {old: "latest/guide/platforms/ios/config.html", new:
"latest/config_ref/index.html"}
+- {old: "dev/guide/platforms/win8/packaging.html", new:
"dev/guide/platforms/win8/index.html#signing-an-app"}
+- {old: "dev/guide/platforms/win8/win10-support.html", new:
"dev/guide/platforms/win8/index.html"}
--- End diff --
@rakatyal are these redirects for `dev` or `latest`? If the links to `dev`
never went out, then the redirects should be for `latest`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Making windows guide single page
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/512 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Making windows guide single page
Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/512#issuecomment-187428663 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Making windows guide single page
GitHub user rakatyal opened a pull request: https://github.com/apache/cordova-docs/pull/512 Making windows guide single page You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-docs raghav-windows-single Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-docs/pull/512.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #512 commit 757926d3501e927aad19e67aa0b6752dd03ffe79 Author: Raghav Katyal Date: 2016-02-22T22:36:37Z Making windows guide single page --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
