[GitHub] cordova-docs pull request: Snapshotting dev to 6.x
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/603 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Snapshotting dev to 6.x
Github user omefire commented on the pull request: https://github.com/apache/cordova-docs/pull/603#issuecomment-219551255 LGTM! Changes to CLI reference are effectively in this PR. I'm OK with not making any changes related to my earlier comments as those were separate PRs. Thanks for doing this, @rakatyal --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Snapshotting dev to 6.x
Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/603#issuecomment-219550624 LGTM! Checked to make sure all changes were to `.md` files in 6.x and that seems to be the case. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Snapshotting dev to 6.x
Github user rakatyal commented on the pull request: https://github.com/apache/cordova-docs/pull/603#issuecomment-219547791 @omefire: This is just copying current dev to latest version on the docs and hence you only see those changes. The privacy policy changes will take effect when I deploy the site. Also I am not sure I can answer/change your other comments since I didn't make those changes. Asking those in the PRs on the dev branch might be a good idea. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Snapshotting dev to 6.x
Github user omefire commented on the pull request: https://github.com/apache/cordova-docs/pull/603#issuecomment-219526115 However, I don't see the privacy policy changes: ```www/privacy/index.md```: https://github.com/apache/cordova-docs/commit/0d5f185c45f11a46e3dc5b720e23d4b38a40779a --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Snapshotting dev to 6.x
Github user omefire commented on the pull request: https://github.com/apache/cordova-docs/pull/603#issuecomment-219525124 Changes related to telemetry are definitely part of this snapshot. Thanks Raghav! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Snapshotting dev to 6.x
Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/603#discussion_r63411548 --- Diff: www/docs/en/6.x/config_ref/images.md --- @@ -137,15 +140,17 @@ For Windows the recommended approach to define app icons is to use `target` attr ``` -where `source` is the path to the icon which needs to be added. +where `src` is the path to the icon which needs to be added. + +The Windows platform handles MRT icons automatically, so if you specify `src="res/windows/storelogo.png"` the following files will be copied into the application's `images` folder: `res/windows/storelogo.scale-100.png`, `res/windows/storelogo.scale-200.png`, etc. -Please note that Windows platform handles MRT icons automatically, so if you specify `src="res/windows/storelogo.png"` the following files will be copied into app's `images` folder: `res/windows/storelogo.scale-100.png`, `res/windows/storelogo.scale-200.png`, etc. +TODO Define what MRT is. -The `target` attribute specifies the base name for resultant icons. For every icon file destination filename is calculated as `target + '.' + MRT_qualifiers + extension(src)`. For the icons to display properly in resultant app every `target` value should be the one of icon filenames, defined in application's `.appxmanifest` file. +The `target` attribute specifies the base name for the resultant icons. For every icon file, its destination filename is calculated as `target + '.' + MRT_qualifiers + extension(src)`. For the icons to display properly in the application, every `target` value should be one of the icon filenames defined in the application's `.appxmanifest` file. -Summarizing the above, using `target` attribute it is possible to: +Summarizing the above... using the `target` attribute it is possible to: --- End diff -- why '...' instead of ',' ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Snapshotting dev to 6.x
Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/603#discussion_r63411414 --- Diff: www/docs/en/6.x/config_ref/images.md --- @@ -137,15 +140,17 @@ For Windows the recommended approach to define app icons is to use `target` attr ``` -where `source` is the path to the icon which needs to be added. +where `src` is the path to the icon which needs to be added. + +The Windows platform handles MRT icons automatically, so if you specify `src="res/windows/storelogo.png"` the following files will be copied into the application's `images` folder: `res/windows/storelogo.scale-100.png`, `res/windows/storelogo.scale-200.png`, etc. -Please note that Windows platform handles MRT icons automatically, so if you specify `src="res/windows/storelogo.png"` the following files will be copied into app's `images` folder: `res/windows/storelogo.scale-100.png`, `res/windows/storelogo.scale-200.png`, etc. +TODO Define what MRT is. --- End diff -- Should this go in a JIRA ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Snapshotting dev to 6.x
Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/603#discussion_r63410912 --- Diff: www/docs/en/6.x/config_ref/images.md --- @@ -19,17 +19,17 @@ license: > title: Customize app icons --- End diff -- 'app' -> 'application' --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Snapshotting dev to 6.x
Github user rakatyal commented on the pull request: https://github.com/apache/cordova-docs/pull/603#issuecomment-219516481 @omefire , @riknoll : Please review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Snapshotting dev to 6.x
GitHub user rakatyal opened a pull request: https://github.com/apache/cordova-docs/pull/603 Snapshotting dev to 6.x You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-docs raghav/snapshot Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-docs/pull/603.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #603 commit 176620c6dc55b9c434a9132cbdc940d3dc888b85 Author: Raghav Katyal Date: 2016-05-16T19:04:12Z Snapshotting dev to 6.x --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Snapshotting dev to 6.x.
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/562#issuecomment-198674853 @riknoll you're right, that PR didn't affect this. However in re-doing it I found out that snapshotting didn't cover ToC files, and I fixed that. All's well now, and the site's deployed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Snapshotting dev to 6.x.
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/562 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Snapshotting dev to 6.x.
Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/562#issuecomment-198590861 This is just moving the docs over right? In that case LGTM (as far as I can review it)! Just make sure that #563 gets in before we publish --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Snapshotting dev to 6.x.
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/562#issuecomment-198592236 Yep, it's just that. Will re-do this once #563 gets merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Snapshotting dev to 6.x.
GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-docs/pull/562 Snapshotting dev to 6.x. @nikhilkh @rakatyal @riknoll please give this a glance when you have a moment. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-docs snapshot Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-docs/pull/562.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #562 commit 958b369c072672a939876e3d4a8dfeb94d47df0c Author: Dmitry Blotsky Date: 2016-03-18T23:33:59Z Snapshotting dev to 6.x. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Snapshotting dev to 6.x.
Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/562#issuecomment-198603743 Do you have to redo it? That PR only affects index.js --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
