[GitHub] cordova-ios issue #237: CB-9789: Support setting the default app locale
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/237 @dpogue Please send a PR for a docs update as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios issue #237: CB-9789: Support setting the default app locale
Github user dpogue commented on the issue: https://github.com/apache/cordova-ios/pull/237 @shazron Thanks, I've rebased on master and updated the tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios issue #237: CB-9789: Support setting the default app locale
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/237 cordova-common 1.4.1 has been bundled in master, and this PR now fails one unit-test (`npm run unit-tests`: ``` Failures: 1) prepare updateProject method should write out the app id to info plist as CFBundleIdentifier with ios-CFBundleIdentifier Message: Expected 'testpkg' to equal 'testpkg_ios'. Stacktrace: Error: Expected 'testpkg' to equal 'testpkg_ios'. at /Users/shaz/Documents/Git/Apache/cordova-ios/tests/spec/unit/prepare.spec.js:126:79 at _fulfilled (/Users/shaz/Documents/Git/Apache/cordova-ios/node_modules/q/q.js:834:54) at self.promiseDispatch.done (/Users/shaz/Documents/Git/Apache/cordova-ios/node_modules/q/q.js:863:30) at Promise.promise.promiseDispatch (/Users/shaz/Documents/Git/Apache/cordova-ios/node_modules/q/q.js:796:13) at /Users/shaz/Documents/Git/Apache/cordova-ios/node_modules/q/q.js:556:49 at runSingle (/Users/shaz/Documents/Git/Apache/cordova-ios/node_modules/q/q.js:137:13) at flush (/Users/shaz/Documents/Git/Apache/cordova-ios/node_modules/q/q.js:125:13) at _combinedTickCallback (internal/process/next_tick.js:67:7) at process._tickCallback (internal/process/next_tick.js:98:9) ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios issue #237: CB-9789: Support setting the default app locale
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/237 https://github.com/apache/cordova-lib/pull/466 has been merged and should be in cordova-common 1.4.1 when it is released. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios issue #237: CB-9789: Support setting the default app locale
Github user dpogue commented on the issue: https://github.com/apache/cordova-ios/pull/237 The `getAttribute` method is implemented in https://github.com/apache/cordova-lib/pull/466 (which isn't merged yet) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios issue #237: CB-9789: Support setting the default app locale
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-ios/pull/237 Can you create a new issue for the language thing and link it instead of CB-9789? And push only the code related to that. Are there issues open for the cleanIcons and cleanSplashScreens bugs? Tests are failing because `has no method 'getAttribute'` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios issue #237: CB-9789: Support setting the default app locale
Github user codecov-io commented on the issue: https://github.com/apache/cordova-ios/pull/237 ## [Current coverage][cc-pull] is 34.72% (diff: 100%) > Merging [#237][cc-pull] into [master][cc-base-branch] will decrease coverage by **17.08%** ```diff @@ master #237 diff @@ == Files11 11 Lines 882884 +2 Methods 132132 Messages 0 0 Branches143144 +1 == - Hits457307 -150 - Misses 425577 +152 Partials 0 0 ``` > Powered by [Codecov](https://codecov.io?src=pr). Last update [5c3885b...e3cfdb2][cc-compare] [cc-base-branch]: https://codecov.io/gh/apache/cordova-ios/branch/master?src=pr [cc-compare]: https://codecov.io/gh/apache/cordova-ios/compare/5c3885b807f4c9556bf350c72400827a333f78d3...e3cfdb2b09099b5a1fa33cf041cb4d48b9db5697?src=pr [cc-pull]: https://codecov.io/gh/apache/cordova-ios/pull/237?src=pr --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
