[GitHub] cordova-ios pull request: * is a Right-to-left associative operato...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/145 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request: * is a Right-to-left associative operato...
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/145#issuecomment-115829041 Stroustrup's take on this (who I think we can agree is an authority): http://www.stroustrup.com/bs_faq2.html#whitespace ``` The critical confusion comes (only) when people try to declare several pointers with a single declaration: int* p, p1; // probable error: p1 is not an int* ``` Other valid points in his FAQ item as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request: * is a Right-to-left associative operato...
Github user Coeur commented on the pull request: https://github.com/apache/cordova-ios/pull/145#issuecomment-115620070 But the original decision was semantically incorrect. It teaches a bad habit. And `blame` can also be configured to hide specific contributions, like the ones related to uncrustify. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request: * is a Right-to-left associative operato...
Github user Coeur commented on the pull request: https://github.com/apache/cordova-ios/pull/145#issuecomment-115621019 Also, the day you move to, let say, Swift, you won't avoid changing latest contribution to someone else. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request: * is a Right-to-left associative operato...
Github user cjpearson commented on the pull request: https://github.com/apache/cordova-ios/pull/145#issuecomment-115654625 The current style is not incorrect or a bad habit. It may not follow Apple's style, but both styles are valid and readable. Many C programmers choose to attach the asterisk to the variable, emphasizing syntax, while most C++ programmers prefer to emphasize the type by attaching the asterisk to the type. Since Objective-C, like C++, is an Object Oriented language, I think it makes much more sense to emphasize type by keeping the asterisk attached to the type. Also, there are several common situations in Objective-C where there is no variable for you to attach the asterisk to even if you wanted. Casting `(NSString*)someObject` Method Parameters `- (void)someMethod:(NSObject*)param;` Generics `NSArrayNSString** someArray;` The common defense against grouping the asterisk with the type is that one might think these two lines behave the same. int* a, b, c; int *a, *b, *c; I think that's a pretty easy situation to avoid. Just declare your variables on different lines. For whatever it's worth, I vote keeping the style the way it is. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request: * is a Right-to-left associative operato...
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/145#issuecomment-115053099 Not sure I see the entire point of this, we've decided Objective-C object pointer declaration should be NSString* foo instead of NSString *foo. This change would potentially change everything in the existing codebase (so git blame will be less useful). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request: * is a Right-to-left associative operato...
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-ios/pull/145#issuecomment-115087441 I agree with Shazron. It is a semantic discussion without benefit, and ultimately would obscure other's contributions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request: * is a Right-to-left associative operato...
GitHub user Coeur opened a pull request: https://github.com/apache/cordova-ios/pull/145 * is a Right-to-left associative operator in C and Objective-C See: http://en.wikipedia.org/wiki/Operators_in_C_and_C%2B%2B#Operator_precedence http://www.techotopia.com/index.php/Objective-C_2.0_Operator_Precedence#Objective-C_Operator_Precedence_and_Associativity You can merge this pull request into a Git repository by running: $ git pull https://github.com/Coeur/cordova-ios RightToLeftAssociativeOperator Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-ios/pull/145.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #145 commit 0d721293720e4cbb96310ff2b7970a46c03e7c1d Author: Antoine CÅur co...@gmx.fr Date: 2015-06-08T11:35:35Z * is a Right-to-left associative operator in C and Objective-C See: http://en.wikipedia.org/wiki/Operators_in_C_and_C%2B%2B#Operator_precedence http://www.techotopia.com/index.php/Objective-C_2.0_Operator_Precedence#Objective-C_Operator_Precedence_and_Associativity --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request: * is a right-to-left associative operato...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/93 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
