[GitHub] cordova-ios pull request: CB-9883 - Remove unused iOS bridges

[csantanapr]

Github user csantanapr commented on the pull request:

https://github.com/apache/cordova-ios/pull/178#issuecomment-154265526
  
@shazron is this a lesson learned that certain experimental things should 
be kept in experimental branches and not in master :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [GitHub] cordova-ios pull request: CB-9883 - Remove unused iOS bridges

[Jesse]

And that we need to watch what others commit. More review would have stopped 
this in the first place. 

> On Nov 5, 2015, at 6:33 PM, csantanapr  wrote:
> 
> Github user csantanapr commented on the pull request:
> 
>https://github.com/apache/cordova-ios/pull/178#issuecomment-154265526
> 
>@shazron is this a lesson learned that certain experimental things should 
> be kept in experimental branches and not in master :+1: 
> 
> 
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
> 

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request: CB-9883 - Remove unused iOS bridges

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-ios/pull/178


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request: CB-9883 - Remove unused iOS bridges

[csantanapr]

Github user csantanapr commented on the pull request:

https://github.com/apache/cordova-ios/pull/178#issuecomment-153887028
  
With this removal, is there a minimum ios version that this will work only 
using the IFRAME_NAV bridge?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request: CB-9883 - Remove unused iOS bridges

[shazron]

Github user shazron commented on the pull request:

https://github.com/apache/cordova-ios/pull/178#issuecomment-153908591
  
IFRAME_NAV has always worked from the beginning and has been the default, 
the other bridge modes are experimental to try to gain speed, but flakey -- 
like the comments in the .js say.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request: CB-9883 - Remove unused iOS bridges

[shazron]

GitHub user shazron opened a pull request:

https://github.com/apache/cordova-ios/pull/178

CB-9883 - Remove unused iOS bridges

Please review.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shazron/cordova-ios CB-9883

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-ios/pull/178.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #178


commit 8f6c8367b476493b48e263d4bed5b5c31916d81d
Author: Shazron Abdullah 
Date:   2015-11-03T22:20:11Z

CB-9883 - Remove bridge changing guide doc

commit 89ea4926040b8febbde90beb04d058a19ef2e3f4
Author: Shazron Abdullah 
Date:   2015-11-03T22:34:57Z

CB-9883 - removed bridges from platform exec.js

commit 81f5036ef7552a3619a3b0448e534854a2be66bd
Author: Shazron Abdullah 
Date:   2015-11-03T22:40:06Z

CB-9883 - removed bridges from platform native code




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org