GitHub user joshdholtz opened a pull request:
https://github.com/apache/cordova-ios/pull/324
CB-12966: (ios) Fix bug by escaping project name in podfile template
### Platforms affected
- iOS
### What does this PR do?
- Fixes a bug when the project name has a single quote in it that caused
the `Podfile` to have invalid syntax
### What testing has been done on this change?
- Just manual testing on my own project. I am not familiar with how to
write a proper tests for this change ð I know I need to add something in
`Podfile.spec.js` but not exactly sure what/how exactly I need to do this. Any
suggestions on how to write these tests would be truly appreciated â¤ï¸
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB- is the JIRA ID & "android" is the platform
affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/joshdholtz/cordova-ios master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/324.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #324
commit ff8061e4de993ec5104701a7211a57b774a9fb74
Author: Josh Holtz
Date: 2017-06-28T17:22:27Z
CB-12966: (ios) Fix bug by escaping project name in podfile template
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
