[GitHub] cordova-js pull request: Fixed callbackFromNative method
Github user matt-way commented on the pull request: https://github.com/apache/cordova-js/pull/98#issuecomment-126184116 Can you give one good example of when NO_RESULT would ever be useful? What is the difference now between NO_RESULT and actually not doing anything? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-js pull request: Fixed callbackFromNative method
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-js/pull/98#issuecomment-126146012 In the case of the contacts plugin, yes, android should return an error on Activity.RESULT_CANCELED This is an inappropriate use of NO_RESULT. Please file an issue in JIRA. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-js pull request: Fixed callbackFromNative method
Github user matt-way commented on the pull request: https://github.com/apache/cordova-js/pull/98#issuecomment-126137282 NO_RESULT doing absolutely nothing in javascript is bad design. For example, now there is no way of telling when/if the cordova-plugin-contacts plugin was cancelled. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-js pull request: Fixed callbackFromNative method
Github user asfgit closed the pull request at: https://github.com/apache/cordova-js/pull/98 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-js pull request: Fixed callbackFromNative method
Github user mdudek commented on the pull request: https://github.com/apache/cordova-js/pull/98#issuecomment-69168149 Fixed also in cordova_b.js --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-js pull request: Fixed callbackFromNative method
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-js/pull/98#issuecomment-69151406 It needs to be done here also: https://github.com/apache/cordova-js/blob/master/src/cordova_b.js#L212 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-js pull request: Fixed callbackFromNative method
GitHub user mdudek opened a pull request: https://github.com/apache/cordova-js/pull/98 Fixed callbackFromNative method NO_RESULT status was resolved as failure. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mdudek/cordova-js patch-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-js/pull/98.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #98 commit 7b1e8e1d68c49ccaa5a38b1805033292d42c2c22 Author: Michael Dudek Date: 2015-01-08T07:28:39Z Fixed callbackFromNative method NO_RESULT status was resolved as failure. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
